qiita-markdown 0.44.0 → 0.44.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: bb18cd9f37329069980cc0322cff454cb1dcbd57ad3fe6836f40b3d8e968e304
-  data.tar.gz: ad7d5e7d89eeb283616d04e2fbdc8a1bb2b090897bf1538f6033d061cbe8d958
+  metadata.gz: 15a4f04515ad1a13dca22d1cdb61272ddb7fca2066dbc5bc82b7ccfa3db06b74
+  data.tar.gz: 4fd57bd43763ee38486898592e63ddd2c945f54450557c08a4d66ea95b2a00ee
 SHA512:
-  metadata.gz: 4f38820e6f6eafd5135f7d6788e9b0f31ff45b42e85afc0ffb14213e263bb951250f734b1473cf1ffbcc21a5b22d823aed16235ab06bf2f218c39ff9aa59a42f
-  data.tar.gz: 0f4b493d2cb3c06de1c2a7d68455f39a9e496d2ae95ed6ff845b8caf3367128ae0ca863a937b44ddb87147573b261178bd6573c4c6042de14a19c7c56d3e5ca1
+  metadata.gz: e648c8b60f7457028a3aaa89c891815fa5b283f553a02c1f6e516d658de480b2626508039fc41247a86b3d8ea931366a108f6bd8a119983906622596a5cb129b
+  data.tar.gz: 9f291ae053a36028df40a665d83a7e3acf1a82d5496c2cb1ead5a54e9369b71d2a43276d7ac5ccd6449e5e52bd9b29df13e3da1371d9531da53ba042c2d66ad4

data/.rubocop_todo.yml

@@ -1,27 +1,11 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config --exclude-limit 99999`
-# on 2022-04-15 03:12:24 UTC using RuboCop version 1.27.0.
+# on 2022-11-14 07:37:46 UTC using RuboCop version 1.39.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 3
-# This cop supports safe auto-correction (--auto-correct).
-# Configuration parameters: TreatCommentsAsGroupSeparators, ConsiderPunctuation, Include.
-# Include: **/*.gemspec
-Gemspec/OrderedDependencies:
-  Exclude:
-    - 'qiita-markdown.gemspec'
-
-# Offense count: 1
-# This cop supports safe auto-correction (--auto-correct).
-# Configuration parameters: Include.
-# Include: **/*.gemspec
-Gemspec/RequireMFA:
-  Exclude:
-    - 'qiita-markdown.gemspec'
-
 # Offense count: 1
 # Configuration parameters: Include.
 # Include: **/*.gemspec
@@ -29,66 +13,16 @@ Gemspec/RequiredRubyVersion:
   Exclude:
     - 'qiita-markdown.gemspec'
 
-# Offense count: 1
-# This cop supports safe auto-correction (--auto-correct).
-Layout/ClosingHeredocIndentation:
-  Exclude:
-    - 'spec/qiita/markdown/processor_spec.rb'
-
-# Offense count: 9
-# This cop supports safe auto-correction (--auto-correct).
-Layout/EmptyLineAfterGuardClause:
-  Exclude:
-    - 'lib/qiita/markdown/filters/custom_block.rb'
-    - 'lib/qiita/markdown/filters/external_link.rb'
-    - 'lib/qiita/markdown/filters/footnote.rb'
-    - 'lib/qiita/markdown/filters/mention.rb'
-    - 'lib/qiita/markdown/filters/simplify.rb'
-    - 'lib/qiita/markdown/transformers/filter_attributes.rb'
-
-# Offense count: 22
-# This cop supports safe auto-correction (--auto-correct).
-# Configuration parameters: AllowMultipleStyles, EnforcedHashRocketStyle, EnforcedColonStyle, EnforcedLastArgumentHashStyle.
-# SupportedHashRocketStyles: key, separator, table
-# SupportedColonStyles: key, separator, table
-# SupportedLastArgumentHashStyles: always_inspect, always_ignore, ignore_implicit, ignore_explicit
-Layout/HashAlignment:
-  Exclude:
-    - 'lib/qiita/markdown/filters/user_input_sanitizer.rb'
-
-# Offense count: 1
-# This cop supports safe auto-correction (--auto-correct).
-# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBrackets.
-# SupportedStyles: space, no_space, compact
-# SupportedStylesForEmptyBrackets: space, no_space
-Layout/SpaceInsideArrayLiteralBrackets:
-  Exclude:
-    - 'lib/qiita/markdown/transformers/filter_iframe.rb'
-
-# Offense count: 2
-# This cop supports safe auto-correction (--auto-correct).
-Lint/AmbiguousOperatorPrecedence:
-  Exclude:
-    - 'lib/qiita/markdown/filters/mention.rb'
-
 # Offense count: 5
-# Configuration parameters: IgnoredMethods, CountRepeatedAttributes.
+# Configuration parameters: AllowedMethods, AllowedPatterns, IgnoredMethods, CountRepeatedAttributes.
 Metrics/AbcSize:
   Max: 22
 
-# Offense count: 10
-# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, IgnoredMethods.
+# Offense count: 9
+# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, AllowedMethods, AllowedPatterns, IgnoredMethods.
 Metrics/MethodLength:
   Max: 20
 
-# Offense count: 2
-# This cop supports safe auto-correction (--auto-correct).
-# Configuration parameters: EnforcedStyle, BlockForwardingName.
-# SupportedStyles: anonymous, explicit
-Naming/BlockForwarding:
-  Exclude:
-    - 'lib/qiita/markdown/filters/truncate.rb'
-
 # Offense count: 1
 Naming/ConstantName:
   Exclude:
@@ -121,27 +55,13 @@ Naming/MemoizedInstanceVariableName:
 
 # Offense count: 1
 # Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames.
-# AllowedNames: at, by, db, id, in, io, ip, of, on, os, pp, to
+# AllowedNames: as, at, by, db, id, if, in, io, ip, of, on, os, pp, to
 Naming/MethodParameterName:
   Exclude:
     - 'lib/qiita/markdown/filters/footnote.rb'
 
-# Offense count: 3
-# This cop supports safe auto-correction (--auto-correct).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: percent_q, bare_percent
-Style/BarePercentLiterals:
-  Exclude:
-    - 'lib/qiita/markdown/filters/syntax_highlight.rb'
-
-# Offense count: 1
-# This cop supports safe auto-correction (--auto-correct).
-Style/ExpandPathArguments:
-  Exclude:
-    - 'qiita-markdown.gemspec'
-
 # Offense count: 47
-# This cop supports safe auto-correction (--auto-correct).
+# This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: always, always_true, never
 Style/FrozenStringLiteralComment:
@@ -194,51 +114,26 @@ Style/FrozenStringLiteralComment:
     - 'spec/qiita/markdown/summary_processor_spec.rb'
     - 'spec/spec_helper.rb'
 
-# Offense count: 6
-# This cop supports safe auto-correction (--auto-correct).
-# Configuration parameters: EnforcedShorthandSyntax, UseHashRocketsWithSymbolValues, PreferHashRocketsForNonAlnumEndingSymbols.
-# SupportedStyles: ruby19, hash_rockets, no_mixed_keys, ruby19_no_mixed_keys
-# SupportedShorthandSyntax: always, never, either
-Style/HashSyntax:
-  EnforcedStyle: ruby19
-  EnforcedShorthandSyntax: never
-
-# Offense count: 2
-# This cop supports safe auto-correction (--auto-correct).
-Style/IfUnlessModifier:
-  Exclude:
-    - 'lib/qiita/markdown/filters/truncate.rb'
-    - 'lib/qiita/markdown/transformers/strip_invalid_node.rb'
-
 # Offense count: 17
-# This cop supports safe auto-correction (--auto-correct).
+# This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: literals, strict
 Style/MutableConstant:
   Exclude:
     - 'lib/qiita/markdown/embed/code_pen.rb'
-    - 'lib/qiita/markdown/filters/group_mention.rb'
-    - 'lib/qiita/markdown/filters/inline_code_color.rb'
-    - 'lib/qiita/markdown/filters/mention.rb'
     - 'lib/qiita/markdown/embed/tweet.rb'
     - 'lib/qiita/markdown/filters/checkbox.rb'
     - 'lib/qiita/markdown/filters/code_block.rb'
+    - 'lib/qiita/markdown/filters/group_mention.rb'
+    - 'lib/qiita/markdown/filters/inline_code_color.rb'
+    - 'lib/qiita/markdown/filters/mention.rb'
     - 'lib/qiita/markdown/filters/simplify.rb'
     - 'lib/qiita/markdown/filters/syntax_highlight.rb'
     - 'lib/qiita/markdown/version.rb'
 
-# Offense count: 2
-# This cop supports safe auto-correction (--auto-correct).
-# Configuration parameters: EnforcedStyle, MinBodyLength.
-# SupportedStyles: skip_modifier_ifs, always
-Style/Next:
-  Exclude:
-    - 'lib/qiita/markdown/filters/code_block.rb'
-    - 'lib/qiita/markdown/filters/image_link.rb'
-
 # Offense count: 5
-# This cop supports unsafe auto-correction (--auto-correct-all).
-# Configuration parameters: EnforcedStyle, IgnoredMethods.
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: EnforcedStyle, AllowedMethods, AllowedPatterns, IgnoredMethods.
 # SupportedStyles: predicate, comparison
 Style/NumericPredicate:
   Exclude:
@@ -255,98 +150,17 @@ Style/OptionalBooleanParameter:
     - 'lib/qiita/markdown/greenmat/heading_rendering.rb'
 
 # Offense count: 1
-# This cop supports safe auto-correction (--auto-correct).
-Style/OrAssignment:
-  Exclude:
-    - 'lib/qiita/markdown/greenmat/html_toc_renderer.rb'
-
-# Offense count: 9
-# This cop supports safe auto-correction (--auto-correct).
-# Configuration parameters: PreferredDelimiters.
-Style/PercentLiteralDelimiters:
-  Exclude:
-    - 'benchmark/heading_anchor_rendering.rb'
-    - 'lib/qiita/markdown/filters/mention.rb'
-    - 'lib/qiita/markdown/filters/syntax_highlight.rb'
-    - 'spec/qiita/markdown/processor_spec.rb'
-    - 'spec/qiita/markdown/summary_processor_spec.rb'
-
-# Offense count: 1
-# This cop supports safe auto-correction (--auto-correct).
-Style/PerlBackrefs:
-  Exclude:
-    - 'lib/qiita/markdown/filters/mention.rb'
-
-# Offense count: 1
-# This cop supports unsafe auto-correction (--auto-correct-all).
+# This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: Methods.
 Style/RedundantArgument:
   Exclude:
     - 'lib/qiita/markdown/filters/custom_block.rb'
 
-# Offense count: 1
-# This cop supports safe auto-correction (--auto-correct).
-Style/RedundantRegexpCharacterClass:
-  Exclude:
-    - 'lib/qiita/markdown/filters/mention.rb'
-
-# Offense count: 9
-# This cop supports safe auto-correction (--auto-correct).
-Style/RedundantRegexpEscape:
-  Exclude:
-    - 'lib/qiita/markdown/filters/group_mention.rb'
-    - 'lib/qiita/markdown/filters/inline_code_color.rb'
-
-# Offense count: 4
-# This cop supports safe auto-correction (--auto-correct).
-# Configuration parameters: EnforcedStyle, AllowInnerSlashes.
-# SupportedStyles: slashes, percent_r, mixed
-Style/RegexpLiteral:
-  Exclude:
-    - 'lib/qiita/markdown/filters/inline_code_color.rb'
-    - 'lib/qiita/markdown/filters/mention.rb'
-
-# Offense count: 1
-# This cop supports safe auto-correction (--auto-correct).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: implicit, explicit
-Style/RescueStandardError:
-  Exclude:
-    - 'lib/qiita/markdown/filters/syntax_highlight.rb'
-
 # Offense count: 2
-# This cop supports safe auto-correction (--auto-correct).
+# This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: ConvertCodeThatCanStartToReturnNil, AllowedMethods, MaxChainLength.
 # AllowedMethods: present?, blank?, presence, try, try!
 Style/SafeNavigation:
   Exclude:
     - 'lib/qiita/markdown/filters/custom_block.rb'
     - 'lib/qiita/markdown/filters/toc.rb'
-
-# Offense count: 3
-# This cop supports safe auto-correction (--auto-correct).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: only_raise, only_fail, semantic
-Style/SignalException:
-  Exclude:
-    - 'lib/qiita/markdown/greenmat/heading_rendering.rb'
-    - 'spec/qiita/markdown/summary_processor_spec.rb'
-
-# Offense count: 13
-# This cop supports safe auto-correction (--auto-correct).
-# Configuration parameters: EnforcedStyleForMultiline.
-# SupportedStylesForMultiline: comma, consistent_comma, no_comma
-Style/TrailingCommaInArguments:
-  Exclude:
-    - 'lib/qiita/markdown/filters/mention.rb'
-    - 'spec/qiita/markdown/processor_spec.rb'
-
-# Offense count: 12
-# This cop supports safe auto-correction (--auto-correct).
-# Configuration parameters: EnforcedStyle, MinSize, WordRegex.
-# SupportedStyles: percent, brackets
-Style/WordArray:
-  Exclude:
-    - 'lib/qiita/markdown/filters/final_sanitizer.rb'
-    - 'lib/qiita/markdown/transformers/filter_script.rb'
-    - 'spec/qiita/markdown/processor_spec.rb'

data/CHANGELOG.md

@@ -1,5 +1,10 @@
 ## Unreleased
 
+## 0.44.1
+
+- Rename package name from `Qiita::Markdown` to `Qiita Markdown` in README
+- Bump rubocop from 1.27.0 to 1.39.0 and apply rubocop auto correct
+
 ## 0.44.0
 
 - Support Figma embedding scripts

data/README.md

@@ -1,4 +1,4 @@
-# Qiita::Markdown
+# Qiita Markdown
 
 [![Gem Version](https://badge.fury.io/rb/qiita-markdown.svg)](https://badge.fury.io/rb/qiita-markdown)
 [![Build Status](https://travis-ci.org/increments/qiita-markdown.svg)](https://travis-ci.org/increments/qiita-markdown)
@@ -42,7 +42,7 @@ processor.call(markdown)
 
 ### Filters
 
-Qiita::Markdown is built on [jch/html-pipeline](https://github.com/jch/html-pipeline).
+Qiita Markdown is built on [jch/html-pipeline](https://github.com/jch/html-pipeline).
 Add your favorite html-pipeline-compatible filters.
 
 ```ruby

data/benchmark/heading_anchor_rendering.rb

@@ -61,7 +61,7 @@ module PostProcess
         end
 
         def anchor_element
-          %[<span id="#{suffixed_id}" class="fragment"></span><a href="##{suffixed_id}"><i class="fa fa-link"></i></a>]
+          %(<span id="#{suffixed_id}" class="fragment"></span><a href="##{suffixed_id}"><i class="fa fa-link"></i></a>)
         end
 
         def content

data/lib/qiita/markdown/filters/code_block.rb

@@ -16,19 +16,19 @@ module Qiita
         def call
           result[:codes] ||= []
           doc.search("pre").each do |pre|
-            if (code = pre.at("code"))
-              metadata = Metadata.new(code["data-metadata"])
-              filename = metadata.filename
-              language = metadata.language
-              language = language_aliases[language] || language
-              pre["filename"] = filename if filename
-              pre["lang"] = language if language
-              result[:codes] << {
-                code: pre.text,
-                filename: filename,
-                language: language,
-              }
-            end
+            next unless (code = pre.at("code"))
+
+            metadata = Metadata.new(code["data-metadata"])
+            filename = metadata.filename
+            language = metadata.language
+            language = language_aliases[language] || language
+            pre["filename"] = filename if filename
+            pre["lang"] = language if language
+            result[:codes] << {
+              code: pre.text,
+              filename: filename,
+              language: language,
+            }
           end
           doc
         end

data/lib/qiita/markdown/filters/custom_block.rb

@@ -8,6 +8,7 @@ module Qiita
           doc.search('div[data-type="customblock"]').each do |div|
             metadata = Metadata.new(div["data-metadata"])
             next unless ALLOWED_TYPES.include?(metadata.type)
+
             klass = Object.const_get("#{self.class}::#{metadata.type.capitalize}")
             klass.new(div, metadata.subtype).convert
           end

data/lib/qiita/markdown/filters/external_link.rb

@@ -7,9 +7,11 @@ module Qiita
         def call
           doc.search("a").each do |anchor|
             next unless anchor["href"]
+
             href = anchor["href"].strip
             href_host = host_of(href)
             next unless href_host
+
             if href_host != hostname
               anchor["rel"] = "nofollow noopener"
               anchor["target"] = "_blank"

data/lib/qiita/markdown/filters/final_sanitizer.rb

@@ -12,41 +12,41 @@ module Qiita
       class FinalSanitizer < HTML::Pipeline::Filter
         RULE = {
           attributes: {
-            "a" => [
-              "data-hovercard-target-name",
-              "data-hovercard-target-type",
-              "href",
-              "rel",
+            "a" => %w[
+              data-hovercard-target-name
+              data-hovercard-target-type
+              href
+              rel
             ],
             "blockquote" => Embed::Tweet::ATTRIBUTES,
-            "iframe" => [
-              "allowfullscreen",
-              "frameborder",
-              "height",
-              "marginheight",
-              "marginwidth",
-              "scrolling",
-              "src",
-              "style",
-              "width",
+            "iframe" => %w[
+              allowfullscreen
+              frameborder
+              height
+              marginheight
+              marginwidth
+              scrolling
+              src
+              style
+              width
             ],
             "img" => [
               "src",
             ],
-            "input" => [
-              "checked",
-              "disabled",
-              "type",
+            "input" => %w[
+              checked
+              disabled
+              type
             ],
-            "div" => [
-              "itemscope",
-              "itemtype",
+            "div" => %w[
+              itemscope
+              itemtype
             ],
             "p" => Embed::CodePen::ATTRIBUTES,
-            "script" => [
-              "async",
-              "src",
-              "type",
+            "script" => %w[
+              async
+              src
+              type
             ].concat(
               Embed::SpeekerDeck::ATTRIBUTES,
               Embed::Docswell::ATTRIBUTES,
@@ -60,104 +60,104 @@ module Qiita
             "th" => [
               "style",
             ],
-            "video" => [
-              "src",
-              "autoplay",
-              "controls",
-              "loop",
-              "muted",
-              "poster",
+            "video" => %w[
+              src
+              autoplay
+              controls
+              loop
+              muted
+              poster
             ],
-            all: [
-              "abbr",
-              "align",
-              "alt",
-              "border",
-              "cellpadding",
-              "cellspacing",
-              "cite",
-              "class",
-              "color",
-              "cols",
-              "colspan",
-              "data-lang",
-              "datetime",
-              "height",
-              "hreflang",
-              "id",
-              "itemprop",
-              "lang",
-              "name",
-              "rowspan",
-              "tabindex",
-              "target",
-              "title",
-              "width",
+            all: %w[
+              abbr
+              align
+              alt
+              border
+              cellpadding
+              cellspacing
+              cite
+              class
+              color
+              cols
+              colspan
+              data-lang
+              datetime
+              height
+              hreflang
+              id
+              itemprop
+              lang
+              name
+              rowspan
+              tabindex
+              target
+              title
+              width
             ],
           },
           css: {
-            properties: [
-              "background-color",
-              "border",
-              "text-align",
+            properties: %w[
+              background-color
+              border
+              text-align
             ],
           },
-          elements: [
-            "a",
-            "b",
-            "blockquote",
-            "br",
-            "code",
-            "dd",
-            "del",
-            "details",
-            "div",
-            "dl",
-            "dt",
-            "em",
-            "font",
-            "h1",
-            "h2",
-            "h3",
-            "h4",
-            "h5",
-            "h6",
-            "h7",
-            "h8",
-            "hr",
-            "i",
-            "img",
-            "input",
-            "ins",
-            "kbd",
-            "li",
-            "ol",
-            "p",
-            "pre",
-            "q",
-            "rp",
-            "rt",
-            "ruby",
-            "s",
-            "samp",
-            "script",
-            "iframe",
-            "span",
-            "strike",
-            "strong",
-            "sub",
-            "summary",
-            "sup",
-            "table",
-            "tbody",
-            "td",
-            "tfoot",
-            "th",
-            "thead",
-            "tr",
-            "tt",
-            "ul",
-            "var",
+          elements: %w[
+            a
+            b
+            blockquote
+            br
+            code
+            dd
+            del
+            details
+            div
+            dl
+            dt
+            em
+            font
+            h1
+            h2
+            h3
+            h4
+            h5
+            h6
+            h7
+            h8
+            hr
+            i
+            img
+            input
+            ins
+            kbd
+            li
+            ol
+            p
+            pre
+            q
+            rp
+            rt
+            ruby
+            s
+            samp
+            script
+            iframe
+            span
+            strike
+            strong
+            sub
+            summary
+            sup
+            table
+            tbody
+            td
+            tfoot
+            th
+            thead
+            tr
+            tt
+            ul
+            var
           ],
           protocols: {
             "a" => {

data/lib/qiita/markdown/filters/footnote.rb

@@ -6,6 +6,7 @@ module Qiita
           doc.search("sup > a").each do |a|
             footnote = find_footnote(a)
             next unless footnote
+
             a[:title] = footnote.text.gsub(/\A\n/, "").gsub(/ ↩\n\z/, "")
           end
           doc
@@ -16,6 +17,7 @@ module Qiita
         def find_footnote(a)
           href = a["href"]
           return nil if !href || href.match(/\A#fn\d+\z/).nil?
+
           doc.search(href).first
         end
       end