qiita-markdown 0.26.0 → 0.27.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7e2e556a9a6cfd7d44402fa85c90d9ef7b8fee58f61f7fd2cdb1e837bdbed4c1
-  data.tar.gz: 3e5c460dcb2a8e732f8f6e52fc363991d2684f409ef74c9721136993a5fc4ea1
+  metadata.gz: e5daef53080035aaeb3d6330fd29a92c62edfb4daf432c62f4617f2683682ab1
+  data.tar.gz: 8bd27e4fb3b789cbbe98ca99dd987277091f262509d4a596996942ead45ae9ca
 SHA512:
-  metadata.gz: de3681b0c6a34adeb742e8d78ce1302429144855f33859ab918aca1696767c9b0606d5921480efe6e38b8e59faacdbb22fdb0df6b2f77d78c0f19ca569314960
-  data.tar.gz: b3a76674697c8d6988c94c8523b1e7a04d07a093e93522cc8ef8f77004cf80175e4fbf9bd6c36995570ae87e587b4239417ad1f501605ae6f7d120b542fc4878
+  metadata.gz: f38d622bdfcec12a795998a31b9dec566583542837024bb9ad6c0c88531b16b759774966ad0925d03d06f3c58de9d81192b074c6ed82c57b26caa7c5a7b93332
+  data.tar.gz: 4c22a80c6be7cb94ee7cc5e1a3966a788aae38f6e72e0784a42678d472cc1081dbd626f89d98250fea91e4000081fc949334d276b09869896cca4b005155e51b

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 ## Unreleased
 
+## 0.27.0
+
+- Support embed Asciinema
+
 ## 0.26.0
 
 - Use greenmat 3.2.2.4

data/lib/qiita/markdown.rb

@@ -9,6 +9,7 @@ require "sanitize"
 
 require "qiita/markdown/embed/code_pen"
 require "qiita/markdown/embed/tweet"
+require "qiita/markdown/embed/asciinema"
 require "qiita/markdown/transformers/filter_attributes"
 require "qiita/markdown/transformers/filter_script"
 require "qiita/markdown/transformers/strip_invalid_node"

data/lib/qiita/markdown/embed/asciinema.rb

@@ -0,0 +1,9 @@
+module Qiita
+  module Markdown
+    module Embed
+      module Asciinema
+        SCRIPT_HOST = "asciinema.org".freeze
+      end
+    end
+  end
+end

data/lib/qiita/markdown/filters/user_input_sanitizer.rb

@@ -26,7 +26,7 @@ module Qiita
             "li"         => %w[id],
             "p"          => Embed::CodePen::ATTRIBUTES,
             "q"          => %w[cite],
-            "script"     => %w[async src],
+            "script"     => %w[async src id],
             "sup"        => %w[id],
             "td"         => %w[colspan rowspan style],
             "th"         => %w[colspan rowspan style],

data/lib/qiita/markdown/transformers/filter_script.rb

@@ -2,11 +2,15 @@ module Qiita
   module Markdown
     module Transformers
       class FilterScript
-        WHITE_LIST = [
+        URL_WHITE_LIST = [
           Embed::CodePen::SCRIPT_URLS,
           Embed::Tweet::SCRIPT_URL,
         ].flatten.freeze
 
+        HOST_WHITE_LIST = [
+          Embed::Asciinema::SCRIPT_HOST,
+        ].flatten.freeze
+
         def self.call(*args)
           new(*args).transform
         end
@@ -17,7 +21,7 @@ module Qiita
 
         def transform
           if name == "script"
-            if WHITE_LIST.include?(node["src"])
+            if URL_WHITE_LIST.include?(node["src"]) || HOST_WHITE_LIST.include?(host_of(node["src"]))
               node["async"] = "async" unless node.attributes.key?("async")
               node.children.unlink
             else
@@ -35,6 +39,12 @@ module Qiita
         def node
           @env[:node]
         end
+
+        def host_of(url)
+          Addressable::URI.parse(url).host if url
+        rescue Addressable::URI::InvalidURIError
+          nil
+        end
       end
     end
   end

data/lib/qiita/markdown/version.rb

@@ -1,5 +1,5 @@
 module Qiita
   module Markdown
-    VERSION = "0.26.0"
+    VERSION = "0.27.0"
   end
 end

data/qiita-markdown.gemspec

@@ -28,7 +28,7 @@ Gem::Specification.new do |spec|
   spec.add_dependency "addressable"
   spec.add_development_dependency "activesupport", "4.2.6"
   spec.add_development_dependency "benchmark-ips", "~> 1.2"
-  spec.add_development_dependency "bundler", "~> 1.7"
+  spec.add_development_dependency "bundler"
   spec.add_development_dependency "codeclimate-test-reporter", "0.4.4"
   spec.add_development_dependency "pry"
   spec.add_development_dependency "rake", "~> 10.0"

data/spec/qiita/markdown/processor_spec.rb

@@ -1385,6 +1385,28 @@ describe Qiita::Markdown::Processor do
         end
       end
 
+      context "with HTML embed code for Asciinema" do
+        let(:markdown) do
+          <<-MARKDOWN.strip_heredoc
+            <script id="example" src="https://asciinema.org/a/example.js"></script>
+          MARKDOWN
+        end
+
+        if allowed
+          it "does not sanitize embed code" do
+            should eq <<-HTML.strip_heredoc
+              <script id="example" src="https://asciinema.org/a/example.js"></script>
+            HTML
+          end
+        else
+          it "forces async attribute on script" do
+            should eq <<-HTML.strip_heredoc
+              <script id="example" src="https://asciinema.org/a/example.js" async="async"></script>
+            HTML
+          end
+        end
+      end
+
       context "with embed code for Tweet" do
         let(:markdown) do
           <<-MARKDOWN.strip_heredoc

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: qiita-markdown
 version: !ruby/object:Gem::Version
-  version: 0.26.0
+  version: 0.27.0
 platform: ruby
 authors:
 - Ryo Nakamura
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-06-11 00:00:00.000000000 Z
+date: 2019-01-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: gemoji
@@ -154,16 +154,16 @@ dependencies:
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.7'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.7'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: codeclimate-test-reporter
   requirement: !ruby/object:Gem::Requirement
@@ -256,6 +256,7 @@ files:
 - lib/qiita-markdown.rb
 - lib/qiita/markdown.rb
 - lib/qiita/markdown/base_processor.rb
+- lib/qiita/markdown/embed/asciinema.rb
 - lib/qiita/markdown/embed/code_pen.rb
 - lib/qiita/markdown/embed/tweet.rb
 - lib/qiita/markdown/filters/checkbox.rb
@@ -310,7 +311,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.7.4
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: Qiita-specified markdown processor.