qiita-markdown 0.0.9 → 0.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 21636db188a28479b34b60fad6c75356d8f010ec
-  data.tar.gz: 7bd8df4cfebd9c817df09535406b5d27836363fa
+  metadata.gz: e9017a4c3b8f333bbd46769e73282dc5ade827b3
+  data.tar.gz: b12d3ec85b24c2e19e727e187f74b4b471bf4078
 SHA512:
-  metadata.gz: 542225d4238907e068fe08f9367e315cb7b450ea74dcb5a6c9c60ce8cee493d70ba3ff754232c7ed895b14161274135b806cc17892c859b04bc5550c153ec7ed
-  data.tar.gz: b567c29e0bb4321e78d6e124897c5abb0f2ce643373d021e305f2a743b7e8b2592d2bf0c8ee1466cf244b70cf9ede6fa5495884106193cac8ac1a076d396aee6
+  metadata.gz: a7f9b5e259c48094d8fc84c117cfc18d8be58f75bb33ec720f082424615c5817ebb98a30d966e8ff4f12b63111e9eae9298c4675b71806df71393f664658ad25
+  data.tar.gz: 7b36281b31d80ae7b2e01a8d4c4c9376720bc3857eebcefdcf79a63d042351495dfa26e70c24f4103628a671835d933b8a724855c6e65617dbfe85e198d0b9f9

data/CHANGELOG.md

@@ -1,3 +1,6 @@
+## 0.1.0
+* Default to add diabled attribute to checkbox
+
 ## 0.0.9
 * Make it Ruby 2.0.0-compatible
 

data/README.md

@@ -51,7 +51,6 @@ processor.call(text)
 :asset_path        - URL path to link to emoji sprite. (String)
 :asset_root        - Base URL to link to emoji sprite. (String)
 :base_url          - Used to construct links to user profile pages for each. (String)
-:checkbox_disabled - Pass true to add `disabled` attribute to input element/ (Boolean)
 :default_language  - Default language used if no language detected from code. (String)
 :language_aliases  - Alias table for some language names. (Hash)
 :rule              - Sanitization rule table. (Hash)

data/lib/qiita/markdown/filters/checkbox.rb

@@ -7,14 +7,10 @@ module Qiita
       # * [ ] Bar
       # * [ ] Baz
       #
-      # Takes following context options:
-      #
-      # * :checkbox_disabled - Pass true to add `disabled` attribute to input element
-      #
       class Checkbox < HTML::Pipeline::Filter
         def call
           doc.search("li").each_with_index do |li, index|
-            list = List.new(disabled: context[:checkbox_disabled], index: index, node: li)
+            list = List.new(index: index, node: li)
             list.convert if list.has_checkbox?
           end
           doc
@@ -26,8 +22,7 @@ module Qiita
           CHECKBOX_CLOSE_MARK = "[x] "
           CHECKBOX_OPEN_MARK  = "[ ] "
 
-          def initialize(disabled: nil, index: nil, node: nil)
-            @disabled = disabled
+          def initialize(index: nil, node: nil)
             @index = index
             @node = node
           end
@@ -57,7 +52,7 @@ module Qiita
             node = Nokogiri::HTML.fragment('<input type="checkbox" class="task-list-item-checkbox">')
             node.children.first["data-checkbox-index"] = @index
             node.children.first["checked"] = true if has_close_checkbox?
-            node.children.first["disabled"] = true if @disabled
+            node.children.first["disabled"] = true
             node
           end
 

data/lib/qiita/markdown/version.rb

@@ -1,5 +1,5 @@
 module Qiita
   module Markdown
-    VERSION = "0.0.9"
+    VERSION = "0.1.0"
   end
 end

data/spec/qiita/markdown/processor_spec.rb

@@ -388,9 +388,9 @@ describe Qiita::Markdown::Processor do
         should eq <<-EOS.strip_heredoc
           <ul>
           <li class="task-list-item">
-          <input type="checkbox" class="task-list-item-checkbox" data-checkbox-index="0">a</li>
+          <input type="checkbox" class="task-list-item-checkbox" data-checkbox-index="0" disabled>a</li>
           <li class="task-list-item">
-          <input type="checkbox" class="task-list-item-checkbox" data-checkbox-index="1" checked>b</li>
+          <input type="checkbox" class="task-list-item-checkbox" data-checkbox-index="1" checked disabled>b</li>
           </ul>
         EOS
       end
@@ -408,11 +408,11 @@ describe Qiita::Markdown::Processor do
         should eq <<-EOS.strip_heredoc
           <ul>
           <li class="task-list-item">
-          <input type="checkbox" class="task-list-item-checkbox" data-checkbox-index="0">a
+          <input type="checkbox" class="task-list-item-checkbox" data-checkbox-index="0" disabled>a
 
           <ul>
           <li class="task-list-item">
-          <input type="checkbox" class="task-list-item-checkbox" data-checkbox-index="1">b</li>
+          <input type="checkbox" class="task-list-item-checkbox" data-checkbox-index="1" disabled>b</li>
           </ul>
           </li>
           </ul>
@@ -439,30 +439,6 @@ describe Qiita::Markdown::Processor do
       end
     end
 
-    context "with task list and :checkbox_disabled context" do
-      before do
-        context[:checkbox_disabled] = true
-      end
-
-      let(:markdown) do
-        <<-EOS.strip_heredoc
-          - [ ] a
-          - [x] b
-        EOS
-      end
-
-      it "inserts checkbox with disabled attribute" do
-        should eq <<-EOS.strip_heredoc
-          <ul>
-          <li class="task-list-item">
-          <input type="checkbox" class="task-list-item-checkbox" data-checkbox-index="0" disabled>a</li>
-          <li class="task-list-item">
-          <input type="checkbox" class="task-list-item-checkbox" data-checkbox-index="1" checked disabled>b</li>
-          </ul>
-        EOS
-      end
-    end
-
     context 'with empty line between task list' do
       let(:markdown) do
         <<-EOS.strip_heredoc
@@ -472,11 +448,11 @@ describe Qiita::Markdown::Processor do
         EOS
       end
 
-      it "inserts checkbox with disabled attribute" do
+      it "inserts checkbox" do
         should eq <<-EOS.strip_heredoc
           <ul>
-          <li class="task-list-item"><p><input type="checkbox" class="task-list-item-checkbox" data-checkbox-index="0">a</p></li>
-          <li class="task-list-item"><p><input type="checkbox" class="task-list-item-checkbox" data-checkbox-index="1" checked>b</p></li>
+          <li class="task-list-item"><p><input type="checkbox" class="task-list-item-checkbox" data-checkbox-index="0" disabled>a</p></li>
+          <li class="task-list-item"><p><input type="checkbox" class="task-list-item-checkbox" data-checkbox-index="1" checked disabled>b</p></li>
           </ul>
         EOS
       end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: qiita-markdown
 version: !ruby/object:Gem::Version
-  version: 0.0.9
+  version: 0.1.0
 platform: ruby
 authors:
 - Ryo Nakamura