qiita-markdown 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1aafe5981c6fc2c652e8f47ee4118ae335823bd9
-  data.tar.gz: 5f6d2cf91d30d61593199967091d85ed79a562e4
+  metadata.gz: 3af22c8eb0334e08693fbe35fefc4918b8f0a23e
+  data.tar.gz: ea1ecd65e7cb7dca1d91e3bbe74edfbb3051fa5f
 SHA512:
-  metadata.gz: ba727b113b43ed6e27756fa157e4545bda5129304350307ae546196a2f7d1fd0f39561d373f2cb28f15c3ff9aa80a1ca08a63d10e5c2f24e4cb9fa4f655ae27b
-  data.tar.gz: fe6a5cbb3bbc7a94a39bc914ff96922be2d8803992b0618877ed2a2e420a51950526c18b8add60dc645372b2ba6073ffb5345f39083ef1ea57b99632110ef892
+  metadata.gz: 97290186fac7d4b16831c5996f589b4357da4892067c4df975134a7c53299854574f5f8950355c667d85efbb8db2a5dceebefdc2dfda7a7d8e408b79c1491dfa
+  data.tar.gz: bd3caef118d1074cc65fcda3aefedee101c3cb4dae0c35d7ffe8df49b9b43d21615b5ffffb4aa8cc1359e42904438fb42be6f013073a20fe8baca899e138fd16

data/CHANGELOG.md

@@ -1,3 +1,6 @@
+## 0.0.4
+* Add iframe and data-attributes support
+
 ## 0.0.3
 * Fix bug of code block that has colon-only label
 

data/lib/qiita/markdown/filters/sanitize.rb

@@ -48,6 +48,17 @@ module Qiita
             "a" => [
               "href",
             ],
+            "iframe" => [
+              "allowfullscreen",
+              "frameborder",
+              "height",
+              "marginheight",
+              "marginwidth",
+              "scrolling",
+              "src",
+              "style",
+              "width",
+            ],
             "img" => [
               "src",
             ],
@@ -55,6 +66,10 @@ module Qiita
               "itemscope",
               "itemtype",
             ],
+            "script" => [
+              "async",
+              "src",
+            ],
             all: [
               "abbr",
               "align",
@@ -78,6 +93,7 @@ module Qiita
               "target",
               "title",
               "width",
+              :data,
             ],
           },
           elements: [
@@ -153,7 +169,7 @@ module Qiita
         }
 
         SCRIPTABLE_RULE = RULE.dup.tap do |rule|
-          rule[:elements] = RULE[:elements] + ["script"]
+          rule[:elements] = RULE[:elements] + ["iframe", "script"]
           rule[:remove_contents] = []
         end
 
@@ -164,6 +180,10 @@ module Qiita
 
         private
 
+        def has_script_context?
+          context[:script] == true
+        end
+
         def rule
           case
           when context[:rule]
@@ -174,10 +194,6 @@ module Qiita
             RULE
           end
         end
-
-        def has_script_context?
-          context[:script] == true
-        end
       end
     end
   end

data/lib/qiita/markdown/version.rb

@@ -1,5 +1,5 @@
 module Qiita
   module Markdown
-    VERSION = "0.0.3"
+    VERSION = "0.0.4"
   end
 end

data/spec/qiita/markdown/processor_spec.rb

@@ -177,6 +177,38 @@ describe Qiita::Markdown::Processor do
       end
     end
 
+    context "with data-attribute" do
+      before do
+        context[:script] = true
+      end
+
+      let(:markdown) do
+        <<-EOS.strip_heredoc
+          <script async data-a="b">alert(1)</script>
+        EOS
+      end
+
+      it "allows data-attributes" do
+        should eq markdown
+      end
+    end
+
+    context "with iframe" do
+      before do
+        context[:script] = true
+      end
+
+      let(:markdown) do
+        <<-EOS.strip_heredoc
+          <iframe width="1" height="2" src="//example.com" frameborder="0" allowfullscreen></iframe>
+        EOS
+      end
+
+      it "allows iframe with some attributes" do
+        should eq markdown
+      end
+    end
+
     context "with mention" do
       let(:markdown) do
         "@alice"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: qiita-markdown
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - Ryo Nakamura