qbwc_requests 0.1.01 → 0.1.02

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 263022899abcdb89c5e828e71307efb086b8a953
-  data.tar.gz: 132ff2c1c2465c38e1c7aadb3f29bc7ece9779ca
+  metadata.gz: 9a3cae709f8032807cdca10ef5c1e786d52a87cf
+  data.tar.gz: 7ef0bcc248bdc8d307a706910dfc69e2ccbde575
 SHA512:
-  metadata.gz: 0990f1cc4ddaf7ba4e86135f9fd1ba5da855a39cef1cf334a82db5e7f64297d782dc3a671ed21e8b03dcb94cf54fa60c98c7ea2354658fc8547cecd499502693
-  data.tar.gz: 9dd0163235f18c77226801d56105b96f04073f7580271c0a323e6c9e64e271e048f090ea40feaa59bd15bc7a0425362942c7fe186b64901c75318f19aeb6e6af
+  metadata.gz: f5432213508fdb31a8e3a37b6ebd7243823d42c7c17fac12085d1c5542f7f251fc7e5fe9ec8c8e7d41d1c71dbcf00ae3d38e2be3b033a1e7dc1a0828298b51a1
+  data.tar.gz: ad7f17f3a7066f60aa54da235ac2bb277fa3f3800dcf4d6eb1d72d608ace68cee334b6d27c473728b0534d89eaf5b77c5e7fbee5567b60e2722b5dc3e07815a5

data/lib/qbwc_requests/qbwc/request/base.rb

@@ -19,7 +19,7 @@ module Qbwc
       def initialize(attributes = {})
         @attributes = compact(attributes)
         @attributes.each do |name, value|
-          self.instance_variable_set("@#{name}", value)
+          self.instance_variable_set("@#{name}", value) if value.present?
         end
       end
 
@@ -44,9 +44,9 @@ module Qbwc
         def compact opts={}
           # I pass two times to avoid {v: '1',k: {}}, gotta find a better algorithm (recursive)
           return {} if opts.nil?
-          proc = Proc.new { |k, v| v.kind_of?(Hash) ? (v.delete_if(&proc); nil) : v.empty? };
+          proc = Proc.new { |k, v| v.kind_of?(Hash) ? (v.delete_if(&proc); nil) : (v == nil || v.empty?) };
           hash = opts.delete_if(&proc)
-          hash.delete_if { |k, v| v.empty? }
+          hash.delete_if { |k, v| (v == nil || v.empty?) }
         end
 
         def add_xml

data/lib/qbwc_requests/version.rb

@@ -1,3 +1,3 @@
 module QbwcRequests
-  VERSION = "0.1.01"
+  VERSION = "0.1.02"
 end

data/spec/qbwc/request/base_spec.rb

@@ -1,7 +1,10 @@
 require 'spec_helper'
 
 class GenericBase < Qbwc::Request::Base
-
+  field :vendor_ref
+  field :ref_number
+  field :memo
+  field :purchase_order_line_add
 end
 
 describe GenericBase do
@@ -16,4 +19,43 @@ describe GenericBase do
 
   end
 
+
+  describe '#add' do
+
+    let(:parameters) {
+      {
+        :vendor_ref => {
+          :list_ID => nil
+        },
+        :ref_number => nil,
+        :memo => nil,
+        :purchase_order_line_add => []
+      }
+    }
+
+    it 'should not raise error for nil values' do
+      expect {
+        GenericBase.new(parameters).add()
+      }.to_not raise_error
+    end
+
+    it 'should generate a xml with just the filled fields' do
+
+      expected_xml = <<-XML
+        <?xml version='1.0' encoding='utf-8'?>
+        <?qbxml version="7.0"?>
+        <QBXML>
+          <QBXMLMsgsRq onError="stopOnError">
+            <GenericBaseAddRq requestID="2">
+              <GenericBaseAdd></GenericBaseAdd>
+            </GenericBaseAddRq>
+          </QBXMLMsgsRq>
+        </QBXML>
+      XML
+      add_xml = GenericBase.new(parameters).add()
+      expect( add_xml ).to be_xml_equal_to expected_xml
+    end
+
+  end
+
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: qbwc_requests
 version: !ruby/object:Gem::Version
-  version: 0.1.01
+  version: 0.1.02
 platform: ruby
 authors:
 - Alexandre Mondaini Calvão
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-06-24 00:00:00.000000000 Z
+date: 2015-06-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: qbxml