qa_server 7.4.0 → 7.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 98cc1d63f4dab80fb1135ddbbef562943e596cae
-  data.tar.gz: 0e90cb6702c55c536e8d16d9e9d157127f695446
+SHA256:
+  metadata.gz: 9b6bf0cabbc1c7f810733789f43c7f0b253f71b0d887fd5be6638aacd3a7e6be
+  data.tar.gz: '0988c35dcea9f1dd1dc565db686835bd63a5812c5ed198f0d39f3e83a055e684'
 SHA512:
-  metadata.gz: 650b0109a2a047900a74272b1e1662a4ce90df5ce830bc47c3def63f115019c72c0ec2c757b25064de73de1694914781ea4a5c6fa0088f36da2a1bdaaceaed5d
-  data.tar.gz: 476c4f9489b0a0ea99df541ef1d7067c90b5b9555d24f26a122783947c6e9888a419a0a59161fbbdbd97a07210580e0ace2f6b98bfe63b95bec64316ffa58cb8
+  metadata.gz: ee5d4b62a4176cdc00a31446541a9e421506cc1ceca98066ff684a51346c976ced23a6778931365f5023ede8ec4d52784326b0af52865599c078401363e34444
+  data.tar.gz: 545ee665c7eceb70ed8459033d86247eeb4a414010b95a41f2cfe4393983e809e9b7756027c6da115df3ea6452f2f97643ba53e2976614f151a2b9578ec59a68

data/.rubocop_fixme.yml

@@ -12,3 +12,9 @@ Lint/UnusedMethodArgument:
 Style/SpecialGlobalVars:
   Exclude:
     - 'tasks/qa_server_dev.rake'
+
+Layout/AccessModifierIndentation:
+  EnforcedStyle: outdent
+
+#Layout/IndentationWidth:
+#  Enabled: false

data/.travis.yml

@@ -13,9 +13,9 @@ before_install:
   - google-chrome-stable --headless --disable-gpu --no-sandbox --remote-debugging-port=9222 http://localhost &
 
 rvm:
-  - 2.4.6
-  - 2.5.5
-  - 2.6.3
+  - 2.5.8
+  - 2.6.6
+  - 2.7.1
 
 env:
   global:
@@ -26,8 +26,7 @@ env:
   # It should be sufficient to test only the latest of the patch versions for a minor version, they
   # should be compatible across patch versions (only bug fixes are released in patch versions).
   matrix:
-    - "RAILS_VERSION=5.1.7"
-    - "RAILS_VERSION=5.2.3"
+    - "RAILS_VERSION=5.2.4"
 
 services:
   - redis-server

data/CHANGELOG.md

@@ -1,3 +1,23 @@
+### 7.5.0 (2020-12-07)
+
+* UI improvements of check_status page
+  * pre-populate selection fields with most recently submitted authorities
+  * add ability to compare two authorities' accuracy tests in UI
+  * update check_status UI to require GO button click to start processing
+  * fix javascript to avoid referencing missing elements
+* accuracy test updates
+  * accuracy tests default to `context=false` since it is not required for testing
+  * allow accuracy tests through rspec to be marked pending (allows for better regression testing)
+  * add pending to failing validation tests such that accuracy_spec passes
+  * sync tests with production accuracy tests
+  * fix typo in `position` and a few syntax errors
+  * adjust result_size for validations where passing tests return less than 200 chars
+  * split locnames_rwo_ld4l_cache into 3 sets of tests of about 9 each to avoid time out
+  * add extended context for getty_aat_ld4l_cache and getty_tgn_ld4l_cache
+  * add authority locvocabs_ld4l_cache
+* add request_data to status_logger (e.g. query for search, identifier for term)
+* update to latest bixby v3.0
+
 ### 7.4.0 (2020-04-13)
 
 * add size and complexity performance statistics (not auto-generated)

data/Rakefile

@@ -9,7 +9,7 @@ end
 Bundler::GemHelper.install_tasks
 
 # Set up the test application prior to running jasmine tasks.
-task :setup_test_server do
+task setup_test_server: :environment do
   require 'engine_cart'
   EngineCart.load_application!
 end

data/app/assets/stylesheets/qa_server/_check-status.scss

@@ -25,6 +25,23 @@ div#example-url-warning {
   color: #4d0000;
 }
 
+div#authority-selector {
+  margin-top: 20px;
+  margin-bottom: 0px;
+  margin-left: 20px;
+  margin-right: 20px;
+  width: 40%;
+}
+
+div#comparison-authority-selector {
+  display: none;
+  margin-top: 20px;
+  margin-bottom: 0px;
+  margin-left: 20px;
+  margin-right: 20px;
+  width: 40%;
+}
+
 div.status-section {
   margin-top: 50px;
 }
@@ -43,6 +60,20 @@ table, th, td {
   padding: 5px;
 }
 
+th.comparison-header {
+  background-color: #2e2c2c;
+}
+
+th.comparison-before {
+  text-align: center;
+  color: #f4f360;
+}
+
+th.comparison-after {
+  text-align: center;
+  color: #7df34c;
+}
+
 th {
   background-color: #a1b1c4;
   color: black;
@@ -52,6 +83,11 @@ td.position {
   text-align: center;
 }
 
+th.bold-left-border,
+td.bold-left-border {
+  border-left: 2px solid black;
+}
+
 .status-good {
   text-align: center;
   background-color: #ccffcc;

data/app/cache_processors/qa_server/cache_expiry_service.rb

@@ -24,15 +24,15 @@ module QaServer
         force
       end
 
-      private
+    private
 
-        # @return [ActiveSupport::TimeWithZone] DateTime at which cache should expire
-        def cache_expires_at
-          offset = QaServer.config.hour_offset_to_expire_cache
-          offset_time = QaServer::TimeService.current_time
-          offset_time = offset_time.tomorrow unless (offset_time + 5.minutes).hour < offset
-          offset_time.beginning_of_day + offset.hours - 5.minutes
-        end
+      # @return [ActiveSupport::TimeWithZone] DateTime at which cache should expire
+      def cache_expires_at
+        offset = QaServer.config.hour_offset_to_expire_cache
+        offset_time = QaServer::TimeService.current_time
+        offset_time = offset_time.tomorrow unless (offset_time + 5.minutes).hour < offset
+        offset_time.beginning_of_day + offset.hours - 5.minutes
+      end
     end
   end
 end

data/app/cache_processors/qa_server/job_id_cache.rb

@@ -19,11 +19,11 @@ module QaServer
         Rails.cache.delete(cache_key(job_key))
       end
 
-      private
+    private
 
-        def cache_key(job_key)
-          "#{job_key}-job_id"
-        end
+      def cache_key(job_key)
+        "#{job_key}-job_id"
+      end
     end
   end
 end

data/app/cache_processors/qa_server/performance_cache.rb

@@ -49,45 +49,45 @@ module QaServer
       cache_to_write = nil # free cache for garbage collection
     end
 
-    private
+  private
 
-      def swap_cache_hash
-        cache_to_write = @cache
-        @cache = {} # reset main cache so new items after write begins are cached in the main cache
-        QaServer.config.performance_cache_logger.debug("#{self.class}##{__method__} - cache memory BEFORE write: #{ObjectSpace.memsize_of(cache_to_write)}")
-        cache_to_write
-      end
+    def swap_cache_hash
+      cache_to_write = @cache
+      @cache = {} # reset main cache so new items after write begins are cached in the main cache
+      QaServer.config.performance_cache_logger.debug("#{self.class}##{__method__} - cache memory BEFORE write: #{ObjectSpace.memsize_of(cache_to_write)}")
+      cache_to_write
+    end
 
-      def log(id:)
-        return if QaServer.config.suppress_logging_performance_datails?
-        Rails.logger.debug("*** performance data for id: #{id} ***")
-        Rails.logger.debug(@cache[id].to_yaml)
-      end
+    def log(id:)
+      return if QaServer.config.suppress_logging_performance_datails?
+      Rails.logger.debug("*** performance data for id: #{id} ***")
+      Rails.logger.debug(@cache[id].to_yaml)
+    end
 
-      def incomplete?(entry)
-        required_keys.each { |k| return true unless entry.key? k }
-        false
-      end
+    def incomplete?(entry)
+      required_keys.each { |k| return true unless entry.key? k }
+      false
+    end
 
-      def required_keys
-        [:dt_stamp,
-         :authority,
-         :action,
-         :action_time_ms,
-         :size_bytes,
-         :retrieve_time_ms,
-         :graph_load_time_ms,
-         :normalization_time_ms]
-      end
+    def required_keys
+      [:dt_stamp,
+       :authority,
+       :action,
+       :action_time_ms,
+       :size_bytes,
+       :retrieve_time_ms,
+       :graph_load_time_ms,
+       :normalization_time_ms]
+    end
 
-      def log_write_all(prefix, size_before, cache_size)
-        if size_before.positive?
-          QaServer.config.performance_cache_logger.debug("#{prefix} 0 of #{size_before} performance data records were saved") if size_before == cache_size
-          QaServer.config.performance_cache_logger.debug("#{prefix} #{size_before - cache_size} of #{size_before} performance data records were saved") if size_before > cache_size
-        else
-          QaServer.config.performance_cache_logger.debug("#{prefix} 0 of 0 performance data records were saved")
-        end
-        QaServer.config.performance_cache_logger.debug("#{prefix} - cache memory AFTER write: #{ObjectSpace.memsize_of @cache}")
+    def log_write_all(prefix, size_before, cache_size)
+      if size_before.positive?
+        QaServer.config.performance_cache_logger.debug("#{prefix} 0 of #{size_before} performance data records were saved") if size_before == cache_size
+        QaServer.config.performance_cache_logger.debug("#{prefix} #{size_before - cache_size} of #{size_before} performance data records were saved") if size_before > cache_size
+      else
+        QaServer.config.performance_cache_logger.debug("#{prefix} 0 of 0 performance data records were saved")
       end
+      QaServer.config.performance_cache_logger.debug("#{prefix} - cache memory AFTER write: #{ObjectSpace.memsize_of @cache}")
+    end
   end
 end

data/app/cache_processors/qa_server/performance_day_graph_cache.rb

@@ -13,15 +13,15 @@ module QaServer
         end
       end
 
-      private
+    private
 
-        def cache_key
-          "QaServer::PerformanceDayGraphCache.generate_graphs--latest_generation_initiated"
-        end
+      def cache_key
+        "QaServer::PerformanceDayGraphCache.generate_graphs--latest_generation_initiated"
+      end
 
-        def next_expiry
-          QaServer::CacheExpiryService.end_of_hour_expiry
-        end
+      def next_expiry
+        QaServer::CacheExpiryService.end_of_hour_expiry
+      end
     end
   end
 end

data/app/cache_processors/qa_server/performance_month_graph_cache.rb

@@ -13,15 +13,15 @@ module QaServer
         end
       end
 
-      private
+    private
 
-        def cache_key
-          "QaServer::PerformanceMonthGraphCache.generate_graphs--latest_generation_initiated"
-        end
+      def cache_key
+        "QaServer::PerformanceMonthGraphCache.generate_graphs--latest_generation_initiated"
+      end
 
-        def next_expiry
-          QaServer::CacheExpiryService.cache_expiry
-        end
+      def next_expiry
+        QaServer::CacheExpiryService.cache_expiry
+      end
     end
   end
 end

data/app/cache_processors/qa_server/performance_year_graph_cache.rb

@@ -13,15 +13,15 @@ module QaServer
         end
       end
 
-      private
+    private
 
-        def cache_key
-          "QaServer::PerformanceYearGraphCache.generate_graphs--latest_generation_initiated"
-        end
+      def cache_key
+        "QaServer::PerformanceYearGraphCache.generate_graphs--latest_generation_initiated"
+      end
 
-        def next_expiry
-          QaServer::CacheExpiryService.cache_expiry
-        end
+      def next_expiry
+        QaServer::CacheExpiryService.cache_expiry
+      end
     end
   end
 end

data/app/cache_processors/qa_server/scenario_history_cache.rb

@@ -21,15 +21,15 @@ module QaServer
         end
       end
 
-      private
+    private
 
-        def cache_key_for_historical_data
-          SCENARIO_RUN_HISTORY_DATA_CACHE_KEY
-        end
+      def cache_key_for_historical_data
+        SCENARIO_RUN_HISTORY_DATA_CACHE_KEY
+      end
 
-        def next_expiry
-          QaServer::CacheExpiryService.cache_expiry
-        end
+      def next_expiry
+        QaServer::CacheExpiryService.cache_expiry
+      end
     end
   end
 end

data/app/cache_processors/qa_server/scenario_history_graph_cache.rb

@@ -13,15 +13,15 @@ module QaServer
         end
       end
 
-      private
+    private
 
-        def cache_key
-          "QaServer::ScenarioHistoryGraphCache.generate_graph--latest_generation_initiated"
-        end
+      def cache_key
+        "QaServer::ScenarioHistoryGraphCache.generate_graph--latest_generation_initiated"
+      end
 
-        def next_expiry
-          QaServer::CacheExpiryService.cache_expiry
-        end
+      def next_expiry
+        QaServer::CacheExpiryService.cache_expiry
+      end
     end
   end
 end

data/app/cache_processors/qa_server/scenario_run_cache.rb

@@ -14,15 +14,15 @@ module QaServer
         end
       end
 
-      private
+    private
 
-        def cache_key
-          "QaServer::ScenarioRunCache.run_tests--latest_run_initiated"
-        end
+      def cache_key
+        "QaServer::ScenarioRunCache.run_tests--latest_run_initiated"
+      end
 
-        def next_expiry
-          QaServer::CacheExpiryService.cache_expiry
-        end
+      def next_expiry
+        QaServer::CacheExpiryService.cache_expiry
+      end
     end
   end
 end

data/app/cache_processors/qa_server/scenario_run_failures_cache.rb

@@ -37,15 +37,15 @@ module QaServer
         end
       end
 
-      private
+    private
 
-        def cache_key_for_run_failures(id)
-          "#{SCENARIO_RUN_FAILURE_DATA_CACHE_KEY}--#{id}{"
-        end
+      def cache_key_for_run_failures(id)
+        "#{SCENARIO_RUN_FAILURE_DATA_CACHE_KEY}--#{id}{"
+      end
 
-        def next_expiry
-          QaServer::CacheExpiryService.cache_expiry
-        end
+      def next_expiry
+        QaServer::CacheExpiryService.cache_expiry
+      end
     end
   end
 end

data/app/cache_processors/qa_server/scenario_run_summary_cache.rb

@@ -26,15 +26,15 @@ module QaServer
         end
       end
 
-      private
+    private
 
-        def cache_key_for_run_summary(id)
-          "#{SCENARIO_RUN_SUMMARY_DATA_CACHE_KEY}--#{id}"
-        end
+      def cache_key_for_run_summary(id)
+        "#{SCENARIO_RUN_SUMMARY_DATA_CACHE_KEY}--#{id}"
+      end
 
-        def next_expiry
-          QaServer::CacheExpiryService.cache_expiry
-        end
+      def next_expiry
+        QaServer::CacheExpiryService.cache_expiry
+      end
     end
   end
 end