pxpay 0.2.1 → 0.2.2

data/Gemfile

@@ -8,7 +8,7 @@ source "http://rubygems.org"
 group :development do
   gem "shoulda", ">= 0"
   gem "bundler", "~> 1.0.0"
-  gem "jeweler", "~> 1.5.2"
+  gem "jeweler", "~> 1.6"
   gem "rcov", ">= 0"
   gem "builder"
   gem "nokogiri"

data/Gemfile.lock

@@ -3,7 +3,7 @@ GEM
   specs:
     builder (2.1.2)
     git (1.2.5)
-    jeweler (1.5.2)
+    jeweler (1.6.0)
       bundler (~> 1.0.0)
       git (>= 1.2.5)
       rake
@@ -21,7 +21,7 @@ PLATFORMS
 DEPENDENCIES
   builder
   bundler (~> 1.0.0)
-  jeweler (~> 1.5.2)
+  jeweler (~> 1.6)
   nokogiri
   rcov
   rest-client

data/README.md

@@ -14,8 +14,8 @@ Installation
 ------------
 Install from Rubygems
     gem install pxpay
-Then run `rails generate pxpay:install` to copy an initializer and a config yml file to your rails app.
-Make sure you add your own development credentials to the `config/initializers/pxpay.rb` file and create success and failure URLs for Payment Express to redirect you back.
+Then run `rails generate pxpay:install` to copy an initializer to your rails app.
+Make sure you add your own development credentials to the `config/initializers/pxpay.rb` file
 You can apply for a development account at <https://www.paymentexpress.com/pxmi/apply>
 
 
@@ -52,8 +52,12 @@ This means your success/failure URL will be hit at least twice for each transact
 
 
 Token Billing can be implemented by setting `:token_billing => true` inside the Request option hash.
+
+
 N.B.
 ----
+The source of most non-gem related errors comes from the fact that Payment Express caches the details of a transaction with the ID given.
+If you are having problems with the wrong price being charged or an invalid card type error make sure you are sending a unique ID through with each transaction.
 
 This gem is in no way endorsed or affiliated with Payment Express
 
@@ -61,7 +65,6 @@ TODO
 ----
 * Add ability to set global configuration options
 * Add more tests
-* Add support for optional text fields
 
 Contributing to PxPay
 =====================

data/VERSION

@@ -1 +1 @@
-0.2.1
+0.2.2

data/lib/pxpay/request.rb

@@ -11,21 +11,22 @@ module Pxpay
     # Create a new instance of Pxpay::Request
     # Pxpay::Request.new( id, amount, options = {} )
     # Current available options are:
-    # :currency_input,  currency for transaction, default is NZD, can be any of Pxpay::Base.currency_types
-    # :reference,       a reference field, default is the id.
-    # :email_address,   email address of user, optional.
-    # :token_billing,   boolean value, set to true to enable token billing.
-    # :billing_id,      optional billing_id field only used if token_billing is set to true.
-    # :txn_type,        can be set to :auth for Auth transaction, defaults to Purchase
-    # :url_success,     Success URL, can optionally be set globally via Pxpay::Base.url_success=
-    # :url_failure,     Failure URL, can optionally be set globally via Pxpay::Base.url_failure=
-    # :txn_data1,       Optional data
-    # :txn_data2,       Optional data
-    # :txn_data3,       Optional data
-    # :txn_data4,       Optional data
-    # :opt,             Optional data
+    # :currency_input,      currency for transaction, default is NZD, can be any of Pxpay::Base.currency_types
+    # :merchant_reference,  a reference field, default is the id.
+    # :email_address,       email address of user, optional.
+    # :token_billing,       boolean value, set to true to enable token billing.
+    # :billing_id,          optional billing_id field only used if token_billing is set to true.
+    # :txn_type,            can be set to :auth for Auth transaction, defaults to Purchase
+    # :url_success,         Success URL, can optionally be set globally via Pxpay::Base.url_success=
+    # :url_failure,         Failure URL, can optionally be set globally via Pxpay::Base.url_failure=
+    # :txn_data1,           Optional data
+    # :txn_data2,           Optional data
+    # :txn_data3,           Optional data
+    # :txn_data4,           Optional data
+    # :opt,                 Optional data
     
     def initialize( id , price, options = {} )
+      warn "Using :reference is deprecated, please use :merchant_reference instead" if options[:reference]
       @post = build_xml( id, price, options )
     end
     
@@ -54,19 +55,19 @@ module Pxpay
         xml.PxPayKey          ::Pxpay::Base.pxpay_key
         xml.AmountInput       sprintf("%.2f", price)
         xml.TxnId             id
-        xml.TxnType           options[:txn_type]        ? options[:txn_type].to_s.capitalize : "Purchase"
-        xml.CurrencyInput     options[:currency_input]  || "NZD"
-        xml.MerchantReference options[:reference]       || id.to_s
-        xml.UrlSuccess        options[:url_success]     || ::Pxpay::Base.url_success 
-        xml.UrlFail           options[:url_failure]     || ::Pxpay::Base.url_failure
-        xml.EmailAddress      options[:email_address]   if options[:email_address]
-        xml.TxnData1          options[:txn_data1]       if options[:txn_data1]
-        xml.TxnData2          options[:txn_data2]       if options[:txn_data2]
-        xml.TxnData3          options[:txn_data3]       if options[:txn_data3]
-        xml.TxnData4          options[:txn_data4]       if options[:txn_data4]
-        xml.Opt               options[:opt]             if options[:opt]
-        xml.EnableAddBillCard 1                         if options[:token_billing]
-        xml.BillingId         options[:billing_id]      if options[:token_billing]
+        xml.TxnType           options[:txn_type]            ? options[:txn_type].to_s.capitalize : "Purchase"
+        xml.CurrencyInput     options[:currency_input]      || "NZD"
+        xml.MerchantReference options[:merchant_reference]  || options[:reference]       || id.to_s ## Backwards compatibility
+        xml.UrlSuccess        options[:url_success]         || ::Pxpay::Base.url_success 
+        xml.UrlFail           options[:url_failure]         || ::Pxpay::Base.url_failure
+        xml.EmailAddress      options[:email_address]       if options[:email_address]
+        xml.TxnData1          options[:txn_data1]           if options[:txn_data1]
+        xml.TxnData2          options[:txn_data2]           if options[:txn_data2]
+        xml.TxnData3          options[:txn_data3]           if options[:txn_data3]
+        xml.TxnData4          options[:txn_data4]           if options[:txn_data4]
+        xml.Opt               options[:opt]                 if options[:opt]
+        xml.EnableAddBillCard 1                             if options[:token_billing]
+        xml.BillingId         options[:billing_id]          if options[:token_billing]
       end
     end
   end

data/pxpay.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{pxpay}
-  s.version = "0.2.1"
+  s.version = "0.2.2"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Bradley Priest"]
-  s.date = %q{2011-04-27}
+  s.date = %q{2011-05-15}
   s.description = %q{A Ruby wrapper around the DPS-hosted PxPay service}
   s.email = %q{bradleypriest@gmail.com}
   s.extra_rdoc_files = [
@@ -41,20 +41,17 @@ Gem::Specification.new do |s|
   s.homepage = %q{http://github.com/bradleypriest/pxpay}
   s.licenses = ["MIT"]
   s.require_paths = ["lib"]
-  s.rubygems_version = %q{1.5.2}
+  s.rubygems_version = %q{1.3.7}
   s.summary = %q{Ruby wrapper for the Payment Express' PxPay API}
-  s.test_files = [
-    "test/helper.rb",
-    "test/test_pxpay.rb"
-  ]
 
   if s.respond_to? :specification_version then
+    current_version = Gem::Specification::CURRENT_SPECIFICATION_VERSION
     s.specification_version = 3
 
     if Gem::Version.new(Gem::VERSION) >= Gem::Version.new('1.2.0') then
       s.add_development_dependency(%q<shoulda>, [">= 0"])
       s.add_development_dependency(%q<bundler>, ["~> 1.0.0"])
-      s.add_development_dependency(%q<jeweler>, ["~> 1.5.2"])
+      s.add_development_dependency(%q<jeweler>, ["~> 1.6"])
       s.add_development_dependency(%q<rcov>, [">= 0"])
       s.add_development_dependency(%q<builder>, [">= 0"])
       s.add_development_dependency(%q<nokogiri>, [">= 0"])
@@ -65,7 +62,7 @@ Gem::Specification.new do |s|
     else
       s.add_dependency(%q<shoulda>, [">= 0"])
       s.add_dependency(%q<bundler>, ["~> 1.0.0"])
-      s.add_dependency(%q<jeweler>, ["~> 1.5.2"])
+      s.add_dependency(%q<jeweler>, ["~> 1.6"])
       s.add_dependency(%q<rcov>, [">= 0"])
       s.add_dependency(%q<builder>, [">= 0"])
       s.add_dependency(%q<nokogiri>, [">= 0"])
@@ -77,7 +74,7 @@ Gem::Specification.new do |s|
   else
     s.add_dependency(%q<shoulda>, [">= 0"])
     s.add_dependency(%q<bundler>, ["~> 1.0.0"])
-    s.add_dependency(%q<jeweler>, ["~> 1.5.2"])
+    s.add_dependency(%q<jeweler>, ["~> 1.6"])
     s.add_dependency(%q<rcov>, [">= 0"])
     s.add_dependency(%q<builder>, [">= 0"])
     s.add_dependency(%q<nokogiri>, [">= 0"])

metadata

@@ -1,8 +1,12 @@
 --- !ruby/object:Gem::Specification 
 name: pxpay
 version: !ruby/object:Gem::Version 
-  prerelease: 
-  version: 0.2.1
+  prerelease: false
+  segments: 
+  - 0
+  - 2
+  - 2
+  version: 0.2.2
 platform: ruby
 authors: 
 - Bradley Priest
@@ -10,7 +14,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-04-27 00:00:00 +12:00
+date: 2011-05-15 00:00:00 +12:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -20,6 +24,8 @@ dependencies:
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
+        segments: 
+        - 0
         version: "0"
   type: :development
   prerelease: false
@@ -31,6 +37,10 @@ dependencies:
     requirements: 
     - - ~>
       - !ruby/object:Gem::Version 
+        segments: 
+        - 1
+        - 0
+        - 0
         version: 1.0.0
   type: :development
   prerelease: false
@@ -42,7 +52,10 @@ dependencies:
     requirements: 
     - - ~>
       - !ruby/object:Gem::Version 
-        version: 1.5.2
+        segments: 
+        - 1
+        - 6
+        version: "1.6"
   type: :development
   prerelease: false
   version_requirements: *id003
@@ -53,6 +66,8 @@ dependencies:
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
+        segments: 
+        - 0
         version: "0"
   type: :development
   prerelease: false
@@ -64,6 +79,8 @@ dependencies:
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
+        segments: 
+        - 0
         version: "0"
   type: :development
   prerelease: false
@@ -75,6 +92,8 @@ dependencies:
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
+        segments: 
+        - 0
         version: "0"
   type: :development
   prerelease: false
@@ -86,6 +105,8 @@ dependencies:
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
+        segments: 
+        - 0
         version: "0"
   type: :development
   prerelease: false
@@ -97,6 +118,8 @@ dependencies:
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
+        segments: 
+        - 0
         version: "0"
   type: :runtime
   prerelease: false
@@ -108,6 +131,8 @@ dependencies:
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
+        segments: 
+        - 0
         version: "0"
   type: :runtime
   prerelease: false
@@ -119,6 +144,8 @@ dependencies:
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
+        segments: 
+        - 0
         version: "0"
   type: :runtime
   prerelease: false
@@ -167,7 +194,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
-      hash: -3326667328160921882
+      hash: 3196313653595730493
       segments: 
       - 0
       version: "0"
@@ -176,14 +203,15 @@ required_rubygems_version: !ruby/object:Gem::Requirement
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
+      segments: 
+      - 0
       version: "0"
 requirements: []
 
 rubyforge_project: 
-rubygems_version: 1.5.2
+rubygems_version: 1.3.7
 signing_key: 
 specification_version: 3
 summary: Ruby wrapper for the Payment Express' PxPay API
-test_files: 
-- test/helper.rb
-- test/test_pxpay.rb
+test_files: []
+