pwwka 0.21.1 → 0.21.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 203046e40a742cdaa8e606739292777af728af3931b26f5ded94718a7cc5b3a6
-  data.tar.gz: 4448188accc4a71b4a4ee82fdb2f53a85eef1d94d19e9711ced0626f399dc449
+  metadata.gz: 913ec15d6763b56d762da0c368fa6caba28cc208a18f8aaba9349363e29097ef
+  data.tar.gz: 469f8b149b50c84ced5373ef6fe8cf8533593ecb9f9a0f78eee278b49bccbbd1
 SHA512:
-  metadata.gz: e5a528af9bf9665fcddd319690431755951f0afee95f0b2f5de93e71611c85c28fb70f880ec4c156bdabfbe3586f75b721eaeb38196d2669fdbaf6ba3f290004
-  data.tar.gz: 601734c090c23ec549c2a7ab65b245984c7c276e45d14df975c6ed028488525c4d3cef06793d6f785dd66a98b45ada1de78368f9a7e72595681d2ed66dade04e
+  metadata.gz: 3d5ac493402d2afd1857ee86faa80b4043d91a4d7dc2837beb3fb9a8ff5cb729af4b9d00f2e7d763f9513856d2f3f518cde6c08710c2f9221240136d0ac31255
+  data.tar.gz: 41a48b20fa6a9fbc47383cd3d993372f8b0ad3a2fa4ddd0e85c6948dd07c469bfe2090b83aa62f7bc58a3067db443d90caa9b2f6f4ed7d98314bb7520d1ca99b

data/lib/pwwka/channel_connector.rb

@@ -1,5 +1,7 @@
 module Pwwka
   class ChannelConnector
+    extend Pwwka::Logging
+    include Pwwka::Logging
 
     attr_reader :connection
     attr_reader :configuration
@@ -12,13 +14,16 @@ module Pwwka
       @configuration     = Pwwka.configuration
       connection_options = {automatically_recover: false}.merge(configuration.options)
       connection_options = {client_properties: {connection_name: connection_name}}.merge(connection_options) if connection_name
-      @connection        = Bunny.new(configuration.rabbit_mq_host,
-                                  connection_options)
+      @connection        = Bunny.new(configuration.rabbit_mq_host, connection_options)
       @connection.start
       @channel           = @connection.create_channel
       if prefetch
         @channel.prefetch(prefetch.to_i)
       end
+    rescue => e
+      logf "ERROR Connecting to RabbitMQ", error: e
+      @connection.close if @connection
+      raise e
     end
 
     def topic_exchange

data/lib/pwwka/version.rb

@@ -1,4 +1,4 @@
 module Pwwka
-  VERSION = '0.21.1'
+  VERSION = '0.21.2'
 end
 

data/spec/unit/channel_connector_spec.rb

@@ -12,6 +12,7 @@ describe Pwwka::ChannelConnector do
     before do
       allow(Bunny).to receive(:new).and_return(bunny_session)
       allow(bunny_session).to receive(:start)
+      allow(bunny_session).to receive(:close)
       allow(bunny_session).to receive(:create_channel).and_return(bunny_channel)
     end
 
@@ -45,6 +46,24 @@ describe Pwwka::ChannelConnector do
       described_class.new
     end
 
+    context "error during connection start" do
+      before do
+        allow(bunny_session).to receive(:start).and_raise("Connection Error!")
+      end
+      it "closes the connection" do
+        begin
+          described_class.new
+        rescue => ex
+        end
+        expect(bunny_session).to have_received(:close)
+      end
+      it "raises an error" do
+        expect {
+          described_class.new
+        }.to raise_error(/Connection Error!/)
+      end
+    end
+
   end
 
   describe "raise_if_delayed_not_allowed" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: pwwka
 version: !ruby/object:Gem::Version
-  version: 0.21.1
+  version: 0.21.2
 platform: ruby
 authors:
 - Stitch Fix Engineering