pwwka 0.0.2 → 0.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ab413d6cec5031e40f04a92fc87f117bfbab457d
-  data.tar.gz: 0791952942b76c40e8106da29fcbc1ab3051b8d3
+  metadata.gz: 8cf3c8a949bbd8b4d824a31484de0349a16c79d9
+  data.tar.gz: 0f53407b75ed79d8cbd3d85cd5945e2a988edeba
 SHA512:
-  metadata.gz: 12554c6f0ed97ba914939cd42f4e37856e9faf7164f74573af3f9f0138cabc7b3122d66827550118d049892067b833af4bf3250697208347e99a21da934d74e9
-  data.tar.gz: e2beebd8979bde2f0846cc24888d6ac1bbf08e287a6aff9b6a40abd5518fa011664df4ccb226298ae9f389c58b8b6e9c5497ad4d53d4ab70e832c64e21b50b47
+  metadata.gz: 570f563f482b9992a0e9d55d8206ac74484d49ecfbc0d3b01d3819f5616f714b7e5f0203f21700a4b0011f6507daf06bc70dad7753a718430e51c99603f08b2d
+  data.tar.gz: 87786f3b94d21352bc2148708514eb8558d61edb3cfc80037a271ca8c69c50e9eb61fc5d22a3d2676615917469c5e1bacea5528243a2bd39315ea59317eaa2a1

data/Gemfile.lock

@@ -1,12 +1,11 @@
 PATH
   remote: .
   specs:
-    pwwka (0.0.2)
+    pwwka (0.1.0)
       activemodel
       activesupport
       bunny
       mono_logger
-      sucker_punch
 
 GEM
   remote: https://www.rubygems.org/
@@ -24,8 +23,6 @@ GEM
     builder (3.2.2)
     bunny (1.4.0)
       amq-protocol (>= 1.9.2)
-    celluloid (0.15.2)
-      timers (~> 1.1.0)
     diff-lcs (1.2.5)
     i18n (0.6.11)
     json (1.8.1)
@@ -44,10 +41,7 @@ GEM
     rspec-mocks (3.0.4)
       rspec-support (~> 3.0.0)
     rspec-support (3.0.4)
-    sucker_punch (1.1)
-      celluloid (~> 0.15.2)
     thread_safe (0.3.4)
-    timers (1.1.0)
     tzinfo (1.2.2)
       thread_safe (~> 0.1)
 

data/lib/pwwka.rb

@@ -17,7 +17,6 @@ module Pwwka
 end
 
 require 'json'
-require 'sucker_punch'
 require 'active_support/inflector'
 require 'active_support/core_ext/module'
 require 'active_support/hash_with_indifferent_access'

data/lib/pwwka/transmitter.rb

@@ -1,27 +1,48 @@
 module Pwwka
+  # Primary interface for sending messages.
+  #
+  # Example:
+  #
+  #     # Send a message, blowing up if there's any problem
+  #     Pwwka::Transmitter.send_message!({ user_id: @user.id }, "users.user.activated")
+  #
+  #     # Send a message, logging if there's any problem
+  #     Pwwka::Transmitter.send_message_safely({ user_id: @user.id }, "users.user.activated")
   class Transmitter
 
     extend Pwwka::Logging
-    include SuckerPunch::Job
+    include Pwwka::Logging
 
+    # Send an important message that must go through.  This method allows any raised exception 
+    # to pass through.
+    #
+    # payload:: Hash of what you'd like to include in your message
+    # routing_key:: String routing key for the message
+    #
+    # Returns true
+    #
+    # Raises any exception generated by the innerworkings of this library.
     def self.send_message!(payload, routing_key)
-      new.async.send_message!(payload, routing_key)
-      info "BACKGROUND AFTER Transmitting Message on #{routing_key} -> #{payload}"
+      new.send_message!(payload, routing_key)
+      info "AFTER Transmitting Message on #{routing_key} -> #{payload}"
     end
 
+    # Send a less important message that doesn't have to go through. This eats
+    # any `StandardError` and logs it, returning false rather than blowing up.
+    #
+    # payload:: Hash of what you'd like to include in your message
+    # routing_key:: String routing key for the message
+    #
+    # Returns true if the message was sent, false otherwise
     def self.send_message_safely(payload, routing_key)
-      begin
-        send_message!(payload, routing_key)
-      rescue => e
-        error "Error Transmitting Message on #{routing_key} -> #{payload}: #{e}"
-        return false
-      end  
+      send_message!(payload, routing_key)
+    rescue => e
+      error "ERROR Transmitting Message on #{routing_key} -> #{payload}: #{e}"
+      false
     end
 
-    # send message asynchronously using sucker_punch
-    # call async.send_message!
     def send_message!(payload, routing_key)
-      self.class.info "BACKGROUND START Transmitting Message on #{routing_key} -> #{payload}"
+      info "START Transmitting Message on #{routing_key} -> #{payload}"
       channel_connector = ChannelConnector.new 
       channel_connector.topic_exchange.publish(
         payload.to_json,
@@ -29,10 +50,8 @@ module Pwwka
         persistent: true)
       channel_connector.connection_close
       # if it gets this far it has succeeded
-      self.class.info "BACKGROUND END Transmitting Message on #{routing_key} -> #{payload}"
-      return true
+      info "END Transmitting Message on #{routing_key} -> #{payload}"
+      true
     end
-
   end
-
 end

data/lib/pwwka/version.rb

@@ -1,3 +1,3 @@
 module Pwwka
-  VERSION = '0.0.2'
+  VERSION = '0.1.0'
 end

data/pwwka.gemspec

@@ -21,7 +21,6 @@ Gem::Specification.new do |s|
   s.add_dependency("bunny")
   s.add_dependency("activesupport")
   s.add_dependency("activemodel")
-  s.add_dependency("sucker_punch")
   s.add_dependency("mono_logger")
   s.add_development_dependency("rake")
   s.add_development_dependency("rspec")

data/spec/spec_helper.rb

@@ -1,13 +1,10 @@
 GEM_ROOT = File.expand_path(File.join(File.dirname(__FILE__),'..'))
 require 'pwwka'
 require 'pwwka/test_handler'
-require 'sucker_punch/testing/inline'
 Dir["#{GEM_ROOT}/spec/support/**/*.rb"].sort.each {|f| require f}
 
 RSpec.configure do |config|
 
-  SuckerPunch.logger = nil
-
   config.expect_with :rspec do |c|
     c.syntax = :expect
   end

data/spec/transmitter_spec.rb

@@ -15,7 +15,7 @@ describe Pwwka::Transmitter do
   describe "#send_message!" do
 
     it "should send the correct payload" do
-      success = Pwwka::Transmitter.new.async.send_message!(payload, routing_key)
+      success = Pwwka::Transmitter.new.send_message!(payload, routing_key)
       expect(success).to be_truthy
       received_payload = @test_handler.get_topic_message_payload_for_tests
       expect(received_payload["this"]).to eq("that")
@@ -24,7 +24,7 @@ describe Pwwka::Transmitter do
     it "should blow up if exception raised" do
       expect(Pwwka::ChannelConnector).to receive(:new).and_raise("blow up")
       expect {
-        Pwwka::Transmitter.new.async.send_message!(payload, routing_key)
+        Pwwka::Transmitter.new.send_message!(payload, routing_key)
       }.to raise_error
     end
 
@@ -38,11 +38,6 @@ describe Pwwka::Transmitter do
       expect(received_payload["this"]).to eq("that")
     end
 
-    it "should use sucker_punch to send the message in the background" do
-      expect_any_instance_of(Pwwka::Transmitter).to receive(:send_message!).with(payload, routing_key).and_return(true)
-      Pwwka::Transmitter.send_message!(payload, routing_key)
-    end
-
     it "should blow up if exception raised" do
       expect(Pwwka::ChannelConnector).to receive(:new).and_raise("blow up")
       expect{

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pwwka
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.1.0
 platform: ruby
 authors:
 - Stitch Fix Engineering
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-08-15 00:00:00.000000000 Z
+date: 2014-08-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bunny
@@ -52,20 +52,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-- !ruby/object:Gem::Dependency
-  name: sucker_punch
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 - !ruby/object:Gem::Dependency
   name: mono_logger
   requirement: !ruby/object:Gem::Requirement
@@ -163,7 +149,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.0
+rubygems_version: 2.2.0.rc.1
 signing_key: 
 specification_version: 4
 summary: Send and receive messages via RabbitMQ