pusher 1.4.2 → 1.4.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 81a153328f0e5452bcdd87e9cd09339464a26679566f1d14f087fee9a29a69b2
-  data.tar.gz: f5e282e3a9f0d60d441da0ef023073cefa1d4ebd2ada5b7fcb82a258a53c402a
+  metadata.gz: 4101c5a5932482beeedbb64514332771698b5c462f951d318f5b0412a379da1e
+  data.tar.gz: 10912c158ead0794e8b8ba7cc68d02e8ce4165458abd7cec6dd48d3583feadca
 SHA512:
-  metadata.gz: 87ed04a2e5bd63cfffd67798066dc9d014d119a00f7b6caad6c7d9a0d1a64c0a251c5f5b9706d883025532758e53f9a5d2f34579b555a206bb341182c624f58d
-  data.tar.gz: 7776a1f8477dc5d7d33efb0cb46edd3dfe0d77d7c40d691eb8cb525d71998216eb4fc7832b546fb7c43f7ec1bb1db5db32e169ed1d4d1c2cdd1291d89e9f8b73
+  metadata.gz: acdc1eb1c1630f04ab0e5de74c9d62c11bf1f9588421d1e130a641c7ee31a547e727c693c4a3a11bd035d800f0ba8721106f1b322bd36e5e97cde7a0c4dbbe43
+  data.tar.gz: 1692589eb319a5fa54560807af603e52ba368897e91363a81184dcdfa3cc3a5b120ecf2f87dea9c56d8e2ee2d689bf8cb3ccc1f6dc36db2095a0d338363b553c

data/CHANGELOG.md

@@ -1,3 +1,9 @@
+1.4.3 / 2020-10-28
+==================
+
+  * Remove newline from end of base64 encoded strings, some decoders don't like
+    them.
+
 1.4.2 / 2020-10-20
 ==================
 

data/lib/pusher/client.rb

@@ -59,7 +59,7 @@ module Pusher
 
       if options.has_key?(:encryption_master_key_base64)
         @encryption_master_key =
-          Base64.decode64(options[:encryption_master_key_base64])
+          Base64.strict_decode64(options[:encryption_master_key_base64])
       end
 
       @http_proxy = nil
@@ -148,7 +148,7 @@ module Pusher
     # Set an encryption_master_key to use with private-encrypted channels from
     # a base64 encoded string.
     def encryption_master_key_base64=(s)
-      @encryption_master_key = s ? Base64.decode64(s) : nil
+      @encryption_master_key = s ? Base64.strict_decode64(s) : nil
     end
 
     ## INTERACT WITH THE API ##
@@ -483,8 +483,8 @@ module Pusher
       ciphertext = secret_box.encrypt(nonce, encoded_data)
 
       MultiJson.encode({
-        "nonce" => Base64::encode64(nonce),
-        "ciphertext" => Base64::encode64(ciphertext),
+        "nonce" => Base64::strict_encode64(nonce),
+        "ciphertext" => Base64::strict_encode64(ciphertext),
       })
     end
 

data/lib/pusher/version.rb

@@ -1,3 +1,3 @@
 module Pusher
-  VERSION = '1.4.2'
+  VERSION = '1.4.3'
 end

data/spec/client_spec.rb

@@ -385,8 +385,8 @@ describe Pusher do
             )
 
             expect(MultiJson.decode(RbNaCl::SecretBox.new(key).decrypt(
-              Base64.decode64(data["nonce"]),
-              Base64.decode64(data["ciphertext"]),
+              Base64.strict_decode64(data["nonce"]),
+              Base64.strict_decode64(data["ciphertext"]),
             ))).to eq({ 'some' => 'data' })
           }
         end
@@ -461,8 +461,8 @@ describe Pusher do
             )
 
             expect(MultiJson.decode(RbNaCl::SecretBox.new(key).decrypt(
-              Base64.decode64(data["nonce"]),
-              Base64.decode64(data["ciphertext"]),
+              Base64.strict_decode64(data["nonce"]),
+              Base64.strict_decode64(data["ciphertext"]),
             ))).to eq({ 'some' => 'data' })
 
             expect(batch[1]["channel"]).to eq("mychannel")

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pusher
 version: !ruby/object:Gem::Version
-  version: 1.4.2
+  version: 1.4.3
 platform: ruby
 authors:
 - Pusher
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-10-20 00:00:00.000000000 Z
+date: 2020-10-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: multi_json