push_package 0.3.0 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6b3e8b567c6ebb1888e02f3cf5157b9bdbd08671
-  data.tar.gz: fe51748466b8ff36fb7325c48dca56816bf7ed2e
+  metadata.gz: 993a2f7345ad1bee0c5aa221936e44e322f63b39
+  data.tar.gz: 09023bbe6ad97d1ebc1e3a97c7b028114aea0ec3
 SHA512:
-  metadata.gz: 73ec74740ad3a70e0eda382a98bb112b9c8f8fc5d6b795dcfd67342b2f81c8f0d8338d5426dffb3fe624bbd16c03489f4648770e47a53f7178a32df7aa592f2f
-  data.tar.gz: e238cc025564ea70167df852b8edd1e3836a944d02e07f998255d3c0e9f66cf1ca6a270a78c45b672d3ddcef60d7c0f09665e492e2a825878d588c66412b37fb
+  metadata.gz: e3ee7036717ed8f3ab09912d0fc56ed497c2f13c3472371f6fd3c7cb305ee88a45b898db5a2fa69262693382a94bd3bd891767be1dbc14f0cc10039e18cfb912
+  data.tar.gz: f479ef6728e2744759ca348d28afc42f730d5e72c40c006835b3324cef2759fe2b0265506737af66d8800a81624fc327f06597f842c27cf928593b2f1204e386

data/.travis.yml

@@ -1,11 +1,9 @@
 ---
 language: ruby
 rvm:
-- 1.9.2
-- 1.9.3
-- 2.0.0
 - 2.1.5
 - 2.2.3
+- 2.3.0
 - jruby-19mode
 sudo: false
 notifications:

data/lib/push_package.rb

@@ -21,7 +21,7 @@ class PushPackage
     raise ArgumentError unless certificate
 
     @website_params = website_params
-    @iconset_path = iconset_path
+    @iconset_path = iconset_path.to_s
 
     if certificate.respond_to?(:read)
       cert_data = certificate.read

data/lib/push_package/version.rb

@@ -1,3 +1,3 @@
 class PushPackage
-  VERSION = '0.3.0'.freeze
+  VERSION = '0.4.0'.freeze
 end

data/push_package.gemspec

@@ -21,7 +21,7 @@ Gem::Specification.new do |gem|
 
   gem.add_runtime_dependency 'rubyzip', '~> 1.1', '>= 1.1.0'
 
-  gem.add_development_dependency 'minitest', '~> 4.7.0', '>= 4.7.0'
+  gem.add_development_dependency 'minitest', '~> 5.8.4', '>= 5.8.4'
   gem.add_development_dependency 'rake', '~> 10.0', '>= 10.0.3'
   gem.add_development_dependency 'pry', '~> 0'
 end

data/spec/push_package_spec.rb

@@ -145,6 +145,14 @@ describe PushPackage do
       File.delete(file.path)
     end
 
+    it 'supports using a Pathname for iconset_path' do
+      iconset_pathname = Pathname.new(iconset_path)
+      push_package = PushPackage.new(website_params, iconset_pathname, certificate, 'testing')
+      file = push_package.save
+      File.exist?(file.path).must_equal true
+      File.delete(file.path)
+    end
+
     it 'should return the file handle' do
       file = push_package.save(output_path)
       file.must_be_instance_of File
@@ -194,14 +202,27 @@ describe PushPackage do
     end
 
     describe 'when intermediate_cert given' do
-      let(:intermediate_cert) { File.open(fixture_path('intermediate.crt')) }
-      let(:push_package) { PushPackage.new(website_params, iconset_path, certificate, 'testing', intermediate_cert) }
-
-      it 'should have one extra cert in signature' do
-        extracted_package.must_include('signature')
-        signature = File.read(tmp_path + '/signature')
-        p7 = OpenSSL::PKCS7.new(signature)
-        p7.certificates().size.must_equal 2
+      describe 'when intermediate_cert is a string' do
+        let(:intermediate_cert) { fixture_path('intermediate.crt') }
+        let(:push_package) { PushPackage.new(website_params, iconset_path, certificate, 'testing', intermediate_cert) }
+
+        it 'should have one extra cert in signature' do
+          extracted_package.must_include('signature')
+          signature = File.read(tmp_path + '/signature')
+          p7 = OpenSSL::PKCS7.new(signature)
+          p7.certificates().size.must_equal 2
+        end
+      end
+      describe 'when intermediate_cert is a Pathname' do
+        let(:intermediate_cert) { Pathname.new(fixture_path('intermediate.crt')) }
+        let(:push_package) { PushPackage.new(website_params, iconset_path, certificate, 'testing', intermediate_cert) }
+
+        it 'should have one extra cert in signature' do
+          extracted_package.must_include('signature')
+          signature = File.read(tmp_path + '/signature')
+          p7 = OpenSSL::PKCS7.new(signature)
+          p7.certificates().size.must_equal 2
+        end
       end
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: push_package
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.4.0
 platform: ruby
 authors:
 - Stefan Natchev
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-02-16 00:00:00.000000000 Z
+date: 2016-03-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubyzip
@@ -37,20 +37,20 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 4.7.0
+        version: 5.8.4
     - - '>='
       - !ruby/object:Gem::Version
-        version: 4.7.0
+        version: 5.8.4
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 4.7.0
+        version: 5.8.4
     - - '>='
       - !ruby/object:Gem::Version
-        version: 4.7.0
+        version: 5.8.4
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement