puppeteer-ruby 0.45.5 → 0.45.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 607484b3ad8ed69659c8ad37dfd501cddd848c4b5b5188be04eb97d0e4153ccd
-  data.tar.gz: c46f92d9f435cede6ea1f1825158c5cf5c97d6beb9b4b10bf0758bf7afb8a130
+  metadata.gz: ba80a8570a4df72a141dff37a81899373827c461a5327311cc28cae8fc5be16f
+  data.tar.gz: 7811d540f215426009b28906723ee03c93eb0504ccbfacd321d1c219be5105a1
 SHA512:
-  metadata.gz: 010dad8d428558d63a89f212db99860e1ce7df56ab765adc491374c0f617f3ca85b993636b84ab5ac8046201ae7f2fb4c9d79f0a224a610568e7fdece6e5a305
-  data.tar.gz: 3112d22f72dbdbd0accbfcce13707e0e7991d5a4b7ca574eee99e06b6982d9ab91597a43b2f1e07048d97f74e5c295b240be74c3666249c305f5af48bc32544a
+  metadata.gz: f047d5dea4f9e7dc34c6578fa22887ef147be87f123f47c16d5b684ae9ac34cf6d2f3797f6d2513b039cf872bf02ff49d3e0505af7cfae98f5fa11df133f6315
+  data.tar.gz: 580d0082d1e2bb05615d5eb472b5df5dff060c291bffd11a2ce08c16ca6592451f071f2b5192ab156141aa65c21d03071eb0af17162395b548dca7a056ab1fff

data/CHANGELOG.md

@@ -1,7 +1,13 @@
-### main [[diff](https://github.com/YusukeIwaki/puppeteer-ruby/compare/0.45.5...main)]
+### main [[diff](https://github.com/YusukeIwaki/puppeteer-ruby/compare/0.45.6...main)]
 
 - xxx
 
+### 0.45.6 [[diff](https://github.com/YusukeIwaki/puppeteer-ruby/compare/0.45.5...0.45.6)]
+
+Bugfix:
+
+- Fix puppeteer-ruby to work with Firefox >= 129. Note that CDP support for Firefox is already ended. [ref](https://fxdx.dev/deprecating-cdp-support-in-firefox-embracing-the-future-with-webdriver-bidi/)
+
 ### 0.45.5 [[diff](https://github.com/YusukeIwaki/puppeteer-ruby/compare/0.45.4...0.45.5)]
 
 Bugfix:

data/README.md

@@ -44,19 +44,19 @@ require 'puppeteer-ruby'
 Puppeteer.launch(headless: false, slow_mo: 50, args: ['--window-size=1280,800']) do |browser|
   page = browser.new_page
   page.viewport = Puppeteer::Viewport.new(width: 1280, height: 800)
-  page.goto("https://github.com/", wait_until: 'domcontentloaded')
+  with_network_retry { page.goto("https://github.com/", wait_until: 'domcontentloaded') }
 
-  form = page.query_selector("form.js-site-search-form")
-  search_input = form.query_selector("input.header-search-input")
+  page.wait_for_selector('[placeholder="Search or jump to..."]').click
+  search_input = page.wait_for_selector('input[name="query-builder-test"]')
   search_input.click
   page.keyboard.type_text("puppeteer")
 
   page.wait_for_navigation do
-    search_input.press('Enter')
+    search_input.press("Enter")
   end
 
-  list = page.query_selector("ul.repo-list")
-  items = list.query_selector_all("div.f4")
+  list = page.wait_for_selector('[data-testid="results-list"]')
+  items = list.query_selector_all(".search-title")
   items.each do |item|
     title = item.eval_on_selector("a", "a => a.innerText")
     puts("==> #{title}")
@@ -95,16 +95,16 @@ More usage examples can be found [here](https://github.com/YusukeIwaki/puppeteer
 
 Following packages are required.
 
-* Google Chrome or Chromium
-  * In Debian-based images, `google-chrome-stable`
-  * In Alpine-based images, `chromium`
+- Google Chrome or Chromium
+  - In Debian-based images, `google-chrome-stable`
+  - In Alpine-based images, `chromium`
 
 Also, CJK font will be required for Chinese, Japanese, Korean sites.
 
 ### References
 
-* Puppeteer official README: https://github.com/puppeteer/puppeteer/blob/main/docs/troubleshooting.md#running-puppeteer-in-docker
-* puppeteer-ruby example: https://github.com/YusukeIwaki/puppeteer-ruby-example/tree/master/docker_chromium
+- Puppeteer official README: https://github.com/puppeteer/puppeteer/blob/main/docs/troubleshooting.md#running-puppeteer-in-docker
+- puppeteer-ruby example: https://github.com/YusukeIwaki/puppeteer-ruby-example/tree/master/docker_chromium
 
 ## :bulb: Collaboration with Selenium or Capybara
 
@@ -224,12 +224,10 @@ RSpec.describe 'Sample integration tests', driver: :null do
 end
 ```
 
-
 ## API
 
 https://yusukeiwaki.github.io/puppeteer-ruby-docs/
 
-
 ## Contributing
 
 Bug reports and pull requests are welcome on GitHub at https://github.com/YusukeIwaki/puppeteer-ruby.

data/docs/api_coverage.md

@@ -1,6 +1,6 @@
 # API coverages
 - Puppeteer version: v19.5.0
-- puppeteer-ruby version: 0.45.4
+- puppeteer-ruby version: 0.45.6
 
 ## Puppeteer
 

data/lib/puppeteer/browser_runner.rb

@@ -178,6 +178,10 @@ class Puppeteer::BrowserRunner
     Timeout.timeout(timeout / 1000.0) do
       loop do
         line = browser_process.stderr.readline
+        /^WebDriver BiDi listening on (ws:\/\/.*)$/.match(line) do |m|
+          raise NotImplementedError.new('WebDriver BiDi support is not yet implemented')
+        end
+
         /^DevTools listening on (ws:\/\/.*)$/.match(line) do |m|
           return m[1].gsub(/\r/, '')
         end

data/lib/puppeteer/connection.rb

@@ -187,8 +187,10 @@ class Puppeteer::Connection
     NON_DEBUG_PRINT_METHODS = [
       'Network.dataReceived',
       'Network.loadingFinished',
+      'Network.requestServedFromCache',
       'Network.requestWillBeSent',
       'Network.requestWillBeSentExtraInfo',
+      'Network.resourceChangedPriority',
       'Network.responseReceived',
       'Network.responseReceivedExtraInfo',
       'Page.lifecycleEvent',

data/lib/puppeteer/launcher/firefox.rb

@@ -122,7 +122,11 @@ module Puppeteer::Launcher
 
     FIREFOX_EXECUTABLE_PATHS = {
       windows: "#{ENV['PROGRAMFILES']}\\Firefox Nightly\\firefox.exe",
-      darwin: '/Applications/Firefox Nightly.app/Contents/MacOS/firefox',
+      darwin: -> {
+        ['Firefox Nightly.app', 'Firefox Developer Edition.app'].map do |app|
+          "/Applications/#{app}/Contents/MacOS/firefox"
+        end.find { |path| File.exist?(path) }
+      },
       linux: -> { Puppeteer::ExecutablePathFinder.new('firefox').find_first },
     }.freeze
 
@@ -161,7 +165,7 @@ module Puppeteer::Launcher
 
       # @param options [Launcher::ChromeArgOptions]
       def initialize(chrome_arg_options)
-        firefox_arguments = ['--no-remote']
+        firefox_arguments = []
 
         if Puppeteer.env.darwin?
           firefox_arguments << '--foreground'
@@ -236,7 +240,6 @@ module Puppeteer::Launcher
         'browser.safebrowsing.blockedURIs.enabled': false,
         'browser.safebrowsing.downloads.enabled': false,
         'browser.safebrowsing.malware.enabled': false,
-        'browser.safebrowsing.passwords.enabled': false,
         'browser.safebrowsing.phishing.enabled': false,
 
         # Disable updates to search engines.
@@ -262,6 +265,9 @@ module Puppeteer::Launcher
         # Do not warn when multiple tabs will be opened
         'browser.tabs.warnOnOpen': false,
 
+        # Do not automatically offer translations, as tests do not expect this.
+        'browser.translations.automaticallyPopup': false,
+
         # Disable the UI tour.
         'browser.uitour.enabled': false,
         # Turn off search suggestions in the location bar so as not to trigger
@@ -324,30 +330,33 @@ module Puppeteer::Launcher
         # Make sure opening about:addons will not hit the network
         'extensions.webservice.discoverURL': "http://#{server}/dummy/discoveryURL",
 
-        # Temporarily force disable BFCache in parent (https://bit.ly/bug-1732263)
-        'fission.bfcacheInParent': false,
-        # Force all web content to use a single content process
-        'fission.webContentIsolationStrategy': 0,
-
         # Allow the application to have focus even it runs in the background
         'focusmanager.testmode': true,
+
         # Disable useragent updates
         'general.useragent.updates.enabled': false,
+
         # Always use network provider for geolocation tests so we bypass the
         # macOS dialog raised by the corelocation provider
         'geo.provider.testing': true,
+
         # Do not scan Wifi
         'geo.wifi.scan': false,
+
         # No hang monitor
         'hangmonitor.timeout': 0,
+
         # Show chrome errors and warnings in the error console
         'javascript.options.showInConsole': true,
 
         # Disable download and usage of OpenH264: and Widevine plugins
         'media.gmp-manager.updateEnabled': false,
-        # Prevent various error message on the console
-        # jest-puppeteer asserts that no error message is emitted by the console
-        'network.cookie.cookieBehavior': 0,
+
+        # Disable the GFX sanity window
+        'media.sanity-test.disabled': true,
+
+        # Disable experimental feature that is only available in Nightly
+        'network.cookie.sameSite.laxByDefault': false,
 
         # Do not prompt for temporary redirects
         'network.http.prompt-temp-redirect': false,
@@ -367,15 +376,17 @@ module Puppeteer::Launcher
 
         'privacy.trackingprotection.enabled': false,
 
-        # Enable Remote Agent
-        # https://bugzilla.mozilla.org/show_bug.cgi?id=1544393
+        # Can be removed once Firefox 89 is no longer supported
+        # https://bugzilla.mozilla.org/show_bug.cgi?id=1710839
         'remote.enabled': true,
 
         # Don't do network connections for mitm priming
         'security.certerrors.mitm.priming.enabled': false,
+
         # Local documents have access to all other local documents,
         # including directory listings
         'security.fileuri.strict_origin_policy': false,
+
         # Do not wait for the notification button security delay
         'security.notification_enable_delay': 0,
 
@@ -385,6 +396,7 @@ module Puppeteer::Launcher
         # Do not automatically fill sign-in forms with known usernames and
         # passwords
         'signon.autofillForms': false,
+
         # Disable password capture, so that tests that include forms are not
         # influenced by the presence of the persistent doorhanger notification
         'signon.rememberSignons': false,
@@ -400,7 +412,24 @@ module Puppeteer::Launcher
 
         # Prevent starting into safe mode after application crashes
         'toolkit.startup.max_resumed_crashes': -1,
-      }
+      }.merge({ # https://github.com/puppeteer/puppeteer/blob/puppeteer-v23.2.2/packages/puppeteer-core/src/node/FirefoxLauncher.ts#L45-L53
+        # Do not close the window when the last tab gets closed
+        'browser.tabs.closeWindowWithLastTab': false,
+        # Prevent various error message on the console
+        # jest-puppeteer asserts that no error message is emitted by the console
+        'network.cookie.cookieBehavior': 0,
+        # Temporarily force disable BFCache in parent (https://bit.ly/bug-1732263)
+        'fission.bfcacheInParent': false,
+        # Only enable the CDP protocol
+        'remote.active-protocols': 2,
+      }).merge({ # https://github.com/puppeteer/puppeteer/blob/puppeteer-v23.2.2/packages/puppeteer-core/src/node/FirefoxLauncher.ts#L55-L60
+        # Force all web content to use a single content process. TODO: remove
+        # this once Firefox supports mouse event dispatch from the main frame
+        # context. Once this happens, webContentIsolationStrategy should only
+        # be set for CDP. See
+        # https://bugzilla.mozilla.org/show_bug.cgi?id=1773393
+        'fission.webContentIsolationStrategy': 0,
+      })
 
       default_preferences.merge(extra_prefs)
     end

data/lib/puppeteer/version.rb

@@ -1,3 +1,3 @@
 module Puppeteer
-  VERSION = '0.45.5'
+  VERSION = '0.45.6'
 end

data/puppeteer-ruby.gemspec

@@ -34,7 +34,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'rspec_junit_formatter' # for CircleCI.
   spec.add_development_dependency 'rubocop', '~> 1.50.0'
   spec.add_development_dependency 'rubocop-rspec'
-  spec.add_development_dependency 'sinatra'
+  spec.add_development_dependency 'sinatra', '< 4.0.0'
   spec.add_development_dependency 'webrick'
   spec.add_development_dependency 'yard'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: puppeteer-ruby
 version: !ruby/object:Gem::Version
-  version: 0.45.5
+  version: 0.45.6
 platform: ruby
 authors:
 - YusukeIwaki
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2024-09-09 00:00:00.000000000 Z
+date: 2024-09-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: concurrent-ruby
@@ -202,16 +202,16 @@ dependencies:
   name: sinatra
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "<"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 4.0.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "<"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 4.0.0
 - !ruby/object:Gem::Dependency
   name: webrick
   requirement: !ruby/object:Gem::Requirement