puppeteer-ruby 0.44.3 → 0.45.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9e3ce791016a5018ed76902a9baa63110032fb28681b52d6beeb2e0b629ec0b1
-  data.tar.gz: d449886d836e7b2d65e6764e8a73745b53117bc01437a05699efbff911d92dbc
+  metadata.gz: 037ab626560f55e8fe53f7ac978eccd187132d795bdda193b9afc5d761593c77
+  data.tar.gz: ee5cd15db34563d127fc4d58c846d92273cb47916096de025bed43e7580a1e81
 SHA512:
-  metadata.gz: 74fce38ce98fffd7a47273e34d6d1b66a8e171656255fe431caf9d78c33fde9c6fc81316253091681521afed796b11a374d123edde4934253a892b9a69947666
-  data.tar.gz: 5fa58e64d918f1ff5d59de1c57cbb0a04728e9c9866a0376c8c0bc2d2729277391a631dbfb3a56cc25b7c43f00ac7208e478c5b66bd1d35afb28c32428569d18
+  metadata.gz: a92921b6c243605d715fb3514c1965f69d2c7446236d33d45a0657a9a9a4c401a3223ee4e68eefcd8cadd6cda7cb598c845a74a152ef8ba1f980f3ea29d335d2
+  data.tar.gz: eb07704a147fa0029b0ac328dee0ec2a6757528058f102669cf2f8e2d6eae954f195665f1cbc4b2bc6a33e02e6b948fea18a78232c65407b9ce0c5762195c2c7

data/CHANGELOG.md

@@ -1,4 +1,11 @@
-### main [[diff](https://github.com/YusukeIwaki/puppeteer-ruby/compare/0.44.3...main)]
+### main [[diff](https://github.com/YusukeIwaki/puppeteer-ruby/compare/0.45.0...main)]
+
+### 0.45.0 [[diff](https://github.com/YusukeIwaki/puppeteer-ruby/compare/0.44.3...0.45.0)]
+
+- Port Puppeteer v18.0-v19.5 features except for 3 features below (If wanted, please create a issue of the feature request :)
+  - Extra headers for Puppeteer.connect ([#9314](https://github.com/puppeteer/puppeteer/pull/9314))
+  - Improvement of missing product message ([#9207](https://github.com/puppeteer/puppeteer/pull/9207))
+  - Configuration file (.puppeteerrc/puppeteer.config.js) ([#9140](https://github.com/puppeteer/puppeteer/pull/9140)).
 
 ### 0.44.3 [[diff](https://github.com/YusukeIwaki/puppeteer-ruby/compare/0.44.2...0.44.3)]
 

data/README.md

@@ -229,12 +229,6 @@ end
 
 https://yusukeiwaki.github.io/puppeteer-ruby-docs/
 
-## Limitations
-
-### Not compatible with Firefox >= v97.0
-
-:sos: Help and contribution wanted! :sos:
-https://github.com/YusukeIwaki/puppeteer-ruby/issues/220
 
 ## Contributing
 

data/docs/api_coverage.md

@@ -1,6 +1,6 @@
 # API coverages
-- Puppeteer version: v17.1.3
-- puppeteer-ruby version: 0.44.3
+- Puppeteer version: v19.5.0
+- puppeteer-ruby version: 0.45.0
 
 ## Puppeteer
 
@@ -14,7 +14,8 @@
 * executablePath => `#executable_path`
 * launch
 * networkConditions => `#network_conditions`
-* ~~registerCustomQueryHandler~~
+* ~~puppeteer~~
+* registerCustomQueryHandler => `#register_custom_query_handler`
 * ~~unregisterCustomQueryHandler~~
 
 ## ~~Accessibility~~
@@ -134,6 +135,7 @@
 * screenshot
 * select
 * tap
+* toElement => `#to_element`
 * type => `#type_text`
 * uploadFile => `#upload_file`
 * waitForSelector => `#wait_for_selector`
@@ -282,6 +284,7 @@
 * addScriptTag => `#add_script_tag`
 * addStyleTag => `#add_style_tag`
 * addStyleTag => `#add_style_tag`
+* addStyleTag => `#add_style_tag`
 * authenticate
 * bringToFront => `#bring_to_front`
 * browser
@@ -356,6 +359,12 @@
 * waitForXPath => `#wait_for_xpath`
 * workers
 
+## ~~ProductLauncher~~
+
+* ~~defaultArgs~~
+* ~~executablePath~~
+* ~~launch~~
+
 ## ~~ProtocolError~~
 
 

data/lib/puppeteer/browser_context.rb

@@ -11,6 +11,8 @@ class Puppeteer::BrowserContext
     @id = context_id
   end
 
+  attr_reader :id
+
   # @param event_name [Symbol] either of :disconnected, :targetcreated, :targetchanged, :targetdestroyed
   def on(event_name, &block)
     unless BrowserContextEmittedEvents.values.include?(event_name.to_s)

data/lib/puppeteer/coverage.rb

@@ -8,11 +8,13 @@ class Puppeteer::Coverage
   def start_js_coverage(
         reset_on_navigation: nil,
         report_anonymous_scripts: nil,
-        include_raw_script_coverage: nil)
+        include_raw_script_coverage: nil,
+        use_block_coverage: nil)
     @js.start(
       reset_on_navigation: reset_on_navigation,
       report_anonymous_scripts: report_anonymous_scripts,
       include_raw_script_coverage: include_raw_script_coverage,
+      use_block_coverage: use_block_coverage,
     )
   end
 
@@ -24,6 +26,7 @@ class Puppeteer::Coverage
         reset_on_navigation: nil,
         report_anonymous_scripts: nil,
         include_raw_script_coverage: nil,
+        use_block_coverage: nil,
         &block)
     unless block
       raise ArgumentError.new('Block must be given')
@@ -33,6 +36,7 @@ class Puppeteer::Coverage
       reset_on_navigation: reset_on_navigation,
       report_anonymous_scripts: report_anonymous_scripts,
       include_raw_script_coverage: include_raw_script_coverage,
+      use_block_coverage: use_block_coverage,
     )
     block.call
     stop_js_coverage

data/lib/puppeteer/element_handle.rb

@@ -126,6 +126,13 @@ class Puppeteer::ElementHandle < Puppeteer::JSHandle
 
   define_async_method :async_wait_for_xpath
 
+  def to_element(tag_name)
+    unless evaluate('(node, tagName) => node.nodeName === tagName.toUpperCase()', tag_name)
+      raise ArgumentError.new("Element is not a(n) `#{tag_name}` element")
+    end
+    self
+  end
+
   def as_element
     self
   end

data/lib/puppeteer/frame_manager.rb

@@ -21,6 +21,8 @@ class Puppeteer::FrameManager
     # @type {!Map<string, !Frame>}
     @frames = {}
 
+    @frame_naviigated_received = Set.new
+
     # @type {!Map<number, !ExecutionContext>}
     @context_id_to_context = {}
 
@@ -42,6 +44,7 @@ class Puppeteer::FrameManager
       handle_frame_attached(client, event['frameId'], event['parentFrameId'])
     end
     client.on_event('Page.frameNavigated') do |event|
+      @frame_naviigated_received << event['frame']['id']
       handle_frame_navigated(event['frame'])
     end
     client.on_event('Page.navigatedWithinDocument') do |event|
@@ -227,7 +230,9 @@ class Puppeteer::FrameManager
     if frame_tree['frame']['parentId']
       handle_frame_attached(session, frame_tree['frame']['id'], frame_tree['frame']['parentId'])
     end
-    handle_frame_navigated(frame_tree['frame'])
+    unless @frame_naviigated_received.delete?(frame_tree['frame']['id'])
+      handle_frame_navigated(frame_tree['frame'])
+    end
     return if !frame_tree['childFrames']
 
     frame_tree['childFrames'].each do |child|

data/lib/puppeteer/isolated_world.rb

@@ -562,18 +562,16 @@ class Puppeteer::IsolaatedWorld
             node.nodeType === Node.TEXT_NODE ? node.parentElement : node;
 
           const style = window.getComputedStyle(element);
+          const hidden_visibility_values = ['hidden', 'collapse'];
           const isVisible =
-            style && style.visibility !== 'hidden' && hasVisibleBoundingBox();
+            style && !hidden_visibility_values.includes(style.visibility) && !isBoundingBoxEmpty(element);
           const success =
             waitForVisible === isVisible || waitForHidden === !isVisible;
           return success ? node : null;
 
-          /**
-          * @return {boolean}
-          */
-          function hasVisibleBoundingBox() {
+          function isBoundingBoxEmpty(element) {
             const rect = element.getBoundingClientRect();
-            return !!(rect.top || rect.bottom || rect.width || rect.height);
+            return rect.width === 0 || rect.height === 0;
           }
         }
     }

data/lib/puppeteer/js_coverage.rb

@@ -31,7 +31,8 @@ class Puppeteer::JSCoverage
   def start(
         reset_on_navigation: nil,
         report_anonymous_scripts: nil,
-        include_raw_script_coverage: nil)
+        include_raw_script_coverage: nil,
+        use_block_coverage: nil)
     raise 'JSCoverage is already enabled' if @enabled
 
     @reset_on_navigation =
@@ -40,6 +41,12 @@ class Puppeteer::JSCoverage
       else
         true
       end
+    @use_block_coverage =
+      if [true, false].include?(use_block_coverage)
+        use_block_coverage
+      else
+        true
+      end
     @report_anonymous_scripts = report_anonymous_scripts || false
     @include_raw_script_coverage = include_raw_script_coverage || false
     @enabled = true
@@ -56,7 +63,7 @@ class Puppeteer::JSCoverage
       @client.async_send_message('Profiler.enable'),
       @client.async_send_message('Profiler.startPreciseCoverage',
         callCount: @include_raw_script_coverage,
-        detailed: true,
+        detailed: @use_block_coverage,
       ),
       @client.async_send_message('Debugger.enable'),
       @client.async_send_message('Debugger.setSkipAllPauses', skip: true),

data/lib/puppeteer/keyboard.rb

@@ -15,7 +15,7 @@ class Puppeteer::Keyboard
 
   # @param key [String]
   # @param text [String]
-  def down(key, text: nil)
+  def down(key, text: nil, commands: nil)
     description = key_description_for_string(key)
 
     auto_repeat = @pressed_keys.include?(description.code)
@@ -34,6 +34,7 @@ class Puppeteer::Keyboard
       autoRepeat: auto_repeat,
       location: description.location,
       isKeypad: description.location == 3,
+      commands: commands,
     }.compact
     @client.send_message('Input.dispatchKeyEvent', params)
   end
@@ -151,8 +152,8 @@ class Puppeteer::Keyboard
   # @param key [String]
   # @param text [String]
   # @return [Future]
-  def press(key, delay: nil, text: nil)
-    down(key, text: text)
+  def press(key, delay: nil, text: nil, commands: nil)
+    down(key, text: text, commands: commands)
     if delay
       sleep(delay.to_i / 1000.0)
     end

data/lib/puppeteer/launcher/chrome.rb

@@ -114,36 +114,38 @@ module Puppeteer::Launcher
 
       # @param options [Launcher::ChromeArgOptions]
       def initialize(chrome_arg_options)
+        # See https://github.com/GoogleChrome/chrome-launcher/blob/main/docs/chrome-flags-for-tools.md
         chrome_arguments = [
+          '--allow-pre-commit-input',
           '--disable-background-networking',
-          '--enable-features=NetworkService,NetworkServiceInProcess',
           '--disable-background-timer-throttling',
           '--disable-backgrounding-occluded-windows',
           '--disable-breakpad',
           '--disable-client-side-phishing-detection',
           '--disable-component-extensions-with-background-pages',
+          '--disable-component-update',
           '--disable-default-apps',
           '--disable-dev-shm-usage',
           '--disable-extensions',
-          # TODO: remove AvoidUnnecessaryBeforeUnloadCheckSync below
-          # once crbug.com/1324138 is fixed and released.
           # AcceptCHFrame disabled because of crbug.com/1348106.
-          '--disable-features=Translate,BackForwardCache,AcceptCHFrame,AvoidUnnecessaryBeforeUnloadCheckSync',
+          '--disable-features=Translate,BackForwardCache,AcceptCHFrame,MediaRouter,OptimizationHints',
           '--disable-hang-monitor',
           '--disable-ipc-flooding-protection',
           '--disable-popup-blocking',
           '--disable-prompt-on-repost',
           '--disable-renderer-backgrounding',
           '--disable-sync',
+          '--enable-automation',
+          # TODO(sadym): remove '--enable-blink-features=IdleDetection' once
+          # IdleDetection is turned on by default.
+          '--enable-blink-features=IdleDetection',
+          '--enable-features=NetworkServiceInProcess2',
+          '--export-tagged-pdf',
           '--force-color-profile=srgb',
           '--metrics-recording-only',
           '--no-first-run',
-          '--enable-automation',
           '--password-store=basic',
           '--use-mock-keychain',
-          # TODO(sadym): remove '--enable-blink-features=IdleDetection'
-          # once IdleDetection is turned on by default.
-          '--enable-blink-features=IdleDetection',
         ]
 
         if chrome_arg_options.user_data_dir

data/lib/puppeteer/lifecycle_watcher.rb

@@ -84,6 +84,7 @@ class Puppeteer::LifecycleWatcher
     @listener_ids['network_manager'] = [
       @frame_manager.network_manager.add_event_listener(NetworkManagerEmittedEvents::Request, &method(:handle_request)),
       @frame_manager.network_manager.add_event_listener(NetworkManagerEmittedEvents::Response, &method(:handle_response)),
+      @frame_manager.network_manager.add_event_listener(NetworkManagerEmittedEvents::RequestFailed, &method(:handle_request_failed)),
     ]
 
     @same_document_navigation_promise = resolvable_future
@@ -107,9 +108,16 @@ class Puppeteer::LifecycleWatcher
     end
   end
 
+  # @param [Puppeteer::HTTPRequest] request
+  def handle_request_failed(request)
+    return if @navigation_request&.internal&.request_id != request.internal.request_id
+
+    @navigation_response_received.fulfill(nil) unless @navigation_response_received.resolved?
+  end
+
   # @param [Puppeteer::HTTPResponse] response
   def handle_response(response)
-    return if @navigation_request&.internal&.request_id  != response.request.internal.request_id
+    return if @navigation_request&.internal&.request_id != response.request.internal.request_id
 
     @navigation_response_received.fulfill(nil) unless @navigation_response_received.resolved?
   end

data/lib/puppeteer/puppeteer.rb

@@ -141,6 +141,42 @@ class Puppeteer::Puppeteer
     launcher.product
   end
 
+  def register_custom_query_handler(name:, query_one:, query_all:)
+    unless name =~ /\A[a-zA-Z]+\z/
+      raise ArgumentError.new("Custom query handler names may only contain [a-zA-Z]")
+    end
+
+    handler_name = name.to_sym
+    if query_handler_manager.query_handlers.key?(handler_name)
+      raise ArgumentError.new("A query handler named #{name} already exists")
+    end
+
+    handler = Puppeteer::CustomQueryHandler.new(query_one: query_one, query_all: query_all)
+    Puppeteer::QueryHandlerManager.instance.query_handlers[handler_name] = handler
+  end
+
+  def with_custom_query_handler(name:, query_one:, query_all:, &block)
+    unless name =~ /\A[a-zA-Z]+\z/
+      raise ArgumentError.new("Custom query handler names may only contain [a-zA-Z]")
+    end
+
+    handler_name = name.to_sym
+
+    handler = Puppeteer::CustomQueryHandler.new(query_one: query_one, query_all: query_all)
+    query_handler_manager = Puppeteer::QueryHandlerManager.instance
+    original = query_handler_manager.query_handlers.delete(handler_name)
+    query_handler_manager.query_handlers[handler_name] = handler
+    begin
+      block.call
+    ensure
+      if original
+        query_handler_manager.query_handlers[handler_name] = original
+      else
+        query_handler_manager.query_handlers.delete(handler_name)
+      end
+    end
+  end
+
   # @return [Puppeteer::Devices]
   def devices
     Puppeteer::Devices
@@ -170,10 +206,4 @@ class Puppeteer::Puppeteer
     }.compact
     launcher.default_args(options)
   end
-
-  # @param {!BrowserFetcher.Options=} options
-  # @return {!BrowserFetcher}
-  def createBrowserFetcher(options = {})
-    BrowserFetcher.new(@project_root, options)
-  end
 end

data/lib/puppeteer/version.rb

@@ -1,3 +1,3 @@
 module Puppeteer
-  VERSION = '0.44.3'
+  VERSION = '0.45.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: puppeteer-ruby
 version: !ruby/object:Gem::Version
-  version: 0.44.3
+  version: 0.45.0
 platform: ruby
 authors:
 - YusukeIwaki
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2023-01-04 00:00:00.000000000 Z
+date: 2023-01-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: concurrent-ruby
@@ -257,7 +257,6 @@ files:
 - lib/puppeteer/browser.rb
 - lib/puppeteer/browser_connector.rb
 - lib/puppeteer/browser_context.rb
-- lib/puppeteer/browser_fetcher.rb
 - lib/puppeteer/browser_runner.rb
 - lib/puppeteer/cdp_session.rb
 - lib/puppeteer/chrome_target_manager.rb

data/lib/puppeteer/browser_fetcher.rb

@@ -1,6 +0,0 @@
-# Download latest chromium.
-class Puppeteer::BrowserFetcher
-  def initialize(project_root, options = {})
-    # 未実装
-  end
-end