puppeteer-ruby 0.41.0 → 0.42.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ccfb160c40e2ef032c0da17ab4b1cc9fe610d4caf42f236042ea0757c9e270e7
-  data.tar.gz: 95a3a457aa850116bc3062e9507ef53bd10e1d451ebeb4703cf9a6f5d663b9c5
+  metadata.gz: 6b06e1f5f867ef4e7d648e93becc953f660bb707b29019ffe6e93f8e9f02acc4
+  data.tar.gz: ff082c6ba661e0f2d8b0d8bc0f92f5aeecf036f9edcd7bb6f8937db4fd019947
 SHA512:
-  metadata.gz: b65da9f89cc8cfeea05e4e0835f919aab382f47e380d27c1e0a439c70cb0b0b7d9e8519a3361ad545e0c5115216d698740e46f20c96960cf96496ee22ac374ea
-  data.tar.gz: 81c846c795efd81bc10af84b65e02a6dfc3a52d9be2cc5f21cc7bc313e84fcd4ef3fed692bc1bc616389bc43f2a06a6944c2353aa8f8c3a614bb8a4c8ef2097c
+  metadata.gz: 19b67fb8ef13bac90538e8755905749427a7131bba5088c16f512b51d72833d80ee296ea7537b5122bb531a28d3c95c7924cd199dc6343ab17a1b3d2c391af9b
+  data.tar.gz: c65cb7780075ddea13c60b6c668b8a9a6d53627a8dbfa263f08694777ff10f1a3f3a98eeb2596a6497e0274a3a6d6aafc24a215ee6873c07485dc400444c0c17

data/CHANGELOG.md

@@ -1,7 +1,11 @@
-### main [[diff](https://github.com/YusukeIwaki/puppeteer-ruby/compare/0.41.0...main)]
+### main [[diff](https://github.com/YusukeIwaki/puppeteer-ruby/compare/0.42.0...main)]
 
 - xxx
 
+### 0.42.0 [[diff](https://github.com/YusukeIwaki/puppeteer-ruby/compare/0.41.0...0.42.0)]
+
+- Port Puppeteer v15.3-v15.5 features, including `Frame#page`
+
 ### 0.41.0 [[diff](https://github.com/YusukeIwaki/puppeteer-ruby/compare/0.40.7...0.41.0)]
 
 - Port Puppeteer v14.0-v15.2 features, including `ElementHandle#wait_for_xpath`

data/docs/api_coverage.md

@@ -1,6 +1,6 @@
 # API coverages
-- Puppeteer version: v15.2.0
-- puppeteer-ruby version: 0.41.0
+- Puppeteer version: v15.5.0
+- puppeteer-ruby version: 0.42.0
 
 ## Puppeteer
 
@@ -14,20 +14,12 @@
 * executablePath => `#executable_path`
 * launch
 * networkConditions => `#network_conditions`
-* product
 * ~~registerCustomQueryHandler~~
 * ~~unregisterCustomQueryHandler~~
 
-## ~~BrowserFetcher~~
+## ~~Accessibility~~
 
-* ~~canDownload~~
-* ~~download~~
-* ~~host~~
-* ~~localRevisions~~
-* ~~platform~~
-* ~~product~~
-* ~~remove~~
-* ~~revisionInfo~~
+* ~~snapshot~~
 
 ## Browser
 
@@ -59,138 +51,55 @@
 * targets
 * waitForTarget => `#wait_for_target`
 
-## Page
-
-* $ => `#query_selector`
-* $$ => `#query_selector_all`
-* $$eval => `#eval_on_selector_all`
-* $eval => `#eval_on_selector`
-* $x => `#Sx`
-* accessibility
-* addScriptTag => `#add_script_tag`
-* addStyleTag => `#add_style_tag`
-* authenticate
-* bringToFront => `#bring_to_front`
-* browser
-* browserContext => `#browser_context`
-* click
-* close
-* content
-* cookies
-* coverage
-* createPDFStream => `#create_pdf_stream`
-* deleteCookie => `#delete_cookie`
-* emulate
-* emulateCPUThrottling => `#emulate_cpu_throttling`
-* emulateIdleState => `#emulate_idle_state`
-* emulateMediaFeatures => `#emulate_media_features`
-* emulateMediaType => `#emulate_media_type`
-* emulateNetworkConditions => `#emulate_network_conditions`
-* emulateTimezone => `#emulate_timezone`
-* emulateVisionDeficiency => `#emulate_vision_deficiency`
-* evaluate
-* evaluateHandle => `#evaluate_handle`
-* evaluateOnNewDocument => `#evaluate_on_new_document`
-* exposeFunction => `#expose_function`
-* focus
-* frames
-* goBack => `#go_back`
-* goForward => `#go_forward`
-* goto
-* hover
-* isClosed => `#closed?`
-* isDragInterceptionEnabled => `#drag_interception_enabled?`
-* isJavaScriptEnabled => `#javascript_enabled?`
-* keyboard
-* mainFrame => `#main_frame`
-* metrics
-* mouse
-* pdf
-* queryObjects => `#query_objects`
-* reload
-* screenshot
-* select
-* setBypassCSP => `#bypass_csp=`
-* setCacheEnabled => `#cache_enabled=`
-* setContent => `#content=`
-* setCookie => `#set_cookie`
-* setDefaultNavigationTimeout => `#default_navigation_timeout=`
-* setDefaultTimeout => `#default_timeout=`
-* ~~setDragInterception~~
-* setExtraHTTPHeaders => `#extra_http_headers=`
-* setGeolocation => `#geolocation=`
-* setJavaScriptEnabled => `#javascript_enabled=`
-* setOfflineMode => `#offline_mode=`
-* setRequestInterception => `#request_interception=`
-* setUserAgent => `#user_agent=`
-* setViewport => `#viewport=`
-* tap
-* target
-* title
-* ~~touchscreen~~
-* tracing
-* type => `#type_text`
-* url
-* viewport
-* ~~waitFor~~
-* waitForFileChooser => `#wait_for_file_chooser`
-* waitForFrame => `#wait_for_frame`
-* waitForFunction => `#wait_for_function`
-* waitForNavigation => `#wait_for_navigation`
-* ~~waitForNetworkIdle~~
-* waitForRequest => `#wait_for_request`
-* waitForResponse => `#wait_for_response`
-* waitForSelector => `#wait_for_selector`
-* waitForTimeout => `#wait_for_timeout`
-* waitForXPath => `#wait_for_xpath`
-* workers
-
-## ~~WebWorker~~
+## ~~BrowserFetcher~~
 
-* ~~evaluate~~
-* ~~evaluateHandle~~
-* ~~executionContext~~
-* ~~url~~
+* ~~canDownload~~
+* ~~download~~
+* ~~host~~
+* ~~localRevisions~~
+* ~~platform~~
+* ~~product~~
+* ~~remove~~
+* ~~revisionInfo~~
 
-## ~~Accessibility~~
+## CDPSession
 
-* ~~snapshot~~
+* connection
+* detach
+* id
+* send
 
-## Keyboard
+## Connection
 
-* down
-* press
-* sendCharacter => `#send_character`
-* type => `#type_text`
-* up
+* createSession => `#create_session`
+* dispose
+* ~~fromSession~~
+* send
+* session
+* url
 
-## Mouse
+## ConsoleMessage
 
-* click
-* down
-* drag
-* dragAndDrop => `#drag_and_drop`
-* dragEnter => `#drag_enter`
-* dragOver => `#drag_over`
-* drop
-* move
-* up
-* wheel
+* args
+* location
+* stackTrace => `#stack_trace`
+* text
+* ~~type~~
 
-## ~~Touchscreen~~
+## Coverage
 
-* ~~tap~~
+* startCSSCoverage => `#start_css_coverage`
+* startJSCoverage => `#start_js_coverage`
+* stopCSSCoverage => `#stop_css_coverage`
+* stopJSCoverage => `#stop_js_coverage`
 
-## Tracing
+## CSSCoverage
 
 * start
 * stop
 
-## FileChooser
+## ~~CustomError~~
 
-* accept
-* cancel
-* isMultiple => `#multiple?`
 
 ## Dialog
 
@@ -200,49 +109,47 @@
 * message
 * type
 
-## ConsoleMessage
-
-* args
-* location
-* stackTrace => `#stack_trace`
-* text
-* ~~type~~
-
-## Frame
+## ElementHandle
 
 * $ => `#query_selector`
 * $$ => `#query_selector_all`
 * $$eval => `#eval_on_selector_all`
 * $eval => `#eval_on_selector`
 * $x => `#Sx`
-* addScriptTag => `#add_script_tag`
-* addStyleTag => `#add_style_tag`
-* childFrames => `#child_frames`
+* asElement => `#as_element`
+* boundingBox => `#bounding_box`
+* boxModel => `#box_model`
 * click
-* content
-* evaluate
-* evaluateHandle => `#evaluate_handle`
-* executionContext => `#execution_context`
+* clickablePoint => `#clickable_point`
+* contentFrame => `#content_frame`
+* drag
+* dragAndDrop => `#drag_and_drop`
+* dragEnter => `#drag_enter`
+* dragOver => `#drag_over`
+* drop
 * focus
-* goto
 * hover
-* isDetached => `#detached?`
-* isOOPFrame => `#oop_frame?`
-* name
-* parentFrame => `#parent_frame`
+* isIntersectingViewport => `#intersecting_viewport?`
+* press
+* screenshot
 * select
-* setContent => `#set_content`
 * tap
-* title
 * type => `#type_text`
-* url
-* ~~waitFor~~
-* waitForFunction => `#wait_for_function`
-* waitForNavigation => `#wait_for_navigation`
+* uploadFile => `#upload_file`
 * waitForSelector => `#wait_for_selector`
-* waitForTimeout => `#wait_for_timeout`
 * waitForXPath => `#wait_for_xpath`
 
+## ~~EventEmitter~~
+
+* ~~addListener~~
+* ~~emit~~
+* ~~listenerCount~~
+* ~~off~~
+* ~~on~~
+* ~~once~~
+* ~~removeAllListeners~~
+* ~~removeListener~~
+
 ## ExecutionContext
 
 * evaluate
@@ -250,53 +157,45 @@
 * frame
 * ~~queryObjects~~
 
-## JSHandle
+## FileChooser
 
-* asElement => `#as_element`
-* dispose
-* evaluate
-* evaluateHandle => `#evaluate_handle`
-* executionContext => `#execution_context`
-* getProperties => `#properties`
-* getProperty => `#[]`
-* jsonValue => `#json_value`
+* accept
+* cancel
+* isMultiple => `#multiple?`
 
-## ElementHandle
+## Frame
 
 * $ => `#query_selector`
 * $$ => `#query_selector_all`
 * $$eval => `#eval_on_selector_all`
 * $eval => `#eval_on_selector`
 * $x => `#Sx`
-* asElement => `#as_element`
-* boundingBox => `#bounding_box`
-* boxModel => `#box_model`
+* addScriptTag => `#add_script_tag`
+* addStyleTag => `#add_style_tag`
+* childFrames => `#child_frames`
 * click
-* clickablePoint => `#clickable_point`
-* contentFrame => `#content_frame`
-* dispose
-* drag
-* dragAndDrop => `#drag_and_drop`
-* dragEnter => `#drag_enter`
-* dragOver => `#drag_over`
-* drop
+* content
 * evaluate
 * evaluateHandle => `#evaluate_handle`
 * executionContext => `#execution_context`
 * focus
-* getProperties => `#properties`
-* getProperty => `#[]`
+* goto
 * hover
-* isIntersectingViewport => `#intersecting_viewport?`
-* jsonValue => `#json_value`
-* press
-* screenshot
+* isDetached => `#detached?`
+* isOOPFrame => `#oop_frame?`
+* name
+* page
+* parentFrame => `#parent_frame`
 * select
+* setContent => `#set_content`
 * tap
-* ~~toString~~
+* title
 * type => `#type_text`
-* uploadFile => `#upload_file`
+* url
+* waitForFunction => `#wait_for_function`
+* waitForNavigation => `#wait_for_navigation`
 * waitForSelector => `#wait_for_selector`
+* waitForTimeout => `#wait_for_timeout`
 * waitForXPath => `#wait_for_xpath`
 
 ## HTTPRequest
@@ -341,6 +240,131 @@
 * ~~timing~~
 * url
 
+## JSCoverage
+
+* start
+* stop
+
+## JSHandle
+
+* asElement => `#as_element`
+* dispose
+* evaluate
+* evaluateHandle => `#evaluate_handle`
+* executionContext => `#execution_context`
+* getProperties => `#properties`
+* getProperty => `#[]`
+* getProperty => `#[]`
+* jsonValue => `#json_value`
+* remoteObject => `#remote_object`
+* ~~toString~~
+
+## Keyboard
+
+* down
+* press
+* sendCharacter => `#send_character`
+* type => `#type_text`
+* up
+
+## Mouse
+
+* click
+* down
+* drag
+* dragAndDrop => `#drag_and_drop`
+* dragEnter => `#drag_enter`
+* dragOver => `#drag_over`
+* drop
+* move
+* up
+* wheel
+
+## Page
+
+* $ => `#query_selector`
+* $$ => `#query_selector_all`
+* $$eval => `#eval_on_selector_all`
+* $eval => `#eval_on_selector`
+* $x => `#Sx`
+* addScriptTag => `#add_script_tag`
+* addStyleTag => `#add_style_tag`
+* authenticate
+* bringToFront => `#bring_to_front`
+* browser
+* browserContext => `#browser_context`
+* click
+* close
+* content
+* cookies
+* createPDFStream => `#create_pdf_stream`
+* deleteCookie => `#delete_cookie`
+* emulate
+* emulateCPUThrottling => `#emulate_cpu_throttling`
+* emulateIdleState => `#emulate_idle_state`
+* emulateMediaFeatures => `#emulate_media_features`
+* emulateMediaType => `#emulate_media_type`
+* emulateNetworkConditions => `#emulate_network_conditions`
+* emulateTimezone => `#emulate_timezone`
+* emulateVisionDeficiency => `#emulate_vision_deficiency`
+* evaluate
+* evaluateHandle => `#evaluate_handle`
+* evaluateOnNewDocument => `#evaluate_on_new_document`
+* exposeFunction => `#expose_function`
+* focus
+* frames
+* goBack => `#go_back`
+* goForward => `#go_forward`
+* goto
+* hover
+* isClosed => `#closed?`
+* isDragInterceptionEnabled => `#drag_interception_enabled?`
+* isJavaScriptEnabled => `#javascript_enabled?`
+* mainFrame => `#main_frame`
+* metrics
+* ~~off~~
+* on
+* once
+* pdf
+* queryObjects => `#query_objects`
+* reload
+* screenshot
+* select
+* setBypassCSP => `#bypass_csp=`
+* setCacheEnabled => `#cache_enabled=`
+* setContent => `#content=`
+* setCookie => `#set_cookie`
+* setDefaultNavigationTimeout => `#default_navigation_timeout=`
+* setDefaultTimeout => `#default_timeout=`
+* ~~setDragInterception~~
+* setExtraHTTPHeaders => `#extra_http_headers=`
+* setGeolocation => `#geolocation=`
+* setJavaScriptEnabled => `#javascript_enabled=`
+* setOfflineMode => `#offline_mode=`
+* setRequestInterception => `#request_interception=`
+* setUserAgent => `#user_agent=`
+* setViewport => `#viewport=`
+* tap
+* target
+* title
+* type => `#type_text`
+* url
+* viewport
+* waitForFileChooser => `#wait_for_file_chooser`
+* waitForFrame => `#wait_for_frame`
+* waitForFunction => `#wait_for_function`
+* waitForNavigation => `#wait_for_navigation`
+* ~~waitForNetworkIdle~~
+* waitForRequest => `#wait_for_request`
+* waitForResponse => `#wait_for_response`
+* waitForSelector => `#wait_for_selector`
+* waitForTimeout => `#wait_for_timeout`
+* waitForXPath => `#wait_for_xpath`
+* workers
+
+## ~~ProtocolError~~
+
+
 ## ~~SecurityDetails~~
 
 * ~~issuer~~
@@ -361,30 +385,21 @@
 * url
 * ~~worker~~
 
-## CDPSession
+## TimeoutError
 
-* connection
-* detach
-* id
-* send
 
-## Coverage
+## ~~Touchscreen~~
 
-* startCSSCoverage => `#start_css_coverage`
-* startJSCoverage => `#start_js_coverage`
-* stopCSSCoverage => `#stop_css_coverage`
-* stopJSCoverage => `#stop_js_coverage`
+* ~~tap~~
 
-## TimeoutError
+## Tracing
 
+* start
+* stop
 
-## ~~EventEmitter~~
+## ~~WebWorker~~
 
-* ~~addListener~~
-* ~~emit~~
-* ~~listenerCount~~
-* ~~off~~
-* ~~on~~
-* ~~once~~
-* ~~removeAllListeners~~
-* ~~removeListener~~
+* ~~evaluate~~
+* ~~evaluateHandle~~
+* ~~executionContext~~
+* ~~url~~

data/lib/puppeteer/element_handle.rb

@@ -169,37 +169,25 @@ class Puppeteer::ElementHandle < Puppeteer::JSHandle
 
   def scroll_into_view_if_needed
     js = <<~JAVASCRIPT
-      async(element, pageJavascriptEnabled) => {
+      async(element) => {
         if (!element.isConnected)
           return 'Node is detached from document';
         if (element.nodeType !== Node.ELEMENT_NODE)
           return 'Node is not of type HTMLElement';
-
-        if (element.scrollIntoViewIfNeeded) {
-          element.scrollIntoViewIfNeeded({block: 'center', inline: 'center', behavior: 'instant'});
-        } else {
-          // force-scroll if page's javascript is disabled.
-          if (!pageJavascriptEnabled) {
-            element.scrollIntoView({block: 'center', inline: 'center', behavior: 'instant'});
-            return false;
-          }
-          const visibleRatio = await new Promise(resolve => {
-            const observer = new IntersectionObserver(entries => {
-              resolve(entries[0].intersectionRatio);
-              observer.disconnect();
-            });
-            observer.observe(element);
-          });
-          if (visibleRatio !== 1.0)
-            element.scrollIntoView({block: 'center', inline: 'center', behavior: 'instant'});
-        }
         return false;
       }
     JAVASCRIPT
-    error = evaluate(js, @page.javascript_enabled) # returns String or false
+    error = evaluate(js) # returns String or false
     if error
       raise ScrollIntoViewError.new(error)
     end
+    begin
+      @remote_object.scroll_into_view_if_needed(@client)
+    rescue => err
+      # Just ignore 'Node does not have a layout object' for backward-compatibility.
+      raise unless err.message =~ /Node does not have a layout object/
+    end
+
     # clickpoint is often calculated before scrolling is completed.
     # So, just sleep about 10 frames
     sleep 0.16
@@ -569,7 +557,7 @@ class Puppeteer::ElementHandle < Puppeteer::JSHandle
       capture_beyond_viewport: capture_beyond_viewport,
       from_surface: from_surface)
   ensure
-    if needs_viewport_reset
+    if needs_viewport_reset && viewport
       @page.viewport = viewport
     end
   end

data/lib/puppeteer/frame.rb

@@ -41,6 +41,10 @@ class Puppeteer::Frame
     @secondary_world = Puppeteer::DOMWorld.new(@client, @frame_manager, self, @frame_manager.timeout_settings)
   end
 
+  def page
+    @frame_manager.page
+  end
+
   def oop_frame?
     @client != @frame_manager.client
   end

data/lib/puppeteer/remote_object.rb

@@ -176,4 +176,8 @@ class Puppeteer::RemoteObject
   def set_file_input_files(client, files, backend_node_id)
     client.send_message('DOM.setFileInputFiles', objectId: @object_id, files: files, backendNodeId: backend_node_id)
   end
+
+  def scroll_into_view_if_needed(client)
+    client.send_message('DOM.scrollIntoViewIfNeeded', objectId: @object_id)
+  end
 end

data/lib/puppeteer/version.rb

@@ -1,3 +1,3 @@
 module Puppeteer
-  VERSION = '0.41.0'
+  VERSION = '0.42.0'
 end

data/puppeteer-ruby.gemspec

@@ -32,7 +32,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'rollbar'
   spec.add_development_dependency 'rspec', '~> 3.11.0'
   spec.add_development_dependency 'rspec_junit_formatter' # for CircleCI.
-  spec.add_development_dependency 'rubocop', '~> 1.31.0'
+  spec.add_development_dependency 'rubocop', '~> 1.35.0'
   spec.add_development_dependency 'rubocop-rspec'
   spec.add_development_dependency 'sinatra'
   spec.add_development_dependency 'webrick'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: puppeteer-ruby
 version: !ruby/object:Gem::Version
-  version: 0.41.0
+  version: 0.42.0
 platform: ruby
 authors:
 - YusukeIwaki
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2022-07-03 00:00:00.000000000 Z
+date: 2022-08-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: concurrent-ruby
@@ -170,14 +170,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.31.0
+        version: 1.35.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.31.0
+        version: 1.35.0
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement