puppetdb_foreman 5.0.0 → 6.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0cea9938cf77ffa6c8a45dc91857bb2e6e5328a1832155fa609e2cd6661358f7
-  data.tar.gz: e216fe8ed183f634446ce7cf498ac9c352b2faa4d646ad703a4ca6dc091f2e61
+  metadata.gz: 2917867afdc2d20921a278f2c2fb35aa90ee71ad3ceca28cbfb6fbff4d087bd9
+  data.tar.gz: 3f6bd9d01c00bd9007220a95b1c0752c938cbbad24c01c670f03ae79e80fd6a5
 SHA512:
-  metadata.gz: 44b82f0ec55d8cb5dfe4440a50164c177e1663310ef7b3d43f9b60a2a6f5954b6371789ca357b2adbd19dca1566e1f3e5d21979ddf52da71ce135b4fa38f067f
-  data.tar.gz: bf42e84aa00284bb1bba3db4b8f1c968e722ceab97d424e2a309f175136717cf1c4e744024b12493f759ce5007fcf9c45ed2ee3d63b577c31431fb41f39ae450
+  metadata.gz: 424fd00c14417f01cc1ae6eac59d468bb6b32048f5fbd2f0e646319182500a8b46349f31d2797d87efb578d86704eed14cb42710bf25097334993118a335c904
+  data.tar.gz: 0e0ad581dbecf0ce351bb50e8fd88c348e080b64a812c82cb933da13c60a9006f681ba1bcdc6229987e36b96d5d37719895eb7be81c685a15ddb5ec1c8630121

data/README.md

@@ -19,6 +19,7 @@ Feel free to raise issues, ask for features, anything, in the github repository
 | --------------- | -------------- |
 | >= 1.17         | ~> 4.0.0       |
 | >= 1.20         | ~> 5.0.0       |
+| >= 3.1          | ~> 6.0.0       |
 
 # Installation:
 
@@ -51,19 +52,6 @@ puppetdb_foreman uses [Semantic Versioning 2.0.0](http://semver.org/spec/v2.0.0.
 
 Go to Administer > Settings > PuppetDB and set `puppetdb_address` with your PuppetDB address, `puppetdb_enabled` to either true or false if you want to enable or disable PuppetDB integration. Obviously you will need a PuppetDB instance at the address you provide.
 
-Alternatively you can put your settings in `config/settings.yaml`. Please keep in mind these will be overwritten if changed in the application, and if the application is rebooted, YAML rules will overwrite again your manually changed settings. Hence passing your settings in this format is discouraged, but allowed.
-
-for PuppetDB 4
-```yaml
-:puppetdb:
-  :enabled: true
-  :address: 'https://puppetdb:8081/pdb/cmd/v1'
-  :ssl_ca_file: '/etc/puppetlabs/puppet/ssl/certs/ca.pem'
-  :ssl_certificate: '/etc/puppetlabs/puppet/ssl/certs/FQDN.pem'
-  :ssl_private_key: '/etc/puppetlabs/puppet/ssl/private_keys/FQDN.pem'
-  :api_version: 4
-```
-
 # Copyright:
 Copyright 2013 CERN, Switzerland and various authors
 

data/Rakefile

@@ -1,4 +1,6 @@
 #!/usr/bin/env rake
+# frozen_string_literal: true
+
 begin
   require 'bundler/setup'
 rescue LoadError
@@ -20,7 +22,7 @@ RDoc::Task.new(:rdoc) do |rdoc|
   rdoc.rdoc_files.include('lib/**/*.rb')
 end
 
-APP_RAKEFILE = File.expand_path('../test/dummy/Rakefile', __FILE__)
+APP_RAKEFILE = File.expand_path('test/dummy/Rakefile', __dir__)
 
 Bundler::GemHelper.install_tasks
 
@@ -37,11 +39,12 @@ task default: :test
 
 begin
   require 'rubocop/rake_task'
-  RuboCop::RakeTask.new
-rescue => _
+rescue StandardError
   puts 'Rubocop not loaded.'
-end
+else
+  RuboCop::RakeTask.new
 
-task :default do
-  Rake::Task['rubocop'].execute
+  task :default do
+    Rake::Task['rubocop'].execute
+  end
 end

data/app/controllers/api/v2/puppetdb_nodes_controller.rb

@@ -1,10 +1,12 @@
+# frozen_string_literal: true
+
 module Api
   module V2
     class PuppetdbNodesController < V2::BaseController
       include Api::Version2
-      before_action :find_node, :only => [:destroy, :import]
+      before_action :find_node, only: %i[destroy import]
 
-      layout 'api/v2/layouts/index_layout', :only => [:index, :unknown]
+      layout 'api/v2/layouts/index_layout', only: %i[index unknown]
 
       api :GET, '/puppetdb_nodes/', N_('List all PuppetDB nodes')
       def index
@@ -19,20 +21,20 @@ module Api
       end
 
       api :DELETE, '/puppetdb_nodes/:id/', N_('Deactivate a node in PuppetDB')
-      param :id, String, :required => true
+      param :id, String, required: true
 
       def destroy
         uuid = Puppetdb.client.deactivate_node(@node)
-        response = { :job => { :uuid => uuid } }
+        response = { job: { uuid: uuid } }
         process_success response
       end
 
       api :PUT, '/puppetdb_nodes/:id/import/', N_('Import PuppetDB Node to Foreman Host')
-      param :id, :identifier, :required => true
+      param :id, :identifier, required: true
 
       def import
         facts = Puppetdb.client.facts(@node)
-        @host = PuppetdbHost.new(:facts => facts).to_host
+        @host = PuppetdbHost.new(facts: facts).to_host
       end
 
       # Overrides because PuppetDB is not backed by ActiveRecord

data/app/controllers/puppetdb_foreman/nodes_controller.rb

@@ -1,6 +1,8 @@
+# frozen_string_literal: true
+
 module PuppetdbForeman
   class NodesController < ApplicationController
-    before_action :find_node, :only => [:show, :destroy, :import]
+    before_action :find_node, only: %i[show destroy import]
 
     def controller_permission
       'puppetdb_nodes'
@@ -12,7 +14,7 @@ module PuppetdbForeman
       @unknown_hosts = @puppetdb_hosts - @foreman_hosts
     end
 
-    def show
+    def show # rubocop:disable Metrics/AbcSize
       response = Puppetdb.client.resources(@node)
 
       class_names = response.map { |v| v['title'] if v['type'] == 'Class' }.compact
@@ -25,17 +27,29 @@ module PuppetdbForeman
 
     def destroy
       Puppetdb.client.deactivate_node(@node)
-      process_success :success_msg => _('Deactivated node %s in PuppetDB') % @node, :success_redirect => puppetdb_foreman_nodes_path
+      process_success(
+        success_msg: _('Deactivated node %s in PuppetDB') % @node,
+        success_redirect: puppetdb_foreman_nodes_path
+      )
     rescue StandardError => e
-      process_error(:redirect => puppetdb_foreman_nodes_path, :error_msg => _('Failed to deactivate node in PuppetDB: %s') % e.message)
+      process_error(
+        redirect: puppetdb_foreman_nodes_path,
+        error_msg: _('Failed to deactivate node in PuppetDB: %s') % e.message
+      )
     end
 
-    def import
+    def import # rubocop:disable Metrics/MethodLength
       facts = Puppetdb.client.facts(@node)
-      host = PuppetdbHost.new(:facts => facts).to_host
-      process_success :success_msg => _('Imported host %s from PuppetDB') % @node, :success_redirect => host_path(:id => host)
+      host = PuppetdbHost.new(facts: facts).to_host
+      process_success(
+        success_msg: _('Imported host %s from PuppetDB') % @node,
+        success_redirect: host_path(id: host)
+      )
     rescue StandardError => e
-      process_error(:redirect => puppetdb_foreman_nodes_path, :error_msg => _('Failed to import host from PuppetDB: %s') % e.message)
+      process_error(
+        redirect: puppetdb_foreman_nodes_path,
+        error_msg: _('Failed to import host from PuppetDB: %s') % e.message
+      )
     end
 
     private

data/app/helpers/concerns/puppetdb_foreman/hosts_helper_extensions.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module PuppetdbForeman
   module HostsHelperExtensions
     extend ActiveSupport::Concern
@@ -9,9 +11,9 @@ module PuppetdbForeman
         if host.puppet_proxy_id?
           buttons << link_to_if_authorized(
             _('Puppet Classes'),
-            hash_for_puppetdb_foreman_node_path(:id => host.name),
-            :title => _('Browse host puppet classes'),
-            :class => 'btn btn-default'
+            hash_for_puppetdb_foreman_node_path(id: host.name),
+            title: _('Browse host puppet classes'),
+            class: 'btn btn-default'
           )
         end
 

data/app/models/concerns/orchestration/puppetdb.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Orchestration
   module Puppetdb
     extend ActiveSupport::Concern
@@ -10,18 +12,23 @@ module Orchestration
 
     def queue_puppetdb_destroy
       return unless ::Puppetdb.ready? && errors.empty?
-      queue.create(:name   => _('Deactivating node %s in PuppetDB') % self, :priority => 60,
-                   :action => [self, :delPuppetdb])
+      queue.create(
+        name: _('Deactivating node %s in PuppetDB') % self,
+        priority: 60,
+        action: [self, :del_puppetdb]
+      )
     end
 
-    def delPuppetdb
+    def del_puppetdb
       Rails.logger.info "Deactivating node in PuppetDB: #{name}"
       ::Puppetdb.client.deactivate_node(name)
     rescue StandardError => e
-      failure _("Failed to deactivate node %{name} in PuppetDB: %{message}\n ") %
-              { :name => name, :message => e.message }, e
+      failure format(
+        _("Failed to deactivate node %<name>s in PuppetDB: %<message>s\n "), name: name, message: e.message
+      ), e
     end
 
-    def setPuppetdb; end
+    def set_puppetdb
+    end
   end
 end

data/app/models/puppetdb_foreman/host_extensions.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module PuppetdbForeman
   module HostExtensions
     extend ActiveSupport::Concern
@@ -7,20 +9,19 @@ module PuppetdbForeman
       after_build :deactivate_host
     end
 
-    def deactivate_host
+    def deactivate_host # rubocop:disable Metrics/MethodLength
       logger.debug "Deactivating host #{name} in PuppetDB"
       return true unless Puppetdb.enabled?
 
       unless Puppetdb.configured?
-        errors.add(:base,
-                   _('PuppetDB plugin is enabled but not configured. Please configure it before trying to delete a host.'))
+        errors.add(:base, _('PuppetDB plugin is enabled but not configured. Please configure it before trying to delete a host.')) # rubocop:disable Layout/LineLength
       end
 
       begin
         Puppetdb.client.deactivate_node(name)
       rescue StandardError => e
         errors.add(:base, _("Could not deactivate host on PuppetDB: #{e}"))
-        return false
+        false
       end
     end
   end

data/app/services/puppetdb.rb

@@ -1,23 +1,19 @@
+# frozen_string_literal: true
+
 module Puppetdb
   API_VERSIONS = {
-    '4' => 'v4: PuppetDB 4.0, 4.1, 4.2, 4.3',
-    '3' => 'v3: PuppetDB 3.0, 3.1, 3.2',
-    '1' => 'v1: PuppetDB 1.1, 1.2, 1.3, 1.4, 1.5, 1.6, 2.0, 2.1, 2.2, 2.3'
+    '4' => 'v4: PuppetDB 4 - 7',
   }.freeze
 
-  def self.client
+  def self.client # rubocop:disable Metrics/MethodLength
     options = {
-      :uri => uri,
-      :ssl_ca_file => Setting[:puppetdb_ssl_ca_file],
-      :ssl_certificate_file => Setting[:puppetdb_ssl_certificate],
-      :ssl_private_key_file => Setting[:puppetdb_ssl_private_key]
+      uri: uri,
+      ssl_ca_file: Setting[:puppetdb_ssl_ca_file],
+      ssl_certificate_file: Setting[:puppetdb_ssl_certificate],
+      ssl_private_key_file: Setting[:puppetdb_ssl_private_key],
     }
 
     case api_version
-    when 1
-      PuppetdbClient::V1.new(options)
-    when 3
-      PuppetdbClient::V3.new(options)
     when 4
       PuppetdbClient::V4.new(options)
     else

data/app/services/puppetdb_client/base.rb

@@ -1,6 +1,8 @@
+# frozen_string_literal: true
+
 module PuppetdbClient
   class Base
-    delegate :logger, :to => :Rails
+    delegate :logger, to: :Rails
     attr_reader :uri, :ssl_ca_file, :ssl_certificate_file, :ssl_private_key_file
 
     def initialize(opts)
@@ -66,13 +68,13 @@ module PuppetdbClient
 
     def request_options
       {
-        headers: request_headers
+        headers: request_headers,
       }.merge(auth_options).merge(ssl_options)
     end
 
     def request_headers
       {
-        'Accept' => 'application/json'
+        'Accept' => 'application/json',
       }
     end
 
@@ -80,11 +82,11 @@ module PuppetdbClient
       if ssl_ca_file
         {
           ssl_ca_file: ssl_ca_file,
-          verify_ssl: true
+          verify_ssl: true,
         }
       else
         {
-          verify_ssl: false
+          verify_ssl: false,
         }
       end
     end
@@ -93,7 +95,7 @@ module PuppetdbClient
       return {} unless certificate_request?
       {
         ssl_client_cert: ssl_certificate,
-        ssl_client_key: ssl_private_key
+        ssl_client_key: ssl_private_key,
       }
     end
 

data/app/services/puppetdb_client/v4.rb

@@ -1,4 +1,51 @@
+# frozen_string_literal: true
+
 module PuppetdbClient
-  class V4 < V3
+  class V4 < Base
+    # The payload is formatted as a JSON map.
+    # certname: The name of the node for which the catalog was compiled.
+    # producer_timestamp: The time of command submission.
+    def deactivate_node_payload(nodename)
+      {
+        'command' => 'deactivate node',
+        'version' => 3,
+        'payload' => {
+          'certname' => nodename,
+          'producer_timestamp' => producer_timestamp,
+        },
+      }.to_json
+    end
+
+    def command_url
+      '/pdb/cmd/v1'
+    end
+
+    def nodes_url
+      '/pdb/query/v4/nodes'
+    end
+
+    def facts_url
+      '/pdb/query/v4/facts'
+    end
+
+    def resources_url
+      '/pdb/query/v4/resources'
+    end
+
+    def query_nodes
+      super.map { |node| node['certname'] }
+    end
+
+    private
+
+    def post_options
+      {
+        content_type: :json,
+      }
+    end
+
+    def producer_timestamp
+      Time.now.iso8601.to_s
+    end
   end
 end

data/app/services/puppetdb_host.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class PuppetdbHost
   attr_accessor :certname, :environment, :facts
 
@@ -8,8 +10,8 @@ class PuppetdbHost
 
   def to_host
     host = Host::Managed.import_host(facts[:fqdn], certname)
-    host.import_facts(facts)
-    host.update_attribute(:environment => environment) if environment
+    HostFactImporter.new(host).import_facts(facts)
+    host.update_attribute(environment: environment) if environment   # rubocop:disable Rails/SkipsModelValidations
     host
   end
 

data/app/views/api/v2/puppetdb_nodes/import.json.rabl

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 object @host
 
 extends 'api/v2/hosts/show'

data/app/views/api/v2/puppetdb_nodes/index.json.rabl

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 collection @nodes
 
 node :name do |node|

data/app/views/api/v2/puppetdb_nodes/unknown.json.rabl

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 collection @nodes
 
 extends 'api/v2/puppetdb_nodes/index'

data/config/routes.rb

@@ -1,7 +1,9 @@
+# frozen_string_literal: true
+
 Rails.application.routes.draw do
   namespace :puppetdb_foreman do
-    constraints(:id => %r{[^\/]+}) do
-      resources :nodes, :only => [:index, :show, :destroy] do
+    constraints(id: %r{[^/]+}) do
+      resources :nodes, only: %i[index show destroy] do
         member do
           put 'import'
         end
@@ -9,13 +11,13 @@ Rails.application.routes.draw do
     end
   end
 
-  namespace :api, :defaults => { :format => 'json' } do
-    scope '(:apiv)', :module => :v2,
-                     :defaults => { :apiv => 'v2' },
-                     :apiv => /v1|v2/,
-                     :constraints => ApiConstraints.new(:version => 2) do
-      constraints(:id => /[^\/]+/) do
-        resources :puppetdb_nodes, :only => [:index, :destroy] do
+  namespace :api, defaults: { format: 'json' } do
+    scope '(:apiv)', module: :v2,
+                     defaults: { apiv: 'v2' },
+                     apiv: /v1|v2/,
+                     constraints: ApiConstraints.new(version: 2) do
+      constraints(id: %r{[^/]+}) do
+        resources :puppetdb_nodes, only: %i[index destroy] do
           collection do
             get 'unknown'
           end

data/db/migrate/20170717140010_migrate_puppetdb_api_version_setting.rb

@@ -1,10 +1,12 @@
+# frozen_string_literal: true
+
 class MigratePuppetdbApiVersionSetting < ActiveRecord::Migration[4.2]
   def up
-    puppetdb_address = Setting.where(:category => 'Setting::Puppetdb', :name => 'puppetdb_address').first.try(:value)
+    puppetdb_address = Setting.where(category: 'Setting::Puppetdb', name: 'puppetdb_address').first.try(:value)
     return unless puppetdb_address
 
     api_version = URI.parse(puppetdb_address).path.start_with?('/pdb') ? 3 : 1
-    setting = Setting.where(:category => 'Setting::Puppetdb', :name => 'puppetdb_api_version').first_or_create
+    setting = Setting.where(category: 'Setting::Puppetdb', name: 'puppetdb_api_version').first_or_create
     setting.value = api_version
     setting.save
   end

data/db/migrate/20181001113836_remove_puppetdb_dashboard_address_setting.puppetdb_foreman.rb

@@ -1,5 +1,7 @@
+# frozen_string_literal: true
+
 class RemovePuppetdbDashboardAddressSetting < ActiveRecord::Migration[5.2]
   def change
-    Setting::Puppetdb.where(name: 'puppetdb_dashboard_address').destroy_all
+    Setting.where(name: 'puppetdb_dashboard_address').destroy_all
   end
 end

data/lib/puppetdb_foreman/engine.rb

@@ -1,55 +1,83 @@
+# frozen_string_literal: true
+
 module PuppetdbForeman
   class Engine < ::Rails::Engine
     engine_name 'puppetdb_foreman'
 
-    initializer 'puppetdb_foreman.load_default_settings', :before => :load_config_initializers do |_app|
-      require_dependency File.expand_path('../../app/models/setting/puppetdb.rb', __dir__) if begin
-                                                                                                     Setting.table_exists?
-                                                                                                   rescue StandardError
-                                                                                                     (false)
-                                                                                                   end
-    end
-
     initializer 'puppetdb_foreman.load_app_instance_data' do |app|
       PuppetdbForeman::Engine.paths['db/migrate'].existent.each do |path|
         app.config.paths['db/migrate'] << path
       end
     end
 
-    initializer 'puppetdb_foreman.register_plugin', :before => :finisher_hook do |_app|
+    initializer 'puppetdb_foreman.register_plugin', before: :finisher_hook do |_app|
       Foreman::Plugin.register :puppetdb_foreman do
-        requires_foreman '>= 1.20'
+        requires_foreman '>= 3.1'
 
         apipie_documented_controllers ["#{PuppetdbForeman::Engine.root}/app/controllers/api/v2/*.rb"]
 
+        settings do
+          category :puppetdb, N_('PuppetDB') do
+            setting :puppetdb_enabled,
+              type: :boolean,
+              default: false,
+              description: _("Integration with PuppetDB, enabled will deactivate a host in PuppetDB when it's deleted in Foreman")  # rubocop:disable Layout/LineLength
+
+            setting :puppetdb_address,
+              type: :string,
+              default: 'https://puppetdb:8081/pdb/cmd/v1',
+              description: _('Foreman will send PuppetDB requests to this address')
+
+            setting :puppetdb_ssl_ca_file,
+              type: :string,
+              default: SETTINGS[:ssl_ca_file],
+              description: _('Foreman will send PuppetDB requests with this CA file')
+
+            setting :puppetdb_ssl_certificate,
+              type: :string,
+              default: SETTINGS[:ssl_certificate],
+              description: _('Foreman will send PuppetDB requests with this certificate file')
+
+            setting :puppetdb_ssl_private_key,
+              type: :string,
+              default: SETTINGS[:ssl_priv_key],
+              description: _('Foreman will send PuppetDB requests with this key file')
+
+            setting :puppetdb_api_version,
+              type: :integer,
+              default: 4,
+              full_name: N_('PuppetDB API Version'),
+              description: _('Foreman will use this PuppetDB API version'),
+              collection: proc { ::Puppetdb::API_VERSIONS }
+          end
+        end
+
         security_block :puppetdb_foreman do
-          permission :view_puppetdb_nodes, :'puppetdb_foreman/nodes' => [:index, :show],
-                                           :'api/v2/puppetdb_nodes' => [:index, :unknown]
+          permission :view_puppetdb_nodes, 'puppetdb_foreman/nodes': %i[index show],
+                                           'api/v2/puppetdb_nodes': %i[index unknown]
 
-          permission :destroy_puppetdb_nodes, :'puppetdb_foreman/nodes' => [:destroy],
-                                              :'api/v2/puppetdb_nodes' => [:destroy]
+          permission :destroy_puppetdb_nodes, 'puppetdb_foreman/nodes': [:destroy],
+                                              'api/v2/puppetdb_nodes': [:destroy]
 
-          permission :import_puppetdb_nodes, :'puppetdb_foreman/nodes' => [:import],
-                                             :'api/v2/puppetdb_nodes' => [:import]
+          permission :import_puppetdb_nodes, 'puppetdb_foreman/nodes': [:import],
+                                             'api/v2/puppetdb_nodes': [:import]
         end
 
         role 'PuppetDB Node Viewer', [:view_puppetdb_nodes]
-        role 'PuppetDB Node Manager', [:view_puppetdb_nodes, :destroy_puppetdb_nodes, :import_puppetdb_nodes]
+        role 'PuppetDB Node Manager', %i[view_puppetdb_nodes destroy_puppetdb_nodes import_puppetdb_nodes]
 
-        menu :top_menu, :nodes, :caption => N_('PuppetDB Nodes'),
-                                :url_hash => { :controller => 'puppetdb_foreman/nodes', :action => 'index' },
-                                :parent => :monitor_menu,
-                                :after => :puppetdb
+        menu :top_menu, :nodes, caption: N_('PuppetDB Nodes'),
+                                url_hash: { controller: 'puppetdb_foreman/nodes', action: 'index' },
+                                parent: :monitor_menu,
+                                after: :puppetdb
       end
     end
 
     config.to_prepare do
-      begin
-        Host::Managed.send :include, PuppetdbForeman::HostExtensions
-        HostsHelper.send(:include, PuppetdbForeman::HostsHelperExtensions)
-      rescue StandardError => e
-        Rails.logger.warn "PuppetdbForeman: skipping engine hook (#{e})"
-      end
+      Host::Managed.include PuppetdbForeman::HostExtensions
+      HostsHelper.include PuppetdbForeman::HostsHelperExtensions
+    rescue StandardError => e
+      Rails.logger.warn "PuppetdbForeman: skipping engine hook (#{e})"
     end
   end
 end

data/lib/puppetdb_foreman/version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module PuppetdbForeman
-  VERSION = '5.0.0'.freeze
+  VERSION = '6.0.0'
 end

data/lib/puppetdb_foreman.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module PuppetdbForeman
   require 'puppetdb_foreman/engine'
 end

data/lib/tasks/puppetdb_foreman_tasks.rake

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Tests
 namespace :test do
   desc 'Test PuppetdbForeman'
@@ -11,7 +13,7 @@ namespace :test do
 end
 
 namespace :puppetdb_foreman do
-  task :rubocop do
+  task rubocop: :environment do
     begin
       require 'rubocop/rake_task'
       RuboCop::RakeTask.new(:rubocop_puppetdb_foreman) do |task|
@@ -30,6 +32,4 @@ end
 Rake::Task[:test].enhance ['test:puppetdb_foreman']
 
 load 'tasks/jenkins.rake'
-if Rake::Task.task_defined?(:'jenkins:unit')
-  Rake::Task['jenkins:unit'].enhance ['test:puppetdb_foreman', 'puppetdb_foreman:rubocop']
-end
+Rake::Task['jenkins:unit'].enhance ['test:puppetdb_foreman', 'puppetdb_foreman:rubocop'] if Rake::Task.task_defined?(:'jenkins:unit')