puppet_forge 5.0.1 → 5.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 03c98f5fd125a4ff36b815a734d7ac6bf7d51578550a1b873fcea09c33d028be
-  data.tar.gz: 34f9e9b0f8e55939349ea47f4fb9c2ad8324a179c73fbb728709f453d9f5bfdf
+  metadata.gz: 173cc16e95da2ae090f719e7d6b1ff2e86f444c27f8c88ada965047e7c24afcc
+  data.tar.gz: 97b40c77169ce1c3f67fcf1ea70e48d8738e9623c3a9a76aa451e493b316b1ca
 SHA512:
-  metadata.gz: 026cf550bb188d6e04eda4dc97a053439f49745fef1413b71c7c1ae9f9e8ed950fe3f89ca2e7d93924e86929e91f7d40ebcd526696992f2c9ddb15adcb20def5
-  data.tar.gz: eee31c229447d406879270db396987ccc75c9cf3fd554efa8805dbbd22d931df648240c08bed8cdd6789f322d40f6e937eade56edd9ea6ce2a27e336c31325fa
+  metadata.gz: 9cea98cd9ec0b7a20f385c61b3f1776067eea4c4345dfc1d20ed274813d24a0d46af80109e709d57014e2cad09cd765ada4e82902cc1c3d3a698f0906453c7bb
+  data.tar.gz: a6bf1839d69b0bd3404c104e6621fe77e29c6e89cedc5ca19b0cdf78c9750ce60bb1cbc5879b23fd807f477b6731c281b6c830da3a48a11ad4fb6845dd1c899d

data/CHANGELOG.md

@@ -3,6 +3,10 @@
 Starting with v2.0.0, all notable changes to this project will be documented in this file.
 This project adheres to [Semantic Versioning](http://semver.org/).
 
+## v5.0.2 - 2023-09-29
+* Correct a Digest call making this thread-safe and allowing for concurrent r10k deploys.
+  Thanks to @cmd-ntrf for fixing it and to @baurmatt for tracking it down in the first place.
+
 ## v5.0.1 - 2023-07-10
 * Update README to reflect accurate Ruby requirement and `faraday` gem dependency
 ## v5.0.0 - 2023-05-07

data/lib/puppet_forge/lru_cache.rb

@@ -9,7 +9,7 @@ module PuppetForge
     # a convenience method for generating cache keys. Cache keys do not
     # have to be SHA256 hashes, but they must be unique.
     def self.new_key(*string_args)
-      Digest::SHA256.hexdigest(string_args.map(&:to_s).join(':'))
+      Digest(:SHA256).hexdigest(string_args.map(&:to_s).join(':'))
     end
 
     # @return [Integer] the maximum number of items to cache.

data/lib/puppet_forge/version.rb

@@ -1,3 +1,3 @@
 module PuppetForge
-  VERSION = '5.0.1' # Library version
+  VERSION = '5.0.2' # Library version
 end

data/spec/unit/forge/lru_cache_spec.rb

@@ -67,18 +67,26 @@ describe PuppetForge::LruCache do
       expect(cache.send(:lru)).to eq(['foo', 'baz'])
     end
 
-    # The below test is non-deterministic but I'm not sure how to unit
-    # test thread-safety.
-    # it 'is thread-safe' do
-    #   cache = PuppetForge::LruCache.new
-    #   cache.put('foo', 'bar')
-    #   cache.put('baz', 'qux')
-    #   threads = []
-    #   threads << Thread.new { 100.times { cache.get('foo') } }
-    #   threads << Thread.new { 100.times { cache.get('baz') } }
-    #   threads.each(&:join)
-    #   expect(cache.send(:lru)).to eq(['baz', 'foo'])
-    # end
+    it 'is thread-safe for get calls' do
+      cache = PuppetForge::LruCache.new
+    
+      # Populate the cache with initial values
+      cache.put('foo', 'bar')
+      cache.put('baz', 'qux')
+    
+      # Create two threads for concurrent cache get operations
+      thread_one = Thread.new do
+        100.times { expect(cache.get('foo')).to eq('bar') }
+      end
+    
+      thread_two = Thread.new do
+        100.times { expect(cache.get('baz')).to eq('qux') }
+      end
+    
+      # Wait for both threads to complete
+      thread_one.join
+      thread_two.join
+    end    
   end
 
   context '#put' do
@@ -102,16 +110,30 @@ describe PuppetForge::LruCache do
       expect(cache.send(:lru)).to eq(['quux', 'baz'])
     end
 
-    # The below test is non-deterministic but I'm not sure how to unit
-    # test thread-safety.
-    # it 'is thread-safe' do
-    #   cache = PuppetForge::LruCache.new
-    #   threads = []
-    #   threads << Thread.new { 100.times { cache.put('foo', 'bar') } }
-    #   threads << Thread.new { 100.times { cache.put('baz', 'qux') } }
-    #   threads.each(&:join)
-    #   expect(cache.send(:lru)).to eq(['baz', 'foo'])
-    # end
+    it 'is thread-safe' do
+      cache = PuppetForge::LruCache.new
+    
+      # Create two threads for concurrent cache operations
+      thread_one = Thread.new do
+        100.times { cache.put('foo', 'bar') }
+      end
+    
+      thread_two = Thread.new do
+        100.times { cache.put('baz', 'qux') }
+      end
+    
+      # Wait for both threads to complete
+      thread_one.join
+      thread_two.join
+    
+      # At this point, we don't need to compare the LRU list,
+      # because the order may change due to concurrent puts.
+      
+      # Instead, we simply expect the code to run without errors.
+      expect { thread_one.value }.not_to raise_error
+      expect { thread_two.value }.not_to raise_error
+    end
+    
   end
 
   context '#clear' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: puppet_forge
 version: !ruby/object:Gem::Version
-  version: 5.0.1
+  version: 5.0.2
 platform: ruby
 authors:
 - Puppet Labs
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-07-10 00:00:00.000000000 Z
+date: 2023-09-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -253,7 +253,7 @@ homepage: https://github.com/puppetlabs/forge-ruby
 licenses:
 - Apache-2.0
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -268,8 +268,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.6
-signing_key: 
+rubygems_version: 3.3.7
+signing_key:
 specification_version: 4
 summary: Access the Puppet Forge API from Ruby for resource information and to download
   releases.