puppet 3.3.0.rc2 → 3.3.0.rc3

data/ext/build_defaults.yaml

@@ -9,7 +9,7 @@ gpg_name: 'info@puppetlabs.com'
 gpg_key: '4BD6EC30'
 sign_tar: FALSE
 # a space separated list of mock configs
-final_mocks: 'pl-el-5-i386 pl-el-6-i386 pl-fedora-17-i386 pl-fedora-18-i386 pl-fedora-19-i386'
+final_mocks: 'pl-el-5-i386 pl-el-6-i386 pl-fedora-18-i386 pl-fedora-19-i386'
 yum_host: 'yum.puppetlabs.com'
 yum_repo_path: '/opt/repository/yum/'
 build_gem: TRUE

data/ext/windows/service/daemon.rb

@@ -55,7 +55,7 @@ class WindowsDaemon < Win32::Daemon
         runinterval = 1800
       end
 
-      pid = Process.create(:command_line => "\"#{puppet}\" agent --onetime #{args}").process_id
+      pid = Process.create(:command_line => "\"#{puppet}\" agent --onetime #{args}", :creation_flags => Process::CREATE_NEW_CONSOLE).process_id
       log_debug("Process created: #{pid}")
 
       log_debug("Service waiting for #{runinterval} seconds")

data/lib/puppet/coercion.rb

@@ -0,0 +1,29 @@
+# Various methods used to coerce values into a canonical form.
+#
+# @api private
+module Puppet::Coercion
+  # Try to coerce various input values into boolean true/false
+  #
+  # Only a very limited subset of values are allowed. This method does not try
+  # to provide a generic "truthiness" system.
+  #
+  # @param value [Boolean, Symbol, String]
+  # @return [Boolean]
+  # @raise
+  # @api private
+  def self.boolean(value)
+    # downcase strings
+    if value.respond_to? :downcase
+      value = value.downcase
+    end
+
+    case value
+    when true, :true, 'true', :yes, 'yes'
+      true
+    when false, :false, 'false', :no, 'no'
+      false
+    else
+      fail('expected a boolean value')
+    end
+  end
+end

data/lib/puppet/configurer.rb

@@ -210,6 +210,13 @@ class Puppet::Configurer
     Puppet::Transaction::Report.indirection.save(report, nil, :environment => @environment) if Puppet[:report]
   rescue => detail
     Puppet.log_exception(detail, "Could not send report: #{detail}")
+    if detail.message =~ /Could not intern from pson.*Puppet::Transaction::Report/
+      Puppet.notice("There was an error sending the report.")
+      Puppet.notice("This error is possibly caused by sending the report in a format the master can not handle.")
+      Puppet.notice("A puppet master older than 3.2.2 can not handle pson reports.")
+      Puppet.notice("Set report_serialization_format=yaml on the agent to send reports to older masters.")
+      Puppet.notice("See http://links.puppetlabs.com/deprecate_yaml_on_network for more information.")
+    end
   end
 
   def save_last_run_summary(report)

data/lib/puppet/defaults.rb

@@ -1081,6 +1081,24 @@ EOT
       can be guaranteed to support this format, but it will be used for all
       classes that support it.",
     },
+    :report_serialization_format => {
+      :default => "pson",
+      :type => :enum,
+      :values => ["pson", "yaml"],
+      :desc => "The serialization format to use when sending reports to the
+      `report_server`. Possible values are `pson` and `yaml`. This setting
+      affects puppet agent, but not puppet apply (which processes its own
+      reports).
+
+      This should almost always be set to `pson`. It can be temporarily set to
+      `yaml` to let agents using this Puppet version connect to a puppet master
+      running Puppet 3.0.0 through 3.2.4.",
+      :hook => proc do |value|
+        if value == "yaml"
+          Puppet.deprecation_warning("Sending reports in 'yaml' is deprecated; use 'pson' instead.")
+        end
+      end
+    },
     :agent_catalog_run_lockfile => {
       :default    => "$statedir/agent_catalog_run.lock",
       :type       => :string, # (#2888) Ensure this file is not added to the settings catalog.
@@ -1234,13 +1252,21 @@ EOT
       :type => :enum,
       :values => ["manifest", "title-hash", "random"],
       :default => "title-hash",
-      :desc => "Controls the default ordering to use in the absence of any
-      dependency information. By default this is 'title-hash', which is an
-      opaque, stable, random order. The value of 'manifest' will use the order
-      in which the resources were added to the catalog, which matches the order
-      that the puppet language executes. The final value of 'random' causes
-      resources to be assigned a random order, while still obeying declared
-      dependencies."
+      :desc => "How unrelated resources should be ordered when applying a catalog.
+      Allowed values are `title-hash`, `manifest`, and `random`. This
+      setting affects puppet agent and puppet apply, but not puppet master.
+
+      * `title-hash` (the default) will order resources randomly, but will use
+        the same order across runs and across nodes.
+      * `manifest` will use the order in which the resources were declared in
+        their manifest files.
+      * `random` will order resources randomly and change their order with each
+        run. This can work like a fuzzer for shaking out undeclared dependencies.
+
+      Regardless of this setting's value, Puppet will always obey explicit
+      dependencies set with the before/require/notify/subscribe metaparameters
+      and the `->`/`~>` chaining arrows; this setting only affects the relative
+      ordering of _unrelated_ resources."
     }
   )
 

data/lib/puppet/file_bucket/file.rb

@@ -13,6 +13,15 @@ class Puppet::FileBucket::File
   attr :contents
   attr :bucket_path
 
+  def self.supported_formats
+    # This should really be :raw, like is done for Puppet::FileServing::Content
+    # but this class hasn't historically supported `from_raw`, so switching
+    # would break compatibility between newer 3.x agents talking to older 3.x
+    # masters. However, to/from_s has been supported and achieves the desired
+    # result without breaking compatibility.
+    [:s]
+  end
+
   def initialize(contents, options = {})
     raise ArgumentError.new("contents must be a String, got a #{contents.class}") unless contents.is_a?(String)
     @contents = contents
@@ -45,11 +54,10 @@ class Puppet::FileBucket::File
     self.new(contents)
   end
 
-  def to_pson
-    { "contents" => contents }.to_pson
-  end
-
+  # This method is deprecated, but cannot be removed for awhile, otherwise
+  # older agents sending pson couldn't backup to filebuckets on newer masters
   def self.from_pson(pson)
+    Puppet.deprecation_warning("Deserializing Puppet::FileBucket::File objects from pson is deprecated. Upgrade to a newer version.")
     self.new(pson["contents"])
   end
 end

data/lib/puppet/indirector/file_bucket_file/file.rb

@@ -44,7 +44,9 @@ module Puppet::FileBucketFile
       checksum, files_original_path = request_to_checksum_and_path(request)
 
       save_to_disk(instance, files_original_path)
-      instance.to_s
+
+      # don't echo the request content back to the agent
+      model.new('')
     end
 
     def validate_key(request)

data/lib/puppet/network/format_handler.rb

@@ -67,20 +67,28 @@ module Puppet::Network::FormatHandler
   # Determine which of the accepted formats should be used given what is supported.
   #
   # @param accepted [Array<String, Symbol>] the accepted formats in a form a
-  #   that can be understood by #format_to_canonical_name and is in order of
-  #   preference (most preferred is first)
+  #   that generally conforms to an HTTP Accept header. Any quality specifiers
+  #   are ignored and instead the formats are simply in strict preference order
+  #   (most preferred is first)
   # @param supported [Array<Symbol>] the names of the supported formats (order
   #   does not matter)
   # @return [Puppet::Network::Format, nil] the most suitable format
   # @api private
   def self.most_suitable_format_for(accepted, supported)
-    format_name = accepted.find do |accepted|
+    format_name = accepted.collect do |accepted|
+      accepted.to_s.sub(/;q=.*$/, '')
+    end.collect do |accepted|
       begin
-        format_name = format_to_canonical_name(accepted)
-        supported.include?(format_name)
+        if accepted == '*/*'
+          formats
+        else
+          format_to_canonical_name(accepted)
+        end
       rescue ArgumentError
-        false
+        nil
       end
+    end.flatten.find do |accepted|
+      supported.include?(accepted)
     end
 
     if format_name

data/lib/puppet/parameter/boolean.rb

@@ -1,20 +1,10 @@
+require 'puppet/coercion'
+
 # This specialized {Puppet::Parameter} handles boolean options, accepting lots
 # of strings and symbols for both truthiness and falsehood.
 #
 class Puppet::Parameter::Boolean < Puppet::Parameter
   def unsafe_munge(value)
-    # downcase strings
-    if value.respond_to? :downcase
-      value = value.downcase
-    end
-
-    case value
-    when true, :true, 'true', :yes, 'yes'
-      true
-    when false, :false, 'false', :no, 'no'
-      false
-    else
-      fail('expected a boolean value')
-    end
+    Puppet::Coercion.boolean(value)
   end
 end

data/lib/puppet/property/boolean.rb

@@ -0,0 +1,7 @@
+require 'puppet/coercion'
+
+class Puppet::Property::Boolean < Puppet::Property
+  def unsafe_munge(value)
+    Puppet::Coercion.boolean(value)
+  end
+end

data/lib/puppet/provider/user/aix.rb

@@ -214,6 +214,11 @@ Puppet::Type.type(:user).provide :aix, :parent => Puppet::Provider::AixObject do
     expiry_date
   end
 
+  def open_security_passwd
+    # helper method for tests
+    File.open("/etc/security/passwd", 'r')
+  end
+
   #--------------------------------
   # Getter and Setter
   # When the provider is initialized, create getter/setter methods for each
@@ -229,15 +234,15 @@ Puppet::Type.type(:user).provide :aix, :parent => Puppet::Provider::AixObject do
   def password
     password = :absent
     user = @resource[:name]
-    f = File.open("/etc/security/passwd", 'r')
+    f = open_security_passwd
     # Skip to the user
     f.each_line { |l| break if l  =~ /^#{user}:\s*$/ }
     if ! f.eof?
       f.each_line { |l|
         # If there is a new user stanza, stop
         break if l  =~ /^\S*:\s*$/
-        # If the password= entry is found, return it
-        if l  =~ /^\s*password\s*=\s*(.*)$/
+        # If the password= entry is found, return it, stripping trailing space
+        if l  =~ /^\s*password\s*=\s*(\S*)\s*$/
           password = $1; break;
         end
       }

data/lib/puppet/transaction/report.rb

@@ -315,6 +315,10 @@ class Puppet::Transaction::Report
     instance_variables - [:@external_times]
   end
 
+  def self.supported_formats
+    [Puppet[:report_serialization_format].intern]
+  end
+
   private
 
   def calculate_change_metric

data/lib/puppet/type/mount.rb

@@ -1,3 +1,5 @@
+require 'puppet/property/boolean'
+
 module Puppet
   # We want the mount to refresh when it changes.
   newtype(:mount, :self_refresh => true) do
@@ -182,11 +184,18 @@ module Puppet
       }
     end
 
-    newproperty(:atboot) do
+    newproperty(:atboot, :parent => Puppet::Property::Boolean) do
       desc "Whether to mount the mount at boot.  Not all platforms
         support this."
 
-      newvalues :yes, :no
+      def munge(value)
+        munged = super
+        if munged
+          :yes
+        else
+          :no
+        end
+      end
     end
 
     newproperty(:dump) do

data/lib/puppet/version.rb

@@ -7,7 +7,7 @@
 
 
 module Puppet
-  PUPPETVERSION = '3.3.0-rc2'
+  PUPPETVERSION = '3.3.0-rc3'
 
   ##
   # version is a public API method intended to always provide a fast and

data/spec/unit/file_bucket/file_spec.rb

@@ -15,8 +15,18 @@ describe Puppet::FileBucket::File do
   let(:bucketdir) { Puppet[:bucketdir] = tmpdir('bucket') }
   let(:destdir) { File.join(bucketdir, "8/b/3/7/0/2/a/d/#{digest}") }
 
-  it "should have a to_s method to return the contents" do
-    Puppet::FileBucket::File.new(contents).to_s.should == contents
+  it "defines its supported format to be `:s`" do
+    expect(Puppet::FileBucket::File.supported_formats).to eq([:s])
+  end
+
+  it "serializes to `:s`" do
+    expect(Puppet::FileBucket::File.new(contents).to_s).to eq(contents)
+  end
+
+  it "deserializes from `:s`" do
+    file = Puppet::FileBucket::File.from_s(contents)
+
+    expect(file.contents).to eq(contents)
   end
 
   it "should raise an error if changing content" do
@@ -66,10 +76,16 @@ describe Puppet::FileBucket::File do
   end
 
   it "should convert the contents to PSON" do
-    Puppet::FileBucket::File.new("file contents").to_pson.should == '{"contents":"file contents"}'
+    # The model class no longer defines to_pson and it is not a supported
+    # format, but pson monkey patches Object#to_pson to return
+    # Object#to_s.to_pson, and it monkey patches String#to_pson to wrap the
+    # returned string in quotes. So it works in a way that is completely
+    # unexpected, and it doesn't round-trip correctly, awesome.
+    Puppet::FileBucket::File.new("file contents").to_pson.should == '"file contents"'
   end
 
   it "should load from PSON" do
+    Puppet.expects(:deprecation_warning).with('Deserializing Puppet::FileBucket::File objects from pson is deprecated. Upgrade to a newer version.')
     Puppet::FileBucket::File.from_pson({"contents"=>"file contents"}).contents.should == "file contents"
   end
 

data/spec/unit/indirector/file_bucket_file/file_spec.rb

@@ -28,6 +28,12 @@ describe Puppet::FileBucketFile::File do
     end
 
     describe "when servicing a save request" do
+      it "should return a result whose content is empty" do
+        bucket_file = Puppet::FileBucket::File.new('stuff')
+        result = Puppet::FileBucket::File.indirection.save(bucket_file, "md5/c13d88cb4cb02003daedb8a84e5d272a")
+        result.contents.should be_empty
+      end
+
       describe "when supplying a path" do
         it "should store the path if not already stored" do
           checksum = save_bucket_file("stuff\r\n", "/foo/bar")

data/spec/unit/network/format_handler_spec.rb

@@ -53,7 +53,7 @@ describe Puppet::Network::FormatHandler do
   describe "#most_suitable_format_for" do
     before :each do
       Puppet::Network::FormatHandler.create(:one, :extension => "foo", :mime => "text/one")
-      Puppet::Network::FormatHandler.create(:two, :extension => "bar", :mime => "text/two")
+      Puppet::Network::FormatHandler.create(:two, :extension => "bar", :mime => "application/two")
     end
 
     let(:format_one) { Puppet::Network::FormatHandler.format(:one) }
@@ -63,6 +63,10 @@ describe Puppet::Network::FormatHandler do
       Puppet::Network::FormatHandler.most_suitable_format_for(accepted, [:one, :two])
     end
 
+    it "finds either format when anything is accepted" do
+      [format_one, format_two].should include(suitable_in_setup_formats(["*/*"]))
+    end
+
     it "finds no format when none are acceptable" do
       suitable_in_setup_formats(["three"]).should be_nil
     end
@@ -79,6 +83,10 @@ describe Puppet::Network::FormatHandler do
       suitable_in_setup_formats(["text/one"]).should == format_one
     end
 
+    it "ignores quality specifiers" do
+      suitable_in_setup_formats(["two;q=0.8", "text/one;q=0.9"]).should == format_two
+    end
+
     it "allows specifying acceptable formats by canonical name" do
       suitable_in_setup_formats([:one]).should == format_one
     end

data/spec/unit/property/boolean_spec.rb

@@ -0,0 +1,24 @@
+require 'spec_helper'
+require 'puppet/property/boolean'
+
+describe Puppet::Property::Boolean do
+  let (:resource) { mock('resource') }
+  subject { described_class.new(:resource => resource) }
+
+  [ true, :true, 'true', :yes, 'yes', 'TrUe', 'yEs' ].each do |arg|
+    it "should munge #{arg.inspect} as true" do
+      subject.munge(arg).should == true
+    end
+  end
+  [ false, :false, 'false', :no, 'no', 'FaLSE', 'nO' ].each do |arg|
+    it "should munge #{arg.inspect} as false" do
+      subject.munge(arg).should == false
+    end
+  end
+  [ nil, :undef, 'undef', '0', 0, '1', 1, 9284 ].each do |arg|
+    it "should fail to munge #{arg.inspect}" do
+      expect { subject.munge(arg) }.to raise_error Puppet::Error
+    end
+  end
+end
+

data/spec/unit/provider/user/aix_spec.rb

@@ -128,4 +128,35 @@ guest id=100 pgrp=usr groups=usr home=/home/guest
       @provider.should_include?(:rlogin, managed_keys).should be_true
     end
   end
+  describe "when handling passwords" do
+    let(:passwd_without_spaces) do
+        # from http://pic.dhe.ibm.com/infocenter/aix/v7r1/index.jsp?topic=%2Fcom.ibm.aix.files%2Fdoc%2Faixfiles%2Fpasswd_security.htm
+        <<-OUTPUT
+smith:
+  password = MGURSj.F056Dj
+  lastupdate = 623078865
+  flags = ADMIN,NOCHECK
+        OUTPUT
+    end
+
+    let(:passwd_with_spaces) do
+        # add trailing space to the password
+        passwd_without_spaces.gsub(/password = (.*)/, 'password = \1   ')
+    end
+
+
+    it "should be able to read the hashed password" do
+      @provider.stubs(:open_security_passwd).returns(StringIO.new(passwd_without_spaces))
+      @resource.stubs(:[]).returns('smith')
+
+      @provider.password.should == 'MGURSj.F056Dj'
+    end
+
+    it "should be able to read the hashed password, even with trailing spaces" do
+      @provider.stubs(:open_security_passwd).returns(StringIO.new(passwd_with_spaces))
+      @resource.stubs(:[]).returns('smith')
+
+      @provider.password.should == 'MGURSj.F056Dj'
+    end
+  end
 end

data/spec/unit/transaction/report_spec.rb

@@ -375,20 +375,33 @@ describe Puppet::Transaction::Report do
     end
   end
 
+  it "defaults to serializing to pson" do
+    expect(Puppet::Transaction::Report.supported_formats).to eq([:pson])
+  end
+
   it "can make a round trip through pson" do
-    status = Puppet::Resource::Status.new(Puppet::Type.type(:notify).new(:title => "a resource"))
-    status.changed = true
+    Puppet[:report_serialization_format] = "pson"
+    report = generate_report
 
-    report = Puppet::Transaction::Report.new('testy', 1357986, 'test_environment', "df34516e-4050-402d-a166-05b03b940749")
-    report << Puppet::Util::Log.new(:level => :warning, :message => "log message")
-    report.add_times("timing", 4)
-    report.add_resource_status(status)
-    report.finalize_report
+    tripped = Puppet::Transaction::Report.convert_from(:pson, report.render)
+
+    expect_equivalent_reports(tripped, report)
+  end
 
-    tripped = Puppet::Transaction::Report.convert_from(:pson, report.render(:pson))
+  it "can make a round trip through yaml" do
+    Puppet[:report_serialization_format] = "yaml"
+    report = generate_report
+
+    yaml_output = report.render
+    tripped = Puppet::Transaction::Report.convert_from(:yaml, yaml_output)
+
+    yaml_output.should =~ /^--- /
+    expect_equivalent_reports(tripped, report)
+  end
 
+  def expect_equivalent_reports(tripped, report)
     tripped.host.should == report.host
-    tripped.time.should == report.time
+    tripped.time.to_i.should == report.time.to_i
     tripped.configuration_version.should == report.configuration_version
     tripped.transaction_uuid.should == report.transaction_uuid
     tripped.report_format.should == report.report_format
@@ -399,7 +412,7 @@ describe Puppet::Transaction::Report do
 
     logs_as_strings(tripped).should == logs_as_strings(report)
     metrics_as_hashes(tripped).should == metrics_as_hashes(report)
-    resource_statuses_as_hashes(tripped).should == resource_statuses_as_hashes(report)
+    expect_equivalent_resource_statuses(tripped.resource_statuses, report.resource_statuses)
   end
 
   def logs_as_strings(report)
@@ -412,9 +425,41 @@ describe Puppet::Transaction::Report do
     end.flatten]
   end
 
-  def resource_statuses_as_hashes(report)
-    Hash[*report.resource_statuses.collect do |name, s|
-      [name, PSON.parse(s.to_pson)]
-    end.flatten]
+  def expect_equivalent_resource_statuses(tripped, report)
+    tripped.keys.sort.should == report.keys.sort
+
+    tripped.each_pair do |name, status|
+      expected = report[name]
+
+      status.title.should == expected.title
+      status.file.should == expected.file
+      status.line.should == expected.line
+      status.resource.should == expected.resource
+      status.resource_type.should == expected.resource_type
+      status.containment_path.should == expected.containment_path
+      status.evaluation_time.should == expected.evaluation_time
+      status.tags.should == expected.tags
+      status.time.to_i.should == expected.time.to_i
+      status.failed.should == expected.failed
+      status.changed.should == expected.changed
+      status.out_of_sync.should == expected.out_of_sync
+      status.skipped.should == expected.skipped
+      status.change_count.should == expected.change_count
+      status.out_of_sync_count.should == expected.out_of_sync_count
+      status.events.should == expected.events
+    end
   end
+
+  def generate_report
+    status = Puppet::Resource::Status.new(Puppet::Type.type(:notify).new(:title => "a resource"))
+    status.changed = true
+
+    report = Puppet::Transaction::Report.new('testy', 1357986, 'test_environment', "df34516e-4050-402d-a166-05b03b940749")
+    report << Puppet::Util::Log.new(:level => :warning, :message => "log message")
+    report.add_times("timing", 4)
+    report.add_resource_status(status)
+    report.finalize_report
+    report
+  end
+
 end

data/spec/unit/type/mount_spec.rb

@@ -263,16 +263,32 @@ describe Puppet::Type.type(:mount), :unless => Puppet.features.microsoft_windows
     end
 
     describe "for atboot" do
-      it "should support yes as a value for atboot" do
-        expect { described_class.new(:name => "/foo", :ensure => :present, :atboot => :yes) }.to_not raise_error
+      it "does not allow non-boolean values" do
+        expect { described_class.new(:name => "/foo", :ensure => :present, :atboot => 'unknown') }.to raise_error Puppet::Error, /expected a boolean value/
       end
 
-      it "should support no as a value for atboot" do
-        expect { described_class.new(:name => "/foo", :ensure => :present, :atboot => :no) }.to_not raise_error
+      it "interprets yes as yes" do
+        resource = described_class.new(:name => "/foo", :ensure => :present, :atboot => :yes)
+
+        expect(resource[:atboot]).to eq(:yes)
+      end
+
+      it "interprets true as yes" do
+        resource = described_class.new(:name => "/foo", :ensure => :present, :atboot => :true)
+
+        expect(resource[:atboot]).to eq(:yes)
       end
 
-      it "should not support other values for atboot" do
-        expect { described_class.new(:name => "/foo", :ensure => :present, :atboot => :true) }.to raise_error Puppet::Error, /Invalid value/
+      it "interprets no as no" do
+        resource = described_class.new(:name => "/foo", :ensure => :present, :atboot => :no)
+
+        expect(resource[:atboot]).to eq(:no)
+      end
+
+      it "interprets false as no" do
+        resource = described_class.new(:name => "/foo", :ensure => :present, :atboot => false)
+
+        expect(resource[:atboot]).to eq(:no)
       end
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: puppet
 version: !ruby/object:Gem::Version
-  version: 3.3.0.rc2
+  version: 3.3.0.rc3
   prerelease: 6
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-08-29 00:00:00.000000000 Z
+date: 2013-09-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: facter
@@ -121,6 +121,7 @@ files:
 - lib/puppet/application/secret_agent.rb
 - lib/puppet/application/status.rb
 - lib/puppet/bindings.rb
+- lib/puppet/coercion.rb
 - lib/puppet/configurer.rb
 - lib/puppet/configurer/downloader.rb
 - lib/puppet/configurer/fact_handler.rb
@@ -576,6 +577,7 @@ files:
 - lib/puppet/pops/visitable.rb
 - lib/puppet/pops/visitor.rb
 - lib/puppet/property.rb
+- lib/puppet/property/boolean.rb
 - lib/puppet/property/ensure.rb
 - lib/puppet/property/keyvalue.rb
 - lib/puppet/property/list.rb
@@ -1860,6 +1862,7 @@ files:
 - spec/unit/pops/types/type_factory_spec.rb
 - spec/unit/pops/types/type_parser_spec.rb
 - spec/unit/pops/visitor_spec.rb
+- spec/unit/property/boolean_spec.rb
 - spec/unit/property/ensure_spec.rb
 - spec/unit/property/keyvalue_spec.rb
 - spec/unit/property/list_spec.rb
@@ -2838,6 +2841,7 @@ test_files:
 - spec/unit/pops/types/type_factory_spec.rb
 - spec/unit/pops/types/type_parser_spec.rb
 - spec/unit/pops/visitor_spec.rb
+- spec/unit/property/boolean_spec.rb
 - spec/unit/property/ensure_spec.rb
 - spec/unit/property/keyvalue_spec.rb
 - spec/unit/property/list_spec.rb