puppet 0.24.5 → 0.24.6

data/CHANGELOG

@@ -1,3 +1,207 @@
+0.24.6
+    Adding support to the user type for: profiles, auths, project, 
+    key/value pairs (extension to Solaris RBAC support added in
+    0.24.6)
+
+    Fixed #1662 - Configuration Reference still references 'section'
+
+    Fixed #1460 - enhance redhat puppetmaster init.d script to easy start puppetmaster as a mongrel cluster
+
+    Fixed #1663 - Regression relating to facter fact naming from 0.24.5
+
+    Fixed #1655 - Provider::Confine::Variable tests are broken
+
+    Fixed #1646 - service puppet status does not work as non-root 
+    on redhat system
+
+    Fixed #1649 - Updated OSX package cleanup
+  
+    Fixed #1647 - puppetdoc -r providers now working again
+
+    Fixed #1639 - uninitialized constant Puppet::Type::User::ProviderUseradd
+
+    Fixed #1637 - With an inexistant (global) templatedir, modules 
+    can't access their templates
+
+    Fixed #1202 - Collection attribute matching doesn't parse arrays
+
+    Fixed #1473 - Puppetd stops with error after puppetmasterd 
+    is unavailable
+
+    Fixed #1354 - yum provider problems with RHEL 3
+
+    Fixed #1633 - Added support for --detailed-exits to bin/puppet
+
+    Fixed #381 - Allow Allow multiple overrides in one statement
+
+    Fixing #947 - pluginsync no longer fails poorly when no plugins exist
+
+    Fixed #981 - Removed 'Adding aliases' info message
+    
+    Fixing #1089 - Log messages are now tagged with the log level,
+    making it easier to match messages in the 'tagmail' report.
+    
+    Fixing #1098 - Multiline strings now correctly increment the line count
+
+    Fixing #1614 - Environments no longer have to be listed out
+
+    Fixed #1628 - Changed node search to use certname rather than Facter 
+    hostname
+    
+    Fixed #1613 - The client environment will be substituted when looking 
+    up settings.
+
+    Updated puppet binary documentation 
+
+    Feature #1624 - Added RBAC roles to solaris user provider
+
+    Fixed #1586 - Specifying "fully qualified" package names in Gentoo
+
+    Fixed #1620 - Add 'sles' to Puppet confines when 'suse' is used
+
+    Fixed #1585 - Allow complex 'if' and variable expressions
+
+    Fixed #1564 - Saving File#checksum to state.yaml broken
+
+    Fixed #1603 - Added support for running Puppet inside a Rack application
+    (mod_rails) with Passenger and Apache
+
+    Fixed #1596 - Deploying file resources with ++ generates error
+
+    Modified the group and zone resource types to no longer call
+    'currentpropvalues' as a means of setting all values to absent.
+    There should be no behaviour change from this change.
+
+    Modified the behaviour of resource-level 'retrieve' -- it only
+    calls 'retrieve' on each property if the resource exists.
+
+    Fixed #1622 - Users and their groups should again add in one transaction
+
+    Fixed #791 - You should now be able to create and find a user/group in one transaction.
+
+    Fixed #1610 - Raise "Filebucketed" messages to Notice priority
+    
+    FIxed #1530 - ssh_authorized_keys provider does not crash anymore on SSH type 1 keys
+
+    Added a number of confines to package providers
+
+    Fixed #1609 - Added confines for the Gentoo, FreeBSD and 
+    SMF (Solaris) service providers 
+
+    Fixed #1608 - Added ubuntu to defaultfor for apt provider
+
+    Fixed #1607 - Added ubuntu to defaultfor for Debian service
+    provider
+
+    Fixed #1045 - Multiple metaparams all get added to resources.
+    
+    Fixed #1472 -- defined, exported resources in the current compile 
+    now get expanded correctly.
+
+    Fixed #1595 - Internally, Property#retrieve is no longer called
+    when no 'should' value is available for a resource.
+
+    Fixed #1588 - Fixed puppetca --clean --all 
+
+    Fixed #1584 - Added support for appended variables
+
+    Fixed #1554 - Added support for multiple template directories
+
+    Fixed #1500 - puppetrun not working
+
+    Fixed #1579 and #1580 - errors in the Puppet RPM spec file
+
+    Fixed #1572 -- file purging now fails if remote sources do not exist.
+    
+    Fixed #1521 -- ldap user and password are now used with the default connection.
+
+    Fixed issues with file descriptors leaking into subprocesses
+
+    Fixed #1568 - createpackage.sh
+
+    Fixed #1571 - Puppet::Util::binary returns incorrect results
+
+    Fixed #1553 - Puppet and Facter cannot both install the plist module into two different locations
+
+    Adjusted hpuxuseradd user provider to confine to HP-UX and fixed HP-UX user provider path regression
+
+    Fixed debug messages in package type - thanks to Todd Zullinger for this fix
+    
+    Fixed #1566 - changed password property of the user type
+
+    Fixed debug messages in package type
+
+    Updated Red Hat spec file
+
+    Fixes #1455 - Adds HP-UX support for user type
+
+    Fixes #1551 puppetmaster.freshness xmlrpc call returns incorrect type
+
+    Fixes #1554 - Fix exception for undefined hostname
+
+    Fixed #1533 - changed permissions for man directory
+
+    Added daemontools and runit providers for service type
+
+    Added simple rake task for running unit tests
+
+    Added spec Rake task
+
+    Fixed #1526 - Fixed leak in template
+
+    Fixed #1506 - Removed storeconfig duplicate indexes
+    
+    Fixed #1457 - case insensitive match for error
+    
+    Fixed #1488 - Moved individual functions out of functions.rb into 
+    lib/puppet/parser/functions directory.  New functions should be create     in this directory.
+
+    Fixed #1508 - Added HP-UX package provider
+
+    Fixed #1502 - Fixed poor stored configuration performance
+
+    Fixed #1510 - Storeconfiguration fixed for Rails 2.1
+
+    Add the -P/--ping option to puppetrun, fixes #1501
+
+    Fixed #1394 - Added stored configuration clearing script to /ext
+    
+    Fixed #1442 - replaced use of Facter for report titling with certname
+
+    Fixed $1456 - add proxy configuration capability to yum repo
+
+    Fixed #1457 - removed confine warning
+
+    A working script to create an OS X pkg out of the Puppet repository
+
+    Fixed #1441 - Updated console colours
+
+    Expose all puppet variables as instance member variables of the template wrapper.
+    This helps resolve redmine #1427, by providing a safe mechanism to access variables.
+    
+     * Implement Puppet::Parser::Scope#to_hash, which returns a hash containing all the
+       variable bindings in the current and, optionally, parent scope.
+     * Use that to set instance member variables into Puppet::Parser::Templatewrapper
+     * Report the time taken for variable binding at debug level, to help identify any
+       performance regression that is encountered in the real world.
+     * Rename the @scope and @file members of the template wrapper, to avoid clashing
+       with a scope variable exposed within puppet.
+
+    Ensure that we consistently use either string #{} interpolation or String.%
+    interpolation, not both, to avoid issues where a #{} interpolated value
+    contains a % character.
+
+    Feature #1476: Allow specification of --bindir --sbindir --sitelibdir --mandir --destdir 
+    in installation
+    
+    Added feature #1241 : Improve performance of group lookups
+
+    Fixed bug #1448: Puppet CA incorrectly writes out all certs to inventory .txt on each 
+    certificate signing
+
+    Fixing puppetlast to make it work with 0.24.5 / 0.25.  Made puppetlast work on 0.24.5 
+    by using the YAML indirector
+ 
 0.24.5
     You can now select the encoding format when transferring the catalog,
     with 'yaml' still being the default but 'marshal' being an option.
@@ -13,6 +217,8 @@
     The fix for #1431 is actually just removing the tests that exposed
     this change; the change happened when I refactored how confines work.
 
+    Removed faulty interface type
+
     Updated /spec/unit/rails.rb test
 
     Fix #1426 - services on redhat are restarted again and status is 

data/Rakefile

@@ -144,3 +144,56 @@ task :tracdocs do
         sh "puppetdoc -m trac -r #{ref.to_s}"
     end
 end
+
+desc "Run the specs under spec/"
+task :spec do
+    require 'spec'
+    require 'spec/rake/spectask'
+    require 'rcov'
+    Spec::Rake::SpecTask.new do |t|
+         #   t.rcov = true
+         t.spec_opts = ['--format','s', '--loadby','mtime']
+         t.spec_files = FileList['spec/**/*.rb']
+    end
+end
+
+desc "Run the unit tests"
+task :unit do
+    sh "cd test; rake"
+end
+
+desc "Send patch information to the puppet-dev list"
+task :mail_patches do
+    if Dir.glob("00*.patch").length > 0
+        raise "Patches already exist matching '00*.patch'; clean up first"
+    end
+
+    unless %x{git status} =~ /On branch (.+)/
+        raise "Could not get branch from 'git status'"
+    end
+    branch = $1
+    
+    unless branch =~ %r{^([^\/]+)/([^\/]+)/([^\/]+)$}
+        raise "Branch name does not follow <type>/<parent>/<name> model; cannot autodetect parent branch"
+    end
+
+    type, parent, name = $1, $2, $3
+
+    # Create all of the patches
+    sh "git-format-patch -C -M -s -n #{parent}..HEAD"
+
+    # And then mail them out.
+
+    # If we've got more than one patch, add --compose
+    if Dir.glob("00*.patch").length > 1
+        compose = "--compose"
+    else
+        compose = ""
+    end
+
+    # Now send the mail.
+    sh "git send-email #{compose} --no-chain-reply-to --no-signed-off-by-cc --suppress-from --no-thread --to puppet-dev@googlegroups.com 00*.patch"
+
+    # Finally, clean up the patches
+    sh "rm 00*.patch"
+end

data/bin/puppet

@@ -3,18 +3,18 @@
 #
 # = Synopsis
 #
-# Run a stand-alone +puppet+ script.
+# Run a stand-alone +puppet+ manifest.
 #
 # = Usage
 #
 #   puppet [-h|--help] [-V|--version] [-d|--debug] [-v|--verbose]
-#               [-l|--logdest <file>] <file>
+#               [--detailed-exitcodes] [-l|--logdest <file>] <file>
 #
 # = Description
 #
-# This is the standalone puppet execution script; use it to execute
-# individual scripts that you write.  If you need to execute site-wide
-# scripts, use +puppetd+ and +puppetmasterd+.
+# This is the standalone puppet execution tool; use it to execute
+# individual manifests that you write.  If you need to execute site-wide
+# manifests, use +puppetd+ and +puppetmasterd+.
 #
 # = Options
 #
@@ -31,6 +31,11 @@
 # debug::
 #   Enable full debugging.
 #
+# detailed-exitcodes::
+#   Provide transaction information via exit codes.  If this is enabled, an exit
+#   code of '2' means there were changes, and an exit code of '4' means that there
+#   were failures during the transaction.
+#
 # help::
 #   Print this help message
 #
@@ -48,7 +53,7 @@
 #
 # = Example
 #
-#   puppet -l /tmp/script.log script.pp
+#   puppet -l /tmp/manifest.log manifest.pp
 #
 # = Author
 #
@@ -72,6 +77,7 @@ options = [
     [ "--loadclasses", "-L",		GetoptLong::NO_ARGUMENT ],
     [ "--verbose",  "-v",			GetoptLong::NO_ARGUMENT ],
     [ "--use-nodes",    			GetoptLong::NO_ARGUMENT ],
+    [ "--detailed-exitcodes",		GetoptLong::NO_ARGUMENT ],
     [ "--version",  "-V",           GetoptLong::NO_ARGUMENT ]
 ]
 
@@ -87,7 +93,8 @@ options = {
     :logfile => false,
     :loadclasses => false,
     :logset => false,
-    :code => nil
+    :code => nil,
+    :detailed_exits => false,
 }
 
 
@@ -118,6 +125,8 @@ begin
                 options[:code] = arg
             when "--loadclasses"
                 options[:loadclasses] = true
+            when "--detailed-exitcodes"
+                options[:detailed_exits] = true
             when "--logdest"
                 begin
                     Puppet::Util::Log.newdestination(arg)
@@ -183,11 +192,12 @@ if Puppet[:parseonly]
 end
 
 # Collect our facts.
-facts = Puppet::Node::Facts.find("me")
-facts.name = facts.values["hostname"]
+facts = Puppet::Node::Facts.find(Puppet[:certname])
 
 # Find our Node
-node = Puppet::Node.find(facts.name)
+unless node = Puppet::Node.find(Puppet[:certname])
+    raise "Could not find node %s" % Puppet[:certname]
+end
 
 # Merge in the facts.
 node.merge(facts.values)
@@ -207,6 +217,7 @@ end
 
 begin
     # Compile our catalog
+    starttime = Time.now
     catalog = Puppet::Node::Catalog.find(node.name, :use_node => node)
 
     # Translate it to a RAL catalog
@@ -216,8 +227,18 @@ begin
 
     catalog.finalize
 
+    catalog.retrieval_duration = Time.now - starttime
+
     # And apply it
-    catalog.apply
+    transaction = catalog.apply
+
+    status = 0
+    if not Puppet[:noop] and options[:detailed_exits] then
+        transaction.generate_report
+    	status |= 2 if transaction.report.metrics["changes"][:total] > 0
+        status |= 4 if transaction.report.metrics["resources"][:failed] > 0
+    end
+    exit(status)
 rescue => detail
     if Puppet[:trace]
         puts detail.backtrace

data/bin/puppetca

@@ -225,6 +225,7 @@ when :clean
 
     if all
         certs = ca.list
+        certs |= ca.list_signed
             if certs.empty?
                 $stderr.puts "No certificates to clean"
                 exit(24)

data/bin/puppetrun

@@ -9,7 +9,7 @@
 #
 #   puppetrun [-a|--all] [-c|--class <class>] [-d|--debug] [-f|--foreground]
 #       [-h|--help] [--host <host>] [--no-fqdn] [--ignoreschedules]
-#       [-t|--tag <tag>] [--test]
+#       [-t|--tag <tag>] [--test] [-p|--ping]
 #
 # = Description
 #
@@ -108,6 +108,10 @@
 #   Print the hosts you would connect to but do not actually connect. This
 #   option requires LDAP support at this point.
 #
+# ping::
+#   
+#   Do a ICMP echo against the target host. Skip hosts that don't respond to ping.
+#
 # = Example
 #
 #   sudo puppetrun -p 10 --host host1 --host host2 -t remotefile -t webserver
@@ -154,6 +158,7 @@ flags = [
     [ "--help",		"-h",			GetoptLong::NO_ARGUMENT ],
     [ "--host",         			GetoptLong::REQUIRED_ARGUMENT ],
     [ "--parallel", "-p",			GetoptLong::REQUIRED_ARGUMENT ],
+    [ "--ping", "-P",			GetoptLong::NO_ARGUMENT ],
     [ "--no-fqdn",  "-n",			GetoptLong::NO_ARGUMENT ],
     [ "--test",                     GetoptLong::NO_ARGUMENT ],
     [ "--version",  "-V",           GetoptLong::NO_ARGUMENT ]
@@ -168,6 +173,7 @@ options = {
     :ignoreschedules => false,
     :foreground => false,
     :parallel => 1,
+    :ping => false,
     :debug => false,
     :test => false,
     :all => false,
@@ -215,6 +221,8 @@ begin
                     $stderr.puts "Could not convert %s to an integer" % arg.inspect
                     exit(23)
                 end
+            when "--ping"
+                 options[:ping] = true 
             when "--foreground"
                 options[:foreground] = true
             when "--debug"
@@ -237,7 +245,7 @@ end
 # Now parse the config
 Puppet.parse_config
 
-if Puppet[:node_terminus] = "ldap"
+if Puppet[:node_terminus] == "ldap" and (options[:all] or classes)
     if options[:all]
         hosts = Puppet::Node.search("whatever").collect { |node| node.name }
         puts "all: %s" % hosts.join(", ")
@@ -294,12 +302,12 @@ while go
     if children.length < options[:parallel] and ! todo.empty?
         host = todo.shift
         pid = fork do
-            # First make sure the client is up
-            out = %x{ping -c 1 #{host}}
-
-            unless $? == 0
-                $stderr.print "Could not contact %s\n" % host
-                next
+            if options[:ping]
+              out = %x{ping -c 1 #{host}}
+              unless $? == 0
+                  $stderr.print "Could not contact %s\n" % host
+                  next
+              end
             end
             client = Puppet::Network::Client.runner.new(
                 :Server => host,