puppet-lint 2.3.2 → 2.3.3

data/.gitignore

@@ -9,3 +9,4 @@ coverage/
 /_site/
 .idea
 /*.pp
+/tmp/

data/.rubocop.yml

@@ -62,7 +62,7 @@ Style/MethodCalledOnDoEndBlock:
 Style/RegexpLiteral:
     EnforcedStyle: percent_r
 Style/TrailingCommaInArguments:
-    EnforcedStyleForMultiline: comma
+    EnforcedStyleForMultiline: no_comma
 Style/TrailingCommaInLiteral:
     EnforcedStyleForMultiline: comma
 Style/FormatStringToken:

data/.travis.yml

@@ -9,8 +9,9 @@ bundler_args: --without development system_tests
 script:
     - bundle exec rake $CHECK
 env:
-    - CHECK=test
+    - CHECK=ci
 rvm:
+  - 1.8.7
   - 1.9.3
   - 2.0.0
   - 2.1.10

data/CHANGELOG.md

@@ -1,5 +1,22 @@
 # Change Log
 
+## [2.3.3](https://github.com/rodjek/puppet-lint/tree/2.3.3) (2017-09-28)
+[Full Changelog](https://github.com/rodjek/puppet-lint/compare/2.3.2...2.3.3)
+
+**Closed issues:**
+
+- 2.3.2 - Rakefile's ignore\_paths not respected [\#760](https://github.com/rodjek/puppet-lint/issues/760)
+- 2.3.1 - Puppet lint fails with 1.8.7-p371 and Puppet 3.8.0 [\#759](https://github.com/rodjek/puppet-lint/issues/759)
+- 2.3.1: puppet-lint does not show errors/warnings --error-level option. [\#756](https://github.com/rodjek/puppet-lint/issues/756)
+
+**Merged pull requests:**
+
+- Add some basic acceptance tests [\#764](https://github.com/rodjek/puppet-lint/pull/764) ([rodjek](https://github.com/rodjek))
+- Restore Ruby 1.8.7 support [\#763](https://github.com/rodjek/puppet-lint/pull/763) ([rodjek](https://github.com/rodjek))
+- Don't override ignore\_paths set in rake task with default value [\#762](https://github.com/rodjek/puppet-lint/pull/762) ([rodjek](https://github.com/rodjek))
+- Add spec for issue raised in \#754 \#756 [\#761](https://github.com/rodjek/puppet-lint/pull/761) ([rodjek](https://github.com/rodjek))
+- Fix setup of default log\_format in PuppetLink.configuration when it is empty. [\#757](https://github.com/rodjek/puppet-lint/pull/757) ([zekefast](https://github.com/zekefast))
+
 ## [2.3.2](https://github.com/rodjek/puppet-lint/tree/2.3.2) (2017-09-27)
 [Full Changelog](https://github.com/rodjek/puppet-lint/compare/2.3.1...2.3.2)
 

data/Rakefile

@@ -1,6 +1,7 @@
 require 'rake'
 require 'rspec/core/rake_task'
 require 'puppet-lint'
+require 'puppet-lint/tasks/release_test'
 
 task :default => :test
 
@@ -27,4 +28,6 @@ rescue LoadError
   $stderr.puts 'Rubocop is not available for this version of Ruby.'
 end
 
+task :ci => [:test, :release_test]
+
 # vim: syntax=ruby

data/appveyor.yml

@@ -26,4 +26,4 @@ before_test:
   - bundle -v
 
 test_script:
-  - bundle exec rake test
+  - bundle exec rake ci

data/lib/puppet-lint.rb

@@ -8,6 +8,7 @@ require 'puppet-lint/configuration'
 require 'puppet-lint/data'
 require 'puppet-lint/checks'
 require 'puppet-lint/bin'
+require 'puppet-lint/monkeypatches'
 
 class PuppetLint::NoCodeError < StandardError; end
 class PuppetLint::NoFix < StandardError; end
@@ -89,7 +90,7 @@ class PuppetLint
   #
   # Returns a format String to be used with String#%.
   def log_format
-    if configuration.log_format == ''
+    if configuration.log_format.nil? || configuration.log_format.empty?
       ## recreate previous old log format as far as thats possible.
       format = '%{KIND}: %{message} on line %{line}'
       format.prepend('%{path} - ') if configuration.with_filename

data/lib/puppet-lint/checks.rb

@@ -68,7 +68,7 @@ class PuppetLint::Checks
 
     @problems
   rescue => e
-    puts <<-END.gsub(%r{^ {6}}, '')
+    $stdout.puts <<-END.gsub(%r{^ {6}}, '')
       Whoops! It looks like puppet-lint has encountered an error that it doesn't
       know how to handle. Please open an issue at https://github.com/rodjek/puppet-lint
       and paste the following output into the issue description.
@@ -80,7 +80,7 @@ class PuppetLint::Checks
     END
 
     if File.readable?(fileinfo)
-      puts [
+      $stdout.puts [
         'file contents:',
         '```',
         File.read(fileinfo),
@@ -88,7 +88,7 @@ class PuppetLint::Checks
       ].join("\n")
     end
 
-    puts [
+    $stdout.puts [
       'error:',
       '```',
       "#{e.class}: #{e.message}",

data/lib/puppet-lint/configuration.rb

@@ -50,9 +50,9 @@ class PuppetLint
     #
     #   <option>=(value)
     def method_missing(method, *args, &_block)
-      super unless method.to_s =~ %r{^(?<option>\w+)=?$}
+      super unless method.to_s =~ %r{^(\w+)=?$}
 
-      option = Regexp.last_match(:option)
+      option = Regexp.last_match(1)
       add_option(option.to_s) if settings[option].nil?
       settings[option] = args[0] unless args.empty?
     end

data/lib/puppet-lint/lexer.rb

@@ -170,7 +170,7 @@ class PuppetLint
     # \v == vertical tab
     # \f == form feed
     # \p{Zs} == ASCII + Unicode non-linebreaking whitespace
-    WHITESPACE_RE = %r{[\t\v\f\p{Zs}]}
+    WHITESPACE_RE = RUBY_VERSION == '1.8.7' ? %r{[\t\v\f ]} : %r{[\t\v\f\p{Zs}]}
 
     # Internal: Access the internal token storage.
     #
@@ -266,7 +266,7 @@ class PuppetLint
           else
             heredoc_tag = heredoc_queue.shift
             heredoc_name = heredoc_tag[%r{\A"?(.+?)"?(:.+?)?(/.*)?\Z}, 1]
-            str_contents = StringScanner.new(code[i + length..-1]).scan_until(%r{\|?\s*-?\s*#{heredoc_name}})
+            str_contents = StringScanner.new(code[(i + length)..-1]).scan_until(%r{\|?\s*-?\s*#{heredoc_name}})
             interpolate_heredoc(str_contents, heredoc_tag)
             length += str_contents.size
           end
@@ -282,8 +282,8 @@ class PuppetLint
           unless heredoc_queue.empty?
             heredoc_tag = heredoc_queue.shift
             heredoc_name = heredoc_tag[%r{\A"?(.+?)"?(:.+?)?(/.*)?\Z}, 1]
-            str_contents = StringScanner.new(code[i + length..-1]).scan_until(%r{\|?\s*-?\s*#{heredoc_name}})
-            _ = code[0..i + length].split("\n")
+            str_contents = StringScanner.new(code[(i + length)..-1]).scan_until(%r{\|?\s*-?\s*#{heredoc_name}})
+            _ = code[0..(i + length)].split("\n")
             interpolate_heredoc(str_contents, heredoc_tag)
             length += str_contents.size
           end
@@ -557,8 +557,8 @@ class PuppetLint
 
       str = string.scan_until(regexp)
       begin
-        str =~ %r{\A(?<value>.*?)(?<terminator>[$]+|\|?\s*-?#{Regexp.escape(eos_text)})\Z}m
-        [Regexp.last_match(:value), Regexp.last_match(:terminator)]
+        str =~ %r{\A(.*?)([$]+|\|?\s*-?#{Regexp.escape(eos_text)})\Z}m
+        [Regexp.last_match(1), Regexp.last_match(2)]
       rescue
         [nil, nil]
       end

data/lib/puppet-lint/monkeypatches.rb

@@ -0,0 +1,51 @@
+begin
+  '%{test}' % { :test => 'replaced' } == 'replaced' # rubocop:disable Style/FormatString
+rescue
+  # monkeypatch String#% into Ruby 1.8.7
+  class String
+    Percent = instance_method('%') unless defined?(Percent)
+
+    def %(*a, &b)
+      a.flatten!
+
+      string = case a.last
+               when Hash
+                 expand(a.pop)
+               else
+                 self
+               end
+
+      if a.empty?
+        string
+      else
+        Percent.bind(string).call(a, &b)
+      end
+    end
+
+    def expand!(vars = {})
+      loop do
+        changed = false
+        vars.each do |var, value|
+          var = var.to_s
+          var.gsub!(%r{[^a-zA-Z0-9_]}, '')
+          changed = gsub!(%r{\%\{#{var}\}}, value.to_s)
+        end
+        break unless changed
+      end
+      self
+    end
+
+    def expand(opts = {})
+      dup.expand!(opts)
+    end
+  end
+end
+
+unless String.respond_to?(:prepend)
+  # monkeypatch String#prepend into Ruby 1.8.7
+  class String
+    def prepend(lead)
+      replace("#{lead}#{self}")
+    end
+  end
+end

data/lib/puppet-lint/optparser.rb

@@ -44,7 +44,7 @@ class PuppetLint::OptParser
       opts.on(
         '--error-level LEVEL',
         [:all, :warning, :error],
-        'The level of error to return (warning, error or all).',
+        'The level of error to return (warning, error or all).'
       ) do |el|
         PuppetLint.configuration.error_level = el
       end

data/lib/puppet-lint/plugins/check_classes/arrow_on_right_operand_line.rb

@@ -12,7 +12,7 @@ PuppetLint.new_check(:arrow_on_right_operand_line) do
         :message =>  'arrow should be on the right operand\'s line',
         :line    => token.line,
         :column  => token.column,
-        :token   => token,
+        :token   => token
       )
     end
   end

data/lib/puppet-lint/plugins/check_classes/autoloader_layout.rb

@@ -27,7 +27,7 @@ PuppetLint.new_check(:autoloader_layout) do
         :error,
         :message => "#{title_token.value} not in autoload module layout",
         :line    => title_token.line,
-        :column  => title_token.column,
+        :column  => title_token.column
       )
     end
   end

data/lib/puppet-lint/plugins/check_classes/class_inherits_from_params_class.rb

@@ -11,7 +11,7 @@ PuppetLint.new_check(:class_inherits_from_params_class) do
         :warning,
         :message => 'class inheriting from params class',
         :line    => class_idx[:inherited_token].line,
-        :column  => class_idx[:inherited_token].column,
+        :column  => class_idx[:inherited_token].column
       )
     end
   end

data/lib/puppet-lint/plugins/check_classes/code_on_top_scope.rb

@@ -13,7 +13,7 @@ PuppetLint.new_check(:code_on_top_scope) do
         :warning,
         :message => "code outside of class or define block - #{token.value}",
         :line    => token.line,
-        :column  => token.column,
+        :column  => token.column
       )
     end
   end

data/lib/puppet-lint/plugins/check_classes/inherits_across_namespaces.rb

@@ -16,7 +16,7 @@ PuppetLint.new_check(:inherits_across_namespaces) do
         :warning,
         :message => 'class inherits across module namespaces',
         :line    => class_idx[:inherited_token].line,
-        :column  => class_idx[:inherited_token].column,
+        :column  => class_idx[:inherited_token].column
       )
     end
   end

data/lib/puppet-lint/plugins/check_classes/names_containing_dash.rb

@@ -17,7 +17,7 @@ PuppetLint.new_check(:names_containing_dash) do
         :error,
         :message => "#{obj_type} name containing a dash",
         :line    => class_idx[:name_token].line,
-        :column  => class_idx[:name_token].column,
+        :column  => class_idx[:name_token].column
       )
     end
   end

data/lib/puppet-lint/plugins/check_classes/names_containing_uppercase.rb

@@ -18,7 +18,7 @@ PuppetLint.new_check(:names_containing_uppercase) do
         :message => "#{obj_type} '#{class_idx[:name_token].value}' contains illegal uppercase",
         :line    => class_idx[:name_token].line,
         :column  => class_idx[:name_token].column,
-        :token   => class_idx[:name_token],
+        :token   => class_idx[:name_token]
       )
     end
   end

data/lib/puppet-lint/plugins/check_classes/nested_classes_or_defines.rb

@@ -19,7 +19,7 @@ PuppetLint.new_check(:nested_classes_or_defines) do
           :warning,
           :message => "#{type} defined inside a class",
           :line    => token.line,
-          :column  => token.column,
+          :column  => token.column
         )
       end
     end

data/lib/puppet-lint/plugins/check_classes/parameter_order.rb

@@ -32,7 +32,7 @@ PuppetLint.new_check(:parameter_order) do
           :warning,
           :message => msg,
           :line    => token.line,
-          :column  => token.column,
+          :column  => token.column
         )
       end
     end

data/lib/puppet-lint/plugins/check_classes/right_to_left_relationship.rb

@@ -9,7 +9,7 @@ PuppetLint.new_check(:right_to_left_relationship) do
         :warning,
         :message =>  'right-to-left (<-) relationship',
         :line    => token.line,
-        :column  => token.column,
+        :column  => token.column
       )
     end
   end

data/lib/puppet-lint/plugins/check_classes/variable_scope.rb

@@ -132,7 +132,7 @@ PuppetLint.new_check(:variable_scope) do
           :warning,
           :message => msg,
           :line    => token.line,
-          :column  => token.column,
+          :column  => token.column
         )
       end
     end

data/lib/puppet-lint/plugins/check_comments/slash_comments.rb

@@ -12,7 +12,7 @@ PuppetLint.new_check(:slash_comments) do
         :message => '// comment found',
         :line    => token.line,
         :column  => token.column,
-        :token   => token,
+        :token   => token
       )
     end
   end

data/lib/puppet-lint/plugins/check_comments/star_comments.rb

@@ -12,7 +12,7 @@ PuppetLint.new_check(:star_comments) do
         :message => '/* */ comment found',
         :line    => token.line,
         :column  => token.column,
-        :token   => token,
+        :token   => token
       )
     end
   end

data/lib/puppet-lint/plugins/check_conditionals/case_without_default.rb

@@ -37,7 +37,7 @@ PuppetLint.new_check(:case_without_default) do
         :warning,
         :message => 'case statement without a default case',
         :line    => case_tokens.first.line,
-        :column  => case_tokens.first.column,
+        :column  => case_tokens.first.column
       )
     end
   end

data/lib/puppet-lint/plugins/check_conditionals/selector_inside_resource.rb

@@ -14,7 +14,7 @@ PuppetLint.new_check(:selector_inside_resource) do
           :warning,
           :message => 'selector inside resource block',
           :line    => token.line,
-          :column  => token.column,
+          :column  => token.column
         )
       end
     end

data/lib/puppet-lint/plugins/check_documentation/documentation.rb

@@ -24,7 +24,7 @@ PuppetLint.new_check(:documentation) do
         :warning,
         :message => "#{type} not documented",
         :line    => first_token.line,
-        :column  => first_token.column,
+        :column  => first_token.column
       )
     end
   end

data/lib/puppet-lint/plugins/check_nodes/unquoted_node_name.rb

@@ -14,7 +14,7 @@ PuppetLint.new_check(:unquoted_node_name) do
           :check    => :syntax,
           :message  => 'Syntax error (try running `puppet parser validate <file>`)',
           :line     => node.line,
-          :column   => node.column,
+          :column   => node.column
         )
         next
       end
@@ -29,7 +29,7 @@ PuppetLint.new_check(:unquoted_node_name) do
           :message => 'unquoted node name found',
           :line    => token.line,
           :column  => token.column,
-          :token   => token,
+          :token   => token
         )
       end
     end

data/lib/puppet-lint/plugins/check_resources/duplicate_params.rb

@@ -26,7 +26,7 @@ PuppetLint.new_check(:duplicate_params) do
               :error,
               :message => 'duplicate parameter found in resource',
               :line    => prev_token.line,
-              :column  => prev_token.column,
+              :column  => prev_token.column
             )
           else
             seen_params[level] << prev_token.value

data/lib/puppet-lint/plugins/check_resources/ensure_first_param.rb

@@ -20,7 +20,7 @@ PuppetLint.new_check(:ensure_first_param) do
         :message  => "ensure found on line but it's not the first attribute",
         :line     => ensure_token.line,
         :column   => ensure_token.column,
-        :resource => resource,
+        :resource => resource
       )
     end
   end

data/lib/puppet-lint/plugins/check_resources/ensure_not_symlink_target.rb

@@ -20,7 +20,7 @@ PuppetLint.new_check(:ensure_not_symlink_target) do
           :line        => value_token.line,
           :column      => value_token.column,
           :param_token => ensure_token,
-          :value_token => value_token,
+          :value_token => value_token
         )
       end
     end

data/lib/puppet-lint/plugins/check_resources/file_mode.rb

@@ -26,7 +26,7 @@ PuppetLint.new_check(:file_mode) do
           :message => MSG,
           :line    => value_token.line,
           :column  => value_token.column,
-          :token   => value_token,
+          :token   => value_token
         )
       end
     end

data/lib/puppet-lint/plugins/check_resources/unquoted_file_mode.rb

@@ -20,7 +20,7 @@ PuppetLint.new_check(:unquoted_file_mode) do
           :message => 'unquoted file mode',
           :line    => value_token.line,
           :column  => value_token.column,
-          :token   => value_token,
+          :token   => value_token
         )
       end
     end

data/lib/puppet-lint/plugins/check_resources/unquoted_resource_title.rb

@@ -12,7 +12,7 @@ PuppetLint.new_check(:unquoted_resource_title) do
         :message => 'unquoted resource title',
         :line    => token.line,
         :column  => token.column,
-        :token   => token,
+        :token   => token
       )
     end
   end

data/lib/puppet-lint/plugins/check_strings/double_quoted_strings.rb

@@ -16,7 +16,7 @@ PuppetLint.new_check(:double_quoted_strings) do
         :message => 'double quoted string containing no variables',
         :line    => token.line,
         :column  => token.column,
-        :token   => token,
+        :token   => token
       )
     end
   end

data/lib/puppet-lint/plugins/check_strings/only_variable_string.rb

@@ -30,7 +30,7 @@ PuppetLint.new_check(:only_variable_string) do
               :column      => var_token.column,
               :start_token => start_token,
               :var_token   => var_token,
-              :end_token   => eos_token,
+              :end_token   => eos_token
             )
           end
           break

data/lib/puppet-lint/plugins/check_strings/puppet_url_without_modules.rb

@@ -15,7 +15,7 @@ PuppetLint.new_check(:puppet_url_without_modules) do
         :message => 'puppet:// URL without modules/ found',
         :line    => token.line,
         :column  => token.column,
-        :token   => token,
+        :token   => token
       )
     end
   end

data/lib/puppet-lint/plugins/check_strings/quoted_booleans.rb

@@ -16,7 +16,7 @@ PuppetLint.new_check(:quoted_booleans) do
         :message => 'quoted boolean value found',
         :line    => token.line,
         :column  => token.column,
-        :token   => token,
+        :token   => token
       )
     end
   end

data/lib/puppet-lint/plugins/check_strings/single_quote_string_with_variables.rb

@@ -11,7 +11,7 @@ PuppetLint.new_check(:single_quote_string_with_variables) do
         :error,
         :message => 'single quoted string containing a variable found',
         :line    => token.line,
-        :column  => token.column,
+        :column  => token.column
       )
     end
   end

data/lib/puppet-lint/plugins/check_strings/variables_not_enclosed.rb

@@ -13,7 +13,7 @@ PuppetLint.new_check(:variables_not_enclosed) do
         :message => 'variable not enclosed in {}',
         :line    => token.line,
         :column  => token.column,
-        :token   => token,
+        :token   => token
       )
     end
   end

data/lib/puppet-lint/plugins/check_variables/variable_contains_dash.rb

@@ -15,7 +15,7 @@ PuppetLint.new_check(:variable_contains_dash) do
         :warning,
         :message => 'variable contains a dash',
         :line    => token.line,
-        :column  => token.column,
+        :column  => token.column
       )
     end
   end

data/lib/puppet-lint/plugins/check_variables/variable_is_lowercase.rb

@@ -15,7 +15,7 @@ PuppetLint.new_check(:variable_is_lowercase) do
         :warning,
         :message => 'variable contains an uppercase letter',
         :line    => token.line,
-        :column  => token.column,
+        :column  => token.column
       )
     end
   end

data/lib/puppet-lint/plugins/check_whitespace/140chars.rb

@@ -14,7 +14,7 @@ PuppetLint.new_check(:'140chars') do
         :warning,
         :message => 'line has more than 140 characters',
         :line    => idx + 1,
-        :column  => 140,
+        :column  => 140
       )
     end
   end

data/lib/puppet-lint/plugins/check_whitespace/2sp_soft_tabs.rb

@@ -13,7 +13,7 @@ PuppetLint.new_check(:'2sp_soft_tabs') do
         :error,
         :message => 'two-space soft tabs not used',
         :line    => token.line,
-        :column  => token.column,
+        :column  => token.column
       )
     end
   end

data/lib/puppet-lint/plugins/check_whitespace/80chars.rb

@@ -13,7 +13,7 @@ PuppetLint.new_check(:'80chars') do
         :warning,
         :message => 'line has more than 80 characters',
         :line    => idx + 1,
-        :column  => 80,
+        :column  => 80
       )
     end
   end

data/lib/puppet-lint/plugins/check_whitespace/arrow_alignment.rb

@@ -73,7 +73,7 @@ PuppetLint.new_check(:arrow_alignment) do
                 :token          => arrow_tok,
                 :arrow_column   => arrow_column[level_idx],
                 :newline        => arrows_on_line.index(arrow_tok) != 0,
-                :newline_indent => param_column[level_idx] - 1,
+                :newline_indent => param_column[level_idx] - 1
               )
             end
           end

data/lib/puppet-lint/plugins/check_whitespace/hard_tabs.rb

@@ -14,7 +14,7 @@ PuppetLint.new_check(:hard_tabs) do
         :message => 'tab character found',
         :line    => token.line,
         :column  => token.column,
-        :token   => token,
+        :token   => token
       )
     end
   end

data/lib/puppet-lint/plugins/check_whitespace/trailing_whitespace.rb

@@ -14,7 +14,7 @@ PuppetLint.new_check(:trailing_whitespace) do
         :message => 'trailing whitespace found',
         :line    => token.line,
         :column  => token.column,
-        :token   => token,
+        :token   => token
       )
     end
   end

data/lib/puppet-lint/tasks/puppet-lint.rb

@@ -65,7 +65,7 @@ class PuppetLint
         end
 
         if PuppetLint.configuration.ignore_paths
-          @ignore_paths = PuppetLint.configuration.ignore_paths
+          @ignore_paths ||= PuppetLint.configuration.ignore_paths
         end
 
         if PuppetLint.configuration.pattern

data/lib/puppet-lint/tasks/release_test.rb

@@ -0,0 +1,84 @@
+require 'rake'
+require 'open3'
+require 'English'
+
+def run_cmd(message, *cmd)
+  print("  #{message}... ")
+
+  if Open3.respond_to?(:capture2e)
+    output, status = Open3.capture2e(*cmd)
+  else
+    output = ''
+
+    Open3.popen3(*cmd) do |stdin, stdout, stderr|
+      stdin.close
+      output += stdout.read
+      output += stderr.read
+    end
+    status = $CHILD_STATUS.dup
+  end
+
+  if status.success?
+    puts 'Done'
+  else
+    puts 'FAILED'
+  end
+
+  [output.strip, status.success?]
+end
+
+task :release_test do
+  branch = if ENV['APPVEYOR']
+             ENV['APPVEYOR_PULL_REQUEST_HEAD_REPO_BRANCH']
+           elsif ENV['TRAVIS']
+             ENV['TRAVIS_PULL_REQUEST_BRANCH']
+           else
+             false
+           end
+
+  if branch && branch !~ %r{\A\d+_\d+_\d+_release\Z}
+    puts 'Skipping release tests on feature branch'
+    exit
+  end
+
+  modules_to_test = [
+    'puppetlabs/puppetlabs-apt',
+    'puppetlabs/puppetlabs-tomcat',
+    'puppetlabs/puppetlabs-apache',
+    'puppetlabs/puppetlabs-mysql',
+    'puppetlabs/puppetlabs-ntp',
+    'puppetlabs/puppetlabs-chocolatey',
+    'voxpupuli/puppet-archive',
+    'voxpupuli/puppet-collectd',
+    'garethr/garethr-docker',
+    'sensu/sensu-puppet',
+    'jenkinsci/puppet-jenkins',
+  ]
+
+  FileUtils.mkdir_p('tmp')
+  Dir.chdir('tmp') do
+    modules_to_test.each do |module_name|
+      puts "Testing #{module_name}..."
+      module_dir = File.basename(module_name)
+
+      if File.directory?(module_dir)
+        Dir.chdir(module_dir) do
+          _, success = run_cmd('Updating repository', 'git', 'pull', '--rebase')
+          next unless success
+        end
+      else
+        _, success = run_cmd('Cloning repository', 'git', 'clone', "https://github.com/#{module_name}")
+        next unless success
+      end
+
+      Dir.chdir(module_dir) do
+        output, success = run_cmd('Running puppet-lint', 'bundle', 'exec', 'puppet-lint', '--relative', '--no-documentation-check', 'manifests')
+        unless output.empty?
+          output.split("\n").each do |line|
+            puts "    #{line}"
+          end
+        end
+      end
+    end
+  end
+end

data/lib/puppet-lint/version.rb

@@ -1,3 +1,3 @@
 class PuppetLint
-  VERSION = '2.3.2'.freeze
+  VERSION = '2.3.3'.freeze
 end

data/spec/puppet-lint/bin_spec.rb

@@ -69,7 +69,7 @@ describe PuppetLint::Bin do
         [
           "#{args[0]} - WARNING: optional parameter listed before required parameter on line 2",
           "#{args[1]} - ERROR: test::foo not in autoload module layout on line 2",
-        ].join("\n"),
+        ].join("\n")
       )
     end
   end
@@ -165,7 +165,7 @@ describe PuppetLint::Bin do
           '',
           "  define test::warning($foo='bar', $baz) { }",
           '                                   ^',
-        ].join("\n"),
+        ].join("\n")
       )
     end
   end
@@ -397,7 +397,7 @@ describe PuppetLint::Bin do
         [
           'IGNORED: double quoted string containing no variables on line 3',
           '  for a good reason',
-        ].join("\n"),
+        ].join("\n")
       )
     end
   end

data/spec/puppet-lint/checks_spec.rb

@@ -40,7 +40,7 @@ describe PuppetLint::Checks do
             :column   => 2,
             :path     => anything,
             :fullpath => anything,
-            :filename => anything,
+            :filename => anything
           )
         end
       end
@@ -62,7 +62,7 @@ describe PuppetLint::Checks do
             :column   => 2,
             :path     => anything,
             :fullpath => anything,
-            :filename => anything,
+            :filename => anything
           )
         end
       end
@@ -111,7 +111,7 @@ describe PuppetLint::Checks do
           instance_double(
             PuppetLint::CheckPlugin,
             :run          => [{ :kind => :error, :check => :arrow_alignment }],
-            :fix_problems => [{ :kind => :fixed, :check => :arrow_alignment }],
+            :fix_problems => [{ :kind => :fixed, :check => :arrow_alignment }]
           )
         end
         let(:mock_hard_tabs) do
@@ -203,7 +203,7 @@ describe PuppetLint::Checks do
     end
 
     it 'checks the configuration for each check to see if it is enabled' do
-      expect(enabled_checks.sort).to eq(expected_enabled_checks.sort)
+      expect(enabled_checks.map(&:to_s).sort).to eq(expected_enabled_checks.map(&:to_s).sort)
     end
   end
 

data/spec/puppet-lint/configuration_spec.rb

@@ -31,7 +31,7 @@ describe PuppetLint::Configuration do
     expect(subject.foobarbaz).to be_nil
   end
 
-  it 'should create options on the fly' do
+  it 'should be able to explicitly add options' do
     subject.add_option('bar')
 
     expect(subject.bar).to be_nil
@@ -40,6 +40,14 @@ describe PuppetLint::Configuration do
     expect(subject.bar).to eq('aoeui')
   end
 
+  it 'should be able to add options on the fly' do
+    expect(subject.test_option).to eq(nil)
+
+    subject.test_option = 'test'
+
+    expect(subject.test_option).to eq('test')
+  end
+
   it 'should be able to set sane defaults' do
     subject.defaults
 
@@ -52,7 +60,7 @@ describe PuppetLint::Configuration do
       'fix'              => false,
       'show_ignored'     => false,
       'json'             => false,
-      'ignore_paths'     => ['vendor/**/*.pp'],
+      'ignore_paths'     => ['vendor/**/*.pp']
     )
   end
 end

data/spec/puppet-lint/lexer_spec.rb

@@ -1525,7 +1525,7 @@ END
       expect(token.value).to eq("\t")
     end
 
-    it 'should parse unicode spaces' do
+    it 'should parse unicode spaces', :unless => RUBY_VERSION == '1.8.7' do
       token = @lexer.tokenise("\xc2\xa0").first
       expect(token.type).to eq(:WHITESPACE)
       expect(token.value).to eq("\xc2\xa0")

data/spec/spec_helper.rb

@@ -131,7 +131,7 @@ RSpec.configure do |config|
   config.include(
     RSpec::LintExampleGroup,
     :type      => :lint,
-    :file_path => Regexp.compile(%w[spec puppet-lint plugins].join('[\\\/]')),
+    :file_path => Regexp.compile(%w[spec puppet-lint plugins].join('[\\\/]'))
   )
 
   config.expect_with(:rspec) do |c|

metadata

@@ -1,29 +1,40 @@
---- !ruby/object:Gem::Specification
+--- !ruby/object:Gem::Specification 
 name: puppet-lint
-version: !ruby/object:Gem::Version
-  version: 2.3.2
+version: !ruby/object:Gem::Version 
+  hash: 5
+  prerelease: 
+  segments: 
+  - 2
+  - 3
+  - 3
+  version: 2.3.3
 platform: ruby
-authors:
+authors: 
 - Tim Sharpe
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-09-27 00:00:00.000000000 Z
+
+date: 2017-09-28 00:00:00 +10:00
+default_executable: 
 dependencies: []
+
 description: |-
   Checks your Puppet manifests against the Puppetlabs
     style guide and alerts you to any discrepancies.
 email: tim@sharpe.id.au
-executables:
+executables: 
 - puppet-lint
 extensions: []
+
 extra_rdoc_files: []
-files:
-- ".gitignore"
-- ".rspec"
-- ".rubocop.yml"
-- ".rubocop_todo.yml"
-- ".travis.yml"
+
+files: 
+- .gitignore
+- .rspec
+- .rubocop.yml
+- .rubocop_todo.yml
+- .travis.yml
 - CHANGELOG.md
 - Gemfile
 - LICENSE
@@ -39,6 +50,7 @@ files:
 - lib/puppet-lint/data.rb
 - lib/puppet-lint/lexer.rb
 - lib/puppet-lint/lexer/token.rb
+- lib/puppet-lint/monkeypatches.rb
 - lib/puppet-lint/optparser.rb
 - lib/puppet-lint/plugins.rb
 - lib/puppet-lint/plugins/check_classes/arrow_on_right_operand_line.rb
@@ -79,6 +91,7 @@ files:
 - lib/puppet-lint/plugins/check_whitespace/hard_tabs.rb
 - lib/puppet-lint/plugins/check_whitespace/trailing_whitespace.rb
 - lib/puppet-lint/tasks/puppet-lint.rb
+- lib/puppet-lint/tasks/release_test.rb
 - lib/puppet-lint/version.rb
 - puppet-lint.gemspec
 - spec/fixtures/test/manifests/fail.pp
@@ -138,84 +151,39 @@ files:
 - spec/puppet-lint/plugins/check_whitespace/trailing_whitespace_spec.rb
 - spec/puppet-lint_spec.rb
 - spec/spec_helper.rb
+has_rdoc: true
 homepage: https://github.com/rodjek/puppet-lint/
 licenses: []
-metadata: {}
+
 post_install_message: 
 rdoc_options: []
-require_paths:
+
+require_paths: 
 - lib
-required_ruby_version: !ruby/object:Gem::Requirement
-  requirements:
+required_ruby_version: !ruby/object:Gem::Requirement 
+  none: false
+  requirements: 
   - - ">="
-    - !ruby/object:Gem::Version
-      version: '0'
-required_rubygems_version: !ruby/object:Gem::Requirement
-  requirements:
+    - !ruby/object:Gem::Version 
+      hash: 3
+      segments: 
+      - 0
+      version: "0"
+required_rubygems_version: !ruby/object:Gem::Requirement 
+  none: false
+  requirements: 
   - - ">="
-    - !ruby/object:Gem::Version
-      version: '0'
+    - !ruby/object:Gem::Version 
+      hash: 3
+      segments: 
+      - 0
+      version: "0"
 requirements: []
+
 rubyforge_project: 
-rubygems_version: 2.6.10
+rubygems_version: 1.6.2
 signing_key: 
-specification_version: 4
+specification_version: 3
 summary: Ensure your Puppet manifests conform with the Puppetlabs style guide
-test_files:
-- spec/fixtures/test/manifests/fail.pp
-- spec/fixtures/test/manifests/ignore.pp
-- spec/fixtures/test/manifests/ignore_multiple_block.pp
-- spec/fixtures/test/manifests/ignore_multiple_line.pp
-- spec/fixtures/test/manifests/ignore_reason.pp
-- spec/fixtures/test/manifests/init.pp
-- spec/fixtures/test/manifests/malformed.pp
-- spec/fixtures/test/manifests/mismatched_control_comment.pp
-- spec/fixtures/test/manifests/unterminated_control_comment.pp
-- spec/fixtures/test/manifests/url_interpolation.pp
-- spec/fixtures/test/manifests/warning.pp
-- spec/puppet-lint/bin_spec.rb
-- spec/puppet-lint/checks_spec.rb
-- spec/puppet-lint/configuration_spec.rb
-- spec/puppet-lint/data_spec.rb
-- spec/puppet-lint/ignore_overrides_spec.rb
-- spec/puppet-lint/lexer/token_spec.rb
-- spec/puppet-lint/lexer_spec.rb
-- spec/puppet-lint/plugins/check_classes/arrow_on_right_operand_line_spec.rb
-- spec/puppet-lint/plugins/check_classes/autoloader_layout_spec.rb
-- spec/puppet-lint/plugins/check_classes/class_inherits_from_params_class_spec.rb
-- spec/puppet-lint/plugins/check_classes/code_on_top_scope_spec.rb
-- spec/puppet-lint/plugins/check_classes/inherits_across_namespaces_spec.rb
-- spec/puppet-lint/plugins/check_classes/name_contains_uppercase_spec.rb
-- spec/puppet-lint/plugins/check_classes/names_containing_dash_spec.rb
-- spec/puppet-lint/plugins/check_classes/nested_classes_or_defines_spec.rb
-- spec/puppet-lint/plugins/check_classes/parameter_order_spec.rb
-- spec/puppet-lint/plugins/check_classes/right_to_left_relationship_spec.rb
-- spec/puppet-lint/plugins/check_classes/variable_scope_spec.rb
-- spec/puppet-lint/plugins/check_comments/slash_comments_spec.rb
-- spec/puppet-lint/plugins/check_comments/star_comments_spec.rb
-- spec/puppet-lint/plugins/check_conditionals/case_without_default_spec.rb
-- spec/puppet-lint/plugins/check_conditionals/selector_inside_resource_spec.rb
-- spec/puppet-lint/plugins/check_documentation/documentation_spec.rb
-- spec/puppet-lint/plugins/check_nodes/unquoted_node_name_spec.rb
-- spec/puppet-lint/plugins/check_resources/duplicate_params_spec.rb
-- spec/puppet-lint/plugins/check_resources/ensure_first_param_spec.rb
-- spec/puppet-lint/plugins/check_resources/ensure_not_symlink_target_spec.rb
-- spec/puppet-lint/plugins/check_resources/file_mode_spec.rb
-- spec/puppet-lint/plugins/check_resources/unquoted_file_mode_spec.rb
-- spec/puppet-lint/plugins/check_resources/unquoted_resource_title_spec.rb
-- spec/puppet-lint/plugins/check_strings/double_quoted_strings_spec.rb
-- spec/puppet-lint/plugins/check_strings/only_variable_string_spec.rb
-- spec/puppet-lint/plugins/check_strings/puppet_url_without_modules_spec.rb
-- spec/puppet-lint/plugins/check_strings/quoted_booleans_spec.rb
-- spec/puppet-lint/plugins/check_strings/single_quote_string_with_variables_spec.rb
-- spec/puppet-lint/plugins/check_strings/variables_not_enclosed_spec.rb
-- spec/puppet-lint/plugins/check_variables/variable_contains_dash_spec.rb
-- spec/puppet-lint/plugins/check_variables/variable_is_lowercase_spec.rb
-- spec/puppet-lint/plugins/check_whitespace/140chars_spec.rb
-- spec/puppet-lint/plugins/check_whitespace/2sp_soft_tabs_spec.rb
-- spec/puppet-lint/plugins/check_whitespace/80chars_spec.rb
-- spec/puppet-lint/plugins/check_whitespace/arrow_alignment_spec.rb
-- spec/puppet-lint/plugins/check_whitespace/hard_tabs_spec.rb
-- spec/puppet-lint/plugins/check_whitespace/trailing_whitespace_spec.rb
-- spec/puppet-lint_spec.rb
-- spec/spec_helper.rb
+test_files: []
+

checksums.yaml

@@ -1,7 +0,0 @@
----
-SHA1:
-  metadata.gz: fbb487b62428cd625a1cf3d397b31caae02add69
-  data.tar.gz: 07c43049840cb8f2fbb145582eb2bc2b8ef2080a
-SHA512:
-  metadata.gz: 7e15459e1239a53a0bacd8f02bce2d762a19e30801778dce52359e0fdc19ece26f1a0557bfd656ec87fcaf0fc9e1ff1e3c0d9648e1a9713f43509f05ae18e9c7
-  data.tar.gz: da721067ae63f5a41452ef969fe5871c16edc155ff89e602860afe200a5df5fc52013a8d5150a2916791a7302c87742857e23bc2f0f2af6c4fe90d457ea1b4e6