puppet-lint-wmf_styleguide-check 1.1.1 → 1.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 899c8c3526bd03b42700fe80c845fc590fc60876ef10410e1216fcab6e4ac7e5
-  data.tar.gz: 4ed16c3cff59cfa2c72b6dca1af26210daca111ff92e984c999087acd5c44b62
+  metadata.gz: '0996980289ea98e58b4da21e94d46732a5fec1cda561ddcd979ec647c91db633'
+  data.tar.gz: d8b5d617cb4ba1f1765670171cf157b723d73428410b8f1e564d8f160f20a046
 SHA512:
-  metadata.gz: b550d1bf27ecffec3b069cf131367232a0b65dc8da3c6296054aa6d1c634b655bd291cece4bf6c71fbb4a2e41939f6455c86a8a594e36d1fe486178f24eec3b8
-  data.tar.gz: d0641b8fd0fe54e5430a1fab4f5e0b40d24d97243ceed0d8195d9faeaa2c57700b91597af050c962b959aed2c0fba6edb4600badc66286d91440df31a57e9110
+  metadata.gz: c8056b429179de7156ecdb3ccb09bad40c9c4ae0c487a2177ca8073b204e4de935da30ac993b3c94ebf896f0140f9bee36707cf045cfeb5e3617c34142debeb2
+  data.tar.gz: 96531a80875d9aa641a8a34ac3a541ab1ad75c0b4fb37228324c6312e2ba736749e3532de77bb6d8412ea5b3c5d973977f69f09a83d2ec10310d9cd3f028f9b4

data/lib/puppet-lint/plugins/check_wmf_styleguide.rb

@@ -280,7 +280,6 @@ end
 
 def lookup_not_in_params(klass)
   # Checks if a lookup call is not in a parameter declaration. Used to check profiles
-
   # Any lookup call that is not inside a parameter declaration is a violation
   tokens = klass.lookup_calls.reject do |token|
     maybe_param = token.prev_code_token.prev_code_token
@@ -498,7 +497,9 @@ PuppetLint.new_check(:wmf_styleguide) do
           msg = {
             message: "wmf-style: regex node matching must match the whole string (^...$), got: #{token.value}",
             line: token.line,
-            column: token.column
+            column: token.column,
+            token: token,
+            problem: 'node_regex'
           }
           notify :error, msg
         end
@@ -547,4 +548,15 @@ PuppetLint.new_check(:wmf_styleguide) do
       check_node node
     end
   end
+
+  def fix_node_regex(problem)
+    problem[:token].value.insert(0, '^') unless problem[:token].value.start_with?('^')
+    problem[:token].value << '$' unless problem[:token].value.end_with?('$')
+  end
+
+  def fix(problem)
+    raise PuppetLint::NoFix unless problem[:problem] == 'node_regex'
+    method = "fix_#{problem[:problem]}"
+    send(method, problem) if respond_to? method
+  end
 end

data/spec/puppet-lint/plugins/check_wmf_styleguide_check_spec.rb

@@ -124,6 +124,12 @@ node /test1.*\\.example\\.com/ {
 }
 EOF
 
+node_regex_fixed = <<-EOF
+node /^test1.*\\.example\\.com$/ {
+     role(spare::system)
+}
+EOF
+
 deprecation_ko = <<-EOF
 define test() {
    base::service_unit{ 'test2': }
@@ -283,4 +289,27 @@ describe 'wmf_styleguide' do
       expect(problems).to contain_error("wmf-style: 'test' should not include the deprecated define 'base::service_unit'")
     end
   end
+
+  context 'with fix enabled' do
+    before do
+      PuppetLint.configuration.fix = true
+    end
+
+    after do
+      PuppetLint.configuration.fix = false
+    end
+
+    context 'node regex with start violation' do
+      let(:code) { node_regex_missing_start }
+      it { expect(manifest).to eq(node_regex_fixed) }
+    end
+    context 'node regex with end violation' do
+      let(:code) { node_regex_missing_end }
+      it { expect(manifest).to eq(node_regex_fixed) }
+    end
+    context 'node regex with start and end violations' do
+      let(:code) { node_regex_missing_both }
+      it { expect(manifest).to eq(node_regex_fixed) }
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: puppet-lint-wmf_styleguide-check
 version: !ruby/object:Gem::Version
-  version: 1.1.1
+  version: 1.1.2
 platform: ruby
 authors:
 - Giuseppe Lavagetto
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-03-13 00:00:00.000000000 Z
+date: 2023-08-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: puppet-lint
@@ -168,5 +168,5 @@ signing_key:
 specification_version: 4
 summary: A puppet-lint plugin to check code adheres to the WMF coding guidelines
 test_files:
-- spec/puppet-lint/plugins/check_wmf_styleguide_check_spec.rb
 - spec/spec_helper.rb
+- spec/puppet-lint/plugins/check_wmf_styleguide_check_spec.rb