puppet-lint-variable_contains_upcase 1.4.0 → 2.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fa3be1ddcdaaf7ce120b5fec3d514a852f564ebb944af0fd06d86e59c2ad089b
-  data.tar.gz: 69ca8e2ac14b1ff274f3d726dc47186cf0fd962be083d29d7a9f68a47c2a18a5
+  metadata.gz: 53f83cc785ebbf6c955776bca8ed589bbf4125ec5863de41bfba6a79791a03a9
+  data.tar.gz: d516ef68f776c3321f2cd756100390e96915f5d22167f1513fe613b6d235033a
 SHA512:
-  metadata.gz: 70f8082c662cc879ad9612ba0a53206d99ddf9ac7c0da8cde607e24f58c424905aa5dcfdb177e96e947e656435c120557be845bdb98af26966ac2db03c3b66ee
-  data.tar.gz: b05501872468a4b0cd5320263b264e7680e975ddb781a6c65674c6c3352d1861d52e97af7aada89c67be250aba29fc496f29bedc8a1237b26d6e10bfd846fdfd
+  metadata.gz: 7abcd5a41b439ac9baa565b14bead8edd7be0663b7ae4a85384e866f2259d2b120d1be415c2ec3900bbf0972f32f2650c36dfe55e8a82171b80ef753f2fcf7b9
+  data.tar.gz: 3f9e5d48e21a05df17d3d94266cadc64f9cf4fe9a8db47ee4f9b4beb22486b576324701cc67cced2a714d2760c9196d7686cc6eca8c82e966d18b6cceae5a25c

data/README.md

@@ -1,6 +1,29 @@
 # Puppet lint check for upcase variables
 
-[![Build Status](https://travis-ci.org/fiddyspence/puppetlint-variablecase.png?branch=master)](https://travis-ci.org/fiddyspence/puppetlint-variablecase)
+[![License](https://img.shields.io/github/license/voxpupuli/puppet-lint-variable_contains_upcase.svg)](https://github.com/voxpupuli/puppet-lint-variable_contains_upcase/blob/master/LICENSE)
+[![Test](https://github.com/voxpupuli/puppet-lint-variable_contains_upcase/actions/workflows/test.yml/badge.svg)](https://github.com/voxpupuli/puppet-lint-variable_contains_upcase/actions/workflows/test.yml)
+[![Release](https://github.com/voxpupuli/puppet-lint-variable_contains_upcase/actions/workflows/release.yml/badge.svg)](https://github.com/voxpupuli/puppet-lint-variable_contains_upcase/actions/workflows/release.yml)
+[![RubyGem Version](https://img.shields.io/gem/v/puppet-lint-variable_contains_upcase.svg)](https://rubygems.org/gems/puppet-lint-variable_contains_upcase)
+[![RubyGem Downloads](https://img.shields.io/gem/dt/puppet-lint-variable_contains_upcase.svg)](https://rubygems.org/gems/puppet-lint-variable_contains_upcase)
+[![Donated by Chris Spence](https://img.shields.io/badge/donated%20by-Chris%%20Spence-fb7047.svg)](#transfer-notice)
 
 The future parser disallows mixed case variables, so this check implements
 warnings for them
+
+## Transfer Notice
+
+This plugin was originally authored by [Chris Spence](https://github.com/fiddyspence).
+The maintainer preferred that [Vox Pupuli](https://voxpupuli.org/) take ownership of the module for future improvement and maintenance.
+
+## License
+
+This gem is licensed under the MIT license.
+
+## Release information
+
+To make a new release, please do:
+* Update the version in the `puppet-lint-variable_contains_upcase.gemspec` file
+* Install gems with `bundle install --with release --path .vendor`
+* generate the changelog with `bundle exec rake changelog`
+* Create a PR with it
+* After it got merged, push a tag. A github workflow will do the actual release

data/lib/puppet-lint/plugins/variable_contains_upcase.rb

@@ -1,18 +1,19 @@
 PuppetLint.new_check(:variable_contains_upcase) do
   def check
-    tokens.select { |r|
+    tokens.select do |r|
       Set[:VARIABLE, :UNENC_VARIABLE].include? r.type
-    }.each do |token|
-      if token.value.gsub(/\[.+?\]/, '').match(/[A-Z]/)
-        notify :warning, {
-          :message => 'variable contains a capital letter',
-          :line    => token.line,
-          :column  => token.column,
-          :token   => token,
-        }
-      end
+    end.each do |token|
+      next unless /[A-Z]/.match?(token.value.gsub(/\[.+?\]/, ''))
+
+      notify :warning, {
+        message: 'variable contains a capital letter',
+        line: token.line,
+        column: token.column,
+        token: token,
+      }
     end
   end
+
   def fix(problem)
     problem[:token].value.downcase!
   end

data/spec/puppet-lint/plugins/variable_contains_upcase_spec.rb

@@ -6,11 +6,11 @@ describe 'variable_contains_upcase' do
   context 'a variable containing a capital' do
     let(:code) { '$fOobar' }
 
-    it 'should only detect a single problem' do
+    it 'onlies detect a single problem' do
       expect(problems).to have(1).problem
     end
 
-    it 'should create a warning' do
+    it 'creates a warning' do
       expect(problems).to contain_warning(msg).on_line(1).in_column(1)
     end
   end
@@ -18,11 +18,11 @@ describe 'variable_contains_upcase' do
   context 'variable containing a capital' do
     let(:code) { '" $fOobar"' }
 
-    it 'should only detect a single problem' do
+    it 'onlies detect a single problem' do
       expect(problems).to have(1).problem
     end
 
-    it 'should create a warning' do
+    it 'creates a warning' do
       expect(problems).to contain_warning(msg).on_line(1).in_column(3)
     end
   end
@@ -39,15 +39,15 @@ describe 'variable_contains_upcase' do
     context 'fix variable containing a capital' do
       let(:code) { '" $fOobar"' }
 
-      it 'should only detect a single problem' do
+      it 'onlies detect a single problem' do
         expect(problems).to have(1).problem
       end
 
-      it 'should fix the manifest' do
+      it 'fixes the manifest' do
         expect(problems).to contain_fixed(msg).on_line(1).in_column(3)
       end
 
-      it 'should downcase the variable name' do
+      it 'downcases the variable name' do
         expect(manifest).to eq('" $foobar"')
       end
     end
@@ -55,21 +55,23 @@ describe 'variable_contains_upcase' do
     context 'a hash with an upcase key should not fail' do
       let(:code) { ' $myhash["Foo"]' }
 
-      it 'should not detect a single problem' do
+      it 'does not detect a single problem' do
         expect(problems).to have(0).problem
       end
     end
+
     context 'a hash with an upcase key should not fail' do
       let(:code) { ' $myhash["Foo"]["bAr"]' }
 
-      it 'should not detect a single problem' do
+      it 'does not detect a single problem' do
         expect(problems).to have(0).problem
       end
     end
+
     context 'a hash variable with an upcase key should fail' do
       let(:code) { ' $myHash["foo"]["bar"]' }
 
-      it 'should detect a single problem' do
+      it 'detects a single problem' do
         expect(problems).to have(1).problem
       end
     end

data/spec/spec_helper.rb

@@ -1,3 +1,29 @@
+# frozen_string_literal: true
+
+begin
+  require 'simplecov'
+  require 'simplecov-console'
+  require 'codecov'
+rescue LoadError
+else
+  SimpleCov.start do
+    track_files 'lib/**/*.rb'
+
+    add_filter '/spec'
+
+    enable_coverage :branch
+
+    # do not track vendored files
+    add_filter '/vendor'
+    add_filter '/.vendor'
+  end
+
+  SimpleCov.formatters = [
+    SimpleCov::Formatter::Console,
+    SimpleCov::Formatter::Codecov,
+  ]
+end
+
 require 'puppet-lint'
 
 PuppetLint::Plugins.load_spec_helper

metadata

@@ -1,10 +1,11 @@
 --- !ruby/object:Gem::Specification
 name: puppet-lint-variable_contains_upcase
 version: !ruby/object:Gem::Version
-  version: 1.4.0
+  version: 2.0.0
 platform: ruby
 authors:
 - Chris Spence
+- Vox Pupuli
 autorequire: 
 bindir: bin
 cert_chain: []
@@ -16,7 +17,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: '3'
     - - "<"
       - !ruby/object:Gem::Version
         version: '5'
@@ -26,83 +27,13 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: '3'
     - - "<"
       - !ruby/object:Gem::Version
         version: '5'
-- !ruby/object:Gem::Dependency
-  name: rspec
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.0'
-- !ruby/object:Gem::Dependency
-  name: rspec-its
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.0'
-- !ruby/object:Gem::Dependency
-  name: rspec-collection_matchers
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.0'
-- !ruby/object:Gem::Dependency
-  name: rake
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: rspec-json_expectations
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 description: "    Extends puppet-lint to ensure that your variables are all lower
   case\n"
-email: chris@spence.org.uk
+email: voxpupuli@groups.io
 executables: []
 extensions: []
 extra_rdoc_files: []
@@ -124,17 +55,15 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 2.7.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.2
+rubygems_version: 3.2.33
 signing_key: 
 specification_version: 4
 summary: puppet-lint variable_case check
-test_files:
-- spec/spec_helper.rb
-- spec/puppet-lint/plugins/variable_contains_upcase_spec.rb
+test_files: []