puppet-lint-variable_contains_upcase 1.0.2 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 39554932c521c1f42fc75d6da016a85386221eea
-  data.tar.gz: 4bcff0bd60853ecc26115cd4ac57c00bf0b907a5
+  metadata.gz: c47187b5699ffc368d42cd63ca37cbc4cc7c8d7c
+  data.tar.gz: 4895198bfe98f7b40a88961220916b9dcb14eb7a
 SHA512:
-  metadata.gz: bb55819703cce72b77b63ee168b30d0dfcfe3459dd0dce86d54db538cffba0cf78c37d011bf7e4924de77f438c6c3206bc0954420deafc4bf19b958c7db22d9e
-  data.tar.gz: 3b962fdd599a186590602dc200c169a66068c7ee322a4904825a10fe49d722f08aab8f079efd00716b67a758e8115e2a190086afbb563d353acdbc292a7df483
+  metadata.gz: a74bb8eed94f347455b6fda32eb76fb9346e32f415c386db4f68c87c2abf0c838d3338cce3635932196b8d8bbb8137af73c86fe0e3c9d3e66095fde0e193dba2
+  data.tar.gz: dd3d9997e01d2cf51cb99883c4b3ab2b2bf3c1590cbbcc86fd3c48b1dd531fa5b3e8079696a93a42fc45316b84d88d90b19fe4a86f0f364704a562fcee0440be

data/lib/puppet-lint/plugins/variable_contains_upcase.rb

@@ -8,8 +8,12 @@ PuppetLint.new_check(:variable_contains_upcase) do
           :message => 'variable contains a capital letter',
           :line    => token.line,
           :column  => token.column,
+          :token   => token,
         }
       end
     end
   end
+  def fix(problem)
+    problem[:token].value.downcase
+  end
 end

data/spec/puppet-lint/plugins/variable_contains_upcase_spec.rb

@@ -26,4 +26,31 @@ describe 'variable_contains_upcase' do
       expect(problems).to contain_warning(msg).on_line(1).in_column(3)
     end
   end
+
+  context 'with fix enabled' do
+    before do
+      PuppetLint.configuration.fix = true
+    end
+
+    after do
+      PuppetLint.configuration.fix = false
+    end
+
+    context 'fix variable containing a capital' do
+      let(:code) { '" $fOobar"' }
+
+      it 'should only detect a single problem' do
+        expect(problems).to have(1).problem
+      end
+
+      it 'should fix the manifest' do
+        expect(problems).to contain_fixed(msg).on_line(1).in_column(3)
+      end
+
+      it 'should downcase the variable name' do
+        expect(manifest).to eq('" $foobar"')
+      end
+    end
+
+  end
 end

metadata

@@ -1,89 +1,103 @@
 --- !ruby/object:Gem::Specification
 name: puppet-lint-variable_contains_upcase
 version: !ruby/object:Gem::Version
-  version: 1.0.2
+  version: 1.1.0
 platform: ruby
 authors:
 - Chris Spence
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-08-24 00:00:00.000000000 Z
+date: 2017-01-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: puppet-lint
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '1.0'
-    - - "<"
+    - - <
       - !ruby/object:Gem::Version
         version: '3.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '1.0'
-    - - "<"
+    - - <
       - !ruby/object:Gem::Version
         version: '3.0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '3.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '3.0'
 - !ruby/object:Gem::Dependency
   name: rspec-its
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '1.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '1.0'
 - !ruby/object:Gem::Dependency
   name: rspec-collection_matchers
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '1.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '1.0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rspec-json_expectations
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 description: |2
@@ -93,8 +107,8 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- LICENSE
 - README.md
+- LICENSE
 - lib/puppet-lint/plugins/variable_contains_upcase.rb
 - spec/puppet-lint/plugins/variable_contains_upcase_spec.rb
 - spec/spec_helper.rb
@@ -108,17 +122,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.3
+rubygems_version: 2.0.14.1
 signing_key: 
 specification_version: 4
 summary: puppet-lint variable_case check