puppet-lint-unquoted_string-check 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 40bb27f1ef50991d0fbdf1d76f5e4d5071e3c720
-  data.tar.gz: f7ed70c0b3c8e374ba3f42018a2ce43d40606348
+  metadata.gz: 1ea22a3b0a227e64b12ee46c8b12f9337c01f4ac
+  data.tar.gz: 69ec7bce2e2a708ec184fb28ad98ddc2db8eb9d7
 SHA512:
-  metadata.gz: e2266dcab6a9cfc29b5e9e9b09514106ba8fd52ed7b250b008395de1bb596f3eea96f7a5c90e618d79b161ae68963c2e8bc13e652791e370c0b07a7fe3d8978c
-  data.tar.gz: dcbb50f022a8c71a1e093d3cd25c4b39c4f92b5e1d288c1bc1ffeaa9693fd7a8007ec9fec2ac5be4637550d86052eb8ef4ee970db3fd3ab4779c474aad1c4256
+  metadata.gz: 3168c4df9279fbfe9e30257cbaf8f1c8ba4749cef7382efd26ebaf41c80c4a93c8144fc69e9afb7ff915a34b6d98057c54118145afe64f00d57b31c4f02174b6
+  data.tar.gz: cb8efc59e01b978ccd5032918e9b702dc2b8004f979d86bd4b99751b4414965e29c29aceedb81b153cfddf6df503a4b7d5017c32e12cdc24a8ec060ae0f08db9

data/lib/puppet-lint/plugins/check_unquoted_string_in_case.rb

@@ -26,7 +26,7 @@ PuppetLint.new_check(:unquoted_string_in_case) do
     case_indexes.each do |kase|
       case_tokens = tokens[kase[:start]..kase[:end]]
 
-      if case_tokens.index { |r| r.type == :NAME || r.type == :CLASSREF }
+      if case_tokens.index { |r| r.next_token.type == :COLON && (r.type == :NAME || r.type == :CLASSREF) }
         notify :warning, {
           :message => 'expected quoted string in case',
           :line    => case_tokens.first.line,

data/spec/puppet-lint/plugins/check_unquoted_string_in_case/check_unquoted_string_in_case_spec.rb

@@ -26,6 +26,53 @@ describe 'unquoted_string_in_case' do
       end
     end
 
+    context 'quoted case containing :NAME' do
+      let(:code) do
+        <<-EOS
+        case $osfamily {
+          'Solaris': {
+            include ::foo
+          }
+          /(Darwin|FreeBSD)/: {
+            include bar
+          }
+          default: {
+            $rootgroup = 'root'
+          }
+        }
+        EOS
+      end
+
+      it 'should not detect any problems' do
+        expect(problems).to have(0).problems
+      end
+    end
+
+    context 'quoted case containing :CLASSREF' do
+      let(:code) do
+        <<-EOS
+        case $osfamily {
+          'Solaris': {
+            Foo {
+              bar => 'baz',
+            }
+          }
+          /(Darwin|FreeBSD)/: {
+            $rootgroup = 'wheel'
+            include bar
+          }
+          default: {
+            $rootgroup = 'root'
+          }
+        }
+        EOS
+      end
+
+      it 'should not detect any problems' do
+        expect(problems).to have(0).problems
+      end
+    end
+
     context ':NAME in case' do
       let(:code) do
         <<-EOS

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: puppet-lint-unquoted_string-check
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - Mickaël Canévet