puppet-lint-topscope-variable-check 1.2.0 → 2.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8168088835aca0348f181b125582456955c20cb0dee175dd62f72ba1df6607bc
-  data.tar.gz: 646719472eedfae47ad5ad0a3cd5d3f57bc5bf6ef3e7f8f0f6a845f27052ed95
+  metadata.gz: bba7e72103955d229936058c4d9e8243a35ea6282e519f0cdf667586584b55b8
+  data.tar.gz: 43eed19d3b88fd0480b5e720969cdc67377deb45f3007607fdad90acec3333ca
 SHA512:
-  metadata.gz: e0585fb8efa9c97dade2f2a3ee3d725d1ccb0c59e220a105420b19100b33c73631b0de286e084b06c79d015ac3faa768044f243c54f4a5500821350a522d8d00
-  data.tar.gz: 23f37b88e4b10d51b8b05702e87081d554e048546193e9e633edc31a1a0350671ff3d01472702e8d7440c197cf2a9d0f63880440cb2b9c993a9827ac2d277392
+  metadata.gz: c733eeba2facfaab46f1538cc909c539b6af2cb1563c7b0cd8596bf4587e115284767834b55cfdb23b2604e8ae542b7ccda55d2c5470d1450cfe0000e5797f3a
+  data.tar.gz: b27d7fedd03fedd7f0a20a25c9d638edefc93fc702930bfe8c9222b9adb66771c4bbf0c7f597ff4e0d73d2011ca62c82cb008aba107d5bdea2295b91a9758b53

data/lib/puppet-lint/plugins/topscope_variable.rb

@@ -5,14 +5,15 @@ PuppetLint.new_check(:topscope_variable) do
     return if class_list.first.nil?
 
     tokens.select { |x| x.type == :VARIABLE }.each do |token|
-      next if token.value !~ /^::[a-z0-9_][a-zA-Z0-9_]+::/
+      next unless /^::[a-z0-9_][a-zA-Z0-9_]+::/.match?(token.value)
+
       fixed = token.value.sub(/^::/, '')
       notify(
         :warning,
         message: "use $#{fixed} instead of $#{token.value}",
         line: token.line,
         column: token.column,
-        token: token
+        token: token,
       )
     end
   end

data/spec/puppet-lint/plugins/topscope_variable_spec.rb

@@ -2,6 +2,7 @@ require 'spec_helper'
 
 describe 'topscope_variable' do
   let(:msg) { 'use $foo::bar instead of $::foo::bar' }
+
   context 'with fix disabled' do
     context 'with correct topscope' do
       let(:code) do
@@ -14,7 +15,7 @@ describe 'topscope_variable' do
         PUP
       end
 
-      it 'should not detect any problems' do
+      it 'does not detect any problems' do
         expect(problems).to have(0).problem
       end
     end
@@ -30,7 +31,7 @@ describe 'topscope_variable' do
         PUP
       end
 
-      it 'should detect one problem' do
+      it 'detects one problem' do
         expect(problems).to have(1).problem
       end
     end
@@ -46,7 +47,7 @@ describe 'topscope_variable' do
         PUP
       end
 
-      it 'should detect one problem' do
+      it 'detects one problem' do
         expect(problems).to have(1).problem
       end
     end
@@ -62,7 +63,7 @@ describe 'topscope_variable' do
         PUP
       end
 
-      it 'should not detect any problems' do
+      it 'does not detect any problems' do
         expect(problems).to have(0).problem
       end
     end
@@ -78,7 +79,7 @@ describe 'topscope_variable' do
         PUP
       end
 
-      it 'should detect one problem' do
+      it 'detects one problem' do
         expect(problems).to have(1).problem
       end
     end
@@ -94,7 +95,7 @@ describe 'topscope_variable' do
         PUP
       end
 
-      it 'should not detect any problems' do
+      it 'does not detect any problems' do
         expect(problems).to have(0).problem
       end
     end
@@ -110,7 +111,7 @@ describe 'topscope_variable' do
         PUP
       end
 
-      it 'should not detect any problems' do
+      it 'does not detect any problems' do
         expect(problems).to have(0).problem
       end
     end
@@ -136,7 +137,7 @@ describe 'topscope_variable' do
         PUP
       end
 
-      it 'should not detect any problems' do
+      it 'does not detect any problems' do
         expect(problems).to have(0).problem
       end
     end
@@ -152,15 +153,15 @@ describe 'topscope_variable' do
         PUP
       end
 
-      it 'should detect one problem' do
+      it 'detects one problem' do
         expect(problems).to have(1).problem
       end
 
-      it 'should fix the problem' do
+      it 'fixes the problem' do
         expect(problems).to contain_fixed(msg).on_line(3).in_column(16)
       end
 
-      it 'should remove :: after the $' do
+      it 'removes :: after the $' do
         expect(manifest).to eq <<~PUP
           class foo::blub {
             notify { 'foo':
@@ -182,15 +183,15 @@ describe 'topscope_variable' do
         PUP
       end
 
-      it 'should detect one problem' do
+      it 'detects one problem' do
         expect(problems).to have(1).problem
       end
 
-      it 'should fix the problem' do
+      it 'fixes the problem' do
         expect(problems).to contain_fixed('use $some_component_module::bar instead of $::some_component_module::bar').on_line(3).in_column(16)
       end
 
-      it 'should remove :: after the $' do
+      it 'removes :: after the $' do
         expect(manifest).to eq <<~PUP
           class profile::foo {
             notify { 'foo':
@@ -212,15 +213,15 @@ describe 'topscope_variable' do
         PUP
       end
 
-      it 'should detect one problem' do
+      it 'detects one problem' do
         expect(problems).to have(1).problem
       end
 
-      it 'should fix the problem' do
+      it 'fixes the problem' do
         expect(problems).to contain_fixed(msg).on_line(3).in_column(20)
       end
 
-      it 'should remove :: after the $' do
+      it 'removes :: after the $' do
         expect(manifest).to eq <<~PUP
           class foo::blub {
             notify { 'foo':
@@ -238,7 +239,8 @@ describe 'topscope_variable' do
         include ::foo
       PUP
     end
-    it 'should not detect any problems' do
+
+    it 'does not detect any problems' do
       expect(problems).to have(0).problem
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: puppet-lint-topscope-variable-check
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 2.0.0
 platform: ruby
 authors:
 - Vox Pupuli
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-02-24 00:00:00.000000000 Z
+date: 2023-04-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: puppet-lint
@@ -16,96 +16,20 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '3'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '4'
+        version: '5'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '3'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '4'
-- !ruby/object:Gem::Dependency
-  name: rake
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '12.0'
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '14'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '12.0'
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '14'
-- !ruby/object:Gem::Dependency
-  name: rspec
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.0'
-- !ruby/object:Gem::Dependency
-  name: rspec-collection_matchers
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.0'
-- !ruby/object:Gem::Dependency
-  name: rspec-its
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.0'
-- !ruby/object:Gem::Dependency
-  name: simplecov
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
+        version: '5'
 description: "    A puppet-lint plugin to check that topscope variable names don't
   start with ::.\n"
 email: voxpupuli@groups.io
@@ -130,7 +54,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 2.7.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
@@ -141,6 +65,4 @@ rubygems_version: 3.2.33
 signing_key: 
 specification_version: 4
 summary: A puppet-lint plugin to check topscope variables.
-test_files:
-- spec/puppet-lint/plugins/topscope_variable_spec.rb
-- spec/spec_helper.rb
+test_files: []