puppet-lint-resource_reference_syntax 1.0.4 → 1.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 968682a225e6084c2004bde43dfb6c9ea5c738fb
-  data.tar.gz: c996f8d7c54b06799e5c24b2b8518f035098e1d5
+  metadata.gz: 7535ed7a11c71f153bf11d5dfd35a06bef5044e0
+  data.tar.gz: ca972b966ba85a130de583157c35a2cdcfaa34b6
 SHA512:
-  metadata.gz: 2a165376ff9f202412f4a163f0b094e8c3dee55637cfded25abc8f140f83dfa5e01ca1c13eea651df41efb5f06420ba45796152897508c3c5a66918691004d84
-  data.tar.gz: 1fdcc56b72dfd1e71462c6422e950032412a50eb14bb7348f042f3b6d23653895c7da2882e59bd91f14875d2dd2e3abfdea61396001853a0c9c69a0a03c7625f
+  metadata.gz: 5d24d371e282aab9727bd12d89f3799ab03b6693538d616670ad1b5d15245b612aeb7372ede3bbf2d7a9ba935a58d43f550f1ea87970e0c0bf20d39630239703
+  data.tar.gz: 2c622e331ef8cb8a0b3c3a5c03d84b9724a6f05dfe86fad30b3b6a85bd289f19d9b84eea264a6b7ebf0c43d196ef21803bbeb9017e6805f6b373c98105f9ca7b

data/.rspec

@@ -0,0 +1,3 @@
+--format
+documentation
+--colour

data/README.md

@@ -23,6 +23,13 @@ This plugin provides two new checks to `puppet-lint`.
 This check will raise an error for any resource reference that has a whitespace
 between the Type reference and the opening bracket.
 
+e.g. the following code is NOT good for Puppet 4:
+
+```
+  require => File ['/etc/motd']
+```
+and will result in the following error:
+
 ```
 ERROR: whitespce between reference type and title on line 4
 ```
@@ -33,7 +40,22 @@ ERROR: whitespce between reference type and title on line 4
 
 This check will raise an error for any resource reference that uses the title with capital letter without enclosed quotes.
 
+e.g. the following code will not work on Puppet 4:
+```
+  require => Service[Apache],
+  require => Service[Apache, Mysql],
+  require => Service[apache]
+```
+and will result in the following error:
 ```
 ERROR: resource reference with title with capital letter on line 4
 ```
 
+The following references are good code for Puppet 4:
+
+```
+  require => Service['apache'],
+  require => Service['apache', 'mysql'], 
+  require => [ Service['apache'], Service['mysql'] ],
+```
+

data/lib/puppet-lint/plugins/resource_reference_without_title_capital.rb

@@ -5,7 +5,7 @@ PuppetLint.new_check(:resource_reference_without_title_capital) do
         ['require', 'subscribe', 'notify', 'before', 'consume', 'export'].include? param_token.value
       }.each do |param_token|
         value_token = param_token.next_code_token.next_code_token.next_code_token.next_token
-        unless value_token.type == :SSTRING or value_token.type == :VARIABLE
+        unless value_token.type == :SSTRING or value_token.type == :VARIABLE or value_token.next_token.type == :SSTRING
           notify :error, {
             :message => 'resource reference with title with capital letter',
             :line    => value_token.line,

data/spec/puppet-lint/plugins/resource_reference_without_title_capital_spec.rb

@@ -19,6 +19,22 @@ describe 'resource_reference_without_title_capital' do
     end
   end
 
+  context 'a proper reference as array in quotes' do
+    let(:code) { "file { 'foo': ensure => file, notify => Title['one', 'two'],}" }
+
+    it 'should detect no problem' do
+      expect(problems).to have(0).problem
+    end
+  end
+
+  context 'multiple proper references as array in quotes' do
+    let(:code) { "file { 'foo': ensure => file, notify => [ Title['one'], Title['two'] ],}" }
+
+    it 'should detect no problem' do
+      expect(problems).to have(0).problem
+    end
+  end
+
   context 'a proper reference as variable' do
     let(:code) { "file { 'foo': ensure => file, notify => Title[$foo_var],}" }
 
@@ -40,6 +56,32 @@ describe 'resource_reference_without_title_capital' do
     end
   end
 
+  context 'resource reference with title as array of capital letters' do
+    let(:msg) { 'resource reference with title with capital letter' }
+    let(:code) { "file { 'foo': ensure => file, notify => Title[One, Two],}" }
+
+    it 'should only detect a single problem' do
+      expect(problems).to have(1).problem
+    end
+
+    it 'should create an error' do
+      expect(problems).to contain_error(msg).on_line(1)
+    end
+  end
+
+  context 'resource reference with title as array of resource references with capital letters' do
+    let(:msg) { 'resource reference with title with capital letter' }
+    let(:code) { "file { 'foo': ensure => file, notify => [Title[One], Title[Two],]}" }
+
+    it 'should only detect a single problem' do
+      expect(problems).to have(1).problem
+    end
+
+    it 'should create an error' do
+      expect(problems).to contain_error(msg).on_line(1)
+    end
+  end
+
   context 'resource reference with title without quotes' do
     let(:msg) { 'resource reference with title with capital letter' }
     let(:code) { "file { 'foo': ensure => file, notify => Title[one],}" }

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: puppet-lint-resource_reference_syntax
 version: !ruby/object:Gem::Version
-  version: 1.0.4
+  version: 1.0.5
 platform: ruby
 authors:
 - Martin Alfke
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-10-18 00:00:00.000000000 Z
+date: 2015-11-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: puppet-lint
@@ -87,6 +87,7 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".rspec"
 - LICENSE
 - README.md
 - lib/puppet-lint/plugins/resource_reference_without_title_capital.rb