puppet-lint-resource_reference_syntax 1.0.1 → 1.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 371616c14d5648e344a31fa1a7d31e350dadfbde
-  data.tar.gz: 5045d5c117f7f684cce916b57baff43675dba38a
+  metadata.gz: 73c7049c068ecde592b71eb2cfbc542a4f0bd55d
+  data.tar.gz: c7b2fd27e59671362db4f8e13fa59cdbca9aea9f
 SHA512:
-  metadata.gz: 5a0308cb0014b98fbb3790cb49a31298d0c478d516cddd8137e4474f45b554bd7355a78546e528764782e853ca7dbefb78cda1c7679cf118f2010f6ad9ef7d59
-  data.tar.gz: cbf0d29ad77fceec6783e286f5cbf17af8d7739dcf612d9eea3e5991ca2f7a96771bf7af812a36ef5e5a246c23924c5a678edfff2b1f4091bc4aa9c822c33ec6
+  metadata.gz: ef016a2d6ad6992a427d7219cbdc3c70444498c70547f7367800c2b70f9907e4ef40c143b53034cecbd090f04ca9495e930f20a5c558beb2ab51bca9708f2414
+  data.tar.gz: 67282c88a86427cd528de11d11b53b5de1fbb5def830646e5970f2a39aed76ad99b91681000284f1422777f021f72b996b795800ba9d496beba06a6433319df7

data/README.md

@@ -31,7 +31,7 @@ ERROR: whitespce between reference type and title on line 4
 
 **--fix support: No**
 
-This check will raise an error for any resource reference that uses the title with capital letter.
+This check will raise an error for any resource reference that uses the title with capital letter without enclosed quotes.
 
 ```
 ERROR: resource reference with title with capital letter on line 4

data/lib/puppet-lint/plugins/resource_reference_without_title_capital.rb

@@ -4,13 +4,15 @@ PuppetLint.new_check(:resource_reference_without_title_capital) do
       resource[:param_tokens].select { |param_token|
         ['require', 'subscribe', 'notify', 'before'].include? param_token.value
       }.each do |param_token|
-        value_token = param_token.next_code_token.next_code_token.next_code_token.next_code_token
-        unless value_token.value =~ (/^[a-z]*$/)
-          notify :error, {
-            :message => 'resource reference with title with capital letter',
-            :line    => value_token.line,
-            :column  => value_token.column
-          }
+        value_token = param_token.next_code_token.next_code_token.next_code_token.next_token
+        unless value_token.type == :SSTRING
+          unless value_token.value =~ (/^[a-z]*$/)
+            notify :error, {
+              :message => 'resource reference with title with capital letter',
+              :line    => value_token.line,
+              :column  => value_token.column
+            }
+          end
         end
       end
     end

data/spec/puppet-lint/plugins/resource_reference_without_title_capital_spec.rb

@@ -11,6 +11,15 @@ describe 'resource_reference_without_title_capital' do
     end
   end
 
+  context 'a proper reference in quotes' do
+    let(:msg) { 'whitespce between reference type and title' }
+    let(:code) { "file { 'foo': ensure => file, notify => Title['One'],}" }
+
+    it 'should detect no problem' do
+      expect(problems).to have(0).problem
+    end
+  end
+
   context 'resource reference with title as capital letter' do
     let(:msg) { 'resource reference with title with capital letter' }
     let(:code) { "file { 'foo': ensure => file, notify => Title[One],}" }

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: puppet-lint-resource_reference_syntax
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.0.2
 platform: ruby
 authors:
 - Martin Alfke
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-10-06 00:00:00.000000000 Z
+date: 2015-10-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: puppet-lint