puppet-lint-resource_reference_syntax 1.0.11 → 1.0.12

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6bec0b0cda5b6e0baaf5be0d7384eeebb8bd54f3
-  data.tar.gz: a1b14449a5dd89ea9519482f7b58601f008d2a83
+  metadata.gz: 92733fa76520fe90aa7a08f0ffdba688819af9d1
+  data.tar.gz: 819e4396e020382c390c8b5f7b8e07a20136dd64
 SHA512:
-  metadata.gz: cc948517e4a2e414e73243d6da93e427a6dbfc0fe24c74847d6a79bc4596b86d3ba8607b399b9aa64d0b9858b8a6b613230b3eca65edfec326c522ec8eac7707
-  data.tar.gz: ca4d94b023baa8b20a2124fcb78b604141d827bd562074ae0b572d2ad92135f8a42e9959a20d71b85fb9df43c6f3c847779fd0eef79b8ae2ad3988f7bda2626e
+  metadata.gz: cb0dd4e61f3c1f5f0d4b2c3463260f45b369f6eb462063c6a26699ed39dd348090995a230bb8c15047e98a46e2ed85dbe08c57d285d91e279284417a7dfb9213
+  data.tar.gz: 6f58ae49f10b4f04d08cf80137187401a4d28d0d6687ace5be58f62b3757f097d6b3c600bfc95e7fa9b8514c8fd3a4f0532bdb4e2778dbd6bae6ab27cc2679dd

data/lib/puppet-lint/plugins/resource_reference_without_whitespace.rb

@@ -1,3 +1,4 @@
+require 'pry'
 PuppetLint.new_check(:resource_reference_without_whitespace) do
   def check
     resource_indexes.each do |resource|
@@ -7,8 +8,9 @@ PuppetLint.new_check(:resource_reference_without_whitespace) do
         check = param_token
         case check.type
         when :CLASSREF
+#          binding.pry
           begin
-            if check.next_token.type == :WHITESPACE
+            if check.next_token.type == :WHITESPACE and check.next_code_token.type == :LBRACK
               notify :error, {
                 :message => 'whitespce between reference type and title',
                 :line    => check.line,

data/spec/puppet-lint/plugins/resource_reference_without_whitespace_spec.rb

@@ -67,7 +67,7 @@ describe 'resource_reference_without_whitespace' do
     let(:msg) { 'whitespce between reference type and title' }
     let(:code) { "package { 'one': ensure => present, } Package ['one'] ~> Service ['two']" }
 
-    it 'should detect three problems' do
+    it 'should detect two problems' do
       expect(problems).to have(2).problem
     end
 
@@ -76,4 +76,25 @@ describe 'resource_reference_without_whitespace' do
     end
   end
 
+  context 'more resources and a whitespace between reference and bracket on chains' do
+    let(:msg) { 'whitespce between reference type and title' }
+    let(:code) { "package { 'one': ensure => present, } package { 'two': ensure => present, } Package ['one'] ~> Service['two']" }
+
+    it 'should detect one problem' do
+      expect(problems).to have(2).problem
+    end
+
+    it 'should create an error' do
+      expect(problems).to contain_error(msg).on_line(1)
+    end
+  end
+
+  context 'collectors should not cause an error' do
+    let(:code) { "@package { 'bar': ensure => installed,}  Package <| |>" }
+
+    it 'should detect no problem' do
+      expect(problems).to have(0).problem
+    end
+  end
+
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: puppet-lint-resource_reference_syntax
 version: !ruby/object:Gem::Version
-  version: 1.0.11
+  version: 1.0.12
 platform: ruby
 authors:
 - Martin Alfke
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-12-30 00:00:00.000000000 Z
+date: 2018-01-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: puppet-lint