puppet-lint-params_empty_string-check 1.1.0 → 2.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f0b1ae2ca9cbc0b49b97b104909cb97a363c7bf1ddf8f7ae81e5b84b3531baf1
-  data.tar.gz: bc4060c86e7c065915f531310820024f956296cb9350f1e913aa785d2415f7ec
+  metadata.gz: bc4054f38eae4940d80dedcce753ad7b51cc74b0365d6c5182a7702fcd119289
+  data.tar.gz: c5e69036e9db4206ac149f8da17448b182393c0ebc36eede10b64536ae1df5a9
 SHA512:
-  metadata.gz: 7678332af3be56c77a0df729cf04bbe7ac274fac48af489514e411711fbc6b2860a2d32ca2b7b97b2f4d5643a8b0d59d13b887fe9485085c1094e28703646021
-  data.tar.gz: 197fac1823799ee83a51ed174c835f5e1aa5d880b7eac2c1124592eb37030cce5c8e041f0aca5e46db23a027858de7ff5fd54a1578ac5d3b2ef5a4950be07f61
+  metadata.gz: 0a248139911486573f757a898d26b619ab1fa7861ee35c4ef75de8d4aef372b46d6841b010a212fbade6cee231e53999b71add8f7db117e354a57c4f98b8a0a6
+  data.tar.gz: 626ed806c8d8411a60fc807e74a42bce4c95548ffeb93e27645c9e4cd32a16cbae9c7e7232f6d8a5b7b62f78f6d28ac1ba71c218bed796c4fbbb30062ffae6dd

data/lib/puppet-lint/plugins/{check-params_empty_string_assignment.rb → check_params_empty_string_assignment.rb}

@@ -11,15 +11,18 @@ PuppetLint.new_check(:params_empty_string_assignment) do
         # why can those be empty?
         next if type.empty?
         next if default_value.empty?
+
         # if the parameter has datatype String/String[]/Variant and a value of ''
         # we filter for the puppet-lint type of the value (:SSTRING) to ignore strings with variables
-        if type[0].type == :TYPE && type[0].value =~ /^(String|Variant)/ && default_value[0].type == :SSTRING && default_value[0].value == ''
-          notify :warning, {
-            :message => 'class parameter with String type defaults to empty string',
-            :line    => param.line,
-            :column  => param.column,
-          }
+        unless type[0].type == :TYPE && type[0].value =~ /^(String|Variant)/ && default_value[0].type == :SSTRING && default_value[0].value == ''
+          next
         end
+
+        notify :warning, {
+          message: 'class parameter with String type defaults to empty string',
+          line: param.line,
+          column: param.column,
+        }
       end
     end
   end

data/spec/puppet-lint/plugins/check_params_empty_string_assignment/check_params_empty_string_assignment_spec.rb

@@ -1,120 +1,124 @@
 require 'spec_helper'
 
 describe 'params_empty_string_assignment' do
-  let (:msg) { 'class parameter with String type defaults to empty string' }
+  let(:msg) { 'class parameter with String type defaults to empty string' }
 
   context 'with fix disabled' do
     context 'class definition without empty strings' do
-      let (:code) {
+      let(:code) do
         <<-EOS
         class foo ( $bar = 'baz' ) { }
         EOS
-      }
+      end
 
-      it 'should not detect any problems' do
+      it 'does not detect any problems' do
         expect(problems).to have(0).problems
       end
     end
 
     context 'class definition with empty strings and 0 as minimal string length' do
-      let (:code) {
+      let(:code) do
         <<-EOS
         class foo ( String[0] $bar = '' ) { }
         EOS
-      }
+      end
 
-      it 'should detect one problem' do
+      it 'detects one problem' do
         expect(problems).to have(1).problem
       end
     end
 
     context 'class definition with empty strings and loose Variant datatype 1' do
-      let (:code) {
+      let(:code) do
         <<-EOS
         class foo ( Variant[String[0], Integer] $bar = '' ) { }
         EOS
-      }
+      end
 
-      it 'should detect one problem' do
+      it 'detects one problem' do
         expect(problems).to have(1).problem
       end
     end
 
     context 'class definition with empty strings and loose Variant datatype 2' do
-      let (:code) {
+      let(:code) do
         <<-EOS
         class foo ( Variant[Any, Optional] $bar = '' ) { }
         EOS
-      }
+      end
 
-      it 'should detect one problem' do
+      it 'detects one problem' do
         expect(problems).to have(1).problem
       end
     end
 
     context 'class internal variable without empty strings' do
-      let (:code) {
+      let(:code) do
         <<-EOS
         class foo ( ) { $bar = 'baz' }
         EOS
-      }
+      end
 
-      it 'should not detect any problems' do
+      it 'does not detect any problems' do
         expect(problems).to have(0).problems
       end
     end
 
     context 'class definition with empty strings' do
-      let (:code) {
+      let(:code) do
         <<-EOS
         class foo ( String $bar = '' ) { }
         EOS
-      }
+      end
 
-      it 'should detect a single problem' do
+      it 'detects a single problem' do
         expect(problems).to have(1).problem
       end
 
-      it 'should create a warning' do
+      it 'creates a warning' do
         expect(problems).to contain_warning(msg).on_line(1).in_column(28)
       end
     end
+
     context 'class internal variable with empty strings' do
-      let (:code) {
+      let(:code) do
         <<-EOS
         class foo ( ) { $bar = '' }
         EOS
-      }
+      end
 
-      it 'should not detect any problems' do
+      it 'does not detect any problems' do
         expect(problems).to have(0).problem
       end
     end
+
     context 'class definition with value and minimal string length at 0' do
-      let (:code) {
+      let(:code) do
         <<-EOS
         class foo ( String[0] $var = 'public' ) { }
         EOS
-      }
+      end
 
-      it 'should not detect any problems' do
+      it 'does not detect any problems' do
         expect(problems).to have(0).problem
       end
     end
+
     context 'class definition with value and no minimal string length' do
-      let (:code) {
+      let(:code) do
         <<-EOS
         class foo ( String $var = 'public' ) { }
         EOS
-      }
+      end
 
-      it 'should not detect any problems' do
+      it 'does not detect any problems' do
         expect(problems).to have(0).problem
       end
     end
+
     # this usecase was reported on slack
     context 'class definition with value and string interpolation and values' do
-      let (:code) {
+      let(:code) do
         <<-EOS
         class foo (
           String $install_path = 'bla',
@@ -123,15 +127,16 @@ describe 'params_empty_string_assignment' do
             # code
           }
         EOS
-      }
+      end
 
-      it 'should not detect any problems' do
+      it 'does not detect any problems' do
         expect(problems).to have(0).problem
       end
     end
+
     # this usecase was reported on slack as well
     context 'class definition with value and string interpolation and not all values' do
-      let (:code) {
+      let(:code) do
         <<-EOS
         class foo (
           String $install_path,
@@ -140,15 +145,16 @@ describe 'params_empty_string_assignment' do
             # code
           }
         EOS
-      }
+      end
 
-      it 'should not detect any problems' do
+      it 'does not detect any problems' do
         expect(problems).to have(0).problem
       end
     end
+
     # this usecase was reported on slack as well
     context 'class definition with value and string interpolation and not all values and types' do
-      let (:code) {
+      let(:code) do
         <<-EOS
         class foo (
           String $install_path,
@@ -157,15 +163,16 @@ describe 'params_empty_string_assignment' do
             # code
           }
         EOS
-      }
+      end
 
-      it 'should not detect any problems' do
+      it 'does not detect any problems' do
         expect(problems).to have(0).problem
       end
     end
+
     # this usecase was reported on slack as well
     context 'class definition with value and string interpolation and not all values and types' do
-      let (:code) {
+      let(:code) do
         <<-EOS
         define bar::foo (
           String $install_path,
@@ -174,15 +181,16 @@ describe 'params_empty_string_assignment' do
             # code
           }
         EOS
-      }
+      end
 
-      it 'should not detect any problems' do
+      it 'does not detect any problems' do
         expect(problems).to have(0).problem
       end
     end
+
     # this usecase was reported on slack as well
     context 'class definition with value and string interpolation and not all values and types' do
-      let (:code) {
+      let(:code) do
         <<-EOS
         define profiles::host_api::nexus::managed::gem_installation (
           String $gem_source,
@@ -197,9 +205,9 @@ describe 'params_empty_string_assignment' do
           # code
         }
         EOS
-      }
+      end
 
-      it 'should not detect any problems' do
+      it 'does not detect any problems' do
         expect(problems).to have(0).problem
       end
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: puppet-lint-params_empty_string-check
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 2.0.0
 platform: ruby
 authors:
 - Vox Pupuli
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-02-24 00:00:00.000000000 Z
+date: 2023-04-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: puppet-lint
@@ -16,90 +16,20 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '2.5'
+        version: '3'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '4'
+        version: '5'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '2.5'
+        version: '3'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '4'
-- !ruby/object:Gem::Dependency
-  name: rspec
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.10'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.10'
-- !ruby/object:Gem::Dependency
-  name: rspec-its
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.3'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.3'
-- !ruby/object:Gem::Dependency
-  name: rspec-collection_matchers
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.2'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.2'
-- !ruby/object:Gem::Dependency
-  name: rspec-json_expectations
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '2.2'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '2.2'
-- !ruby/object:Gem::Dependency
-  name: rake
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
+        version: '5'
 description: 
 email: voxpupuli@groups.io
 executables: []
@@ -108,7 +38,7 @@ extra_rdoc_files: []
 files:
 - LICENSE
 - README.md
-- lib/puppet-lint/plugins/check-params_empty_string_assignment.rb
+- lib/puppet-lint/plugins/check_params_empty_string_assignment.rb
 - spec/puppet-lint/plugins/check_params_empty_string_assignment/check_params_empty_string_assignment_spec.rb
 - spec/spec_helper.rb
 homepage: https://github.com/voxpupuli/puppet-lint-params_empty_string-check
@@ -123,7 +53,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 2.7.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
@@ -135,6 +65,4 @@ signing_key:
 specification_version: 4
 summary: A puppet-lint plugin to check for class parameters assigned to the empty
   string.
-test_files:
-- spec/puppet-lint/plugins/check_params_empty_string_assignment/check_params_empty_string_assignment_spec.rb
-- spec/spec_helper.rb
+test_files: []