puppet-lint-module_reference-check 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 165ae50c695f4525d85426dea4ec555b9d4f44b7321f642d86783277319787fb
-  data.tar.gz: 952b6da27bc82a66b29a23df6bae49ecd16e742750a94cb75f0ce0d4646af1f8
+  metadata.gz: ee854abe4315d279e6979682faf87b6690d950f1e7f9c7a91d8482c6289195c9
+  data.tar.gz: a4253c750197e353a05a78adb1de8f7206832bd9fd8e366d19699fcf947d78c2
 SHA512:
-  metadata.gz: 96cdff2aed65b20e028d2093dc27668a7b32c8479ad3f552bc9bbdc59f655a6858d3ee2a36713367b949242978cd048854e0cb2c0a2b6cabd6d8c78caf476587
-  data.tar.gz: 124c80e7b55984c5a06d2fc5ecf70e192625d8984003d2f9277fbce6d4130e08028c4ce6140d4ae1105d44e6d155e6d9eee7ec7ef704212a6424204841c3f3ad
+  metadata.gz: 706218a66652064c2270eaf2d0a051265f6bcc661d52e45e3c7c9c15c8bb0f1fb27bb04df20b5302bfbac044fafa4a5fc0506886c32628d11398d86e167c44a4
+  data.tar.gz: ae4b93169eb6cdaa3c8cd24247ef5fb34b8105759db84a275fc4ca09eba5e0856f7d7e8b19174aa4e8967866378ce0e605e1900c1cd68d542f167c70c3517bb7

data/lib/puppet-lint/plugins/check_module_reference.rb

@@ -130,7 +130,7 @@ PuppetLint.new_check(:module_reference) do
       return return_object if captures['name'].match?(%r(https?://))
 
       reference = @workflow.references.select { |ref| ref[:name] == captures['name'] }
-      return warn("Can't find referenced module #{captures['name']}") if reference.empty?
+      return return_object if reference.empty?
 
       return_object[:type] = reference.first[:type]
     else

data/spec/puppet-lint/plugins/check_module_reference_spec.rb

@@ -34,6 +34,31 @@ describe 'module_reference' do
     end
   end
 
+  context 'valid code with reference to unused module' do
+    let(:code) do
+      <<~CODE
+        # @ref apache
+        # @note puppetlabs-apache
+        # @see https://forge.puppet.com/modules/puppetlabs/apache
+        #
+        # @see profile::test
+        #
+        # @see profile::testfeature - Feature "test"
+        class test () {
+          include profile::test
+          class {
+            'apache':
+          }
+          include apache
+        }
+      CODE
+    end
+
+    it 'should detect detect any problems' do
+      expect(problems).to have(0).problems
+    end
+  end
+
   context 'code with missing internal link' do
     let(:code) do
       <<~CODE
@@ -165,35 +190,6 @@ describe 'module_reference' do
     end
   end
 
-  context 'code with reference to unused module' do
-    let(:code) do
-      <<~CODE
-        # @ref apache
-        # @note puppetlabs-apache
-        # @see https://forge.puppet.com/modules/puppetlabs/apache
-        #
-        # @see profile::test
-        #
-        # @see profile::testfeature - Feature "test"
-        class test () {
-          include profile::test
-          class {
-            'apache':
-          }
-          include apache
-        }
-      CODE
-    end
-
-    it 'should detect exactly one problem' do
-      expect(problems).to have(1).problems
-    end
-
-    it 'should create a warning' do
-      expect(problems).to contain_warning('Can\'t find referenced module profile::testfeature').on_line(1).in_column(1)
-    end
-  end
-
   context 'code with unsorted component references' do
     let(:code) do
       <<~CODE

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: puppet-lint-module_reference-check
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Dennis Ploeger