puppet-lint-manifest_whitespace-check 0.1.8 → 0.1.9
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- checksums.yaml +4 -4
- data/lib/puppet-lint/plugins/check_manifest_whitespace_closing_brace.rb +2 -2
- data/lib/puppet-lint/plugins/check_manifest_whitespace_opening_brace.rb +3 -1
- data/spec/puppet-lint/plugins/manifest_whitespace_closing_brace_spec.rb +12 -0
- data/spec/puppet-lint/plugins/manifest_whitespace_opening_brace_spec.rb +15 -0
- metadata +2 -2
checksums.yaml
CHANGED
@@ -1,7 +1,7 @@
|
|
1
1
|
---
|
2
2
|
SHA256:
|
3
|
-
metadata.gz:
|
4
|
-
data.tar.gz:
|
3
|
+
metadata.gz: deec283a984c69934edd2522701fd6e840fb15e5ebbaf5d836366e59a6f7d894
|
4
|
+
data.tar.gz: e4b9559d3d6f82ef25f362b1bcbf8d7e8268e2f54089398dfb22519f6529b289
|
5
5
|
SHA512:
|
6
|
-
metadata.gz:
|
7
|
-
data.tar.gz:
|
6
|
+
metadata.gz: 4a49d305962a6ea8168b6deb0f3ec7baf47276d7c6aa56c3869f16f73ed3ade68c3ff63acea7a5ebdef71cab5388b67b5d5cfc898d2f2f2daaa3bb9d7867a4a2
|
7
|
+
data.tar.gz: 10217466afcdf5fcd832eb08a54d1031c1f88d417783bc77da4a035ee3dfa5cfacc020ee87bac0b030abe59d80f080f596ffa0c803cddaf73aa0f312a3ac7d1d
|
@@ -7,9 +7,9 @@ PuppetLint.new_check(:manifest_whitespace_closing_brace_before) do
|
|
7
7
|
prev_code_token = prev_non_space_token(brace_token)
|
8
8
|
|
9
9
|
next unless prev_token && prev_code_token
|
10
|
-
next if %i[LBRACE
|
10
|
+
next if %i[LBRACE].include?(prev_token.type)
|
11
11
|
|
12
|
-
unless %i[LBRACE
|
12
|
+
unless %i[LBRACE].include?(prev_code_token.type)
|
13
13
|
if is_single_space(prev_token) && tokens.index(prev_code_token) == tokens.index(brace_token) - 2
|
14
14
|
next
|
15
15
|
end
|
@@ -7,7 +7,9 @@ PuppetLint.new_check(:manifest_whitespace_opening_brace_before) do
|
|
7
7
|
prev_code_token = prev_non_space_token(brace_token)
|
8
8
|
|
9
9
|
next unless prev_token && prev_code_token
|
10
|
-
|
10
|
+
if %i[LBRACK LBRACE COLON COMMA COMMENT].include?(prev_code_token.type)
|
11
|
+
next
|
12
|
+
end
|
11
13
|
next unless tokens.index(prev_code_token) != tokens.index(brace_token) - 2 ||
|
12
14
|
!is_single_space(prev_token)
|
13
15
|
|
@@ -5,6 +5,18 @@ require 'spec_helper'
|
|
5
5
|
describe 'manifest_whitespace_closing_brace_before' do
|
6
6
|
let(:closing_brace_msg) { 'there should be a bracket or a single newline before a closing brace' }
|
7
7
|
|
8
|
+
context 'with nested hash' do
|
9
|
+
let(:code) do
|
10
|
+
<<~EOF
|
11
|
+
Hash $instances = { 'localhost' => { 'url' => 'http://localhost/mod_status?auto' } },
|
12
|
+
EOF
|
13
|
+
end
|
14
|
+
|
15
|
+
it 'should detect no problems' do
|
16
|
+
expect(problems).to have(0).problem
|
17
|
+
end
|
18
|
+
end
|
19
|
+
|
8
20
|
context 'with comment only' do
|
9
21
|
let(:code) do
|
10
22
|
<<~EOF
|
@@ -19,6 +19,21 @@ describe 'manifest_whitespace_opening_brace_before' do
|
|
19
19
|
end
|
20
20
|
end
|
21
21
|
|
22
|
+
context 'with cases' do
|
23
|
+
let(:code) do
|
24
|
+
<<~EOF
|
25
|
+
case $facts['kernel'] {
|
26
|
+
'OpenBSD': { $has_wordexp = false }
|
27
|
+
default: { $has_wordexp = true }
|
28
|
+
}
|
29
|
+
EOF
|
30
|
+
end
|
31
|
+
|
32
|
+
it 'should detect no problems' do
|
33
|
+
expect(problems).to have(0).problem
|
34
|
+
end
|
35
|
+
end
|
36
|
+
|
22
37
|
context 'with no spaces' do
|
23
38
|
let(:code) do
|
24
39
|
<<~EOF
|
metadata
CHANGED
@@ -1,14 +1,14 @@
|
|
1
1
|
--- !ruby/object:Gem::Specification
|
2
2
|
name: puppet-lint-manifest_whitespace-check
|
3
3
|
version: !ruby/object:Gem::Version
|
4
|
-
version: 0.1.
|
4
|
+
version: 0.1.9
|
5
5
|
platform: ruby
|
6
6
|
authors:
|
7
7
|
- Jo Vandeginste
|
8
8
|
autorequire:
|
9
9
|
bindir: bin
|
10
10
|
cert_chain: []
|
11
|
-
date: 2020-06-
|
11
|
+
date: 2020-06-25 00:00:00.000000000 Z
|
12
12
|
dependencies:
|
13
13
|
- !ruby/object:Gem::Dependency
|
14
14
|
name: puppet-lint
|