puppet-lint-file_ensure-check 0.2.0 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: cfa9f5e1fc0ea251d4bad7cf61e5afe8826fd5f8
-  data.tar.gz: 77cdaaabc6993fe383d7c813104f49dbe0857f4b
+  metadata.gz: 7a19b6f8a71a7d085e00b8c4dc8c2aa1c70f0350
+  data.tar.gz: bc567c6838b7f3bdec4d9fbb719b50a562a55c9f
 SHA512:
-  metadata.gz: 3970c7fb794837a782894fcd3690674219e099de8438038637375e3a9b305ab92a322c77786c83d4c033e0d3bd711d125ec19113a5c6b228df49996ad7ed3342
-  data.tar.gz: 4f2c9fa4a829aaf148b090a7825cedb90c594336e567917a1ac59b92fdd10e6c28c6c147512887a93ef0c108a0c59eb31975bb2ea58777853e04902886af01db
+  metadata.gz: c0a2bac21c5c62a01b618d51391f04607192eca8acc66dbb13215e3608a2bf1d6f8e984ac5328a4c0b383045974b106dfbeef1c48ca073859a4cf9e0bca19861
+  data.tar.gz: 6f80d95338f238c007d22df8b2659c3e1fdb3a309b822841ae4468791a11f671c156af5efed8bc87132af6ff76d7ffd8a2b3a934ba6546443e6d8bb6c4e55fa0

data/lib/puppet-lint/plugins/check_file_ensure.rb

@@ -5,18 +5,17 @@ PuppetLint.new_check(:file_ensure) do
         attr = resource[:tokens].select { |t| t.type == :NAME && \
                                               t.value == 'ensure' && \
                                               t.next_code_token.type == :FARROW }
-        unless attr.empty?
-          val_token = attr[0].next_code_token.next_code_token
-          if val_token.value == 'present'
-              notify :warning, {
-                :message  => 'ensure set to present on file resource',
-                :line     => val_token.line,
-                :column   => val_token.column,
-                :token    => val_token,
-                :resource => resource,
-              }
-          end
-        end
+        next if attr.empty?
+        val_token = attr[0].next_code_token.next_code_token
+        next unless val_token.value == 'present'
+        next unless [:NAME, :STRING, :SSTRING].include? val_token.type
+        notify :warning, {
+          :message  => 'ensure set to present on file resource',
+          :line     => val_token.line,
+          :column   => val_token.column,
+          :token    => val_token,
+          :resource => resource,
+        }
       end
     end
   end

data/spec/puppet-lint/plugins/check_file_ensure/check_file_ensure_spec.rb

@@ -15,6 +15,10 @@ describe 'file_ensure' do
           ensure => 'target',
           target => '/etc/mtab',
         }
+
+        file { '/tmp/foo':
+          ensure => $present,
+        }
         EOS
       }
 
@@ -34,6 +38,10 @@ describe 'file_ensure' do
           ensure => 'present',
           target => '/etc/mtab',
         }
+
+        file { '/tmp/foo':
+          ensure => $present,
+        }
         EOS
       }
 
@@ -68,6 +76,10 @@ describe 'file_ensure' do
           ensure => 'target',
           target => '/etc/mtab',
         }
+
+        file { '/tmp/foo':
+          ensure => $present,
+        }
         EOS
       }
 
@@ -91,6 +103,10 @@ describe 'file_ensure' do
           ensure => 'present',
           target => '/etc/mtab',
         }
+
+        file { '/tmp/foo':
+          ensure => $present,
+        }
         EOS
       }
 
@@ -114,6 +130,10 @@ describe 'file_ensure' do
           ensure => 'link',
           target => '/etc/mtab',
         }
+
+        file { '/tmp/foo':
+          ensure => $present,
+        }
           EOS
         )
       end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: puppet-lint-file_ensure-check
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
 platform: ruby
 authors:
 - Camptocamp