puppet-ghostbuster 0.7.1 → 0.7.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a78a0b11c9950a7bd0ee29f97d952fa7fedcf1ac
-  data.tar.gz: 9063dd63354c9ee624e9337d155c800a7391bf03
+  metadata.gz: 8b2e06b759612d9b773d0d6eb3efaef0b91acc36
+  data.tar.gz: c38603601072ff8cbb8a7dae4ffd44fd26965091
 SHA512:
-  metadata.gz: cf75180a7a7f695c88b81bf72d703064805e539bf59dca5445fe8cb9257ef23012a7f9ed47d667fd0f16d56e1b3f578f7adb0c070837ec517aa838d6c97f12db
-  data.tar.gz: a3f9e6efcfe9d34f1e050e5721b61cc6d771a1d77db627c27f022e24c6e73bde4ed46be15c9345ca11f647d3d574a5a1192056e18489c70ea350f3eaaafbf162
+  metadata.gz: aa349856ba8787af3b7aea3bd2640cd73e571b7ea459d87108f48d0c85bf8a7562724dca6d47e6978fd735def66ee34e4c5c5efafed48986e24deb18474d4744
+  data.tar.gz: d396dee2c8f039f3b6a41a4af415b642b0a5d8db916f502b591c27f3610cbb2f104ae186d77863f1d64460186385b3651c37f17274b9e9e9f1c2ffbe327fec16

data/CHANGELOG.md

@@ -1,5 +1,12 @@
 # Change Log
 
+## [0.7.2](https://rubygems.org/gems/puppet-ghostbuster/versions/0.7.2) (2016-05-19)
+[Full Changelog](https://github.com/camptocamp/puppet-ghostbuster/compare/0.7.1...0.7.2)
+
+**Fixed bugs:**
+
+- Detect facts used in inline_templates()
+
 ## [0.7.1](https://rubygems.org/gems/puppet-ghostbuster/versions/0.7.1) (2016-05-16)
 [Full Changelog](https://github.com/camptocamp/puppet-ghostbuster/compare/0.7.0...0.7.1)
 

data/lib/puppet-ghostbuster/version.rb

@@ -1,3 +1,3 @@
 class PuppetGhostbuster
-  VERSION = '0.7.1'
+  VERSION = '0.7.2'
 end

data/lib/puppet-lint/plugins/check_ghostbuster_classes.rb

@@ -1,5 +1,19 @@
 require 'puppet-ghostbuster/puppetdb'
 
+class PuppetLint::Checks
+  def load_data(path, content)
+    lexer = PuppetLint::Lexer.new
+    PuppetLint::Data.path = path
+    begin
+      PuppetLint::Data.manifest_lines = content.split("\n", -1)
+      PuppetLint::Data.tokens = lexer.tokenise(content)
+      PuppetLint::Data.parse_control_comments
+    rescue
+      PuppetLint::Data.tokens = []
+    end
+  end
+end
+
 PuppetLint.new_check(:ghostbuster_classes) do
   def check
     return if path.match(%r{^\./(:?[^/]+/){2}?manifests/.+$}).nil?

data/lib/puppet-lint/plugins/check_ghostbuster_defines.rb

@@ -1,5 +1,19 @@
 require 'puppet-ghostbuster/puppetdb'
 
+class PuppetLint::Checks
+  def load_data(path, content)
+    lexer = PuppetLint::Lexer.new
+    PuppetLint::Data.path = path
+    begin
+      PuppetLint::Data.manifest_lines = content.split("\n", -1)
+      PuppetLint::Data.tokens = lexer.tokenise(content)
+      PuppetLint::Data.parse_control_comments
+    rescue
+      PuppetLint::Data.tokens = []
+    end
+  end
+end
+
 PuppetLint.new_check(:ghostbuster_defines) do
   def check
     return if path.match(%r{^\./(:?[^/]+/){2}?manifests/.+$}).nil?

data/lib/puppet-lint/plugins/check_ghostbuster_facts.rb

@@ -1,3 +1,17 @@
+class PuppetLint::Checks
+  def load_data(path, content)
+    lexer = PuppetLint::Lexer.new
+    PuppetLint::Data.path = path
+    begin
+      PuppetLint::Data.manifest_lines = content.split("\n", -1)
+      PuppetLint::Data.tokens = lexer.tokenise(content)
+      PuppetLint::Data.parse_control_comments
+    rescue
+      PuppetLint::Data.tokens = []
+    end
+  end
+end
+
 PuppetLint.new_check(:ghostbuster_facts) do
   def manifests
     Dir.glob('./**/manifests/**/*.pp')
@@ -18,6 +32,7 @@ PuppetLint.new_check(:ghostbuster_facts) do
 
       manifests.each do |manifest|
         found = true if File.readlines(manifest).grep(%r{\$\{?::#{fact_name}\}?}).size > 0
+        found = true if File.readlines(manifest).grep(%r{@#{fact_name}}).size > 0
         break if found
       end
 

data/lib/puppet-lint/plugins/check_ghostbuster_functions.rb

@@ -1,3 +1,17 @@
+class PuppetLint::Checks
+  def load_data(path, content)
+    lexer = PuppetLint::Lexer.new
+    PuppetLint::Data.path = path
+    begin
+      PuppetLint::Data.manifest_lines = content.split("\n", -1)
+      PuppetLint::Data.tokens = lexer.tokenise(content)
+      PuppetLint::Data.parse_control_comments
+    rescue
+      PuppetLint::Data.tokens = []
+    end
+  end
+end
+
 PuppetLint.new_check(:ghostbuster_functions) do
   def manifests
     Dir.glob('./**/manifests/**/*.pp')

data/lib/puppet-lint/plugins/check_ghostbuster_hiera_files.rb

@@ -1,3 +1,17 @@
+class PuppetLint::Checks
+  def load_data(path, content)
+    lexer = PuppetLint::Lexer.new
+    PuppetLint::Data.path = path
+    begin
+      PuppetLint::Data.manifest_lines = content.split("\n", -1)
+      PuppetLint::Data.tokens = lexer.tokenise(content)
+      PuppetLint::Data.parse_control_comments
+    rescue
+      PuppetLint::Data.tokens = []
+    end
+  end
+end
+
 PuppetLint.new_check(:ghostbuster_hiera_files) do
 
   def regexprs

data/lib/puppet-lint/plugins/check_ghostbuster_types.rb

@@ -1,5 +1,19 @@
 require 'puppet-ghostbuster/puppetdb'
 
+class PuppetLint::Checks
+  def load_data(path, content)
+    lexer = PuppetLint::Lexer.new
+    PuppetLint::Data.path = path
+    begin
+      PuppetLint::Data.manifest_lines = content.split("\n", -1)
+      PuppetLint::Data.tokens = lexer.tokenise(content)
+      PuppetLint::Data.parse_control_comments
+    rescue
+      PuppetLint::Data.tokens = []
+    end
+  end
+end
+
 PuppetLint.new_check(:ghostbuster_types) do
   def manifests
     Dir.glob('./**/manifests/**/*.pp')

data/spec/fixtures/modules/foo/lib/facter/quux.rb

@@ -0,0 +1,6 @@
+# Fact used in inline_template
+Facter.add('quux') do
+  setcode do
+    'quux'
+  end
+end

data/spec/fixtures/modules/foo/manifests/bar.pp

@@ -16,4 +16,7 @@ class foo::bar {
   }
   $foo = bar('baz')
   bar { 'bar': }
+  file { 'quux':
+    content => inline_template('<%= @quux %>'),
+  }
 }

data/spec/puppet-lint/plugins/ghostbuster_facts_spec.rb

@@ -44,5 +44,13 @@ describe 'ghostbuster_facts' do
         expect(problems).to have(0).problems
       end
     end
+
+    context 'when fact is used in an inline_template' do
+      let(:path) { "./spec/fixtures/modules/foo/lib/facter/quux.rb" }
+
+      it 'should not detect any problem' do
+        expect(problems).to have(0).problems
+      end
+    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: puppet-ghostbuster
 version: !ruby/object:Gem::Version
-  version: 0.7.1
+  version: 0.7.2
 platform: ruby
 authors:
 - Camptocamp
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-05-16 00:00:00.000000000 Z
+date: 2016-05-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: coveralls
@@ -193,6 +193,7 @@ files:
 - spec/fixtures/modules/foo/lib/facter/baz.rb
 - spec/fixtures/modules/foo/lib/facter/foo.rb
 - spec/fixtures/modules/foo/lib/facter/multi.rb
+- spec/fixtures/modules/foo/lib/facter/quux.rb
 - spec/fixtures/modules/foo/lib/puppet/parser/functions/bar.rb
 - spec/fixtures/modules/foo/lib/puppet/parser/functions/baz.rb
 - spec/fixtures/modules/foo/lib/puppet/parser/functions/foo.rb