puppet-ghostbuster 0.7.0 → 0.7.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0f4d56b90b0f6e22a0f28b01e5ca1bdccc3c3bcc
-  data.tar.gz: 75c739ec623682f6eb850ad7559126b67ef7a676
+  metadata.gz: a78a0b11c9950a7bd0ee29f97d952fa7fedcf1ac
+  data.tar.gz: 9063dd63354c9ee624e9337d155c800a7391bf03
 SHA512:
-  metadata.gz: 1a49b28f9dfe55668e828d06f05f0c564718c13ffa913c28318445c17f701d861e5da4a3d2daecd94320c2702fbea8bd5affac28d9cd189e877af8ae83ebd50d
-  data.tar.gz: d040b8d124939e48574cabd486f625bda849216e6fd9e6bc461080fde2cfd02abb16dba06f519f9c2ed4a55d258637013f28267842b26aa9cf7e14c86c09d24b
+  metadata.gz: cf75180a7a7f695c88b81bf72d703064805e539bf59dca5445fe8cb9257ef23012a7f9ed47d667fd0f16d56e1b3f578f7adb0c070837ec517aa838d6c97f12db
+  data.tar.gz: a3f9e6efcfe9d34f1e050e5721b61cc6d771a1d77db627c27f022e24c6e73bde4ed46be15c9345ca11f647d3d574a5a1192056e18489c70ea350f3eaaafbf162

data/CHANGELOG.md

@@ -1,5 +1,13 @@
 # Change Log
 
+## [0.7.1](https://rubygems.org/gems/puppet-ghostbuster/versions/0.7.1) (2016-05-16)
+[Full Changelog](https://github.com/camptocamp/puppet-ghostbuster/compare/0.7.0...0.7.1)
+
+**Implemented enhancements:**
+
+- Add missing documentation.
+- Use PuppetDB instead of manifests to detect unused types.
+
 ## [0.7.0](https://rubygems.org/gems/puppet-ghostbuster/versions/0.7.0) (2016-05-16)
 [Full Changelog](https://github.com/camptocamp/puppet-ghostbuster/compare/0.6.0...0.7.0)
 

data/README.md

@@ -18,7 +18,7 @@ Usage
 -----
 
 ```shell
-$ find . -type f -exec puppet-lint --only-checks ghostbuster_classes,ghostbuster_defines,ghostbuster_files,ghostbuster_hiera_files,ghostbuster_templates {} \+
+$ find . -type f -exec puppet-lint --only-checks ghostbuster_classes,ghostbuster_defines,ghostbuster_facts,ghostbuster_files,ghostbuster_functions,ghostbuster_hiera_files,ghostbuster_templates,ghostbuster_types {} \+
 ```
 
 Environment variables
@@ -55,10 +55,18 @@ Find unused classes in PuppetDB.
 
 Find unused defined types in PuppetDB.
 
+### ghostbuster_facts
+
+Find unused facts in Puppet manifests and templates.
+
 ### ghostbuster_files
 
 Find unused files in PuppetDB or in Puppet manifests.
 
+### ghsotbuster_functions
+
+Find unused functions in Puppet manifests or templates.
+
 ### ghostbuster_hiera_files
 
 Find unused hiera files in PuppetDB.
@@ -67,6 +75,10 @@ Find unused hiera files in PuppetDB.
 
 Find unused templates in Puppet manifests.
 
+### ghostbuster_types
+
+Find unused types in Puppet manifests.
+
 Example output
 --------------
 

data/lib/puppet-ghostbuster/version.rb

@@ -1,3 +1,3 @@
 class PuppetGhostbuster
-  VERSION = '0.7.0'
+  VERSION = '0.7.1'
 end

data/lib/puppet-lint/plugins/check_ghostbuster_types.rb

@@ -1,3 +1,5 @@
+require 'puppet-ghostbuster/puppetdb'
+
 PuppetLint.new_check(:ghostbuster_types) do
   def manifests
     Dir.glob('./**/manifests/**/*.pp')
@@ -9,9 +11,8 @@ PuppetLint.new_check(:ghostbuster_types) do
 
     type_name = m.captures[0]
 
-    manifests.each do |manifest|
-      return if File.readlines(manifest).grep(%r{^\s*#{type_name}\s*\{}).size > 0
-    end
+    puppetdb = PuppetGhostbuster::PuppetDB.new
+    return if puppetdb.client.request('resources', [:'=', 'type', type_name.capitalize]).data.size > 0
 
     notify :warning, {
       :message => "Type #{type_name.capitalize} seems unused",

data/spec/fixtures/resources.json

@@ -1,9 +1,6 @@
 [
   {
-    "type": "Foo"
-  },
-  {
-    "type": "Foo::Foo"
+    "type": "Bar::Foo"
   },
   {
     "type": "Class",
@@ -21,5 +18,8 @@
       "source": "puppet:///modules/foo/baz",
       "recurse": "true"
     }
+  },
+  {
+    "type": "Bar"
   }
 ]

data/spec/puppet-lint/plugins/ghostbuster_defines_spec.rb

@@ -4,25 +4,25 @@ describe 'ghostbuster_defines' do
 
   context 'with fix disabled' do
 
-    context 'when define is used' do
-      let(:code) { "define foo {}" }
-      let(:path) { "./modules/foo/manifests/init.pp" }
-
-      it 'should not detect any problem' do
-        expect(problems).to have(0).problems
-      end
-    end
-
     context 'when define is not used' do
-      let(:code) { "define bar {}" }
-      let(:path) { "./modules/bar/manifests/init.pp" }
+      let(:code) { "define foo::foo {}" }
+      let(:path) { "./modules/foo/manifests/foo.pp" }
 
       it 'should detect one problem' do
         expect(problems).to have(1).problems
       end
 
       it 'should create a warning' do
-        expect(problems).to contain_warning('Define Bar seems unused')
+        expect(problems).to contain_warning('Define Foo::Foo seems unused')
+      end
+    end
+
+    context 'when define is used' do
+      let(:code) { "define bar::foo {}" }
+      let(:path) { "./modules/bar/manifests/foo.pp" }
+
+      it 'should not detect any problem' do
+        expect(problems).to have(0).problems
       end
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: puppet-ghostbuster
 version: !ruby/object:Gem::Version
-  version: 0.7.0
+  version: 0.7.1
 platform: ruby
 authors:
 - Camptocamp