puppet-ghostbuster 0.4.0 → 0.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 65c4533a993b62ad0194d46774be738437de8a38
-  data.tar.gz: d68124e057a0aee869af77cbf7923b8d3a47eaa3
+  metadata.gz: fe3d424e7d8e045262acebbde7420fe8da3e00a6
+  data.tar.gz: c7cced00812e60526b634819c5adb054ea8bb444
 SHA512:
-  metadata.gz: af14464b230b01dbde502d0f69f94d0be802ade503bf0067d660f557189419388534e2f936438a0249d480447ba2384a399a60c383530dfad2bcc2c9ff7319e7
-  data.tar.gz: 2884410e432f51d41c39bcb0f2e21cd164f788de919dd66c7057bc4842ac1bb71be20e90699140c0f78de96459d7958a1811077c653c46aed6956dbc8dbf434f
+  metadata.gz: 03b601bcf25c8fc053370f4a91f23c94e2422c94406045879617899ec75dc562d6051bb0b6e6e4f7a8dbe90f5579bc2be6e447f99195f3acd472d17c30b824c6
+  data.tar.gz: 11bb6306ee9dccc67810af7b8d12c71a2a8584d3830fa4d051fb9ec01d31416191907a9cbe2adcb341a5995d393384714962c5d83afb3c2e2a4488ef5246a8de

data/CHANGELOG.md

@@ -1,5 +1,12 @@
 # Change Log
 
+## [0.4.1](https://rubygems.org/gems/puppet-ghostbuster/versions/0.4.1) (2016-05-02)
+[Full Changelog](https://github.com/camptocamp/puppet-ghostbuster/compare/0.4.0...0.4.1)
+
+**Fixed bugs:**
+
+- Fix unused files detection[\#20](https://github.com/camptocamp/puppet-ghostbuster/pull/20) ([mcanevet](https://github.com/mcanevet))
+
 ## [0.4.0](https://rubygems.org/gems/puppet-ghostbuster/versions/0.4.0) (2016-04-28)
 [Full Changelog](https://github.com/camptocamp/puppet-ghostbuster/compare/0.3.0...0.4.0)
 

data/lib/puppet-ghostbuster/version.rb

@@ -1,3 +1,3 @@
 class PuppetGhostbuster
-  VERSION = '0.4.0'
+  VERSION = '0.4.1'
 end

data/lib/puppet-ghostbuster.rb

@@ -147,20 +147,18 @@ class PuppetGhostbuster
       next unless File.file?(file)
       module_name, file_name = file.match(/.*\/([^\/]+)\/files\/(.+)$/).captures
       count = 0
-      Dir["#{path}"].each do |caller_file|
-        next unless File.file?(caller_file)
-        begin
-          if caller_file =~ /\.pp$/
-            if match = caller_file.match(/.*\/([^\/]+)\/manifests\/.+$/)
-              manifest_module_name = match.captures[0]
-              if manifest_module_name == module_name
-                count += File.readlines(caller_file).grep(/["']\$\{module_name\}\/#{file_name}["']/).size
-              end
-            end
+      manifests.each do |manifest|
+        if File.symlink?(manifest)
+          @@logger.warn "  Skipping symlink #{manifest}"
+          next
+        end
+        if match = caller_file.match(/.*\/([^\/]+)\/manifests\/.+$/)
+          manifest_module_name = match.captures[0]
+          if manifest_module_name == module_name
+            count += File.readlines(caller_file).grep(/["']\$\{module_name\}\/#{file_name}["']/).size
           end
-          count += File.readlines(caller_file).grep(/#{module_name}\/#{file_name}/).size
-        rescue ArgumentError
         end
+        count += File.readlines(caller_file).grep(/#{module_name}\/#{file_name}/).size
       end
       @@issues << { :title => "[GhostBuster] File #{module_name}/#{file_name} seems unused", :body => file } if count == 0
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: puppet-ghostbuster
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.4.1
 platform: ruby
 authors:
 - Camptocamp
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-04-28 00:00:00.000000000 Z
+date: 2016-05-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: coveralls