puppet-ghostbuster 0.1.2 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d0a4d2d4d4774a408dccc8f8b819bc54881d776b
-  data.tar.gz: 4a3dc52fc6781c0c8a6349bbe0368fdfb46bfc42
+  metadata.gz: e0e4553e6823762987d5f037c2f398496ba8e116
+  data.tar.gz: d45d5765efb485e178d0ac361a3caed3d14bc297
 SHA512:
-  metadata.gz: 7e8510218d6e6ef39dd62f489cda59583ac1602eb8808add21484ed7d7c5048b3a67d38cd481e259a9ac98ae63a848f340fa77ca1101aff8676816af2f80e333
-  data.tar.gz: ed3a5af6d8ec4b628f2805e28bd7fcdbe85b001f274f0ef0245269d5c504bbb8d0ea7ffc2aaa59f56f75cc17860f559f23b2b9a9d27a7deabc4d268ab21e0100
+  metadata.gz: 727bc5028c12732e1a9fcf542fe250b6c13a3a6d7f0bcbddbf0f098cd5d6d86a2b5ee7a09c0d090664093a5c756c504f138d02c5d2f6010170976343dd851162
+  data.tar.gz: dd7a8967c4651125dd743475fdaddd255c28bfe92eceff07401004cedf0b516023d68257d5a3b681857bf7983ec6ac70527b1a6ec07779c259da2a0ccd9c1e20

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # Change Log
 
+## [0.1.2](https://github.com/camptocamp/puppet-ghostbuster/releases/tag/0.1.3) (2015-04-23)
+
+- Add --log-level option and debug
+
 ## [0.1.2](https://github.com/camptocamp/puppet-ghostbuster/releases/tag/0.1.2) (2015-04-23)
 
 **Fixed bugs:**

data/README.md

@@ -12,7 +12,7 @@ Classes used 0 time should be removed.
 Usage
 -----
 
-This gem needs enough permissions to read puppet configuration files and private key.
+If you want to read default options and private key from puppet configuration, this gem needs to have root (puppet) permissions.
 ```
 sudo bundle exec puppet-ghostbuster
 ```

data/lib/puppet-ghostbuster/bin.rb

@@ -19,7 +19,7 @@ class PuppetGhostbuster::Bin
       puts "puppet-ghostbuster #{PuppetGhostbuster::VERSION}"
       return 0
     end
-   
+
     if @args[0].nil?
       PuppetGhostbuster.new().run
     else

data/lib/puppet-ghostbuster/configuration.rb

@@ -4,7 +4,7 @@ class PuppetGhostbuster
   class Configuration
 
     def initialize
-      Puppet.initialize_settings 
+      Puppet.initialize_settings
     end
 
     # Public: Catch situations where options are being set for the first time
@@ -86,6 +86,7 @@ class PuppetGhostbuster
     # Returns nothing.
     def defaults
       settings.clear
+      self.loglevel = Logger::INFO
       self.puppetdbserverurl = "https://#{Puppet[:server]}:8081"
       self.hostprivkey = Puppet[:hostprivkey]
       self.hostcert    = Puppet[:hostcert]

data/lib/puppet-ghostbuster/optparser.rb

@@ -29,12 +29,17 @@ class PuppetGhostbuster::OptParser
         opts.load(file)
       end
 
-      opts.on('--error-level LEVEL', [:all, :warning, :error],
-              'The level of error to return (warning, error or all).') do |el|
-        PuppetGhostbuster.configuration.error_level = el
+      opts.on('--log-level LEVEL', [:debug, :info, :warn, :error],
+              'The level of verbosity (debug, info, warn or error)') do |loglevel|
+        PuppetGhostbuster.configuration.loglevel=Logger::DEBUG if loglevel==:debug
+        PuppetGhostbuster.configuration.loglevel=Logger::INFO  if loglevel==:info
+        PuppetGhostbuster.configuration.loglevel=Logger::WARN  if loglevel==:warn
+        PuppetGhostbuster.configuration.loglevel=Logger::ERROR if loglevel==:error
       end
 
-      opts.on('-s', '--puppetdburl SERVER', 'puppet db server url to connect to.') do |s|
+      opts.on('-s', '--puppetdburl SERVER',
+              'puppet db server url to connect to.',
+              'Defaults to the puppet server found in puppet configuration') do |s|
         PuppetGhostbuster.configuration.puppetdbserverurl = s
       end
 

data/lib/puppet-ghostbuster/version.rb

@@ -1,3 +1,3 @@
 class PuppetGhostbuster
-  VERSION = '0.1.2'
+  VERSION = '0.1.3'
 end

data/lib/puppet-ghostbuster.rb

@@ -31,7 +31,6 @@ class PuppetGhostbuster
     self.class.configuration
   end
 
-
   def self.puppetdbserverfilename
     return configuration.puppetdbserverurl.gsub(/[:\/]/,'_')
   end
@@ -55,7 +54,8 @@ class PuppetGhostbuster
     end
   end
 
-  def self.client 
+  def self.client
+    @@logger.debug "Connecting to puppet DB #{configuration.puppetdbserverurl}"
     PuppetDB::Client.new({
       :server => configuration.puppetdbserverurl,
       :pem    => {
@@ -78,8 +78,13 @@ class PuppetGhostbuster
   end
 
   def find_unused_classes
+    @@logger.info 'Now trying to find unused classes'
     manifests.each do |file|
-      next if File.symlink?(file)
+      @@logger.debug "  file #{file}."
+      if File.symlink?(file)
+        @@logger.warn "  Skipping symlink #{file}"
+        next
+      end
       if c = File.readlines(file).grep(/^class\s+([^\s\(\{]+)/){$1}[0]
         class_name = c.split('::').map(&:capitalize).join('::')
         count = self.class.used_classes.select { |klass| klass == class_name }.size
@@ -89,8 +94,12 @@ class PuppetGhostbuster
   end
 
   def find_unused_defines
+    @@logger.info 'Now trying to find unused defines'
     manifests.each do |file|
-      next if File.symlink?(file)
+      if File.symlink?(file)
+        @@logger.warn "  Skipping symlink #{file}"
+        next
+      end
       if d = File.readlines(file).grep(/^define\s+([^\s\(\{]+)/){$1}[0]
         define_name = d.split('::').map(&:capitalize).join('::')
         count = self.class.client.request('resources', [:'=', 'type', define_name]).data.size
@@ -100,12 +109,16 @@ class PuppetGhostbuster
   end
 
   def find_unused_templates
+    @@logger.info 'Now trying to find unused templates'
     templates.each do |template|
       next unless File.file?(template)
       module_name, template_name = template.match(/.*\/([^\/]+)\/templates\/(.+)$/).captures
       count = 0
       manifests.each do |manifest|
-        next if File.symlink?(manifest)
+        if File.symlink?(manifest)
+          @@logger.warn "  Skipping symlink #{manifest}"
+          next
+        end
         if match = manifest.match(/.*\/([^\/]+)\/manifests\/.+$/)
           manifest_module_name = match.captures[0]
           count += File.readlines(manifest).grep(/["']\$\{module_name\}\/#{template_name}["']/).size if manifest_module_name == module_name
@@ -117,6 +130,7 @@ class PuppetGhostbuster
   end
 
   def find_unused_files
+    @@logger.info 'Now trying to find unused files'
     files.each do |file|
       next unless File.file?(file)
       module_name, file_name = file.match(/.*\/([^\/]+)\/files\/(.+)$/).captures
@@ -142,6 +156,10 @@ class PuppetGhostbuster
 
   def initialize(path = '.')
     self.path = path
+    @@logger = Logger.new(STDERR).tap do |log|
+      log.progname = 'PuppetGhostbuster'
+      log.level=PuppetGhostbuster.configuration.loglevel
+    end
   end
 
   def run

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: puppet-ghostbuster
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - Camptocamp
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-04-23 00:00:00.000000000 Z
+date: 2015-04-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: json