puppet-debugger 1.4.0 → 1.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 588f4c8928181443aa7e98e820530d79c9efb705a7a9b95f5e447066d87cac96
-  data.tar.gz: 109e0616bd93547ea2e6975bbdd4e58b27e92bcc9533b206c4194d37be6a49e8
+  metadata.gz: c05bac6e844493bd642e75761c8aa9362e7b1858c7b425c304f7f9babd973965
+  data.tar.gz: c067b4abb4088b86050f77afecc23bd14b75a1ae58f8136e4407ac2e7002b58e
 SHA512:
-  metadata.gz: 592067114dea290451e1933655d0f72ee254c8c7fb063e5bcf7901d2f3caf9afb45c7f370a5c6cbbc2c9dfff22e35a2a60d776ad94e4ba5b6a6b476e2bd82c29
-  data.tar.gz: b7b2a003cdc1051f58e7be727ffcdd61d5d888312eac091015c54ea1ea137ba23ad4ac2d2c1514b0a4dd5d1ef7872a850dbf576b67d25ec49f419f0d6995c3b1
+  metadata.gz: 001e82eafc7e251adb9fe445a7657cdf9171d301621e848c416dcbd75c9e39965f0e50058ec177a03b895e28b23ed5e5ae618b1279272c6a318224dc0a56b990
+  data.tar.gz: 95858260c3286ac3b1f2eed2a8b0a01e6a1554426c981483b680ce3089119468bed28a58f5171e10b9e93f66d1b677d629b667902894949ea34674f024eb1bc8

data/.ruby-version

@@ -1 +1 @@
-2.6.5
+3.4.2

data/CHANGELOG.md

@@ -1,6 +1,10 @@
 # Puppet Debugger Changelog
 
 ## Unreleased
+
+## 1.5 (3/28/25)
+- Fix legacy facterdb fact issue
+
 ## 1.4
 - Add support for puppet 8
 - Add support for ruby 3 (tested with 3.0-3.4)

data/lib/puppet-debugger/support/facts.rb

@@ -12,7 +12,7 @@ module PuppetDebugger
       end
 
       def default_facterdb_filter
-        "operatingsystem=#{facter_os_name} and operatingsystemrelease=#{facter_os_version} and architecture=x86_64 and facterversion=#{facter_version}"
+        "os.name=#{facter_os_name} and os.release.major=#{facter_os_version} and os.architecture=x86_64 and facterversion=#{facter_version}"
       end
 
       def facter_version
@@ -21,19 +21,15 @@ module PuppetDebugger
 
       # return the correct supported version of facter facts
       def default_facter_version
-        if Gem::Version.new(Puppet.version) >= Gem::Version.new(4.4)
-          '/^3\.1/'
-        else
-          '/^2\.4/'
-        end
+        '/^4/'
       end
 
       def facter_os_name
-        ENV['DEBUGGER_FACTER_OS_NAME'] || 'Fedora'
+        ENV['DEBUGGER_FACTER_OS_NAME'] || 'Rocky'
       end
 
       def facter_os_version
-        ENV['DEBUGGER_FACTER_OS_VERSION'] || '23'
+        ENV['DEBUGGER_FACTER_OS_VERSION'] || '8'
       end
 
       def set_facts(value)
@@ -49,7 +45,8 @@ module PuppetDebugger
           message = <<~OUT
             Using filter: #{dynamic_facterdb_filter}
             Bad FacterDB filter, please change the filter so it returns a result set.
-            See https://github.com/camptocamp/facterdb/#with-a-string-filter
+            Use puppet debugger --no-facterdb to disable facterdb.
+            See https://github.com/voxpupuli/facterdb/#with-a-string-filter
           OUT
           raise PuppetDebugger::Exception::BadFilter, message: message
         end

data/lib/puppet-debugger/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module PuppetDebugger
-  VERSION = '1.4.0'
+  VERSION = '1.5.0'
 end

data/spec/facts_spec.rb

@@ -8,7 +8,7 @@ describe 'facts' do
   end
 
   let(:puppet_version) do
-    '4.5.3'
+    '8.1'
   end
 
   let(:facter_version) do
@@ -19,28 +19,9 @@ describe 'facts' do
     allow(Puppet).to receive(:version).and_return(puppet_version)
   end
 
-  describe '2.4' do
-    before(:each) do
-      ENV['DEBUGGER_FACTERDB_FILTER'] = nil
-    end
-    let(:puppet_version) do
-      '4.2.0'
-    end
-    it 'returns 2.4' do
-      expect(facter_version).to eq('/^2\.4/')
-    end
-    it 'return default filter' do
-      expect(debugger.dynamic_facterdb_filter).to eq('operatingsystem=Fedora and operatingsystemrelease=23 and architecture=x86_64 and facterversion=/^2\\.4/')
-    end
-    it 'get node_facts' do
-      expect(debugger.node_facts).to be_instance_of(Hash)
-    end
-    it 'has fqdn' do
-      expect(debugger.node_facts[:fqdn]).to eq('foo.example.com')
-    end
-  end
 
-  describe '3.1' do
+
+  describe '4' do
     before(:each) do
       ENV['DEBUGGER_FACTERDB_FILTER'] = nil
     end
@@ -56,11 +37,11 @@ describe 'facts' do
     it 'has fqdn' do
       expect(debugger.node_facts[:fqdn]).to eq('foo.example.com')
     end
-    it 'returns 3.1' do
-      expect(facter_version).to eq('/^3\.1/')
+    it 'returns 4' do
+      expect(facter_version).to eq('/^4/')
     end
     it 'return default filter' do
-      expect(debugger.dynamic_facterdb_filter).to eq('operatingsystem=Fedora and operatingsystemrelease=23 and architecture=x86_64 and facterversion=/^3\\.1/')
+      expect(debugger.dynamic_facterdb_filter).to eq("os.name=Rocky and os.release.major=8 and os.architecture=x86_64 and facterversion=/^4/")
     end
   end
 
@@ -78,10 +59,10 @@ describe 'facts' do
     end
     describe 'good filter' do
       before(:each) do
-        ENV['DEBUGGER_FACTERDB_FILTER'] = 'facterversion=/^3\.1/'
+        ENV['DEBUGGER_FACTERDB_FILTER'] = 'facterversion=/^4.0.52/'
       end
       it 'return filter' do
-        expect(debugger.dynamic_facterdb_filter).to eq('facterversion=/^3\\.1/')
+        expect(debugger.dynamic_facterdb_filter).to eq('facterversion=/^4.0.52/')
       end
     end
   end

data/spec/input_responders/functions_spec.rb

@@ -43,6 +43,7 @@ describe :functions do
     debugger_output = /HELLO/
     debugger.handle_input("swapcase('hello')")
     expect(output.string).to match(debugger_output)
+    # did you run? bundle exec puppet module install puppetlabs-stdlib
   end
 
   it '#function_obj with native function' do

data/spec/spec_helper.rb

@@ -32,7 +32,8 @@ $LOAD_PATH.unshift(File.dirname(__FILE__))
 
 require 'rspec'
 require 'puppet-debugger'
-ENV['REPL_FACTERDB_FILTER'] = 'operatingsystem=Fedora and operatingsystemrelease=23 and architecture=x86_64 and facterversion=/^2\\.4/'
+
+ENV['REPL_FACTERDB_FILTER'] = 'os.name=Rocky and os.release.major=8 and architecture=x86_64 and facterversion=/^4/'
 # Requires supporting files with custom matchers and macros, etc,
 # in ./support/ and its subdirectories.
 Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].sort.each { |f| require f }

data/test_matrix.rb

@@ -23,7 +23,7 @@ def run_container(image, puppet_version)
 end
 
 def ci_data
-  @ci_data ||= YAML.load_file(File.expand_path('.gitlab-ci.yml'))
+  @ci_data ||= YAML.load_file(File.expand_path('.gitlab-ci.yml'), aliases: true)
 end
 
 def matrix

metadata

@@ -1,14 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: puppet-debugger
 version: !ruby/object:Gem::Version
-  version: 1.4.0
+  version: 1.5.0
 platform: ruby
 authors:
 - Corey Osman
-autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-01-18 00:00:00.000000000 Z
+date: 2025-03-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: awesome_print
@@ -307,7 +306,6 @@ licenses:
 - MIT
 metadata:
   allowed_push_host: https://rubygems.org
-post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -322,8 +320,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.10
-signing_key:
+rubygems_version: 3.6.2
 specification_version: 4
 summary: A repl based debugger for the puppet language
 test_files: []