puppet-check 1.3.0 → 1.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2ce83eaa817c69d2ca4cd5219571bc0af2d0e125
-  data.tar.gz: 34afb49f0e47a20d75417dd11d5f2d277192394b
+  metadata.gz: 5eed739fa10d5c5223812d0e88edf139d4c5e0e7
+  data.tar.gz: b6cc39fa5d43da1a090ca7be86315876285d94b7
 SHA512:
-  metadata.gz: 1d5e0aae72d0fd85ac9332c2abbccb16d5000c458677ade54adac994a343037301f7abc123245a582ecbd1b151cd52f633264d43d1fe815895fa4f0af58ed602
-  data.tar.gz: 3ea14379bdcd682feedbdf10a82c2939f175832c2794ebc9fb81d0e673703d8f354c63664a4cbc6ce31380829a306424033e1190b0489e29ac58581e17796d46
+  metadata.gz: c259d0803a2fae163241ef523e6c326b402be1d7363929adf857db87b2fc82b1f9af5dbe673a4eaf6ce0fee6ec4b3464f0931f5e000e97e3fa3e15fef913f926
+  data.tar.gz: 3159e4d695987cd9f4ccde352bb69a965fedc3204fdf7fbced757b93f9c777f49ef9408fc8189d71aebd78bbf7f9490c6a0382b43aec1b9a36c80186f1dae7ed

data/CHANGELOG.md

@@ -1,18 +1,18 @@
 ### 1.4.0 (Roadmap)
-- rudimentary catalog compilation testing? (only for Puppet4)
-- minimum Puppet version increased from 3.4 to 3.7.
-- rakefile interface with puppet-lint, rubocop, reek
-- rspec puppet stubbing
-- infrataster and analogous docker task like thing ripienaar did?
-- some multithreading for speedup
+- optional dep octocatalog-diff interface (minor)
+- minimum Puppet version increased from 3.4 to 3.7 (minor)
+- rakefile interface with puppet-lint, rubocop, reek (minor)
+- rspec puppet stubbing (minor)
+- acceptance testing with vagrant/docker+serverspec (minor)
+- improved json and yaml output formats support (file arrays become file hashes and output results further handles formatting) (minor; this would be a big refactoring effort)
+- split syntax and style checks to separate methods for style (patch)
+- add additional hiera checks (patch)
 
-### 1.3.1 (Roadmap)
-- split syntax and style checks to separate methods for speedup
-- more args, fewer self accessors
-- improved json and yaml output formats support (file arrays become file hashes and output results further handles formatting)
-- metadata.json checks for dependency upper bounds, dependencies/operatingsystem_support as array of hashes, and operatingsystem and operatingsystem_release within operatingsystem_support
-- do another reek and rubocop check
-- add additional hiera checks
+### 1.3.1
+- For the git and mercurial methods of downloading external module dependencies as spec fixtures, the module is now updated if it is already present and previously retrieved with git or mercurial respectively. Previously, a fresh clone was always attempted.
+- Additional syntax and style checks within the `operatingsystem_support`, `requirements`, and `dependencies` hashes in `metadata.json`.
+- Reek is now required dependency for all Ruby versions and locked to 3.11 for Ruby 2.0.
+- Slight code cleanup and optimization.
 
 ### 1.3.0
 - Minimum Ruby version increased from 1.9.3 to 2.0.0.
@@ -21,7 +21,7 @@
 - Support for outputting the results in YAML or JSON formats.
 - Additional style check for `metadata.json`.
 - Slight code cleanup and optimization.
-- Block hieradata checks from excuting on `hiera.yaml`.
+- Block hieradata checks from executing on `hiera.yaml`.
 
 ### 1.2.1
 - Code and output cleanup.

data/README.md

@@ -6,6 +6,7 @@
   - [CLI](#cli)
   - [Rake](#rake)
   - [Docker](#docker)
+  - [Vagrant](#vagrant)
   - [Exit Codes](#exit-codes)
   - [Optional Dependencies](#optional-dependencies)
 - [Contributing](#contributing)
@@ -112,14 +113,19 @@ The following files have unrecognized formats and therefore were not processed:
 - Puppetlabs Spec Helper has no CLI.
 - Puppetlabs Spec Helper intrinsically only executes spec tests against one module at a time.
 - Puppetlabs Spec Helper requires an additional config file for RSpec Puppet support.
+- Puppetlabs Spec Helper does not update external module dependencies in a stateful/persistent workspace and fails gracefully instead.
+- Puppetlabs Spec Helper requires extra configuration items to setup self-module RSpec testing.
 
 It is worth nothing that there is no current development objective for Puppet Check to achieve the same advanced level of robustness for spec testing that Puppetlabs Spec Helper enables. If you are performing standard spec testing on your Puppet code and data, then Puppet Check's spec testing is a fantastic lightweight and faster alternative to Puppetlabs Spec Helper. If you require advanced and intricate capabilities in your spec testing (e.g. direct interfacing to the `Puppet::Parser::Scope` API), then you will likely prefer Puppetlabs Spec Helper's spec testing in conjunction with Puppet Check's file validation.
 
 ## Usage
 Puppet Check requires `ruby >= 2.0.0`, `puppet >= 3.4`, and `puppet-lint >= 2.0.0`. All other dependencies should be fine with various versions. Puppet Check can be used either with a CLI or Rake tasks. Please note both interfaces will ignore any directories named `fixtures` or specified paths with that directory during file checks and spec tests.
 
+#### Reek
+Reek dropped support for Ruby 2.0 when it went to 4.0. Since dependencies by Ruby version are allowed in Gemfiles but not gemspecs, this means that PuppetCheck installed with `bundler` will automatically pick up the correct version of Reek for your Ruby version and install it. If you are installing PuppetCheck via `gem`, then you can install reek normally with `gem` with Ruby >= 2.1, but you will need to specify `gem install reek -v 3.11` if you are using Ruby 2.0.
+
 #### Important Note for Ruby 1.9.3 and PuppetCheck <= 1.2.1
-If you are using Ruby 1.9.3, there is an issue where `Hiera <= 3.2.0` has an unspecified version dependency on JSonPure. Since JSonPure 2.0.2 requires `ruby >= 2.0.0`, this breaks Hiera installs on Ruby 1.9.3, which breaks Puppet installs, which breaks PuppetCheck installs. Therefore, you will need to either restrict your installed version of JSonPure to something lower than 2.0.2 if you are using Ruby 1.9.3, or use `Hiera >= 3.2.1`.
+If you are using Ruby 1.9.3 (and therefore also PuppetCheck <= 1.2.1), there is an issue where `Hiera <= 3.2.0` has an unspecified version dependency on JSonPure. Since JSonPure 2.0.2 requires `ruby >= 2.0.0`, this breaks Hiera installs on Ruby 1.9.3, which breaks Puppet installs, which breaks PuppetCheck installs. Therefore, you will need to either restrict your installed version of JSonPure to something lower than 2.0.2 if you are using Ruby 1.9.3, or use `Hiera >= 3.2.1`.
 
 ### CLI
 ```
@@ -137,7 +143,7 @@ The command line interface enables the ability to select the Puppet future parse
 
 Example:
 ```
-puppet-check -s --puppet-lint no-hard_tabs-check,no-140chars-check --rubocop Metrics/LineLength,Style/Encoding path/to/code_and_data
+puppet-check -s --puppet-lint no-hard_tabs-check,no-140chars-check --rubocop Metrics/LineLength,Style/Encoding -o yaml path/to/code_and_data
 ```
 
 ### Rake
@@ -156,7 +162,7 @@ You can add style checks to and select the future parser for the `rake puppetche
 ```ruby
 PuppetCheck.style_check = true
 PuppetCheck.future_parser = true
-PuppetCheck.output_format = yaml
+PuppetCheck.output_format = 'yaml'
 ```
 
 Please note that `rspec` does not support yaml output and therefore would still use the default 'progress' formatter even if `yaml` is specified as the format option to Puppet Check.
@@ -208,6 +214,8 @@ Example:
 ]
 ```
 
+Note that `args` will be ignored during `git pull` and `hg pull/hg update` when the modules are updated instead of freshly cloned.
+
 #### puppetcheck:beaker
 The spec tests will be executed against everything that matches the pattern `**/acceptance`. Any of these directories inside of a `fixtures` directory will be ignored. This means everything in the current path that appears to be a Puppet module acceptance test for your module (not dependencies) will be regarded as such and executed during this rake task.
 
@@ -236,15 +244,40 @@ ENTRYPOINT ["rake", "puppetcheck"]
 
 You can also build your own general container for testing various Puppet situations by removing the last three lines. You can then test each module, directory environment, etc. on top of that container by merely adding and modifying the final three lines to a Dockerfile that uses the container you built from the first four lines. This is recommended usage due to being very efficient and stable.
 
+### Vagrant
+
+As an alternative to Docker, you can also use Vagrant for quick and disposable testing, but it is not as portable as Docker for these testing purposes. Below is an example Vagrantfile for this purpose.
+
+```ruby
+Vagrant.configure(2) do |config|
+  # a reliable and small box at the moment
+  config.vm.box = 'fedora/23'
+
+  config.vm.provision 'shell', inline: <<-SHELL
+    # cd to 'sync' if this is recent Vagrant; cd to '/vagrant' if this is older Vagrant
+    cd sync || cd /vagrant
+    # you need ruby and any other extra dependencies that come from packages; in this example we install git to use it for downloading external module dependencies
+    sudo dnf install ruby rubygems git -y
+    # you need puppet-check and any other extra dependencies that come from gems; in this example we install reek because the ruby ABI is 2.2 and then rspec-puppet and rake for extra testing
+    sudo gem install --no-rdoc --no-ri puppet-check reek rspec-puppet rake
+    # this is needed for the ruby json parser to not flip out on fresh os installs for some reason (change encoding value as necessary)
+    export LANG='en_US.UTF-8'
+    # execute your tests; in this example we are executing the full suite of tests
+    rake puppetcheck
+  SHELL
+end
+```
+
+To overcome the lack of convenient portability, you could try spinning up the Vagrant instance at the top level of your Puppet code and data and then descend into directories to execute tests as necessary. Cleverness or patience will be necessary if you decide to use Vagrant for testing and desire portability.
+
 ### Exit Codes
 - 0: PuppetCheck exited with no internal exceptions or errors in your Puppet code and data.
 - 1: PuppetCheck exited with an internal exception (takes preference over other non-zero exit codes) or failed spec test.
 - 2: PuppetCheck exited with one or more errors in your Puppet code and data.
 
 ### Optional dependencies
-- **reek**: will automatically (with `bundler`, otherwise manually) be installed as a dependency and checks enabled during style checks if your Ruby version is `>= 2.1.0`.
 - **rake**: install this if you want to use Puppet Check with `rake` tasks in addition to the CLI.
-- **rspec**: install this if you want to use Puppet Check to execute the spec tests for your ruby files during `rake`.
+- **rspec**: install this if you want to use Puppet Check to execute the spec tests for your Ruby files during `rake`.
 - **rspec-puppet**: install this if you want to use Puppet Check to execute the spec tests for your Puppet files during `rake`.
 - **beaker**: install this if you want to use Puppet Check to execute the acceptance tests during `rake`.
 - **git**: install this if you want to use Puppet Check to download external module dependencies with `git` commands during RSpec Puppet testing.

data/lib/puppet-check/cli.rb

@@ -21,7 +21,7 @@ class PuppetCheck::CLI
 
       # base options
       opts.on('--version', 'Display the current version.') do
-        puts 'puppet-check 1.3.0'
+        puts 'puppet-check 1.3.1'
         exit 0
       end
 

data/lib/puppet-check/data_parser.rb

@@ -50,9 +50,11 @@ class DataParser
             errors.push("Required field '#{key}' not found.") unless parsed.key?(key)
           end
 
-          # check for duplicate dependencies and requirements
+          # check for duplicate dependencies and requirements, and that both are an array of hashes if they exist
           %w(requirements dependencies).each do |key|
             next unless parsed.key?(key)
+            next errors.push("Field '#{key}' is not an array of hashes.") unless (parsed[key].is_a? Array) && (parsed[key].empty? || (parsed[key][0].is_a? Hash))
+
             names = []
             parsed[key].each do |req_dep|
               name = req_dep['name']
@@ -72,8 +74,37 @@ class DataParser
           next PuppetCheck.error_files.push("#{file}:\n#{errors.join("\n")}") unless errors.empty?
 
           # check for warnings
-          # check for operatingsystem_support
-          warnings.push('Recommended field \'operatingsystem_support\' not found.') unless parsed.key?('operatingsystem_support')
+          # check for operatingsystem_support hash array
+          if parsed.key?('operatingsystem_support')
+            # check if operatingsystem_support array is actually empty
+            if !(parsed['operatingsystem_support'].is_a? Array) || parsed['operatingsystem_support'].empty? || (!parsed['operatingsystem_support'].empty? && !(parsed['operatingsystem_support'][0].is_a? Hash))
+              warnings.push('Recommended field \'operatingsystem\' not found.')
+              warnings.push('Recommended field \'operatingsystemrelease\' not found.')
+            else
+              # check for operatingsystem string
+              if parsed['operatingsystem_support'][0].key?('operatingsystem')
+                warnings.push('Field \'operatingsystem\' is not a string.') unless parsed['operatingsystem_support'][0]['operatingsystem'].is_a? String
+              else
+                warnings.push('Recommended field \'operatingsystem\' not found.')
+              end
+              # check for operatingsystemrelease string array
+              if parsed['operatingsystem_support'][0].key?('operatingsystemrelease')
+                warnings.push('Field \'operatingsystemrelease\' is not a string array.') unless parsed['operatingsystem_support'][0]['operatingsystemrelease'][0].is_a? String
+              else
+                warnings.push('Recommended field \'operatingsystemrelease\' not found.')
+              end
+            end
+          else
+            warnings.push('Recommended field \'operatingsystem_support\' not found.')
+          end
+
+          # check for requirement and dependency upper bounds
+          %w(requirements dependencies).each do |key|
+            next if parsed[key].empty?
+            parsed[key].each do |req_dep|
+              warnings.push("'#{req_dep['name']}' is missing an upper bound.") unless req_dep['version_requirement'].include?('<')
+            end
+          end
 
           # check for spdx license (rubygems/util/licenses for rubygems >= 2.5 in the far future)
           if parsed.key?('license') && !SpdxLicenses.exist?(parsed['license']) && parsed['license'] !~ /[pP]roprietary/

data/lib/puppet-check/output_results.rb

@@ -16,17 +16,13 @@ class OutputResults
       print "\n\033[32mThe following files have no errors or warnings:\033[0m\n-- "
       puts PuppetCheck.clean_files.join("\n-- ")
     end
-    unless PuppetCheck.ignored_files.empty?
-      print "\n\033[36mThe following files have unrecognized formats and therefore were not processed:\033[0m\n-- "
-      puts PuppetCheck.ignored_files.join("\n-- ")
-    end
+    return if PuppetCheck.ignored_files.empty?
+    print "\n\033[36mThe following files have unrecognized formats and therefore were not processed:\033[0m\n-- "
+    puts PuppetCheck.ignored_files.join("\n-- ")
   end
 
   # output the results as yaml or json
   def self.markup
-    require 'yaml'
-    require 'json'
-
     # generate output hash
     hash = {}
     hash['errors'] = PuppetCheck.error_files unless PuppetCheck.error_files.empty?
@@ -36,8 +32,10 @@ class OutputResults
 
     # convert hash to markup language
     if PuppetCheck.output_format == 'yaml'
+      require 'yaml'
       puts Psych.dump(hash, indentation: 2)
     elsif PuppetCheck.output_format == 'json'
+      require 'json'
       puts JSON.pretty_generate(hash)
     else
       raise "puppet-check: Unsupported output format '#{PuppetCheck.output_format}' was specified."

data/lib/puppet-check/puppet_parser.rb

@@ -4,12 +4,12 @@ require_relative '../puppet-check'
 # executes diagnostics on puppet files
 class PuppetParser
   # checks puppet (.pp)
-  def self.manifest(files)
+  def self.manifest(files, future, style, pl_args)
     require 'puppet/face'
 
     # prepare the Puppet settings for the error checking
     Puppet.initialize_settings unless Puppet.settings.app_defaults_initialized?
-    Puppet[:parser] = 'future' if PuppetCheck.future_parser && (Puppet::PUPPETVERSION.to_i < 4)
+    Puppet[:parser] = 'future' if future && (Puppet::PUPPETVERSION.to_i < 4)
 
     files.each do |file|
       # setup error logging and collection
@@ -29,15 +29,15 @@ class PuppetParser
       Puppet::Util::Log.close_all
 
       # check puppet style
-      if PuppetCheck.style_check
+      if style
         require 'puppet-lint'
         require 'puppet-lint/optparser'
 
         # check for invalid arguments to PuppetLint
         begin
-          PuppetLint::OptParser.build.parse!(PuppetCheck.puppetlint_args.clone)
+          PuppetLint::OptParser.build.parse!(pl_args.clone)
         rescue OptionParser::InvalidOption
-          raise "puppet-lint: invalid option supplied among #{PuppetCheck.puppetlint_args.join(' ')}"
+          raise "puppet-lint: invalid option supplied among #{pl_args.join(' ')}"
         end
 
         # prepare the PuppetLint object for style checks
@@ -61,7 +61,7 @@ class PuppetParser
 
     files.each do |file|
       # puppet before version 4 cannot check template syntax
-      next PuppetCheck.ignored_files.push("#{file}: ignored due to Puppet < 4.0.0") if Puppet::PUPPETVERSION.to_i < 4
+      next PuppetCheck.ignored_files.push("#{file}: ignored due to Puppet < 4") if Puppet::PUPPETVERSION.to_i < 4
 
       # check puppet template syntax
       begin

data/lib/puppet-check/rspec_puppet_support.rb

@@ -4,6 +4,7 @@ class RSpecPuppetSupport
   # 'puppetcheck:spec' task invokes 'run'
   # 'run' invokes 'file_setup' always and 'dependency_setup' if metadata.json exists
   # 'dependency_setup' invokes 'git/forge/hg' if dependencies exist and git/forge/hg is download option
+  # 'git/forge/hg' downloads module fixture appropriately
 
   # prepare the spec fixtures directory for rspec-puppet testing
   def self.run
@@ -43,9 +44,8 @@ class RSpecPuppetSupport
     end
 
     # create spec_helper if missing
-    unless File.file?('spec/spec_helper.rb')
-      File.open('spec/spec_helper.rb', 'w') { |file| file.puts "require 'rspec-puppet/spec_helper'\n" }
-    end
+    return if File.file?('spec/spec_helper.rb')
+    File.open('spec/spec_helper.rb', 'w') { |file| file.puts "require 'rspec-puppet/spec_helper'\n" }
   end
 
   # setup the module dependencies for rspec-puppet testing
@@ -56,25 +56,27 @@ class RSpecPuppetSupport
     parsed = JSON.parse(File.read('metadata.json'))
 
     # grab dependencies if they exist
-    unless parsed['dependencies'].empty?
-      parsed['dependencies'].each do |dependency_hash|
-        # determine how the user wants to download the module dependency
-        if dependency_hash.key?('git')
-          git(dependency_hash['git'], dependency_hash['args'])
-        elsif dependency_hash.key?('forge')
-          forge(dependency_hash['forge'], dependency_hash['args'])
-        elsif dependency_hash.key?('hg')
-          hg(dependency_hash['hg'], dependency_hash['args'])
-        else
-          warn "#{dependency_hash['name']} has an unspecified, or specified but unsupported, download method."
-        end
+    return if parsed['dependencies'].empty?
+    parsed['dependencies'].each do |dependency_hash|
+      # determine how the user wants to download the module dependency
+      if dependency_hash.key?('git')
+        git(dependency_hash['git'], dependency_hash['args'])
+      elsif dependency_hash.key?('forge')
+        forge(dependency_hash['forge'], dependency_hash['args'])
+      elsif dependency_hash.key?('hg')
+        hg(dependency_hash['hg'], dependency_hash['args'])
+      else
+        warn "#{dependency_hash['name']} has an unspecified, or specified but unsupported, download method."
       end
     end
   end
 
   # download external module dependency with git
   def self.git(git_url, args = '')
-    system("git -C spec/fixtures/modules/ clone #{args} #{git_url}")
+    # establish path to clone module to
+    path = "spec/fixtures/modules/#{File.basename(git_url, '.git')}"
+    # is the module present and already cloned with git? do a pull; otherwise, do a clone
+    File.directory?("#{path}/.git") ? system("git -C #{path} pull") : system("git clone #{args} #{git_url} #{path}")
   end
 
   # download external module dependency with forge
@@ -84,6 +86,9 @@ class RSpecPuppetSupport
 
   # download external module dependency with hg
   def self.hg(hg_url, args = '')
-    system("hg --cwd spec/fixtures/modules/ clone #{args} #{hg_url}")
+    # establish path to clone module to
+    path = "spec/fixtures/modules/#{File.basename(hg_url)}"
+    # is the module present and already cloned with hg? do a pull and update; otherwise do a clone
+    File.directory?("#{path}/.hg") ? system("hg --cwd #{path} pull; hg --cwd #{path} update") : system("hg clone #{args} #{hg_url} #{path}")
   end
 end

data/lib/puppet-check/ruby_parser.rb

@@ -4,7 +4,7 @@ require_relative 'utils'
 # executes diagnostics on ruby files
 class RubyParser
   # checks ruby (.rb)
-  def self.ruby(files)
+  def self.ruby(files, style, rc_args)
     files.each do |file|
       # check ruby syntax
       begin
@@ -14,20 +14,18 @@ class RubyParser
         PuppetCheck.error_files.push("#{file}:\n#{err}")
       else
         # check ruby style
-        if PuppetCheck.style_check
+        if style
           require 'rubocop'
 
           # check RuboCop and collect warnings
-          rubocop_warnings = Utils.capture_stdout { RuboCop::CLI.new.run(PuppetCheck.rubocop_args + ['--format', 'emacs', file]) }
+          rubocop_warnings = Utils.capture_stdout { RuboCop::CLI.new.run(rc_args + ['--format', 'emacs', file]) }
           warnings = rubocop_warnings == '' ? '' : rubocop_warnings.split("#{File.absolute_path(file)}:").join('')
 
           # check Reek and collect warnings
-          if Gem::Version.new(RUBY_VERSION.dup) >= Gem::Version.new('2.1.0')
-            require 'reek'
-            require 'reek/cli/application'
-            reek_warnings = Utils.capture_stdout { Reek::CLI::Application.new([file]).execute }
-            warnings += reek_warnings.split("\n")[1..-1].map(&:strip).join("\n") unless reek_warnings == ''
-          end
+          require 'reek'
+          require 'reek/cli/application'
+          reek_warnings = Utils.capture_stdout { Reek::CLI::Application.new([file]).execute }
+          warnings += reek_warnings.split("\n")[1..-1].map(&:strip).join("\n") unless reek_warnings == ''
 
           # return warnings
           next PuppetCheck.warning_files.push("#{file}:\n#{warnings.strip}") unless warnings == ''
@@ -61,7 +59,7 @@ class RubyParser
   end
 
   # checks librarian puppet (Puppetfile/Modulefile) and misc ruby (Rakefile/Gemfile)
-  def self.librarian(files)
+  def self.librarian(files, style, rc_args)
     files.each do |file|
       # check librarian puppet syntax
       begin
@@ -71,14 +69,13 @@ class RubyParser
         PuppetCheck.error_files.push("#{file}:\n#{err}")
       # check librarian puppet style
       else
-        if PuppetCheck.style_check
+        if style
           require 'rubocop'
 
           # check Rubocop
-          rubocop_args = PuppetCheck.rubocop_args.clone
           # RuboCop is grumpy about non-snake_case filenames so disable the Style/FileName check
-          rubocop_args.include?('--except') ? rubocop_args[rubocop_args.index('--except') + 1] = "#{rubocop_args[rubocop_args.index('--except') + 1]},Style/FileName" : rubocop_args.concat(['--except', 'Style/FileName'])
-          warnings = Utils.capture_stdout { RuboCop::CLI.new.run(rubocop_args + ['--format', 'emacs', file]) }
+          rc_args.include?('--except') ? rc_args[rc_args.index('--except') + 1] = "#{rc_args[rc_args.index('--except') + 1]},Style/FileName" : rc_args.concat(['--except', 'Style/FileName'])
+          warnings = Utils.capture_stdout { RuboCop::CLI.new.run(rc_args + ['--format', 'emacs', file]) }
 
           # collect style warnings
           next PuppetCheck.warning_files.push("#{file}:\n#{warnings.split("#{File.absolute_path(file)}:").join('')}") unless warnings.empty?

data/lib/puppet-check.rb

@@ -33,7 +33,7 @@ class PuppetCheck
     files = self.class.parse_paths(paths)
 
     # parse the files
-    execute_parsers(files)
+    execute_parsers(files, self.class.future_parser, self.class.style_check, self.class.puppetlint_args, self.class.rubocop_args)
 
     # output the diagnostic results
     PuppetCheck.output_format == 'text' ? OutputResults.text : OutputResults.markup
@@ -64,12 +64,12 @@ class PuppetCheck
   end
 
   # categorize and pass the files out to the parsers to determine their status
-  def execute_parsers(files)
-    PuppetParser.manifest(files.select { |file| File.extname(file) == '.pp' })
+  def execute_parsers(files, future, style, pl_args, rc_args)
+    PuppetParser.manifest(files.select { |file| File.extname(file) == '.pp' }, future, style, pl_args)
     files.reject! { |file| File.extname(file) == '.pp' }
     PuppetParser.template(files.select { |file| File.extname(file) == '.epp' })
     files.reject! { |file| File.extname(file) == '.epp' }
-    RubyParser.ruby(files.select { |file| File.extname(file) == '.rb' })
+    RubyParser.ruby(files.select { |file| File.extname(file) == '.rb' }, style, rc_args)
     files.reject! { |file| File.extname(file) == '.rb' }
     RubyParser.template(files.select { |file| File.extname(file) == '.erb' })
     files.reject! { |file| File.extname(file) == '.erb' }
@@ -77,7 +77,7 @@ class PuppetCheck
     files.reject! { |file| File.extname(file) =~ /\.ya?ml$/ }
     DataParser.json(files.select { |file| File.extname(file) == '.json' })
     files.reject! { |file| File.extname(file) == '.json' }
-    RubyParser.librarian(files.select { |file| File.basename(file) =~ /(?:Puppet|Module|Rake|Gem)file$/ })
+    RubyParser.librarian(files.select { |file| File.basename(file) =~ /(?:Puppet|Module|Rake|Gem)file$/ }, style, rc_args)
     files.reject! { |file| File.basename(file) =~ /(?:Puppet|Module|Rake|Gem)file$/ }
     files.each { |file| self.class.ignored_files.push(file.to_s) }
   end

data/spec/fixtures/metadata_good/metadata.json

@@ -29,7 +29,5 @@
     }
   ],
   "description": "Standard Library for Puppet Modules",
-  "dependencies": [
-
-  ]
+  "dependencies": []
 }

data/spec/fixtures/metadata_style/metadata.json

@@ -10,7 +10,7 @@
   "requirements": [
     {
       "name": "pe",
-      "version_requirement": ">= 3.0.0 < 2015.4.0"
+      "version_requirement": ">= 3.0.0"
     },
     {
       "name": "puppet",
@@ -18,7 +18,5 @@
     }
   ],
   "description": "Standard Library for Puppet Modules",
-  "dependencies": [
-
-  ]
+  "dependencies": []
 }

data/spec/fixtures/metadata_style_two/metadata.json

@@ -0,0 +1,26 @@
+{
+  "name": "puppetlabs-stdlib",
+  "version": "4.11.0",
+  "author": "puppetlabs",
+  "summary": "Standard library of resources for Puppet modules.",
+  "license": "Apache-2.0",
+  "source": "https://github.com/puppetlabs/puppetlabs-stdlib",
+  "project_page": "https://github.com/puppetlabs/puppetlabs-stdlib",
+  "issues_url": "https://tickets.puppetlabs.com/browse/MODULES",
+  "operatingsystem_support": [],
+  "requirements": [
+    {
+      "name": "pe",
+      "version_requirement": ">= 3.0.0 < 2016.4"
+    },
+    {
+      "name": "puppet",
+      "version_requirement": ">=2.7.20 <5.0.0"
+    }
+  ],
+  "description": "Standard Library for Puppet Modules",
+  "dependencies": [
+    { "name": "puppetlabs/one", "version_requirement": ">= 3.2.0 < 5.0.0" },
+    { "name": "puppetlabs/two", "version_requirement": ">= 0.0.4" }
+  ]
+}

data/spec/fixtures/metadata_syntax/metadata.json

@@ -11,5 +11,6 @@
     {"name": "puppetlabs/nothing", "version_requirement": ">=1.1.1 < 2.2.2"},
     {"name": "puppetlabs/nothing", "version_requirement": ">=1.1.1 < 2.2.2"}
   ],
+  "requirements": ["not an array of hashes"],
   "checksum": "foo"
 }

data/spec/puppet-check/data_parser_spec.rb

@@ -38,14 +38,20 @@ describe DataParser do
     end
     it 'puts a bad metadata json file in the error files array' do
       DataParser.json([fixtures_dir + 'metadata_syntax/metadata.json'])
-      expect(PuppetCheck.error_files[0]).to match(%r{^#{fixtures_dir}metadata_syntax/metadata.json:\nRequired field.*\nDuplicate dependencies.*\nDeprecated field.*\nSummary exceeds})
+      expect(PuppetCheck.error_files[0]).to match(%r{^#{fixtures_dir}metadata_syntax/metadata.json:\nRequired field.*\nField 'requirements'.*\nDuplicate dependencies.*\nDeprecated field.*\nSummary exceeds})
       expect(PuppetCheck.warning_files).to eql([])
       expect(PuppetCheck.clean_files).to eql([])
     end
     it 'puts a bad style metadata json file in the warning files array' do
       DataParser.json([fixtures_dir + 'metadata_style/metadata.json'])
       expect(PuppetCheck.error_files).to eql([])
-      expect(PuppetCheck.warning_files[0]).to match(%r{^#{fixtures_dir}metadata_style/metadata.json:\n.*operatingsystem_support.*\nLicense identifier})
+      expect(PuppetCheck.warning_files[0]).to match(%r{^#{fixtures_dir}metadata_style/metadata.json:\n.*operatingsystem_support.*\n'pe' is missing an upper bound.\nLicense identifier})
+      expect(PuppetCheck.clean_files).to eql([])
+    end
+    it 'puts another bad style metadata json file in the warning files array' do
+      DataParser.json([fixtures_dir + 'metadata_style_two/metadata.json'])
+      expect(PuppetCheck.error_files).to eql([])
+      expect(PuppetCheck.warning_files[0]).to match(%r{^#{fixtures_dir}metadata_style_two/metadata.json:\n.*operatingsystem.*\n.*operatingsystemrelease.*\n'puppetlabs/two' is missing an upper bound})
       expect(PuppetCheck.clean_files).to eql([])
     end
     it 'puts a good json file in the clean files array' do

data/spec/puppet-check/puppet_parser_spec.rb

@@ -6,52 +6,42 @@ describe PuppetParser do
     PuppetCheck.error_files = []
     PuppetCheck.warning_files = []
     PuppetCheck.clean_files = []
-    PuppetCheck.future_parser = false
-    PuppetCheck.style_check = false
-    PuppetCheck.puppetlint_args = []
   end
 
   context '.manifest' do
     it 'puts a bad syntax Puppet manifest in the error files array' do
-      PuppetParser.manifest([fixtures_dir + 'manifests/syntax.pp'])
+      PuppetParser.manifest([fixtures_dir + 'manifests/syntax.pp'], false, false, [])
       # expect(subject.instance_variable_get(:@error_files)[0]).to match(%r{^#{fixtures_dir}manifests/syntax.pp:.*syntax error})
       expect(PuppetCheck.error_files[0]).to match(%r{^#{fixtures_dir}manifests/syntax.pp:\nThis Variable has no effect.*\nIllegal variable name})
       expect(PuppetCheck.warning_files).to eql([])
       expect(PuppetCheck.clean_files).to eql([])
     end
     it 'puts a bad parser and lint style Puppet manifest in the warning files array' do
-      PuppetCheck.style_check = true
-      PuppetParser.manifest([fixtures_dir + 'manifests/style_parser.pp'])
+      PuppetParser.manifest([fixtures_dir + 'manifests/style_parser.pp'], false, true, [])
       expect(PuppetCheck.error_files).to eql([])
       expect(PuppetCheck.warning_files[0]).to match(%r{^#{fixtures_dir}manifests/style_parser.pp:\nUnrecognized escape sequence.*\nUnrecognized escape sequence.*\n.*double quoted string containing})
       expect(PuppetCheck.clean_files).to eql([])
     end
     it 'puts a bad lint style Puppet manifest in the warning files array' do
-      PuppetCheck.style_check = true
-      PuppetParser.manifest([fixtures_dir + 'manifests/style_lint.pp'])
+      PuppetParser.manifest([fixtures_dir + 'manifests/style_lint.pp'], false, true, [])
       expect(PuppetCheck.error_files).to eql([])
       expect(PuppetCheck.warning_files[0]).to match(%r{^#{fixtures_dir}manifests/style_lint.pp:\n.*double quoted string containing.*\n.*indentation of})
       expect(PuppetCheck.clean_files).to eql([])
     end
     it 'puts a bad style Puppet manifest in the clean files array when puppetlint_args ignores its warnings' do
-      PuppetCheck.style_check = true
-      PuppetCheck.puppetlint_args = ['--no-double_quoted_strings-check', '--no-arrow_alignment-check']
-      PuppetParser.manifest([fixtures_dir + 'manifests/style_lint.pp'])
+      PuppetParser.manifest([fixtures_dir + 'manifests/style_lint.pp'], false, true, ['--no-double_quoted_strings-check', '--no-arrow_alignment-check'])
       expect(PuppetCheck.error_files).to eql([])
       expect(PuppetCheck.warning_files).to eql([])
       expect(PuppetCheck.clean_files).to eql(["#{fixtures_dir}manifests/style_lint.pp"])
     end
     it 'puts a good Puppet manifest in the clean files array' do
-      PuppetCheck.style_check = true
-      PuppetParser.manifest([fixtures_dir + 'manifests/good.pp'])
+      PuppetParser.manifest([fixtures_dir + 'manifests/good.pp'], false, true, [])
       expect(PuppetCheck.error_files).to eql([])
       expect(PuppetCheck.warning_files).to eql([])
       expect(PuppetCheck.clean_files).to eql(["#{fixtures_dir}manifests/good.pp"])
     end
     it 'throws a well specified error for an invalid PuppetLint argument' do
-      PuppetCheck.style_check = true
-      PuppetCheck.puppetlint_args = ['--non-existent', '--does-not-exist']
-      expect { PuppetParser.manifest([fixtures_dir + 'manifests/style_lint.pp']) }.to raise_error(RuntimeError, 'puppet-lint: invalid option supplied among --non-existent --does-not-exist')
+      expect { PuppetParser.manifest([fixtures_dir + 'manifests/style_lint.pp'], false, true, ['--non-existent', '--does-not-exist']) }.to raise_error(RuntimeError, 'puppet-lint: invalid option supplied among --non-existent --does-not-exist')
     end
   end
 

data/spec/puppet-check/ruby_parser_spec.rb

@@ -6,45 +6,29 @@ describe RubyParser do
     PuppetCheck.error_files = []
     PuppetCheck.warning_files = []
     PuppetCheck.clean_files = []
-    PuppetCheck.style_check = false
-    PuppetCheck.rubocop_args = []
   end
 
   context '.ruby' do
     it 'puts a bad syntax ruby file in the error files array' do
-      RubyParser.ruby([fixtures_dir + 'lib/syntax.rb'])
+      RubyParser.ruby([fixtures_dir + 'lib/syntax.rb'], false, [])
       expect(PuppetCheck.error_files[0]).to match(%r{^#{fixtures_dir}lib/syntax.rb:\n.*syntax error})
       expect(PuppetCheck.warning_files).to eql([])
       expect(PuppetCheck.clean_files).to eql([])
     end
-    if Gem::Version.new(RUBY_VERSION.dup) >= Gem::Version.new('2.1.0')
-      it 'puts a bad style ruby file in the warning files array' do
-        PuppetCheck.style_check = true
-        RubyParser.ruby([fixtures_dir + 'lib/style.rb'])
-        expect(PuppetCheck.error_files).to eql([])
-        expect(PuppetCheck.warning_files[0]).to match(%r{^#{fixtures_dir}lib/style.rb:\n.*Useless assignment.*\n.*Use the new.*\n.*Do not introduce.*\n.*Prefer single.*\n.*is a writable attribute.*\n.*Issue has no descriptive comment})
-        expect(PuppetCheck.clean_files).to eql([])
-      end
-    else
-      it 'puts a bad style ruby file in the warning files array' do
-        PuppetCheck.style_check = true
-        RubyParser.ruby([fixtures_dir + 'lib/style.rb'])
-        expect(PuppetCheck.error_files).to eql([])
-        expect(PuppetCheck.warning_files[0]).to match(%r{^#{fixtures_dir}lib/style.rb:\n.*Useless assignment.*\n.*Use the new.*\n.*Do not introduce.*\n.*Prefer single})
-        expect(PuppetCheck.clean_files).to eql([])
-      end
+    it 'puts a bad style ruby file in the warning files array' do
+      RubyParser.ruby([fixtures_dir + 'lib/style.rb'], true, [])
+      expect(PuppetCheck.error_files).to eql([])
+      expect(PuppetCheck.warning_files[0]).to match(%r{^#{fixtures_dir}lib/style.rb:\n.*Useless assignment.*\n.*Use the new.*\n.*Do not introduce.*\n.*Prefer single.*\n.*is a writable attribute.*\n.*Issue has no descriptive comment})
+      expect(PuppetCheck.clean_files).to eql([])
     end
     it 'puts a bad style ruby file in the clean files array when rubocop_args ignores its warnings' do
-      PuppetCheck.style_check = true
-      PuppetCheck.rubocop_args = ['--except', 'Lint/UselessAssignment,Style/HashSyntax,Style/GlobalVars,Style/StringLiterals']
-      RubyParser.ruby([fixtures_dir + 'lib/rubocop_style.rb'])
+      RubyParser.ruby([fixtures_dir + 'lib/rubocop_style.rb'], true, ['--except', 'Lint/UselessAssignment,Style/HashSyntax,Style/GlobalVars,Style/StringLiterals'])
       expect(PuppetCheck.error_files).to eql([])
       expect(PuppetCheck.warning_files).to eql([])
       expect(PuppetCheck.clean_files).to eql(["#{fixtures_dir}lib/rubocop_style.rb"])
     end
     it 'puts a good ruby file in the clean files array' do
-      PuppetCheck.style_check = true
-      RubyParser.ruby([fixtures_dir + 'lib/good.rb'])
+      RubyParser.ruby([fixtures_dir + 'lib/good.rb'], true, [])
       expect(PuppetCheck.error_files).to eql([])
       expect(PuppetCheck.warning_files).to eql([])
       expect(PuppetCheck.clean_files).to eql(["#{fixtures_dir}lib/good.rb"])
@@ -80,29 +64,25 @@ describe RubyParser do
 
   context '.librarian' do
     it 'puts a bad syntax librarian Puppet file in the error files array' do
-      RubyParser.librarian([fixtures_dir + 'librarian_syntax/Puppetfile'])
+      RubyParser.librarian([fixtures_dir + 'librarian_syntax/Puppetfile'], false, [])
       expect(PuppetCheck.error_files[0]).to match(%r{^#{fixtures_dir}librarian_syntax/Puppetfile:\n.*syntax error})
       expect(PuppetCheck.warning_files).to eql([])
       expect(PuppetCheck.clean_files).to eql([])
     end
     it 'puts a bad style librarian Puppet file in the warning files array' do
-      PuppetCheck.style_check = true
-      RubyParser.librarian([fixtures_dir + 'librarian_style/Puppetfile'])
+      RubyParser.librarian([fixtures_dir + 'librarian_style/Puppetfile'], true, [])
       expect(PuppetCheck.error_files).to eql([])
       expect(PuppetCheck.warning_files[0]).to match(%r{^#{fixtures_dir}librarian_style/Puppetfile:\n.*Align the parameters.*\n.*Use the new})
       expect(PuppetCheck.clean_files).to eql([])
     end
     it 'puts a bad style librarian Puppet file in the clean files array when rubocop_args ignores its warnings' do
-      PuppetCheck.style_check = true
-      PuppetCheck.rubocop_args = ['--except', 'Style/AlignParameters,Style/HashSyntax']
-      RubyParser.librarian([fixtures_dir + 'librarian_style/Puppetfile'])
+      RubyParser.librarian([fixtures_dir + 'librarian_style/Puppetfile'], true, ['--except', 'Style/AlignParameters,Style/HashSyntax'])
       expect(PuppetCheck.error_files).to eql([])
       expect(PuppetCheck.warning_files).to eql([])
       expect(PuppetCheck.clean_files).to eql(["#{fixtures_dir}librarian_style/Puppetfile"])
     end
     it 'puts a good librarian Puppet file in the clean files array' do
-      PuppetCheck.style_check = true
-      RubyParser.librarian([fixtures_dir + 'librarian_good/Puppetfile'])
+      RubyParser.librarian([fixtures_dir + 'librarian_good/Puppetfile'], true, [])
       expect(PuppetCheck.error_files).to eql([])
       expect(PuppetCheck.warning_files).to eql([])
       expect(PuppetCheck.clean_files).to eql(["#{fixtures_dir}librarian_good/Puppetfile"])

data/spec/puppet-check_spec.rb

@@ -40,7 +40,7 @@ describe PuppetCheck do
 
     it 'correctly parses one directory and returns all of its files' do
       dir.each { |file| expect(File.file?(file)).to be true }
-      expect(dir.length).to eql(28)
+      expect(dir.length).to eql(29)
     end
 
     it 'correctly parses multiple directories and returns all of their files' do

data/spec/system/system_spec.rb

@@ -13,7 +13,7 @@ describe PuppetCheck do
       expect { cli }.not_to raise_exception
 
       expect(PuppetCheck.error_files.length).to eql(8)
-      expect(PuppetCheck.warning_files.length).to eql(8)
+      expect(PuppetCheck.warning_files.length).to eql(9)
       expect(PuppetCheck.clean_files.length).to eql(11)
       expect(PuppetCheck.ignored_files.length).to eql(1)
 
@@ -38,7 +38,7 @@ describe PuppetCheck do
       expect { tasks }.not_to raise_exception
 
       expect(PuppetCheck.error_files.length).to eql(8)
-      expect(PuppetCheck.warning_files.length).to eql(8)
+      expect(PuppetCheck.warning_files.length).to eql(9)
       expect(PuppetCheck.clean_files.length).to eql(11)
       expect(PuppetCheck.ignored_files.length).to eql(1)
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: puppet-check
 version: !ruby/object:Gem::Version
-  version: 1.3.0
+  version: 1.3.1
 platform: ruby
 authors:
 - Matt Schuchard
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-09-24 00:00:00.000000000 Z
+date: 2016-11-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: puppet
@@ -148,6 +148,7 @@ files:
 - spec/fixtures/metadata.json
 - spec/fixtures/metadata_good/metadata.json
 - spec/fixtures/metadata_style/metadata.json
+- spec/fixtures/metadata_style_two/metadata.json
 - spec/fixtures/metadata_syntax/metadata.json
 - spec/fixtures/spec/facter/facter_spec.rb
 - spec/fixtures/spec/fixtures/do_not_parse_me
@@ -214,6 +215,7 @@ test_files:
 - spec/fixtures/metadata.json
 - spec/fixtures/metadata_good/metadata.json
 - spec/fixtures/metadata_style/metadata.json
+- spec/fixtures/metadata_style_two/metadata.json
 - spec/fixtures/metadata_syntax/metadata.json
 - spec/fixtures/spec/facter/facter_spec.rb
 - spec/fixtures/spec/fixtures/do_not_parse_me