puppet-check 1.0.0 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1ffc2e861ac23804ea044caf8772a9a73e217d84
-  data.tar.gz: e97edbae606ba57e138b47668a94419b3e0cef48
+  metadata.gz: 9ef6e25a3e4df73cbaddd5f509626cc853b4cb9d
+  data.tar.gz: bbfa05df7d4d1d92f27a0b270d102bf2434c0ecb
 SHA512:
-  metadata.gz: e08a269bd34024edc353a0f9d5fd60cb1370a3cec7b66f451b83979f8c9b6f5f67d9595423fc7cf43e2e85beb8aa0cd96930499531a25a5e4775d7fd4ce427b9
-  data.tar.gz: 27c1c67568bfdcdd805ae14814fbb1c62ce8bde32e17f6d59e7612eeaae40027a35cc51059bfda7d8270ed48806387bfb41289b45dfbb623ac5e676ec5fb2dc6
+  metadata.gz: 791c901be64ebca7dc49db9f5aa99940b1e138be58e5fd5605b881b32c97b36819c5bd7d2f353914bd2756c6a0c75f6cfc455de7429d27b20eca099a1a6498d5
+  data.tar.gz: 1e2f6c6c65ee1af874689f9fe2aab3fb7d4865c4047294de7808ed81d7c6541b16c2b2d9e749dac3bf01f16df2b3059f0875533e65e426e1220cc0250a069803

data/CHANGELOG.md

@@ -1,14 +1,16 @@
 ### 1.3.0 (Roadmap)
 - minimum puppet version bump to 3.5 and future parser enabled by force for version < 4 (search code on 'future')
-- minimum ruby version bump to 2.0.0 (switch vagrant to centos7, remove 1.9.3 from travis.yml, add 2.3.x to travis.yml, update readme, remove psych::syntaxerror from dataparser.yaml, and remove | already initialized constant from rubyparser.template style spec)
+- minimum ruby version bump to 2.0.0 (switch vagrant to centos7, remove 1.9.3 from travis.yml, add 2.3.x to travis.yml, update readme, remove psych::syntaxerror from dataparser.yaml, and remove 1.9.3 test from rubyparser.template style spec)
 
 ### 1.2.0 (Roadmap)
-- json and yaml output formats support
-- beaker as optional task
-
-### 1.1.0 (Roadmap)
-- rspec and rspec puppet as optional tasks
+- json and yaml output formats support (error_files becomes hash with file keys and array of issues; refactor output_results)
+- rspec-puppet external dependencies support
 - add additional hiera checks, including nested hash parsing
+- explore puppet-catalog-test integration
+
+### 1.1.0
+- Support for RSpec, RSpec-Puppet, and Beaker.
+- Empty hieradata file bug fix.
 
 ### 1.0.0
 - Initial release.

data/README.md

@@ -2,7 +2,7 @@
 [![Build Status](https://travis-ci.org/mschuchard/puppet-check.svg?branch=master)](https://travis-ci.org/mschuchard/puppet-check)
 
 ## Description
-Puppet Check is a gem for comprehensive, efficient, streamlined, and easy verification and validation of your Puppet code and data.
+Puppet Check is a gem that provides a comprehensive, streamlined, and efficient analysis of the syntax, style, and validity of your entire Puppet code and data.
 
 ### Former Method for Code and Data Checks
 ![Old](https://raw.githubusercontent.com/mschuchard/puppet-check/master/images/puppetcheck_old.png)
@@ -95,14 +95,17 @@ The following files have unrecognized formats and therefore were not processed:
 ```
 
 ### Why not Puppetlabs Spec Helper?
-- Puppetlabs Spec Helper is a larger and varied gem with a different overall emphasis for its features.  Puppet Check is a lean and efficient gem solely for comprehensive Puppet code and data validation.
+- Puppetlabs Spec Helper is focused more on advanced and robust spec testing.  Puppet Check is focused more on efficient and comprehensive Puppet code and data validation.
 - Puppetlabs Spec Helper performs fewer types of checks.
 - Puppetlabs Spec Helper has extra layers of gems in between it and the gems executing the checks.
 - Puppetlabs Spec Helper does not allow interfacing through it to the gems executing the checks.
 - Puppetlabs Spec Helper has no CLI.
+- Puppetlabs Spec Helper intrinsically only executes spec tests against one module at a time.
+
+It is worth nothing that there is no current development objective for Puppet Check to achieve the same advanced level of robustness for spec testing that Puppetlabs Spec Helper enables. If you are performing standard spec testing on your Puppet code and data, then Puppet Check's spec testing is a fantastic lightweight and faster alternative to Puppetlabs Spec Helper. If you require advanced and intricate capabilities in your spec testing (e.g. direct interfacing to the `Puppet::Parser::Scope` API), you will likely prefer Puppetlabs Spec Helper's spec testing in conjunction with Puppet Check's file validation. Also, Puppet Check currently has no intrinsic support for external dependencies during spec testing, so you will need Puppetlabs Spec Helper or Librarian Puppet for that.
 
 ## Usage
-Puppet Check requires `ruby >= 1.9.3`, `puppet >= 3.2`, and `puppet-lint >= 1.1.0`. All other dependencies should be fine with various versions. Puppet Check can be used either with a CLI or Rake tasks.
+Puppet Check requires `ruby >= 1.9.3`, `puppet >= 3.2`, and `puppet-lint >= 1.1.0`. All other dependencies should be fine with various versions. Puppet Check can be used either with a CLI or Rake tasks. Please note both interfaces will ignore any directories named `fixtures` during file checks.
 
 ### CLI
 ```
@@ -122,23 +125,48 @@ puppet-check -s --puppet-lint no-hard_tabs-check,no-80chars-check --rubocop Metr
 ```
 
 ### Rake
-Interfacing with Puppet-Check via `rake` requires a `require puppet-check/tasks` in your Rakefile. This generates the following `rake` command:
+Interfacing with Puppet-Check via `rake` requires a `require puppet-check/tasks` in your Rakefile. This generates the following `rake` commands:
 
 ```
+rake puppetcheck           # Execute all Puppet-Check checks
 rake puppetcheck:file      # Execute Puppet-Check file checks
+rake puppetcheck:spec      # Execute RSpec and RSpec-Puppet tests
+rake puppetcheck:beaker    # Execute Beaker acceptance tests
 ```
 
-You can add style checks to and select the future parser for the `rake` by adding the following after the require:
+#### puppetcheck:file
+You can add style checks to and select the future parser for the `rake puppetcheck:file` by adding the following after the require:
 
 ```ruby
 PuppetCheck.style_check = true
 PuppetCheck.future_parser = true
 ```
 
-The style checks from within `rake` are directly interfaced to `puppet-lint`, `rubocop`, and `reek`. This means that all arguments and options should be specified from within your `.puppet-lint.rc`, `.rubocop.yml`, and `*.reek`. The capability to pass arguments and options to them from within the `Rakefile` task block will be considered for future versions.
+The style checks from within `rake puppetcheck:file` are directly interfaced to `puppet-lint`, `rubocop`, and `reek`. This means that all arguments and options should be specified from within your `.puppet-lint.rc`, `.rubocop.yml`, and `*.reek`. However, `puppet-lint` can still be interfaced with from within the `Rakefile` with the normal method of `PuppetLint.configuration.send('foo')` after the require. The capability to pass ruby style arguments and options from within the `Rakefile` task block will be considered for future versions.
+
+#### puppetcheck:spec
+The spec tests will be executed against everything that matches the pattern `**/{classes, defines, facter, functions, hosts, puppet, unit, types}/**/*_spec.rb`. This means everything in the current path that appears to be a Puppet module spec test will be regarded as such and executed during this rake task.
+
+Please note it is perfectly acceptable to only execute standard RSpec tests in your modules and not use the extended RSpec Puppet matchers. If RSpec Puppet is not installed, then no RSpec Puppet related actions (including those described below) will be performed.
+
+Prior to executing the spec tests, Puppet Check will parse everything in the current path and identify all `spec` directories. It will then execute `RSpec::Puppet::Setup` inside each assumed module directory containing these `spec` directories. This ensures any missing configuration items or non-current symlinks are created without altering your current configuration items, directories, or symlinks. The drawback to this is that your modules will be populated with useless `Rakefiles` if they do not already exist.
+
+#### puppetcheck:beaker
+The spec tests will be executed against everything that matches the pattern `**/acceptance`. This means everything in the current path that appears to be a Puppet module acceptance test will be regarded as such and executed during this rake task.
+
+Please note this is merely a frontend to Beaker and that Beaker itself has a self-contained scope compared to all the other tools Puppet Check interfaces with and utilizes. This means if you want to add Beaker-RSpec, Serverspec, etc., or perform advanced configurations, those would be all be performed within Beaker itself. This task merely provides an interface to integrate Beaker in with your other testing infrastructure.
+
+### Exit Codes
+- 0: PuppetCheck exited with no internal exceptions or errors in your Puppet code and data.
+- 1: PuppetCheck exited with an internal exception (takes preference over other non-zero exit codes).
+- 2: PuppetCheck exited with errors in your Puppet code and data.
 
-### Optional Checks
-`reek` will automatically be installed as a dependency and checks enabled during style checks if your Ruby version is `>= 2.1`. `rspec`, `rspec-puppet`, and `beaker` are forthcoming purely optional dependency checks.
+### Optional dependencies
+- **reek**: will automatically be installed as a dependency and checks enabled during style checks if your Ruby version is `>= 2.1.0`.
+- **rake**: install this if you want to use Puppet Check with `rake` tasks in addition to the CLI.
+- **rspec**: install this if you want to use Puppet Check to execute the spec tests for your ruby files during `rake`.
+- **rspec-puppet**: install this if you want to use Puppet Check to execute the spec tests for your Puppet files during `rake`.
+- **beaker**: install this if you want to use Puppet Check to execute the acceptance tests during `rake`.
 
 ## Contributing
 Code should pass all spec tests. New features should involve new spec tests. Adherence to Rubocop and Reek is expected where not overly onerous or where the check is of dubious cost/benefit.

data/lib/puppet-check.rb

@@ -35,7 +35,7 @@ class PuppetCheck
     self.class.output_results
 
     # exit code
-    self.class.error_files.empty? ? 0 : 1
+    self.class.error_files.empty? ? 0 : 2
   end
 
   # parse the paths and return the array of files
@@ -50,6 +50,8 @@ class PuppetCheck
         files.push(path)
       end
     end
+    # do not process fixtures
+    files.reject! { |file| file =~ /fixtures/ }
 
     # check that at least one file was found, remove double slashes, and return unique files
     raise "No files found in supplied paths #{paths.join(', ')}." if files.empty?

data/lib/puppet-check/data_parser.rb

@@ -13,7 +13,8 @@ class DataParser
       rescue Psych::SyntaxError, StandardError => err
         PuppetCheck.error_files.push("-- #{file}:\n#{err.to_s.gsub("(#{file}): ", '')}")
       else
-        warnings = hiera(parsed)
+        # perform some rudimentary hiera checks if data exists
+        warnings = parsed.class.to_s == 'NilClass' ? [] : hiera(parsed)
         next PuppetCheck.warning_files.push("-- #{file}:\n#{warnings.join("\n")}") unless warnings.empty?
         PuppetCheck.clean_files.push("-- #{file}")
       end
@@ -31,6 +32,8 @@ class DataParser
       rescue JSON::ParserError => err
         PuppetCheck.error_files.push("-- #{file}:\n#{err.to_s.lines.first.strip}")
       else
+        warnings = []
+
         # check metadata.json
         if file =~ /.*metadata\.json$/
           # metadata-json-lint has issues and is essentially no longer maintained so here is an improved and leaner version of it
@@ -66,19 +69,15 @@ class DataParser
           next PuppetCheck.error_files.push("-- #{file}:\n#{errors.join("\n")}") unless errors.empty?
 
           # check for warnings
-          warnings = []
-
           # check for spdx license (rubygems/util/licenses for rubygems >= 2.5 in the far future)
           if parsed.key?('license') && !SpdxLicenses.exist?(parsed['license']) && parsed['license'] !~ /[pP]roprietary/
             warnings.push("License identifier '#{parsed['license']}' is not in the SPDX list: http://spdx.org/licenses/")
           end
-
-          next PuppetCheck.warning_files.push("-- #{file}:\n#{warnings.join("\n")}") unless warnings.empty?
         else
-          # check for questionable hieradata
-          warnings = hiera(parsed)
-          next PuppetCheck.warning_files.push("-- #{file}:\n#{warnings.join("\n")}") unless warnings.empty?
+          # perform some rudimentary hiera checks if data exists
+          warnings = hiera(parsed) unless parsed.class.to_s == 'NilClass'
         end
+        next PuppetCheck.warning_files.push("-- #{file}:\n#{warnings.join("\n")}") unless warnings.empty?
         PuppetCheck.clean_files.push("-- #{file}")
       end
     end

data/lib/puppet-check/tasks.rb

@@ -1,13 +1,51 @@
-require 'rake'
+require 'rspec/core/rake_task'
 require 'rake/tasklib'
+require 'rake/task'
 require_relative '../puppet-check'
 
 # the rake interface for PuppetCheck
 class PuppetCheck::Tasks < ::Rake::TaskLib
   def initialize
-    desc 'Execute Puppet-Check file checks'
-    task 'puppetcheck:file' do
-      exit PuppetCheck.new.run(Dir.glob('*'))
+    desc 'Execute all Puppet-Check checks'
+    task :puppetcheck do
+      %w(puppetcheck:file puppetcheck:spec puppetcheck:beaker).each { |task| Rake::Task[task.to_sym].invoke }
+    end
+
+    namespace :puppetcheck do
+      desc 'Execute Puppet-Check file checks'
+      task :file do
+        exit_code = PuppetCheck.new.run(Dir.glob('*'))
+        # changes nothing if this task is run separately; aborts 'puppetcheck' task if there are errors here
+        exit exit_code if exit_code != 0
+      end
+
+      desc 'Execute RSpec and RSpec-Puppet tests'
+      RSpec::Core::RakeTask.new(:spec) do |task|
+        rspec_puppet_setup
+        # generate tasks for all recognized directories inside of spec directories
+        task.pattern = '**/{classes, defines, facter, functions, hosts, puppet, unit, types}/**/*_spec.rb'
+      end
+
+      desc 'Execute Beaker acceptance tests'
+      RSpec::Core::RakeTask.new(:beaker) do |task|
+        task.pattern = '**/acceptance'
+      end
+    end
+  end
+
+  # prepare the directories for rspec-puppet testing
+  def rspec_puppet_setup
+    # leave method immediately if there is no rspec-puppet installed
+    begin
+      require 'rspec-puppet/setup'
+    rescue LoadError
+      return
+    end
+
+    # executes rspec::puppet::setup in every module directory to ensure module spec directories are configured correctly
+    Dir.glob('**/spec').each do |specdir|
+      Dir.chdir(specdir + '/..')
+      RSpec::Puppet::Setup.run
     end
   end
 end

data/spec/fixtures/manifests/good.pp

@@ -1 +1,4 @@
-notify { 'i am a good manifest': }
+# class is for rspec-puppet to generate module name for testing
+class fixtures::good {
+  notify { 'i am a good manifest': }
+}

data/spec/fixtures/spec/facter/facter_spec.rb

@@ -0,0 +1,7 @@
+require_relative '../../../spec_helper'
+
+describe 'I am a standard RSpec test' do
+  it 'that does a dumb check to prove this test is executing during the puppetcheck:spec task' do
+    expect(true).to eq(true)
+  end
+end

data/spec/fixtures/spec/fixtures/do_not_parse_me

@@ -0,0 +1 @@
+i am a file that should not be processed

data/spec/integration/integration_spec.rb

@@ -1,40 +1,41 @@
-require 'rake'
+require 'rake/task'
 require_relative '../spec_helper.rb'
 require_relative '../../lib/puppet-check/cli'
 require_relative '../../lib/puppet-check/tasks'
 
 describe 'PuppetCheck' do
   context 'executed as a system from the CLI with arguments and various files to be processed' do
-    let(:cli) { PuppetCheck::CLI.run(%W(-s --puppet-lint no-hard_tabs-check,no-80chars-check --rubocop Metrics/LineLength,Style/Encoding #{fixtures_dir})) }
+    let(:cli) { PuppetCheck::CLI.run(%w(-s --puppet-lint no-hard_tabs-check,no-80chars-check --rubocop Metrics/LineLength,Style/Encoding .)) }
 
     it 'outputs diagnostic results correctly after processing all of the files' do
-      expect(cli).to eql(1)
+      Dir.chdir(fixtures_dir)
+
+      expect(cli).to eql(2)
       expect { cli }.not_to raise_exception
       expect(PuppetCheck.error_files.length).to eql(8)
       expect(PuppetCheck.warning_files.length).to eql(8)
-      expect(PuppetCheck.clean_files.length).to eql(9)
+      expect(PuppetCheck.clean_files.length).to eql(10)
       expect(PuppetCheck.ignored_files.length).to eql(1)
     end
   end
 
   context 'executed as a system from the Rakefile with arguments and various files to be processed' do
-    let(:tasks) { Rake::Task['puppetcheck:file'].invoke }
+    let(:tasks) { Rake::Task['puppetcheck:file'.to_sym].invoke }
 
-    before(:each) do
-      FileUtils.cd fixtures_dir
+    it 'outputs diagnostic results correctly after processing all of the files' do
+      # ensure rake only checks the files inside fixtures
+      Dir.chdir(fixtures_dir)
       PuppetCheck.error_files = []
       PuppetCheck.warning_files = []
       PuppetCheck.clean_files = []
       PuppetCheck.ignored_files = []
       PuppetCheck.style_check = true
-    end
 
-    it 'outputs diagnostic results correctly after processing all of the files' do
-      expect(tasks).to eql(1)
+      expect(tasks).to eql(2)
       expect { tasks }.not_to raise_exception
       expect(PuppetCheck.error_files.length).to eql(8)
       expect(PuppetCheck.warning_files.length).to eql(8)
-      expect(PuppetCheck.clean_files.length).to eql(9)
+      expect(PuppetCheck.clean_files.length).to eql(10)
       expect(PuppetCheck.ignored_files.length).to eql(1)
     end
   end

data/spec/puppet-check/ruby_parser_spec.rb

@@ -58,11 +58,20 @@ describe RubyParser do
       expect(PuppetCheck.warning_files).to eql([])
       expect(PuppetCheck.clean_files).to eql([])
     end
-    it 'puts a bad style ruby template file in the warning files array' do
-      RubyParser.template([fixtures_dir + 'templates/style.erb'])
-      expect(PuppetCheck.error_files).to eql([])
-      expect(PuppetCheck.warning_files[0]).to match(%r{^\-\- #{fixtures_dir}templates/style.erb:\n.*already initialized constant.*\n.*(previous definition of|already initialized constant)})
-      expect(PuppetCheck.clean_files).to eql([])
+    if Gem::Version.new(RUBY_VERSION.dup) >= Gem::Version.new('2.0.0')
+      it 'puts a bad style ruby template file in the warning files array' do
+        RubyParser.template([fixtures_dir + 'templates/style.erb'])
+        expect(PuppetCheck.error_files).to eql([])
+        expect(PuppetCheck.warning_files[0]).to match(%r{^\-\- #{fixtures_dir}templates/style.erb:\n.*already initialized constant.*\n.*previous definition of})
+        expect(PuppetCheck.clean_files).to eql([])
+      end
+    else
+      it 'puts a bad style ruby template file in the warning files array' do
+        RubyParser.template([fixtures_dir + 'templates/style.erb'])
+        expect(PuppetCheck.error_files).to eql([])
+        expect(PuppetCheck.warning_files[0]).to match(%r{^\-\- #{fixtures_dir}templates/style.erb:})
+        expect(PuppetCheck.clean_files).to eql([])
+      end
     end
     it 'puts a ruby template file with ignored errors in the clean files array' do
       RubyParser.template([fixtures_dir + 'templates/no_method_error.erb'])

data/spec/puppet-check/tasks_spec.rb

@@ -0,0 +1,31 @@
+require 'rake/task'
+require_relative '../spec_helper.rb'
+require_relative '../../lib/puppet-check/tasks'
+
+describe PuppetCheck::Tasks do
+  context 'puppetcheck:spec' do
+    let(:spec_tasks) { Rake::Task['puppetcheck:spec'.to_sym].invoke }
+
+    it 'executes RSpec and RSpec-Puppet checks in the expected manner' do
+      Dir.chdir(fixtures_dir)
+
+      # rspec task executed
+      expect { spec_tasks }.to output(/ruby.*rspec/).to_stdout
+      # if this is first then the stdout is not captured for testing
+      expect { spec_tasks }.not_to raise_exception
+      # rspec-puppet setup executed
+      expect(File.directory?('spec/fixtures/modules/fixtures')).to be true
+
+      # cleanup rspec-puppet setup
+      %w(Rakefile spec/spec_helper.rb).each { |file| File.delete(file) }
+      %w(manifests modules).each { |dir| FileUtils.rm_r('spec/fixtures/' + dir) }
+    end
+  end
+
+  context 'puppetcheck:beaker' do
+    it 'verifies the Beaker task exists' do
+      Dir.chdir(fixtures_dir)
+      expect { Rake::Task['puppetcheck:spec'.to_sym].invoke }.not_to raise_exception
+    end
+  end
+end

data/spec/puppet-check_spec.rb

@@ -24,23 +24,25 @@ describe PuppetCheck do
   end
 
   context '.parse_paths' do
+    before(:each) { Dir.chdir(fixtures_dir) }
+
     let(:no_files) { puppetcheck.parse_paths(%w(foo bar baz)) }
-    let(:file) { puppetcheck.parse_paths([fixtures_dir + 'lib/good.rb']) }
-    let(:dir) { puppetcheck.parse_paths([fixtures_dir]) }
-    let(:multi_dir) { puppetcheck.parse_paths([fixtures_dir + 'hieradata', fixtures_dir + 'lib', fixtures_dir + 'manifests']) }
-    let(:repeats) { puppetcheck.parse_paths([fixtures_dir + 'hieradata', fixtures_dir + 'hieradata', fixtures_dir + 'lib', fixtures_dir + 'hieradata/good.json', fixtures_dir + 'manifests/good.pp', fixtures_dir + 'manifests/good.pp']) }
+    let(:file) { puppetcheck.parse_paths(['lib/good.rb']) }
+    let(:dir) { puppetcheck.parse_paths(['.']) }
+    let(:multi_dir) { puppetcheck.parse_paths(%w(hieradata lib manifests)) }
+    let(:repeats) { puppetcheck.parse_paths(['hieradata', 'hieradata', 'lib', 'hieradata/good.json', 'manifests/good.pp', 'manifests/good.pp']) }
 
     it 'raises an error if no files were found' do
       expect { no_files }.to raise_error(RuntimeError, 'No files found in supplied paths foo, bar, baz.')
     end
 
     it 'correctly parses one file and returns it' do
-      expect(file[0]).to match(%r{spec/fixtures/lib/good.rb})
+      expect(file[0]).to eql('lib/good.rb')
     end
 
     it 'correctly parses one directory and returns all of its files' do
       dir.each { |file| expect(File.file?(file)).to be true }
-      expect(dir.length).to eql(26)
+      expect(dir.length).to eql(27)
     end
 
     it 'correctly parses multiple directories and returns all of their files' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: puppet-check
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.1.0
 platform: ruby
 authors:
 - Matt Schuchard
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-05-14 00:00:00.000000000 Z
+date: 2016-05-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: puppet
@@ -30,26 +30,6 @@ dependencies:
     - - "<"
       - !ruby/object:Gem::Version
         version: '5'
-- !ruby/object:Gem::Dependency
-  name: rake
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '9'
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '13'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '9'
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '13'
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
@@ -106,6 +86,40 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3.0'
+- !ruby/object:Gem::Dependency
+  name: rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '9'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '12'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '9'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '12'
+- !ruby/object:Gem::Dependency
+  name: rspec-puppet
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.0'
 description: Puppet Check is a gem that provides a comprehensive, streamlined, and
   efficient analysis of the syntax, style, and validity of your entire Puppet code
   and data.
@@ -115,20 +129,10 @@ executables:
 extensions: []
 extra_rdoc_files: []
 files:
-- ".rubocop.yml"
-- ".travis.yml"
 - CHANGELOG.md
-- Dockerfile
-- Gemfile
 - LICENSE.md
 - README.md
-- Rakefile
-- Vagrantfile
 - bin/puppet-check
-- config.reek
-- images/puppetcheck_new.png
-- images/puppetcheck_old.odp
-- images/puppetcheck_old.png
 - lib/puppet-check.rb
 - lib/puppet-check/cli.rb
 - lib/puppet-check/data_parser.rb
@@ -136,7 +140,6 @@ files:
 - lib/puppet-check/ruby_parser.rb
 - lib/puppet-check/tasks.rb
 - lib/puppet-check/utils.rb
-- puppet-check.gemspec
 - spec/fixtures/foobarbaz
 - spec/fixtures/hieradata/good.json
 - spec/fixtures/hieradata/good.yaml
@@ -157,6 +160,8 @@ files:
 - spec/fixtures/metadata_good/metadata.json
 - spec/fixtures/metadata_style/metadata.json
 - spec/fixtures/metadata_syntax/metadata.json
+- spec/fixtures/spec/facter/facter_spec.rb
+- spec/fixtures/spec/fixtures/do_not_parse_me
 - spec/fixtures/templates/good.epp
 - spec/fixtures/templates/good.erb
 - spec/fixtures/templates/no_method_error.erb
@@ -168,6 +173,7 @@ files:
 - spec/puppet-check/data_parser_spec.rb
 - spec/puppet-check/puppet_parser_spec.rb
 - spec/puppet-check/ruby_parser_spec.rb
+- spec/puppet-check/tasks_spec.rb
 - spec/puppet-check/utils_spec.rb
 - spec/puppet-check_spec.rb
 - spec/spec_helper.rb
@@ -217,6 +223,8 @@ test_files:
 - spec/fixtures/metadata_good/metadata.json
 - spec/fixtures/metadata_style/metadata.json
 - spec/fixtures/metadata_syntax/metadata.json
+- spec/fixtures/spec/facter/facter_spec.rb
+- spec/fixtures/spec/fixtures/do_not_parse_me
 - spec/fixtures/templates/good.epp
 - spec/fixtures/templates/good.erb
 - spec/fixtures/templates/no_method_error.erb
@@ -228,6 +236,7 @@ test_files:
 - spec/puppet-check/data_parser_spec.rb
 - spec/puppet-check/puppet_parser_spec.rb
 - spec/puppet-check/ruby_parser_spec.rb
+- spec/puppet-check/tasks_spec.rb
 - spec/puppet-check/utils_spec.rb
 - spec/puppet-check_spec.rb
 - spec/spec_helper.rb

data/.rubocop.yml

@@ -1,11 +0,0 @@
----
-AllCops:
-  Include:
-    - 'lib/**/*.rb'
-    - 'bin/*.rb'
-    - 'spec/**/*.rb'
-  Exclude:
-    - 'spec/fixtures/**/*.rb'
-
-Metrics/LineLength:
-  Enabled: false

data/.travis.yml

@@ -1,21 +0,0 @@
-sudo: false
-notifications:
-  email: false
-
-language: ruby
-cache: bundler
-
-matrix:
-  include:
-    - rvm: 1.9.3
-      env: TEST=spec
-    - rvm: 2.0.0
-      env: TEST=spec
-    - rvm: 2.1.9
-      env: TEST=default
-    - rvm: 2.2.5
-      env: TEST=spec
-
-before_install: gem update bundler
-install: bundle install --retry=3
-script: bundle exec rake $TEST

data/Dockerfile

@@ -1,22 +0,0 @@
-# PuppetCheck: automated rake testing in reproducible environment
-
-# Build container to automatically provision environment and execute tests.
-# sudo docker build -t puppetcheck .
-
-# Start and enter container for troubleshooting if necessary.
-# sudo docker run -it -d puppetcheck
-# sudo docker exec -it `sudo docker ps -qa | awk '{print $1}' | head -n 1` bash
-
-# Remove running containers before rebuild.
-# sudo docker ps -qa | xargs sudo docker kill
-
-# Cleanup all instances when you are finished.
-# sudo docker ps -qa | xargs sudo docker rm
-# sudo docker images | grep puppetcheck | awk '{print $3}' | xargs sudo docker rmi
-
-FROM ubuntu:15.10
-RUN apt-get update && apt-get install ruby -y
-RUN gem install --no-rdoc --no-ri puppet rspec rake rubocop reek puppet-lint spdx-licenses
-COPY / /
-# Exit 0 to ensure container is built with tag for troubleshooting.
-RUN rake; exit 0

data/Gemfile

@@ -1,5 +0,0 @@
-source 'https://rubygems.org'
-
-gemspec
-
-gem 'reek' if Gem::Version.new(RUBY_VERSION.dup) >= Gem::Version.new('2.1.0')

data/Rakefile

@@ -1,24 +0,0 @@
-require 'rspec/core/rake_task'
-require 'rubocop/rake_task'
-require 'reek/rake/task' if Gem::Version.new(RUBY_VERSION.dup) >= Gem::Version.new('2.1.0')
-
-task default: [:rubocop, :reek, :unit, :integration]
-
-RuboCop::RakeTask.new(:rubocop) do |task|
-  task.formatters = ['simple']
-  task.fail_on_error = false
-end
-
-if Gem::Version.new(RUBY_VERSION.dup) >= Gem::Version.new('2.1.0')
-  Reek::Rake::Task.new do |task|
-    task.fail_on_error = false
-  end
-end
-
-RSpec::Core::RakeTask.new(:unit) do |task|
-  task.pattern = 'spec/{puppet-check_spec.rb, puppet-check/*_spec.rb}'
-end
-
-RSpec::Core::RakeTask.new(:integration) do |task|
-  task.pattern = 'spec/integration/*_spec.rb'
-end

data/Vagrantfile

@@ -1,77 +0,0 @@
-# PuppetCheck: testing gem build, install, and execution
-
-# -*- mode: ruby -*-
-# vi: set ft=ruby :
-
-# All Vagrant configuration is done below. The "2" in Vagrant.configure
-# configures the configuration version (we support older styles for
-# backwards compatibility). Please don't change it unless you know what
-# you're doing.
-Vagrant.configure(2) do |config|
-  # The most common configuration options are documented and commented below.
-  # For a complete reference, please see the online documentation at
-  # https://docs.vagrantup.com.
-
-  # Every Vagrant development environment requires a box. You can search for
-  # boxes at https://atlas.hashicorp.com/search.
-  config.vm.box = 'ubuntu/trusty64'
-
-  # Disable automatic box update checking. If you disable this, then
-  # boxes will only be checked for updates when the user runs
-  # `vagrant box outdated`. This is not recommended.
-  # config.vm.box_check_update = false
-
-  # Create a forwarded port mapping which allows access to a specific port
-  # within the machine from a port on the host machine. In the example below,
-  # accessing "localhost:8080" will access port 80 on the guest machine.
-  # config.vm.network "forwarded_port", guest: 80, host: 8080
-
-  # Create a private network, which allows host-only access to the machine
-  # using a specific IP.
-  # config.vm.network "private_network", ip: "192.168.33.10"
-
-  # Create a public network, which generally matched to bridged network.
-  # Bridged networks make the machine appear as another physical device on
-  # your network.
-  # config.vm.network "public_network"
-
-  # Share an additional folder to the guest VM. The first argument is
-  # the path on the host to the actual folder. The second argument is
-  # the path on the guest to mount the folder. And the optional third
-  # argument is a set of non-required options.
-  # config.vm.synced_folder "../data", "/vagrant_data"
-
-  # Provider-specific configuration so you can fine-tune various
-  # backing providers for Vagrant. These expose provider-specific options.
-  # Example for VirtualBox:
-  #
-  # config.vm.provider "virtualbox" do |vb|
-  #   # Display the VirtualBox GUI when booting the machine
-  #   vb.gui = true
-  #
-  #   # Customize the amount of memory on the VM:
-  #   vb.memory = "1024"
-  # end
-  #
-  # View the documentation for the provider you are using for more
-  # information on available options.
-
-  # Define a Vagrant Push strategy for pushing to Atlas. Other push strategies
-  # such as FTP and Heroku are also available. See the documentation at
-  # https://docs.vagrantup.com/v2/push/atlas.html for more information.
-  # config.push.define "atlas" do |push|
-  #   push.app = "YOUR_ATLAS_USERNAME/YOUR_APPLICATION_NAME"
-  # end
-
-  # Enable provisioning with a shell script. Additional provisioners such as
-  # Puppet, Chef, Ansible, Salt, and Docker are also available. Please see the
-  # documentation for more information about their specific syntax and use.
-  config.vm.provision 'shell', inline: <<-SHELL
-    cd /vagrant
-    sudo apt-get install git -y
-    sudo gem build puppet-check.gemspec
-    sudo gem install --no-rdoc --no-ri puppet-check*.gem
-    sudo /usr/local/bin/puppet-check -s spec/fixtures
-    sudo rm -f puppet-check*.gem
-  SHELL
-end

data/config.reek

@@ -1,3 +0,0 @@
----
-exclude_paths:
-  - spec/fixtures

data/puppet-check.gemspec

@@ -1,25 +0,0 @@
-Gem::Specification.new do |spec|
-  spec.name          = 'puppet-check'
-  spec.version       = '1.0.0'
-  spec.authors       = ['Matt Schuchard']
-  spec.description   = 'Puppet Check is a gem that provides a comprehensive, streamlined, and efficient analysis of the syntax, style, and validity of your entire Puppet code and data.'
-  spec.summary       = 'A streamlined comprehensive set of checks for your entire Puppet code and data'
-  spec.homepage      = 'https://www.github.com/mschuchard/puppet-check'
-  spec.license       = 'MIT'
-
-  spec.files         = `git ls-files`.split($INPUT_RECORD_SEPARATOR)
-  spec.executables   = spec.files.grep(%r{^bin/}) { |file| File.basename(file) }
-  spec.test_files    = spec.files.grep(%r{^spec/})
-  spec.require_paths = Dir['lib']
-
-  spec.required_ruby_version = Gem::Requirement.new('>= 1.9.3')
-  spec.add_dependency 'puppet', '>= 3.2', '< 5'
-  # spec.add_dependency 'rspec', '~> 3.0'
-  spec.add_dependency 'rake', '>= 9', '< 13'
-  spec.add_dependency 'rubocop', '~> 0'
-  spec.add_dependency 'puppet-lint', '~> 1.1'
-  # spec.add_dependency 'rspec-puppet', '~> 2.0'
-  # spec.add_dependency 'beaker.' '~> 2.0'
-  spec.add_dependency 'spdx-licenses', '~> 1.0'
-  spec.add_development_dependency 'rspec', '~> 3.0'
-end