pupilfirst_xapi 0.2.2 → 0.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f4c1f6e893b9a58bb193b6ddcbdf806ae9c341c3ff5527f3a2ba6a528cda7a05
-  data.tar.gz: 87858bf6e6a1b2beaa9bc8a85f9e7bc22424788a8011bc1a476f96fcd52d8370
+  metadata.gz: 9af22d07f8c93f261b7174d2e9e7c0718556931f7f09ec7e3efe91a20d6d6fa6
+  data.tar.gz: 5414db57b6f4f3b6851fc6c1c5938cbe918dab54cbdc3e41666e135fa788f6b3
 SHA512:
-  metadata.gz: a9a7da4741a9151c9251e7f9a31dc149d303a213fadb94cbdccd9a65578fb21bc7adfadfec168f30d6dbbf614fdb372aeb8ac2a967547628d427c046c0c3d944
-  data.tar.gz: 606c6d2f23faccbc6d30ee80e49b912148a862cc9855ea10814e1d64cd18300ece70469daea7f72093d5dad1cc176a1ddb2b5818a850bb9de9e88ab66982356c
+  metadata.gz: 5dbadb2c9cbbb1d501162bc3fd325aac8a9f2d44566a870942031fe7dba223292c4afe532a60a21a3eb2afa3393f9adb82277fb073ddb330c7cff8c6fb6482e0
+  data.tar.gz: 8710df83e5839915c2792edb71c9dde22bfb21c52e6aa1ca4b11641e645ee409e30c81011a8b27220d7c84fed0bc4cacf4f34977b1b4272d08aba9ca04d927b4

data/lib/pupilfirst_xapi/objects/course.rb

@@ -13,6 +13,7 @@ module PupilfirstXapi
           if course.ends_at.present?
             duration = ActiveSupport::Duration.build(course.ends_at - course.created_at).iso8601
             obj.with_extension("http://id.tincanapi.com/extension/planned-duration", duration)
+            obj.with_extension('http://id.tincanapi.com/extension/ending-position', course.targets.count)
           end
         end.call
       end

data/lib/pupilfirst_xapi/objects/target.rb

@@ -4,7 +4,6 @@ module PupilfirstXapi
       def call(target, uri_for)
         course = target.course
         target_uri = uri_for.call(target)
-        course_uri = uri_for.call(course)
 
         Builder.new(
           id: target_uri,
@@ -12,8 +11,8 @@ module PupilfirstXapi
           name: target.title,
           description: target.description
         ).tap do |obj|
-          obj.with_extension('course_id', course_uri)
-          obj.with_extension('course_name', course.name)
+          obj.with_extension('http://id.tincanapi.com/extension/host', Objects.course(course, uri_for).as_json)
+          obj.with_extension('http://id.tincanapi.com/extension/position', target.sort_index)
         end.call
       end
     end

data/lib/pupilfirst_xapi/version.rb

@@ -1,3 +1,3 @@
 module PupilfirstXapi
-  VERSION = '0.2.2'
+  VERSION = '0.3.1'
 end

data/spec/outbox_spec.rb

@@ -4,8 +4,8 @@ module PupilfirstXapi
   RSpec.describe Outbox do
     let(:timestamp)   { Time.now }
     let(:john)        { double(:john, name: 'John Doe', email: 'john@doe.com') }
-    let(:course)      { double(:course, id: 32, name: 'Rails for Begginers', description: 'Seems easy', created_at: 1.week.ago, ends_at: nil) }
-    let(:target)      { double(:target, title: '1st target', description: 'Seems easy', course: course) }
+    let(:course)      { double(:course, id: 32, name: 'Rails for Begginers', description: 'Seems easy', created_at: 1.week.ago, ends_at: nil, targets: []) }
+    let(:target)      { double(:target, title: '1st target', description: 'Seems easy', course: course, sort_index: 7) }
     let(:good_one)    { double(:timeline_event, target: target, passed?: true) }
     let(:bad_one)     { double(:timeline_event, target: target, passed?: false) }
 

data/spec/statements/course_completed_spec.rb

@@ -5,7 +5,11 @@ module PupilfirstXapi
     RSpec.describe CourseCompleted do
       it do
         john   = double(:john, name: 'John Doe', email: 'john@doe.com')
-        course = double(:course, name: 'Rails for Begginers', description: 'Seems easy', created_at: 1.week.ago, ends_at: nil)
+        course = double(:course, name: 'Rails for Begginers', description: 'Seems easy', created_at: 1.week.ago, ends_at: nil,
+                                 targets: [
+                                   double(:target, title: '1st target', description: 'Seems easy'),
+                                   double(:target, title: '2nd target', description: 'Seems not easy')
+                                  ])
         data = {
           course: { 456 => course },
           user: { 123 => john },

data/spec/statements/course_registered_spec.rb

@@ -5,7 +5,11 @@ module PupilfirstXapi
     RSpec.describe CourseRegistered do
       it do
         john   = double(:john, name: 'John Doe', email: 'john@doe.com')
-        course = double(:course, name: 'Rails for Begginers', description: 'Seems easy', created_at: 1.week.ago, ends_at: nil)
+        course = double(:course, name: 'Rails for Begginers', description: 'Seems easy', created_at: 1.week.ago, ends_at: nil,
+                                 targets: [
+                                   double(:target, title: '1st target', description: 'Seems easy'),
+                                   double(:target, title: '2nd target', description: 'Seems not easy')
+                                  ])
         data = {
           course: { 456 => course },
           user: { 123 => john },
@@ -34,7 +38,11 @@ module PupilfirstXapi
         duration  = ActiveSupport::Duration.build(ends_at - starts_at).iso8601
 
         john   = double(:john, name: 'John Doe', email: 'john@doe.com')
-        course = double(:course, name: 'Rails for Begginers', description: 'Seems easy', created_at: starts_at, ends_at: ends_at)
+        course = double(:course, name: 'Rails for Begginers', description: 'Seems easy', created_at: starts_at, ends_at: ends_at,
+                                 targets: [
+                                   double(:target, title: '1st target', description: 'Seems easy'),
+                                   double(:target, title: '2nd target', description: 'Seems not easy')
+                                  ])
         data = {
           course: { 456 => course },
           user: { 123 => john },
@@ -54,7 +62,10 @@ module PupilfirstXapi
         expect(xapi.object.definition.type).to eq 'http://adlnet.gov/expapi/activities/product'
         expect(xapi.object.definition.name).to eq({'en-US' => 'Rails for Begginers'})
         expect(xapi.object.definition.description).to eq({'en-US' => 'Seems easy'})
-        expect(xapi.object.definition.extensions).to eq({"http://id.tincanapi.com/extension/planned-duration" => duration})
+        expect(xapi.object.definition.extensions).to eq({
+          "http://id.tincanapi.com/extension/planned-duration" => duration,
+          "http://id.tincanapi.com/extension/ending-position" => 2
+        })
       end
     end
   end

data/spec/statements/target_completed_spec.rb

@@ -4,8 +4,12 @@ module PupilfirstXapi
   module Statements
     RSpec.describe TargetCompleted do
       it do
-        course = double(:course, id: 17, name: 'Rails for Begginers', description: 'Seems easy', created_at: 1.week.ago, ends_at: nil)
-        target = double(:target, title: '1st target', course: course, description: 'Seems easy')
+        course = double(:course, id: 17, name: 'Rails for Begginers', description: 'Seems easy', created_at: 1.week.ago, ends_at: nil,
+                                 targets: [
+                                   double(:target, title: '1st target', description: 'Seems easy'),
+                                   double(:target, title: '2nd target', description: 'Seems not easy')
+                                  ])
+        target = double(:target, title: '1st target', course: course, description: 'Seems easy', sort_index: 5)
         submission = double(:timeline_event, target: target, passed?: true)
         john   = double(:john, name: 'John Doe', email: 'john@doe.com')
         data = {
@@ -27,14 +31,11 @@ module PupilfirstXapi
         expect(xapi.object.definition.type).to eq 'http://activitystrea.ms/schema/1.0/task'
         expect(xapi.object.definition.name).to eq({'en-US' => '1st target'})
         expect(xapi.object.definition.description).to eq({'en-US' => 'Seems easy'})
-        expect(xapi.object.definition.extensions).to eq({
-          'course_id'=>'course-1',
-          'course_name'=>'Rails for Begginers'
-        })
+        expect(xapi.object.definition.extensions['http://id.tincanapi.com/extension/host']['id']).to eq 'course-1'
       end
 
       it 'no-op when submission is not passed'  do
-        target = double(:target, title: '1st target', description: 'Seems easy')
+        target = double(:target, title: '1st target', description: 'Seems easy', sort_index: 3)
         submission = double(:timeline_event, target: target, passed?: false)
         john   = double(:john, name: 'John Doe', email: 'john@doe.com')
         data = {

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pupilfirst_xapi
 version: !ruby/object:Gem::Version
-  version: 0.2.2
+  version: 0.3.1
 platform: ruby
 authors:
 - GrowthTribe
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-05-13 00:00:00.000000000 Z
+date: 2021-05-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails