pundit 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b2e10a94ed9f8cbd38d1c51f38344eedd7d680d8
-  data.tar.gz: 89b88467b3f85513d764ff7f2357f98dfa078b5c
+  metadata.gz: e2a27c306e9cc67fc0ecabc8c910f7e4a5b0706a
+  data.tar.gz: e94f7b364462ea0cf5b4c30d48620f523d89ff4a
 SHA512:
-  metadata.gz: 78331e942eabf7eb0b0990e0760481498cd056f10f3b11ecc7f9fb9718ae6532a1bd64a3682d012d8245ab019cf39f2e8671dff82e55dee1bf4e76afcf62dd05
-  data.tar.gz: c95f7e2fb27998009aeb6948464ce550938fc59a21d9169d0def6df7b3e467140f2d00fa198b97adce8cb08d232bd42d95cda46ab84813e08f305cc2277aee40
+  metadata.gz: d754a6ba6a9b2c00eff1100c320cba4ab34dbca2877e966d477febec75aa79348b978397f53a7961f771f694ac377fb0b87a4af8e79be75e840d15ff0cf53189
+  data.tar.gz: ce78572422e59c3cd811b9062cc033aabfe69713a7e7ee364a0fe12c505f4399ebbd645683d0935b1f045af8903835e9a97d31e47edcf2928c4fd90f89cbe87d

data/CHANGELOG.md

@@ -1,5 +1,10 @@
 # Pundit
 
+## 1.0.1 (2015-05-27)
+
+- Fixed a regression where NotAuthorizedError could not be ininitialized with a string.
+- Use `camelize` instead of `classify` for symbol policies to prevent weird pluralizations.
+
 ## 1.0.0 (2015-04-19)
 
 - Caches policy scopes and policies.

data/lib/pundit.rb

@@ -14,11 +14,15 @@ module Pundit
     attr_reader :query, :record, :policy
 
     def initialize(options = {})
-      @query  = options[:query]
-      @record = options[:record]
-      @policy = options[:policy]
-
-      message = options.fetch(:message) { "not allowed to #{query} this #{record.inspect}" }
+      if options.is_a? String
+        message = options
+      else
+        @query  = options[:query]
+        @record = options[:record]
+        @policy = options[:policy]
+
+        message = options.fetch(:message) { "not allowed to #{query} this #{record.inspect}" }
+      end
 
       super(message)
     end

data/lib/pundit/policy_finder.rb

@@ -47,9 +47,9 @@ module Pundit
         elsif object.is_a?(Class)
           object
         elsif object.is_a?(Symbol)
-          object.to_s.classify
+          object.to_s.camelize
         elsif object.is_a?(Array)
-          object.join('/').to_s.classify
+          object.join('/').camelize
         else
           object.class
         end

data/lib/pundit/version.rb

@@ -1,3 +1,3 @@
 module Pundit
-  VERSION = "1.0.0"
+  VERSION = "1.0.1"
 end

data/spec/pundit_spec.rb

@@ -138,17 +138,17 @@ describe Pundit do
       end
 
       it "returns an instantiated policy given a symbol" do
-        policy = Pundit.policy(user, :dashboard)
-        expect(policy.class).to eq DashboardPolicy
+        policy = Pundit.policy(user, :criteria)
+        expect(policy.class).to eq CriteriaPolicy
         expect(policy.user).to eq user
-        expect(policy.dashboard).to eq :dashboard
+        expect(policy.criteria).to eq :criteria
       end
 
       it "returns an instantiated policy given an array" do
-        policy = Pundit.policy(user, [:project, :dashboard])
-        expect(policy.class).to eq Project::DashboardPolicy
+        policy = Pundit.policy(user, [:project, :criteria])
+        expect(policy.class).to eq Project::CriteriaPolicy
         expect(policy.user).to eq user
-        expect(policy.dashboard).to eq [:project, :dashboard]
+        expect(policy.criteria).to eq [:project, :criteria]
       end
     end
   end
@@ -179,17 +179,17 @@ describe Pundit do
     end
 
     it "returns an instantiated policy given a symbol" do
-      policy = Pundit.policy!(user, :dashboard)
-      expect(policy.class).to eq DashboardPolicy
+      policy = Pundit.policy!(user, :criteria)
+      expect(policy.class).to eq CriteriaPolicy
       expect(policy.user).to eq user
-      expect(policy.dashboard).to eq :dashboard
+      expect(policy.criteria).to eq :criteria
     end
 
     it "returns an instantiated policy given an array" do
-      policy = Pundit.policy!(user, [:project, :dashboard])
-      expect(policy.class).to eq Project::DashboardPolicy
+      policy = Pundit.policy!(user, [:project, :criteria])
+      expect(policy.class).to eq Project::CriteriaPolicy
       expect(policy.user).to eq user
-      expect(policy.dashboard).to eq [:project, :dashboard]
+      expect(policy.criteria).to eq [:project, :criteria]
     end
 
     it "throws an exception if the given policy can't be found" do
@@ -344,4 +344,11 @@ describe Pundit do
       expect(Controller.new(double, params).permitted_attributes(post)).to eq({ 'votes' => 5 })
     end
   end
+
+  describe "Pundit::NotAuthorizedError" do
+    it "can be initialized with a string as message" do
+      error = Pundit::NotAuthorizedError.new("must be logged in")
+      expect(error.message).to eq "must be logged in"
+    end
+  end
 end

data/spec/spec_helper.rb

@@ -93,10 +93,10 @@ class ArticleTag
   end
 end
 
-class DashboardPolicy < Struct.new(:user, :dashboard); end
+class CriteriaPolicy < Struct.new(:user, :criteria); end
 
 module Project
-  class DashboardPolicy < Struct.new(:user, :dashboard); end
+  class CriteriaPolicy < Struct.new(:user, :criteria); end
 end
 
 class DenierPolicy < Struct.new(:user, :record)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: pundit
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - Jonas Nicklas
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-04-19 00:00:00.000000000 Z
+date: 2015-05-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -178,7 +178,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5
+rubygems_version: 2.4.6
 signing_key: 
 specification_version: 4
 summary: OO authorization for Rails