punchblock 2.5.0 → 2.5.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b468b4ccd6ae157d9309dd8daf2462f6a3c83a26
-  data.tar.gz: 2c60dd9989e3116bb0e3a57271fe813db7ab746a
+  metadata.gz: 85f605669ee36883cccb2b7d33830c63b1b5de9c
+  data.tar.gz: 48f9adbd486d8605a48c8757854fb6ea2303fcaf
 SHA512:
-  metadata.gz: 9d67fd215f169976483231ed2228ed7f6005142a10c686eebe6ee6968f84e813cea80675921e5c66dc59e2aef2024502782adbe766204803849295bc21221030
-  data.tar.gz: 37f3f5f6083f2e1123246a7324c9612bd8245b25470adf4024144f9478421d27a65ab9cb23fd89cfa24c96990ae0af6ae64c1e7a335aa71b01c3e5200a153e26
+  metadata.gz: 40c3712d24b3c6eaf4d78526fda48b03e71895252a0efa86c23984b4bd34c6867d8c88885f8cd9ac79b5cd25c6ba673b2e2f75a2ae326e08215911052314e3d5
+  data.tar.gz: 57c1421e0a20fc88ad2b2c41fb3eb70e6c9e658aa44c59daa1f13ba43dfa4e68c1e6a97b78e4180ced54bfed6ee11a106640f6f22bf5db11f64740fe91dca98f

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # [develop](https://github.com/adhearsion/punchblock)
 
+# [v2.5.1](https://github.com/adhearsion/punchblock/compare/v2.5.0...v2.5.1) - [2014-03-31](https://rubygems.org/gems/punchblock/versions/2.5.1)
+  * Bugfix: Ensure DTMF recognisers get shut down when finishing
+  * Bugfix: Hangup reason on Asterisk was `:hangup`, should be `:hungup`. See [the Rayo spec](http://xmpp.org/extensions/xep-0327.html#def-end-reason).
+
 # [v2.5.0](https://github.com/adhearsion/punchblock/compare/v2.4.2...v2.5.0) - [2014-03-05](https://rubygems.org/gems/punchblock/versions/2.5.0)
   * Feature: Support language, sensitivity and minimum confidence on UniMRCP-based ASR on Asterisk
   * Feature: Support sending messages to calls (eg SIP MESSAGE) on Asterisk

data/Guardfile

@@ -1,5 +1,5 @@
 group 'rspec' do
-  guard 'rspec', :cli => '--format documentation' do
+  guard 'rspec', cmd: 'bundle exec rspec' do
     watch(%r{^spec/.+_spec\.rb$})
     watch(%r{^lib/(.+)\.rb$})     { |m| "spec/#{m[1]}_spec.rb" }
     watch('spec/spec_helper.rb')  { "spec/" }

data/lib/punchblock/translator/asterisk/call.rb

@@ -16,8 +16,8 @@ module Punchblock
         attr_reader :id, :channel, :translator, :agi_env, :direction
 
         HANGUP_CAUSE_TO_END_REASON = Hash.new { :error }
-        HANGUP_CAUSE_TO_END_REASON[0] = :hangup
-        HANGUP_CAUSE_TO_END_REASON[16] = :hangup
+        HANGUP_CAUSE_TO_END_REASON[0] = :hungup
+        HANGUP_CAUSE_TO_END_REASON[16] = :hungup
         HANGUP_CAUSE_TO_END_REASON[17] = :busy
         HANGUP_CAUSE_TO_END_REASON[18] = :timeout
         HANGUP_CAUSE_TO_END_REASON[19] = :reject

data/lib/punchblock/translator/dtmf_recognizer.rb

@@ -122,6 +122,7 @@ module Punchblock
           @responder.send match_type
         end
         @finished = true
+        terminate
       end
     end
   end

data/lib/punchblock/version.rb

@@ -1,5 +1,5 @@
 # encoding: utf-8
 
 module Punchblock
-  VERSION = "2.5.0"
+  VERSION = "2.5.1"
 end

data/punchblock.gemspec

@@ -36,7 +36,7 @@ Gem::Specification.new do |s|
   s.add_runtime_dependency %q<ruby_jid>, ["~> 1.0"]
 
   s.add_development_dependency %q<bundler>, ["~> 1.0"]
-  s.add_development_dependency %q<rspec>, ["~> 2.7"]
+  s.add_development_dependency %q<rspec>, ["~> 2.13"]
   s.add_development_dependency %q<ci_reporter>, ["~> 1.6"]
   s.add_development_dependency %q<yard>, ["~> 0.6"]
   s.add_development_dependency %q<rake>, [">= 0"]

data/spec/punchblock/translator/asterisk/call_spec.rb

@@ -303,7 +303,7 @@ module Punchblock
               comp_command.response(0.1).should be_a Ref
               expected_complete_event = Punchblock::Event::Complete.new :target_call_id => subject.id, :component_id => component.id, source_uri: component.id
               expected_complete_event.reason = Punchblock::Event::Complete::Hangup.new
-              expected_end_event = Punchblock::Event::End.new :reason => :hangup, platform_code: cause, :target_call_id  => subject.id
+              expected_end_event = Punchblock::Event::End.new :reason => :hungup, platform_code: cause, :target_call_id  => subject.id
 
               translator.should_receive(:handle_pb_event).with(expected_complete_event).once.ordered
               translator.should_receive(:handle_pb_event).with(expected_end_event).once.ordered
@@ -338,7 +338,7 @@ module Punchblock
               end
 
               it "should use the AMI timestamp for the Rayo event" do
-                expected_end_event = Punchblock::Event::End.new reason: :hangup,
+                expected_end_event = Punchblock::Event::End.new reason: :hungup,
                                                                 platform_code: cause,
                                                                 target_call_id: subject.id,
                                                                 timestamp: DateTime.new(2014, 2, 25, 22, 46, 20)
@@ -370,8 +370,8 @@ module Punchblock
               let(:cause)     { '0' }
               let(:cause_txt) { 'Undefined' }
 
-              it 'should send an end (hangup) event to the translator' do
-                expected_end_event = Punchblock::Event::End.new :reason   => :hangup,
+              it 'should send an end (hungup) event to the translator' do
+                expected_end_event = Punchblock::Event::End.new :reason   => :hungup,
                                                                 platform_code: cause,
                                                                 :target_call_id  => subject.id
                 translator.should_receive(:handle_pb_event).with expected_end_event
@@ -383,8 +383,8 @@ module Punchblock
               let(:cause)     { '16' }
               let(:cause_txt) { 'Normal Clearing' }
 
-              it 'should send an end (hangup) event to the translator' do
-                expected_end_event = Punchblock::Event::End.new :reason   => :hangup,
+              it 'should send an end (hungup) event to the translator' do
+                expected_end_event = Punchblock::Event::End.new :reason   => :hungup,
                                                                 platform_code: cause,
                                                                 :target_call_id  => subject.id
                 translator.should_receive(:handle_pb_event).with expected_end_event

data/spec/punchblock/translator/asterisk/component/asterisk/agi_command_spec.rb

@@ -159,8 +159,8 @@ module Punchblock
                   context "when the PUNCHBLOCK_END_ON_ASYNCAGI_BREAK channel var is set" do
                     let(:chan_var) { 'true' }
 
-                    it 'should send an end (hangup) event to the translator' do
-                      expected_end_event = Punchblock::Event::End.new reason: :hangup,
+                    it 'should send an end (hungup) event to the translator' do
+                      expected_end_event = Punchblock::Event::End.new reason: :hungup,
                                                                       platform_code: 16,
                                                                       target_call_id: mock_call.id
 
@@ -181,7 +181,7 @@ module Punchblock
                       end
 
                       it "should use the AMI timestamp for the Rayo event" do
-                        expected_end_event = Punchblock::Event::End.new reason: :hangup,
+                        expected_end_event = Punchblock::Event::End.new reason: :hungup,
                                                                         platform_code: 16,
                                                                         target_call_id: mock_call.id,
                                                                         timestamp: DateTime.new(2014, 2, 25, 22, 46, 20)

data/spec/punchblock/translator/asterisk/component/input_spec.rb

@@ -99,6 +99,10 @@ module Punchblock
                   subject.should_receive(:process_dtmf).never
                   send_ami_events_for_dtmf 3
                 end
+
+                it "should not leave the recognizer running" do
+                  Celluloid::Actor.all.map { |a| a.class }.should_not include(Punchblock::Translator::DTMFRecognizer)
+                end
               end
 
               context "when the match is invalid" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: punchblock
 version: !ruby/object:Gem::Version
-  version: 2.5.0
+  version: 2.5.1
 platform: ruby
 authors:
 - Jason Goecke
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-03-05 00:00:00.000000000 Z
+date: 2014-03-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri
@@ -212,14 +212,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.7'
+        version: '2.13'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.7'
+        version: '2.13'
 - !ruby/object:Gem::Dependency
   name: ci_reporter
   requirement: !ruby/object:Gem::Requirement
@@ -558,7 +558,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: 1.3.7
 requirements: []
 rubyforge_project: punchblock
-rubygems_version: 2.2.0
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Punchblock is a telephony middleware library