puma 2.9.0 → 2.9.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: dd2e7a0ca1eba42615a406f35c0bbc304b91ee4c
-  data.tar.gz: fe274c58f7d7722caa7a7d444b080873c271034b
+  metadata.gz: 4587d687f274e6f12836cc110a0b9f69800e96a2
+  data.tar.gz: deac8749f171c5b8a6bf10666ba748676f8e3049
 SHA512:
-  metadata.gz: f021e24772d46c519e6edc358e25d3ab51bd65b6378918826bd647d7f08d1084c61f49e234c38c24113acdd075985a45f9bd83f7a1cb685526a36586af082ba3
-  data.tar.gz: 8dfc80519eaa94052b3f377546c701b7d1b84efeb40b6345d894caa40369a467a2bfc37955ece93ea84f4cb5a5013e14ff3952ccaf58f0260e222a09e1a6ac72
+  metadata.gz: b555eb3bc18a5679d72540458a20813161cb828c9be652f861e74ca7b00be2f05f7c44594088cf6e578d8df3a96152d2fc105d68b01b5e350596fa32529bdf70
+  data.tar.gz: f4be4cc2cc0bd2d9f880047c3547a4204995bf54a127ca72fcbfcc3f6bfb3854499701406c56515b66bcb0067caee762b44cd8eff8dbeb91dfb5564a96aa3014

data/History.txt

@@ -1,3 +1,15 @@
+=== 2.9.1 / 2014-09-05
+
+* 4 bug fixes:
+  * Cleanup the SSL related structures properly, fixes memory leak
+  * Fix thread spawning edge case.
+  * Force a worker check after a worker boots, don't wait 5sec. Fixes #574
+  * Implement SIGHUP for logs reopening
+
+* 2 PRs merged:
+  * Merge pull request #561 from theoldreader/sighup
+  * Merge pull request #570 from havenwood/spawn-thread-edge-case
+
 === 2.9.0 / 2014-07-12
 
 * 1 minor feature:

data/docs/signals.md

@@ -38,5 +38,6 @@ Puma cluster responds to these signals:
 - `TERM` send `TERM` to worker. Worker will attempt to finish then exit.
 - `USR2` restart workers
 - `USR1` restart workers in phases, a rolling restart.
+- `HUP`  reopen log files defined in stdout_redirect configuration parameter
 - `INT` equivalent of sending Ctrl-C to cluster. Will attempt to finish then exit.
 - `CHLD`

data/ext/puma_http11/mini_ssl.c

@@ -13,8 +13,8 @@ typedef struct {
 } ms_conn;
 
 void engine_free(ms_conn* conn) {
-  BIO_free(conn->read);
-  BIO_free(conn->write);
+  SSL_free(conn->ssl);
+  SSL_CTX_free(conn->ctx);
 
   free(conn);
 }

data/lib/puma/cli.rb

@@ -537,6 +537,14 @@ module Puma
         log "*** SIGTERM not implemented, signal based gracefully stopping unavailable!"
       end
 
+      begin
+        Signal.trap "SIGHUP" do
+          redirect_io
+        end
+      rescue Exception
+        log "*** SIGHUP not implemented, signal based logs reopening unavailable!"
+      end
+
       if jruby?
         Signal.trap("INT") do
           @status = :exit
@@ -564,6 +572,10 @@ module Puma
       true
     end
 
+    def redirect_io
+      @runner.redirect_io
+    end
+
     def stats
       @runner.stats
     end

data/lib/puma/cluster.rb

@@ -36,6 +36,12 @@ module Puma
       end
     end
 
+    def redirect_io
+      super
+
+      @workers.each { |x| x.hup }
+    end
+
     class Worker
       def initialize(idx, pid, phase)
         @index = idx
@@ -82,6 +88,11 @@ module Puma
         Process.kill "KILL", @pid
       rescue Errno::ESRCH
       end
+
+      def hup
+        Process.kill "HUP", @pid
+      rescue Errno::ESRCH
+      end
     end
 
     def spawn_workers
@@ -104,9 +115,9 @@ module Puma
     end
 
     def next_worker_index
-      all_positions =  0...@options[:workers] 
+      all_positions =  0...@options[:workers]
       occupied_positions = @workers.map { |w| w.index }
-      available_positions = all_positions.to_a - occupied_positions 
+      available_positions = all_positions.to_a - occupied_positions
       available_positions.first
     end
 
@@ -114,8 +125,8 @@ module Puma
       @workers.count { |w| !w.booted? } == 0
     end
 
-    def check_workers
-      return if @next_check && @next_check >= Time.now
+    def check_workers(force=false)
+      return if !force && @next_check && @next_check >= Time.now
 
       @next_check = Time.now + 5
 
@@ -172,6 +183,7 @@ module Puma
       $0 = "puma: cluster worker #{index}: #{master}"
       Signal.trap "SIGINT", "IGNORE"
 
+      @workers = []
       @master_read.close
       @suicide_pipe.close
 
@@ -345,6 +357,8 @@ module Puma
           begin
             res = IO.select([read], nil, nil, 5)
 
+            force_check = false
+
             if res
               req = read.read_nonblock(1)
 
@@ -357,6 +371,7 @@ module Puma
                 when "b"
                   w.boot!
                   log "- Worker #{w.index} (pid: #{pid}) booted, phase: #{w.phase}"
+                  force_check = true
                 when "p"
                   w.ping!
                 end
@@ -370,7 +385,7 @@ module Puma
               @phased_restart = false
             end
 
-            check_workers
+            check_workers force_check
 
           rescue Interrupt
             @status = :stop

data/lib/puma/const.rb

@@ -28,7 +28,7 @@ module Puma
   # too taxing on performance.
   module Const
 
-    PUMA_VERSION = VERSION = "2.9.0".freeze
+    PUMA_VERSION = VERSION = "2.9.1".freeze
     CODE_NAME = "Team High Five".freeze
 
     FAST_TRACK_KA_TIMEOUT = 0.2

data/lib/puma/thread_pool.rb

@@ -114,7 +114,7 @@ module Puma
 
         @todo << work
 
-        if @waiting == 0 and @spawned < @max
+        if @waiting < @todo.size and @spawned < @max
           spawn_thread
         end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: puma
 version: !ruby/object:Gem::Version
-  version: 2.9.0
+  version: 2.9.1
 platform: ruby
 authors:
 - Evan Phoenix
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-07-13 00:00:00.000000000 Z
+date: 2014-09-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack