puma 2.3.1 → 2.3.2

data/History.txt

@@ -1,3 +1,9 @@
+=== 2.3.2 / 2013-07-08
+
+* 1 bug fix:
+
+  * Move starting control server to after daemonization.
+
 === 2.3.1 / 2013-07-06
 
 * 2 bug fixes:

data/lib/puma/cli.rb

@@ -287,7 +287,6 @@ module Puma
     end
 
     def graceful_stop
-      @control.stop(true) if @control
       @runner.stop_blocked
       log "- Goodbye!"
     end
@@ -428,10 +427,6 @@ module Puma
 
       setup_signals
 
-      if cont = @options[:control_url]
-        start_control cont
-      end
-
       @status = :run
 
       @runner.run
@@ -443,8 +438,10 @@ module Puma
         graceful_stop
       when :restart
         log "* Restarting..."
-        @control.stop true if @control
+        @runner.before_restart
         restart!
+      when :exit
+        # nothing
       end
     end
 
@@ -467,44 +464,13 @@ module Puma
 
       if jruby?
         Signal.trap("INT") do
+          @status = :exit
           graceful_stop
           exit
         end
       end
     end
 
-    def start_control(str)
-      require 'puma/app/status'
-
-      uri = URI.parse str
-
-      app = Puma::App::Status.new self
-
-      if token = @options[:control_auth_token]
-        app.auth_token = token unless token.empty? or token == :none
-      end
-
-      control = Puma::Server.new app, @events
-      control.min_threads = 0
-      control.max_threads = 1
-
-      case uri.scheme
-      when "tcp"
-        log "* Starting control server on #{str}"
-        control.add_tcp_listener uri.host, uri.port
-      when "unix"
-        log "* Starting control server on #{str}"
-        path = "#{uri.host}#{uri.path}"
-
-        control.add_unix_listener path
-      else
-        error "Invalid control URI: #{str}"
-      end
-
-      control.run
-      @control = control
-    end
-
     def stop
       @status = :stop
       @runner.stop

data/lib/puma/cluster.rb

@@ -175,6 +175,7 @@ module Puma
     def stop_blocked
       @status = :stop if @status == :run
       wakeup!
+      @control.stop(true) if @control
       Process.waitall
     end
 
@@ -258,6 +259,8 @@ module Puma
 
       redirect_io
 
+      start_control
+
       @cli.write_state
 
       @master_read, @worker_write = read, @wakeup

data/lib/puma/const.rb

@@ -28,7 +28,7 @@ module Puma
   # too taxing on performance.
   module Const
 
-    PUMA_VERSION = VERSION = "2.3.1".freeze
+    PUMA_VERSION = VERSION = "2.3.2".freeze
     CODE_NAME = "Delicious Thin Mints"
 
     FAST_TRACK_KA_TIMEOUT = 0.2

data/lib/puma/runner.rb

@@ -4,6 +4,7 @@ module Puma
       @cli = cli
       @options = cli.options
       @app = nil
+      @control = nil
     end
 
     def daemon?
@@ -22,6 +23,45 @@ module Puma
       @cli.error str
     end
 
+    def before_restart
+      @control.stop(true) if @control
+    end
+
+    def start_control
+      str = @options[:control_url]
+      return unless str
+
+      require 'puma/app/status'
+
+      uri = URI.parse str
+
+      app = Puma::App::Status.new @cli
+
+      if token = @options[:control_auth_token]
+        app.auth_token = token unless token.empty? or token == :none
+      end
+
+      control = Puma::Server.new app, @cli.events
+      control.min_threads = 0
+      control.max_threads = 1
+
+      case uri.scheme
+      when "tcp"
+        log "* Starting control server on #{str}"
+        control.add_tcp_listener uri.host, uri.port
+      when "unix"
+        log "* Starting control server on #{str}"
+        path = "#{uri.host}#{uri.path}"
+
+        control.add_unix_listener path
+      else
+        error "Invalid control URI: #{str}"
+      end
+
+      control.run
+      @control = control
+    end
+
     def output_header(mode)
       min_t = @options[:min_threads]
       max_t = @options[:max_threads]

data/lib/puma/single.rb

@@ -22,6 +22,7 @@ module Puma
 
     def stop_blocked
       log "- Gracefully stopping, waiting for requests to finish"
+      @control.stop(true) if @control
       @server.stop(true)
     end
 
@@ -68,6 +69,8 @@ module Puma
 
       @cli.write_state
 
+      start_control
+
       @server = server = start_server
 
       unless @options[:daemon]

data/puma.gemspec

@@ -2,11 +2,11 @@
 
 Gem::Specification.new do |s|
   s.name = "puma"
-  s.version = "2.3.1"
+  s.version = "2.3.2"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Evan Phoenix"]
-  s.date = "2013-07-06"
+  s.date = "2013-07-09"
   s.description = "Puma is a simple, fast, threaded, and highly concurrent HTTP 1.1 server for Ruby/Rack applications. Puma is intended for use in both development and production environments. In order to get the best throughput, it is highly recommended that you use a  Ruby implementation with real threads like Rubinius or JRuby."
   s.email = ["evan@phx.io"]
   s.executables = ["puma", "pumactl"]

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: puma
 version: !ruby/object:Gem::Version
-  version: 2.3.1
+  version: 2.3.2
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-07-06 00:00:00.000000000 Z
+date: 2013-07-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack