puma-metrics 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 37f1ce3ea6119b2ed16fc6a44b782c73c8a5556b8a34d05d0405ef858cbe296c
-  data.tar.gz: 88c7934712eeaa24b0d4bc7b7046d2a3831da3f03052c30ed9e9b1a3273b7a81
+  metadata.gz: 9e3c5ff9a4590de56cba5e3dc7d0e84d9d21ab6bb7bab1e27c63549060450799
+  data.tar.gz: 5cc03919e7392338382a36b7b9b535f1f48216d91a46677c7e44e44c57c1344b
 SHA512:
-  metadata.gz: 0914550673aeeecf7535cf6a049d041c8e9b350eb416bf090a686a426f4a51e2d9060f4899d60a74359486c02f237e266f5174a59786d4bf1ad110c9978d0e47
-  data.tar.gz: 02b8e0d1ee0f29035446915617459d651485b847f8586b8c6d6c2dbf9452ab11ed77a1db840e81e04c2d71c85eee5532e1f1e063fcd2a47e27ce92a1c5ae6224
+  metadata.gz: 50d8e95de5e257801fd78f05cfb77e822899e88af4a30cee359ee358516cd51c2f6cb49f87fe894222f75281660681d4df780e15d76a2501428c4b9376c27c01
+  data.tar.gz: 955e0ebc87caa2a4a55e924065b93b5d03a93201ff3a7192bfe24061b271faceb4e5c7417860e09ab4775214f6349bb32fbfd07fee28359d4b33067624b3353a

data/.travis.yml

@@ -8,6 +8,9 @@ script:
 - bundle exec rake
 - bundle exec overcommit --sign
 - bundle exec overcommit --run
+branches:
+  only:
+  - master
 deploy:
   provider: rubygems
   api_key:

data/CHANGELOG.md

@@ -1,5 +1,10 @@
 # Changelog
 
+## 1.0.1
+
+Bugfixes:
+- `metrics_url` in `config/puma.rb` should be optional
+
 ## 1.0.0
 
 Initial release of the `puma-metrics` gem.

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    puma-metrics (1.0.0)
+    puma-metrics (1.0.1)
       prometheus-client (~> 0.8)
       puma (~> 3.0)
 

data/lib/puma/metrics/dsl.rb

@@ -1,6 +1,6 @@
 module Puma
   class DSL
-    def metrics_url(url = 'tcp://0.0.0.0:9393')
+    def metrics_url(url)
       @options[:metrics_url] = url
     end
   end

data/lib/puma/metrics/version.rb

@@ -1,5 +1,5 @@
 module Puma
   module Metrics
-    VERSION = '1.0.0'.freeze
+    VERSION = '1.0.1'.freeze
   end
 end

data/lib/puma/plugin/metrics.rb

@@ -3,8 +3,7 @@ require 'puma/metrics/dsl'
 Puma::Plugin.create do
   # rubocop:disable Metrics/MethodLength, Metrics/AbcSize
   def start(launcher)
-    str = launcher.options[:metrics_url]
-    return unless str
+    str = launcher.options[:metrics_url] || 'tcp://0.0.0.0:9393'
 
     require 'puma/metrics/app'
 
@@ -23,6 +22,13 @@ Puma::Plugin.create do
       launcher.events.error "Invalid control URI: #{str}"
     end
 
+    launcher.events.register(:state) do |state|
+      if %i[halt restart stop].include?(state)
+        metrics.stop
+        metrics.binder.close
+      end
+    end
+
     metrics.run
   end
   # rubocop:enable Metrics/MethodLength, Metrics/AbcSize

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: puma-metrics
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - Harm-Jan Blok
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-09-17 00:00:00.000000000 Z
+date: 2018-09-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: prometheus-client