psn 0.0.1 → 0.0.2

data/.rvmrc

@@ -0,0 +1,48 @@
+#!/usr/bin/env bash
+
+# This is an RVM Project .rvmrc file, used to automatically load the ruby
+# development environment upon cd'ing into the directory
+
+# First we specify our desired <ruby>[@<gemset>], the @gemset name is optional,
+# Only full ruby name is supported here, for short names use:
+#     echo "rvm use 1.9.3" > .rvmrc
+environment_id="ruby-1.9.3-p327@psn"
+
+# Uncomment the following lines if you want to verify rvm version per project
+# rvmrc_rvm_version="1.17.0 (master)" # 1.10.1 seams as a safe start
+# eval "$(echo ${rvm_version}.${rvmrc_rvm_version} | awk -F. '{print "[[ "$1*65536+$2*256+$3" -ge "$4*65536+$5*256+$6" ]]"}' )" || {
+#   echo "This .rvmrc file requires at least RVM ${rvmrc_rvm_version}, aborting loading."
+#   return 1
+# }
+
+# First we attempt to load the desired environment directly from the environment
+# file. This is very fast and efficient compared to running through the entire
+# CLI and selector. If you want feedback on which environment was used then
+# insert the word 'use' after --create as this triggers verbose mode.
+if [[ -d "${rvm_path:-$HOME/.rvm}/environments"
+  && -s "${rvm_path:-$HOME/.rvm}/environments/$environment_id" ]]
+then
+  \. "${rvm_path:-$HOME/.rvm}/environments/$environment_id"
+  [[ -s "${rvm_path:-$HOME/.rvm}/hooks/after_use" ]] &&
+    \. "${rvm_path:-$HOME/.rvm}/hooks/after_use" || true
+else
+  # If the environment file has not yet been created, use the RVM CLI to select.
+  rvm --create  "$environment_id" || {
+    echo "Failed to create RVM environment '${environment_id}'."
+    return 1
+  }
+fi
+
+# If you use bundler, this might be useful to you:
+# if [[ -s Gemfile ]] && {
+#   ! builtin command -v bundle >/dev/null ||
+#   builtin command -v bundle | GREP_OPTIONS= \grep $rvm_path/bin/bundle >/dev/null
+# }
+# then
+#   printf "%b" "The rubygem 'bundler' is not installed. Installing it now.\n"
+#   gem install bundler
+# fi
+# if [[ -s Gemfile ]] && builtin command -v bundle >/dev/null
+# then
+#   bundle install | GREP_OPTIONS= \grep -vE '^Using|Your bundle is complete'
+# fi

data/lib/psn/api.rb

@@ -1,10 +1,12 @@
 require 'active_support/all'
+require 'cgi'
 require 'retriable/no_kernel'
 require 'open-uri'
 require 'net/http'
 require 'nokogiri'
 module PSN
   class API
+    RETRIES = 3
     BASE_URL="http://www.psnapi.com.ar/ps3/api/psn.asmx"
     attr_reader :client
 
@@ -19,20 +21,28 @@ module PSN
 
     private
     def fetch(url, options)
-      response = Retriable.retriable on: OpenURI::HTTPError, tries: 3, interval: 1 do
-        open("#{BASE_URL}/#{url}?#{normalize_params options}").read
+      url = "#{BASE_URL}/#{url}?#{normalize_params options}"
+      response = Retriable.retriable on: OpenURI::HTTPError, tries: RETRIES, interval: 1 do
+        open(url).read
       end
       parse_and_extract_response response
+    rescue OpenURI::HTTPError => e
+      raise Error, url
     end
 
     def normalize_params(params)
       query = ""
-      params.each {|k, v| query += "#{k}=#{v}&"}
+      params.each {|k, v| query += "#{k}=#{CGI.escape v}&"}
       query
     end
 
     def parse_and_extract_response(response)
       Nokogiri::Slop response
     end
+    class Error < RuntimeError
+      def initialize(url)
+        super("#{url} is not working after #{RETRIES} retries. Please check.")
+      end
+    end
   end
 end

data/lib/psn/version.rb

@@ -1,3 +1,3 @@
 module PSN
-  VERSION = "0.0.1"
+  VERSION = "0.0.2"
 end

data/spec/psn/api_spec.rb

@@ -13,5 +13,10 @@ module PSN
     it "fetches games for an user", :vcr do
       api.games_for(user).should be_a_kind_of Nokogiri::XML::NodeSet
     end
+
+    it "raises PSN::API::Error for errors in API", :vcr do
+      username = 'Kevin100Brasil'
+      expect{api.games_for(User.new(username))}.to raise_error(PSN::API::Error)
+    end
   end
 end

metadata

@@ -2,14 +2,14 @@
 name: psn
 version: !ruby/object:Gem::Version
   prerelease: 
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - Pedro Nascimento
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-12-16 00:00:00.000000000 Z
+date: 2012-12-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   version_requirements: !ruby/object:Gem::Requirement
@@ -153,6 +153,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - .gitignore
+- .rvmrc
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -190,7 +191,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 2485592278397945638
+      hash: 224315629052507505
   none: false
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
@@ -199,7 +200,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 2485592278397945638
+      hash: 224315629052507505
   none: false
 requirements: []
 rubyforge_project: