pry-note 0.2.7 → 0.2.8

data/lib/pry-note/commands.rb

@@ -151,7 +151,7 @@ Pry::Commands.create_command "note" do
     if message
       new_content = message
     else
-      old_content = notes[co_name][note_number.to_i - 1]
+      old_content = notes[co_name][note_number_s.to_i - 1]
       new_content = edit_note(co_name, old_content.to_s)
     end
 

data/lib/pry-note/version.rb

@@ -1,3 +1,3 @@
 module PryNote
-  VERSION = "0.2.7"
+  VERSION = "0.2.8"
 end

data/pry-note.gemspec

@@ -2,11 +2,11 @@
 
 Gem::Specification.new do |s|
   s.name = "pry-note"
-  s.version = "0.2.7"
+  s.version = "0.2.8"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["John Mair (banisterfiend)"]
-  s.date = "2012-12-06"
+  s.date = "2012-12-12"
   s.description = "Ease refactoring and exploration by attaching notes to methods and classes in Pry"
   s.email = "jrmair@gmail.com"
   s.files = ["README.md", "Rakefile", "lib/pry-note.rb", "lib/pry-note/commands.rb", "lib/pry-note/hooks.rb", "lib/pry-note/version.rb", "pry-note.gemspec", "test/helper.rb", "test/test_pry_note.rb"]

data/test/helper.rb

@@ -14,6 +14,11 @@ ensure
   File.unlink(f) if File.exists?(f)
 end
 
+Pad = OpenStruct.new
+def Pad.clear
+  @table = {}
+end
+
 # Return any raised exceptino objects inside the block
 def capture_exception
   ex = nil

data/test/test_pry_note.rb

@@ -183,13 +183,31 @@ describe PryNote do
       end
     end
 
-    describe "-m switch (used to amend note inline and bypass editor)" do
-      it 'should amend the content of a note' do
-        @t.process_command "note add PryNote::TestClass -m 'my note1'"
-        @t.process_command "note edit PryNote::TestClass:1 -m 'bing'"
-        PryNote.notes["PryNote::TestClass"].count.should == 1
-        PryNote.notes["PryNote::TestClass"].first.should =~ /bing/
-      end
+    it 'should amend the content of a note with -m' do
+      @t.process_command "note add PryNote::TestClass -m 'my note1'"
+      @t.process_command "note edit PryNote::TestClass:1 -m 'bing'"
+      PryNote.notes["PryNote::TestClass"].count.should == 1
+      PryNote.notes["PryNote::TestClass"].first.should =~ /bing/
+    end
+
+    # this is a regression against a bug which made it impossible to ever
+    # edit a note in an editor
+    it 'should not raise an exception when amending content without -m' do
+      Pry.config.editor = proc { nil }
+      @t.process_command "note add PryNote::TestClass -m 'my note1'"
+
+      capture_exception do
+        @t.process_command "note edit PryNote::TestClass:1"
+      end.is_a?(Exception).should == false
+    end
+
+    it 'should leave note unchanged when no changes are made in editor' do
+      Pry.config.editor = proc { nil }
+      @t.process_command "note add PryNote::TestClass -m 'my note1'"
+      @t.process_command "note edit PryNote::TestClass:1"
+
+      PryNote.notes["PryNote::TestClass"].count.should == 1
+      PryNote.notes["PryNote::TestClass"].first.should =~ /my note1/
     end
   end
 
@@ -264,6 +282,15 @@ describe PryNote do
       end
     end
 
+    it 'should not export when there are no notes' do
+      cleanup_file("bing.yml") do
+        Pry.config.notes_file = "bing.yml"
+        @t.process_command "note export"
+        o = File.exists?(Pry.config.notes_file).should == false
+        Pry.config.notes_file = nil
+      end
+    end
+
     it 'should export to specified file' do
       cleanup_file("blah.yml") do
         @t.process_command "note add PryNote::TestClass -m 'my note1'"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: pry-note
 version: !ruby/object:Gem::Version
-  version: 0.2.7
+  version: 0.2.8
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-12-06 00:00:00.000000000 Z
+date: 2012-12-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake