prubybility 0.0.10 → 0.0.11

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7008a898bc7c90b667bd58172ddc33537c87a4f8286768257c240fe5217d3917
-  data.tar.gz: cbeaad372d0ac0753242d241be73d26031f7949649a46ea4bdb77019c6aebe4a
+  metadata.gz: 790170e89a7c891831abb215dbc77ada38b587e6ea631b4f31fcc200d8820ae5
+  data.tar.gz: 2dd4031d7521c0cf6b5adf95fca477c2d7c664284496d90868481fccf57fcc56
 SHA512:
-  metadata.gz: 83f5245aa2c4994cf23c1e25aff636ba6812c39e877c85c597bafa3eda1c54881fffeaae51737fd55e440256fd5c826b856f788ee1c6992a4a6a9de80e6acb9b
-  data.tar.gz: 586dcbb65407a4ffd4f7652a833ffbe667380594bddc5202080e2387fd304d34d05bc7005194679894635c65a9998f47213c673f1086912bc52e69cf978eb053
+  metadata.gz: ba3a53b4d9ddd08e3db885f63fde6db6d815ca16c355d6fd669d8eb7424dd137df665554e20d354096c125c940972f981cb43c8ee77677c9b273f0075041c1d5
+  data.tar.gz: '091618c288164478bed9703d9929788f9146c1dfce6656598906cbd4e1a06fd23d29cd1fc593e95d28e07ee599b1876d695f6deb93b7c3d748a8407575c3c315'

data/lib/prubybility/binomial.rb

@@ -5,8 +5,6 @@ module Prubybility
   #
   # See README for example usages.
   class Binomial
-    # include Prubybility::Combinations
-
     attr_reader :n, :theta, :expected_value, :variance
 
     alias mean expected_value
@@ -25,7 +23,6 @@ module Prubybility
     private
 
     def choose(var)
-      return 0.0 if var < 0
       Prubybility::Combinations.choose(n, var)
     end
 

data/lib/prubybility/combinations.rb

@@ -16,10 +16,22 @@ module Prubybility
     extern 'char* binom(long, long)'
 
     def self.choose(x, y)
+      return unless valid_input?(x, y)
+
       ptr = binom(x, y)
       int = ptr.to_s.to_i
       free_binom(ptr)
       int
     end
+
+    private
+
+    def self.valid_input?(x, y)
+      return false unless x.is_a?(Integer) && y.is_a?(Integer)
+      return false unless x > 0 && y > 0
+      return false unless x < 2**64 && y < 2**64
+      return false unless x >= y
+      true
+    end
   end
 end

data/lib/prubybility/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Prubybility
-  VERSION = '0.0.10'
+  VERSION = '0.0.11'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: prubybility
 version: !ruby/object:Gem::Version
-  version: 0.0.10
+  version: 0.0.11
 platform: ruby
 authors:
 - Jacob Lee
@@ -58,7 +58,6 @@ files:
 - lib/prubybility/binomial.rb
 - lib/prubybility/combinations.rb
 - lib/prubybility/geometric.rb
-- lib/prubybility/libprubybility.so
 - lib/prubybility/negative_binomial.rb
 - lib/prubybility/version.rb
 - prubybility.gemspec