proxy_pac_rb 0.5.7 → 0.5.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c931688e2a83602e1fddd5ae9392932d87b78fd9
-  data.tar.gz: 6cdaa73ca1615fd2615c08fb884770d99a52d63e
+  metadata.gz: de39ce4d9ce02bf48628e304ce64bd2ff1ef67fa
+  data.tar.gz: a50ef8b2be723a9ed22230be24a308044b679815
 SHA512:
-  metadata.gz: dbfa654f164948f27fe1bc01f028c84f58ff0ec0dd6afe565533325cc4d482af6b8ec1bb0138b3bffa0c084ab8b42286b2ac3b4b47c3d0875086ab4d1ac08ea8
-  data.tar.gz: 682817b528c3ddbd54a34482e51203c3126fa3a851117443095b19b51bf94bf4155bfd6da8241a4e28e70b29cbae836dadd8c6dd46b802961e498db4a13e13ac
+  metadata.gz: 434850e84feb3f3d688697a40310a164ee6a96e29b7b0d4df759fb65690980b76d5b979f753b10d3e9298bf874a8316ec6a6a3303010f24ed4446212ce16b083
+  data.tar.gz: d3bba9a2761c30a466c2883d5ca2d647529174d427710ac540c9434d37bf3b4c0ac15d7a62022fab26b17fd37cb71c6aca868dfde968b9761931eede5d9db44f

data/Gemfile.lock

@@ -22,7 +22,7 @@ GIT
 PATH
   remote: .
   specs:
-    proxy_pac_rb (0.5.6)
+    proxy_pac_rb (0.5.8)
       activesupport (~> 4.1)
       addressable (~> 2.3.8)
       uglifier (~> 2.7.1)

data/lib/proxy_pac_rb/environment.rb

@@ -54,8 +54,11 @@ module ProxyPacRb
       !resolve_host(host).blank?
     end
 
-    def isInNet(host, pattern, mask)
-      IPAddr.new(pattern).mask(mask).include? resolve_host(host)
+    def isInNet(host, base_ip, mask)
+      raise ArgumentError, "<base ip> needs to be defined" if base_ip.nil? || base_ip.empty?
+      raise ArgumentError, "<mask> needs to be defined" if mask.nil? || mask.empty?
+
+      IPAddr.new(base_ip).mask(mask).include? resolve_host(host)
     end
 
     def dnsResolve(host)

data/lib/proxy_pac_rb/version.rb

@@ -1,5 +1,5 @@
 # encoding: utf-8
 # ProxyPacRb
 module ProxyPacRb
-  VERSION = '0.5.7'
+  VERSION = '0.5.8'
 end

data/spec/environment_spec.rb

@@ -122,6 +122,26 @@ RSpec.describe ProxyPacRb::Environment do
       let(:result) { environment.isInNet('', '93.0.0.0', '255.0.0.0') }
       it { expect(result).to eq false }
     end
+
+    context 'when base ip is empty string' do
+      let(:result) { environment.isInNet('127.0.0.1', '', '255.0.0.0') }
+      it { expect{ result }.to raise_error ArgumentError }
+    end
+
+    context 'when base ip is nil' do
+      let(:result) { environment.isInNet('127.0.0.1', nil, '255.0.0.0') }
+      it { expect{ result }.to raise_error ArgumentError }
+    end
+
+    context 'when mask is empty string ""' do
+      let(:result) { environment.isInNet('127.0.0.1', '93.0.0.0', '') }
+      it { expect{ result }.to raise_error ArgumentError }
+    end
+
+    context 'when mask is nil' do
+      let(:result) { environment.isInNet('127.0.0.1', '93.0.0.0', nil) }
+      it { expect{ result }.to raise_error ArgumentError }
+    end
   end
 
   describe '#dnsResolve' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: proxy_pac_rb
 version: !ruby/object:Gem::Version
-  version: 0.5.7
+  version: 0.5.8
 platform: ruby
 authors:
 - Dennis Günnewig
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-04-22 00:00:00.000000000 Z
+date: 2015-05-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: addressable