proxy_pac_rb 0.3.3 → 0.3.4

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    YTczOTMwM2ZkNGNhM2E2YWE1MWJmMDRhNjc2OGNlNTM0ZTAwOWE1NA==
+    ZmUwYmYzZTQ5ZDI1YTE5MWVlNTQ0ZThhMGRhYjUwNmM2OWVlZWE1ZA==
   data.tar.gz: !binary |-
-    MTE0Y2JmMWQzNGE3YmUwZjI0MmU0ZGYzMDcxZjE4ZGNkZTQ5MzlmNA==
+    OTgwOWNmNGM5YTY2NDU0MzQ2MTJhMzY2ZGFiMzM2ZTgwM2QxNTRmYw==
 SHA512:
   metadata.gz: !binary |-
-    MmJkOTZjZWUwODQ1YzZhYjNhMjc4ZDI5Yjc0MzIzZDY0MDI2YjQ0MGI1M2Ni
-    MzhjMWZmOTk5OTBjMWFmZjU5NDAzZTU3MDRmZTY2YTEwODdmZTEzN2NhNWM1
-    MmFiNTk5YTJmMzNjYzUyNDBiNWE1NDZjZTE3NjhiYTE4ODljM2Q=
+    YmEwZTU3MjE1ZmFjOWQ4MWU4YjlhZjVmMjYwYjdjMDY2YTcyYjY0YTMyMTY1
+    YWNiZGVkNDc2ZWMzYWYwYzg4MWMxOGFlYzZhNmQyMTMzODEzZjc0ZDkyYzY0
+    ZTljNjJkZDZlZWE1NTIyODk5OWZiYzBmZDdjOGNmM2FmZmQzMmY=
   data.tar.gz: !binary |-
-    ZTFlNDZiNjI0MGM3ZDI4MmY5MDM1ZDEyMDQ2ODhjMGVjMmM4NTM2NmI1ZjQz
-    ZjM5ZWMwMjk0NmIxZDlhMzM5MTRiN2RlMDJjMTdiZDQ2YjVmMDU0Yjg0YTli
-    MDU3YzQ1YzBmM2FiN2IzOTIxZWUxNzAzODQzZTIxZGZiY2UzYzI=
+    OGJhOTczZGI3MDI0ZmU0NDYwZTU1NzQ2MWJkNzM4ZTdkZTRkMGNiYTc2OGU4
+    N2JmOGNiZmJlNGRlMWFmNjU1YzhjMTc4ZGMzYzA2YjFiZjJmYjVkNzRlMWVk
+    OGE2MDZhMDgzMTk0ZmY0YmQwMmYxMmVjYjJhNDhiY2E0ZjdmOWU=

data/bin/pprb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# encoding: utf-8
 
 $LOAD_PATH << File.expand_path('../../lib', __FILE__)
 

data/lib/proxy_pac_rb/environment.rb

@@ -58,7 +58,7 @@ module ProxyPacRb
     end
 
     def dnsResolve(host)
-      resolve_host(host).to_s
+      resolve_host(host)
     end
 
     def dnsDomainLevels(host)
@@ -72,7 +72,9 @@ module ProxyPacRb
     private
 
     def resolve_host(host)
-      Resolv.each_address(host) do |address|
+      return nil if host.blank?
+
+      Resolv.each_address(host.force_encoding('ASCII-8BIT')) do |address|
         begin
           return address if IPAddr.new(address).ipv4?
         rescue ArgumentError

data/lib/proxy_pac_rb/version.rb

@@ -1,4 +1,4 @@
 #main ProxyPacRb
 module ProxyPacRb
-  VERSION = '0.3.3'
+  VERSION = '0.3.4'
 end

data/lib/proxy_pac_rb.rb

@@ -4,6 +4,7 @@ require 'resolv'
 require 'time'
 require 'open-uri'
 require 'active_support/core_ext/string/strip'
+require 'active_support/core_ext/object/blank'
 
 require 'proxy_pac_rb/version'
 require 'proxy_pac_rb/encoding'

data/spec/environment_spec.rb

@@ -67,6 +67,28 @@ describe ProxyPacRb::Environment do
       result = environment.isInNet('10.0.0.1', '127.0.0.0', '255.255.255.0')
       expect(result).to be_false
     end
+
+    it 'resolves host name' do
+      name =  'google-public-dns-a.google.com'
+      result = environment.isInNet(name, '8.0.0.0', '255.0.0.0')
+      expect(result).to eq true
+    end
+
+    it 'handles not resolvable host names' do
+      name =  'asdf.in.localhost.localdomain'
+      result = environment.isInNet(name, '8.0.0.0', '255.0.0.0')
+      expect(result).to eq false
+    end
+
+    it 'handles empty strings' do
+      result = environment.isInNet('', '8.0.0.0', '255.0.0.0')
+      expect(result).to eq false
+    end
+
+    it 'handles nil' do
+      result = environment.isInNet(nil, '8.0.0.0', '255.0.0.0')
+      expect(result).to eq false
+    end
   end
 
   describe '#dnsResolve' do
@@ -76,9 +98,21 @@ describe ProxyPacRb::Environment do
       expect(environment.dnsResolve(name)).to eq(ip)
     end
 
-    it 'return an empty string for a not resolvable host name' do
+    it 'return nil for a not resolvable host name' do
       name =  'not.resolvable.localhost.localdomain'
-      expect(environment.dnsResolve(name)).to eq('')
+      expect(environment.dnsResolve(name)).to eq(nil)
+    end
+
+    it 'handles nil values as input' do
+      expect(environment.dnsResolve(nil)).to eq(nil)
+    end
+
+    it 'handles empty string as input' do
+      expect(environment.dnsResolve('')).to eq(nil)
+    end
+
+    it 'handles garbage as input' do
+      expect(environment.dnsResolve('§§jk:')).to eq(nil)
     end
   end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: proxy_pac_rb
 version: !ruby/object:Gem::Version
-  version: 0.3.3
+  version: 0.3.4
 platform: ruby
 authors:
 - Dennis Günnewig