protokoll 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 65dba789e3d32b3c53109a8388d60a9657d6f4e4
-  data.tar.gz: a9ff4072bb3c7848507bea2508c1aa18037cc08d
+  metadata.gz: bd0f2c68950237c7a6e046e5b71eb626b1153e42
+  data.tar.gz: 23de0d9139dd69f36e811f4499ebaab8a9c035b9
 SHA512:
-  metadata.gz: 65b0deabd38eb5c0deff93f9a3ac873681b9d64902d3382b657e633031962ef32f8205a22473718a243e1e8e2808a8402488c72286aa2d52b2e4713d61a24614
-  data.tar.gz: 307c7306307927a569ff017ca644335ce520834a9a003de938859276f8e9c1ef87d5d2218aaf4217d2d0ee1977a802464cd9ac96ed850834bf3bea9f0d2f18f4
+  metadata.gz: 399235e68180d984694573b3d5bab1851d45570f025d6aa8a8348911aa28ecd10e5d4ea1fe80f05ab95d198630972303198595eff8572ed22245c75e8fddd85d
+  data.tar.gz: 5ae6f2301708d32706c7b5d13b1d57d1abb77b3cacfc30385f0c0a33ea317f77ceb13a5b5e86b7593322f2e396b77139942dd5567599f2b265229ab50736d062

data/README.md

@@ -3,7 +3,7 @@
 
 ## Description
 
-Protokoll is a simple Rails 4 pluggin to simplify the management of a custom autoincrement value for a model. 
+Protokoll is a simple Rails 4 pluggin to simplify the management of a custom autoincrement value for a model.
 
 If you want to create an autoincrement information on the database, just like those callcenter registration number (2011000001, 2011000002, 20110000003 and on) this gem is for you! If you want to create just an custom autoincrement value, this gem is for you too! =)
 
@@ -53,13 +53,13 @@ Or use any time based format. You can use in the pattern any combination of:
 
 ```ruby
 # assume it's 2011/01/01 12:00
-"%Y" for year   	# => appends 2011 
-"%y" for year   	# => appends 11 
+"%Y" for year   	# => appends 2011
+"%y" for year   	# => appends 11
 "%m" for month  	# => appends 01
 "%d" for day	 	# => appends 01
 "%H" for hour	 	# => appends 12
 "%M" for minute 	# => appends 00
-"#"  for the autoincrement number (use and long as you want)
+"#"  for the autoincrement number (use as long as you want)
 ```
 
 Using the Time formating string ("%y", "%m", ...) is totally optional. It's fine to use "CALL####", "BUY###N" or any combination you like.
@@ -71,7 +71,7 @@ class Car < ActiveRecord::Base
     protokoll :number, :pattern => "CAR%y#####"
 end
 
-# will produce => "CAR1100001", "CAR1100002"... 
+# will produce => "CAR1100001", "CAR1100002"...
 
 # :sell_number must be a String
 class House < ActiveRecord::Base
@@ -103,7 +103,7 @@ It just increases the counter so any other object that gets saved or uses the #r
 ## Installation
 
 Just add to the Gemfile:
- 
+
 ```ruby
 gem 'protokoll'
 ```

data/lib/protokoll/counter.rb

@@ -19,7 +19,7 @@ module Protokoll
     private
 
     def self.outdated?(record, options)
-      Time.now.strftime(update_event(options)).to_i > record.updated_at.strftime(update_event(options)).to_i
+      Time.now.utc.strftime(update_event(options)).to_i > record.updated_at.strftime(update_event(options)).to_i
     end
 
     def self.update_event(options)

data/lib/protokoll/protokoll.rb

@@ -17,6 +17,8 @@ module Protokoll
                   :start         => 0 }
 
       options.merge!(_options)
+      raise ArgumentError.new("pattern can't be nil!") if options[:pattern].nil?
+      raise ArgumentError.new("pattern requires at least one counter symbol #{options[:number_symbol]}") unless pattern_includes_symbols?(options)
 
       # Defining custom method
       send :define_method, "reserve_#{options[:column]}!".to_sym do
@@ -30,6 +32,12 @@ module Protokoll
         end
       end
     end
+
+    private
+
+    def pattern_includes_symbols?(options)
+      options[:pattern].count(options[:number_symbol]) > 0
+    end
   end
 
 end

data/lib/protokoll/version.rb

@@ -1,3 +1,3 @@
 module Protokoll
-  VERSION = "1.0.0"
+  VERSION = "1.0.1"
 end

data/test/protokoll_test.rb

@@ -388,6 +388,24 @@ class ProtokollTest < ActiveSupport::TestCase
     assert_equal "2011092601", protocol3.number
   end
 
+  test "rejects empty patterns" do
+
+    assert_raise ArgumentError do
+      class Protocol < ActiveRecord::Base
+        protokoll :number, :pattern => nil
+      end
+    end
+  end
+
+  test "rejects invalid patterns" do
+
+    assert_raise ArgumentError do
+      class Protocol < ActiveRecord::Base
+        protokoll :number, :pattern => "%ydodgyPattern"
+      end
+    end
+  end
+
 end
 
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: protokoll
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - Celso Dantas
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-02-07 00:00:00.000000000 Z
+date: 2015-09-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails